Jump to content

Nereid

Members
 View Profile  See their activity

  • Posts

    1,043

  • Joined

  • Last visited

 Content Type 

Everything posted by Nereid

  1. Nereid
    This is already in the queue. But I had to implement persistent settings/configs for this. This is done now and window positions will be saved in one of the next releases.
  2. Nereid
    TY for reporting. I'm quite confident that this fix will solve this issue so I have uploaded FF on Space Port now. It should not break the classic ribbons (I have tested it only for a few ribbons, but all changes are related to custom ribbons only). I still do not understand why the ALT-F key isn't working for everyone.
  3. Nereid
    It seems that those two fixes solves the problem with the custom ribbons. Not all (see below), but the most obvious is gone for me. One bug had rendered custom ribbons broken. It worked randomly, but often the ribbons get mixed up. I have uploaded a test version: 0.3.5 Feel free to DL it. I will upload it on spaceport if I get some positive feedback. There is still one issue remaining: I had exactly one case (out of many), where assigning a custom ribbon at Space Center destroyed a save game. Just after assigning it, all kerbals were dead and time was reset to game start. I suspect some kind of threading problem when calling HighLogic.CurrentGame.Updated(). Maybe someone knows a better method to mark the game as updated (necessary at Space Center, because the game wasn't saved otherwise). This call is only done if a custom ribbon is assigned while not in flight. EDIT: I will answer some other posts later this weekend.
  4. Nereid
    Just a small update: I found two errors in the code that caused the vanishing custom ribbons. One of them is a really big one... I'm still testing, if fixing this will solve all problems.
  5. Nereid
    Ok, I will check this, too. The good news: I have added a configuration window in which the log level could be adjusted, so we can get a more detailed view if necessary without spamming the log. The strange thing is, that some of the issues are not deterministic. I suspected the ingame time at first (FF relies heavy on those timestamps and reverts ribbon assignments, if time is reverted), but it seems that this part is ok. Hash- and Equal-methods are next candidates for causing such problems. Missing entries in some internal lists may cause this, too. I will first try to solve the reproducable issue that I have found. Maybe this solve others, too. This could take some days (until friday/saturday?). Does anybody have any issues with non-custom ribbons or issues without using custom ribbons at all?
  6. Nereid
    Confirmed. It happen sometimes for me (at least one time). But its a rare event on my system (about one of ten starts of KSP will erase the assigned custom ribbons). This will be hard to analyze, because starting KSP for a test is a hassle.... even in vanilla... EDIT: It happens every time, when the name (or text?) of the custom ribbon was changed and KSP is exited (it wont happen when the name and text of the ribbon remains unchanged). There are are few other issues with the names of the ribbons, too (the wrong ribbons get renamed). So I finally got a way to reproduce the issue. Strange thing is, that it wont happen, if only a save game is resumed without exiting KSP. I will look into this the next few days. File-Rotation: works well. For debugging a backup each save this is very, very useful. So I keep it this way for a while. If the save/load issues are fixed, it will changed to a lesser frequency.
  7. Nereid
    Ok, this will help. It's quite strange KSP behaves this way, because it should not make any difference if you just leave a game or exit out of KSP completely, but I will check this. I don't remember which of those alternatives I had testet yesterday, but I'm sure it weren't both.
  8. Nereid
    A backup is created at every save of KSP and KSP saves every time Space Center is loaded. I will check if there is an event when KSP is exited (FF is destroyed several times, so this wont work...). Until then 9 backup copies have to be enough.
  9. Nereid
    Thank you for the feedback. Its very strange that you have lost the custom ribbons when exiting the game, because it works for me - even when I'm assigning them at space center. I'm working on a version with adjustable log levels, so we can get detailed information when needed without spamming the log. Unfortunately the log levels of vanilla KSP are very strange from a developer point of view: INFO, WARNING, and ERROR only. :confused: But it's not that difficult to create a wrapper class around this. Its a bit more complicated to make this settings persistent though... But to get closer to the problem, try to answer the questions: Are only ribbons lost when assigning them at space center or are ingame ribbons (i.e. assigned while in a flight) are affected, too? Have you switched to a flight after assigning a custom ribbon at space center? Is this one lost, too? (important, because if those ribbons aren't lost, then we may have found the cause of the problem) And please take a note of the ingame time when leaving and after reloading. Try to check if the lost ribbons are after the load time. If possible try to reproduce the issue with minimal amount of steps, so I can try it myself.
  10. Nereid
    Noted. Will be fixed later this day.
  11. Nereid
    Can you please provide the exact information how to enable 'hardcore' mode (disabled quick saves), so I can try to reproduce this? FF relies on some events that saves the ribbon stats. If you have disabled them, perhaps we can find another solution to save the ribbons.
  12. Nereid
    Final Frontier 0.3.3 is on Spaceport Changes: warning message if custom ribbons are assigned in space center. fixed a bug that causes ribbons to overflow in the hall of fame browser log reduced backups of the halloffame.ksp in save game folder fix for the invalid index bug reported by malkuth
  13. Nereid
    Fixed in the next release today.
  14. Nereid
    Ok, I'm back in business today. Sorry, but I'm a software developer in real life too and we had a major release rolled out last week. And working on two projects with a lot of trouble was just too much this time. This, the coming spring weather in Germany , and some other issues had prevented me from continue my work with FF for a few days. But I will upload a newer version today. Just a few minor tweaks planed: No custom ribbons in space center without a word of warning, because they give some trouble to some users. The halloffame.ksp isn't saved directly, when assigning custom ribbons (because this could be the reason for some issues). Backups of the halloffame.ksp. A fix for the invalid index bug reported by malkuth. Unfortunately custom ribbons work very well on my system even in the last version. So it's not easy for me to analyze those issues and I need feedback, if the new version works.
  15. Nereid
    I'm still a bit busy in real life at the moment. FF isn't abandoned, but I don't have much time at the moment. It seems I may need another week to continue my work on FF. So don't expect any updates until next week.
  16. Nereid
    No. Just a few reasons to explain, why I had decided against it: Some achievements of the forum ribbons are hard if impossible to detect. All ribbons are plain graphics and I don't combine graphics at runtime. This way its a lot easier for me and easier for a user to change the graphics. It would be just waste of space and memory to include all combinations. Kerbals are proud of their achivement, so they want a lot of ribbons.
  17. Nereid
    At the moment I will concentrate to fix the major bugs, some have reported. BTW: you could change text and name of a custom ribbon at any state. Even if it is already assigned. But until the problems with the custom ribbons are solved, I would strongly suggest to keep away from them!
  18. Nereid
    I was thinking a bit what causes the problems and why I cannot reproduce them. There is another change from 0.2.7 to 0.3.0: saving the halloffame.ksp after awarding a ribbon. I had choosen to do this, because some have reported missing custom ribbons but I had a bad feeling about this. This causes is I/O in the UI-thread which is bad anyway. But thats not all: It will save the file regardless of the state of KSP and under some circumstances KSP may decide to do a save just at the same time in another thread. This will trigger a call of Persistence.save twice in different threads and this method isn't thread save. I have done this to get around this nasty behavior of KSP to revert time when the space center to launch pad. Its really sad, but KSP seems to have some trouble with game changes within the space center. So I think I will try a suggestion of someone else here, and just disable the custom awards when not in flight. EDIT: I have tested a bit yesterday, but all works fine for me. If this is some kind of timing problem, it's quite common to work on some machines often and never on some other.
  19. Nereid
    I have removed permadeath from 0.3.1. I have only borrowed one line of code: HighLogic.CurrentGame.Parameters.Difficulty.MissingCrewsRespawn = false; If this is causing this, it should be gone with 0.3.1. And maybe thats the reason I can't reproduce this anymore.
  20. Nereid
    Maybe its this part of the code in DisplayWindow.cs: private void AwardSelectedCustomRibbon() { [...] HallOfFame.instance.BeginArwardOfRibbons(HighLogic.CurrentGame.UniversalTime); HallOfFame.instance.Record(entry.GetKerbal(), selected); HallOfFame.instance.EndArwardOfRibbons(); // and save (mark game as updated) HighLogic.CurrentGame.Updated(); // <- suspicious // save hall of fame Persistence.Save(HallOfFame.instance); } But removing this will make any ribbons awarded in space center void after leaving the game...
  21. Nereid
    Ah, ok, this helps a lot. But really cannot analyze this today. Tomorrow I will give it a chance. EDIT: It seems that loading has a bug and messes the the hall of fame up. EDIT^2: I still cant reproduce it, but the stack trace should help to do something about that.
  22. Nereid
    Well, I have uploaded 0.3.1 and tested a bit: All ribbons awarded in Space Center remain for me, if I launch or continue a mission, or if I just levae the game (or both). very very strange...
  23. Nereid
    Maybe. I have just copied the code from another mod. But because this may be an issue I will just remove it today and we will see...
  24. Nereid
    Well, if I read this I really can't believe that FF was causing this. If you arward a custom ribbon two this happen: 1. The game is marked as updated (so just leaving space center will save it) and 2. the halloffame.ksp is saved. Losing all ribbons may the result of a failed save (thats why I'm thinking to create backup each save) but losing all ships? KSP has done similar things to me several times (but never all ships, just a few and not in 0.23). And again: make a backup of an ongoing game at least once a day - if it's important for you not to start over.
  25. Nereid
    Sorry for the delay guys, but I was a bit busy the last days. And didn't read here for a few days. Still doesnt work in latest. This is very strange, because it works for me. I will have to change the code to get a bit more log info and perhaps someone with better knowledge may help. Noted. I will remove this ASAP. For those who have all ribbons lost, I'm sorry to hear this. But please, make a copy of your save game every then and now. It's not just because FF may have bugs, also KSP does sometimes very strange things. Just zip your savegame folder. This way you will backup all ribbons, too. Regarding the lost custom ribbons: As I have explained already: this is some kind of strange behaviour in KSP. It seems that the game time in the space center isn't paused but reverted back to the last ingame time, when KSP switches to the launchpad or a space-ship. This doesn't play well with my method to revert ribbons by timestamps. Currently I set the award time to the game time (Highlogic.Currentgame.Universaltime) and for this worked quite well. Obviously it won't work for everyone and I still do not understand what causes this. Just a few questions: - Are the custom ribbons working/saved if awarded in a mission? - Have you launched/flown a mission after awarding a custom ribbon in space center? - Who was affected by the all-ribbons-lost-effect and what have you done directly before this has happened? (if this is an issue I will add some kind of backup functionality) If all fails we have to add log outputs and I will have to analyze this. If I can't reproduce this on my own (and I still can't), then perhaps someone can help me to test this directly (live via ICQ perhaps?). EDIT: Anyway. I will upload 0.3.1 with a few reverts in a few hours. I will not change much, just fix the ribbon graphics for one ribbon, removing permadeatch and one file from the toolbar folder. If will add some log outputs in a later version.
×
×
  • Create New...