[1.4.x] Contract Pack: Tourism Plus [v1.5.2] [2016-12-14]

[nightingale]

2 hours ago, Moikle said:

I have been having an issue with the first contract. I have completed it 3 times now, but every time I quit the game, the contract is reset and I have to "kick off space tourism" again. I cannot access any other missions either.

KSP.log please!

[faraon]

I got a funny situation with a camp contract came with one of the tourists being named the same as one of my existing Kerbonats, it didn't spawn another Kerbal tourists of the same name so I will probably have to retrieve the my guy from my Mun Station an bring him back together with the tourists.

Also the visit asteroid contract is really OP. The 500k is enough to get an asteroid and bring it to Kerbin, but for subsequent contracts I can take my SSTO and do it for 8K in fuel. Maybe the contract should have both a docked to asteroid while in Kerbin Orbit and docked to asteroid while in Kerbol orbit. This way the reward makes sense since You have to either go get a new asteroid or fly the one You have in Kerbin orbit outside it's SOI.

 

 

[nightingale]

19 hours ago, faraon said:

I got a funny situation with a camp contract came with one of the tourists being named the same as one of my existing Kerbonats, it didn't spawn another Kerbal tourists of the same name so I will probably have to retrieve the my guy from my Mun Station an bring him back together with the tourists.

Also the visit asteroid contract is really OP. The 500k is enough to get an asteroid and bring it to Kerbin, but for subsequent contracts I can take my SSTO and do it for 8K in fuel. Maybe the contract should have both a docked to asteroid while in Kerbin Orbit and docked to asteroid while in Kerbol orbit. This way the reward makes sense since You have to either go get a new asteroid or fly the one You have in Kerbin orbit outside it's SOI.

Yup, this is a known issue/limitation with the asteroid stuff.  It's even worse if you just land the asteroid near KSC.

I don't have a good solution, but maybe writing it so they have to have it in Sun SOI is a good idea.

[CodatheSpaceFox]

So it seems this pack along with the Configurator were released for the 1.2 Prerelease via CKAN, but for some reason it seems that this particular pack has quite a few quirks about it, the first tourism contract hasn't loaded for me, and even on a new save up to being able to reach the moons, it seems that the game is convinced I've done a tourism contract, since the not having done a standard tourism contract condition is considered Unmet.

[nightingale]

3 minutes ago, CodatheSpaceFox said:

So it seems this pack along with the Configurator were released for the 1.2 Prerelease via CKAN, but for some reason it seems that this particular pack has quite a few quirks about it, the first tourism contract hasn't loaded for me, and even on a new save up to being able to reach the moons, it seems that the game is convinced I've done a tourism contract, since the not having done a standard tourism contract condition is considered Unmet.

This is a known issue.

Also, I didn't realize that this was up on CKAN.  The mistake is mine, as I forgot to check off 1.20.1 as a pre-release version - that's done now, and if it's not automatically removed from CKAN I'll send them a PR.

[CodatheSpaceFox]

6 hours ago, nightingale said:

This is a known issue.

Also, I didn't realize that this was up on CKAN.  The mistake is mine, as I forgot to check off 1.20.1 as a pre-release version - that's done now, and if it's not automatically removed from CKAN I'll send them a PR.

Thanks for the quick response. So if the issue is known, is there any way of correcting it?

It also seems that there are some other quirks (namely the base and field research contract packs) that have similar issues where certain conditions are considered unmet from a newly made save. I suppose all of this in question is because I wasn't actually supposed to have the contract packs with the 1.2 pre-release in the first place?
 

[nightingale]

27 minutes ago, CodatheSpaceFox said:

Thanks for the quick response. So if the issue is known, is there any way of correcting it?

It also seems that there are some other quirks (namely the base and field research contract packs) that have similar issues where certain conditions are considered unmet from a newly made save. I suppose all of this in question is because I wasn't actually supposed to have the contract packs with the 1.2 pre-release in the first place?
 

Yup, I haven't had time to test any of this stuff myself yet.  Priority has been getting 1.2 out the door - mods will come later.

[CodatheSpaceFox]

1 hour ago, nightingale said:

Yup, I haven't had time to test any of this stuff myself yet.  Priority has been getting 1.2 out the door - mods will come later.

Roger that, I'll save terrifying groups of unsuspecting tourists with my terrible rocket designs till then, now all I need to do is finish what non stock contracts were working (Splashed down in highlands must be the rarest biome condition on kerbin or something.) and uninstall them until then. Might take up to the release date before that happens.

[Kerbas_ad_astra]

When you do get to Tourism Plus / CC, the issue seems to start with the CompleteContract REQUIREMENT (CompleteContractRequirement.RequirementMet) in the very first tourism contract:

TargetParameterCountException: parameters do not match signature
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0 
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <filename unknown>:0 
  at ContractConfigurator.CompleteContractRequirement.RequirementMet (ContractConfigurator.ConfiguredContract contract) [0x00000] in <filename unknown>:0 
  at ContractConfigurator.Util.MissionControlUI.CheckRequirements (IEnumerable`1 requirements) [0x00000] in <filename unknown>:0 

I don't know KSP's contract system well enough to diagnose from there -- it's just something I stumbled across while debugging other things (fixing the NotSupportedExceptions from all the mods that use Toolbar...gonna have a pull-request party, yay).

Edited October 20, 2016 by Kerbas_ad_astra

[nightingale]

2 hours ago, Kerbas_ad_astra said:

When you do get to Tourism Plus / CC, the issue seems to start with the CompleteContract REQUIREMENT (CompleteContractRequirement.RequirementMet) in the very first tourism contract:

TargetParameterCountException: parameters do not match signature
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0 
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <filename unknown>:0 
  at ContractConfigurator.CompleteContractRequirement.RequirementMet (ContractConfigurator.ConfiguredContract contract) [0x00000] in <filename unknown>:0 
  at ContractConfigurator.Util.MissionControlUI.CheckRequirements (IEnumerable`1 requirements) [0x00000] in <filename unknown>:0 

I don't know KSP's contract system well enough to diagnose from there -- it's just something I stumbled across while debugging other things (fixing the NotSupportedExceptions from all the mods that use Toolbar...gonna have a pull-request party, yay).

Good catch, that saves me a lot of investigation.  And big thanks of the PRs...   I'm not looking forward to breaking *everything* when I release Contract Configurator...

[Mordrehl]

First Tourism contract on CC and TPlus 1.2 shows up ... but won't complete, the counter for time doesnt' change at all

[DocMop]

25 minutes ago, Mordrehl said:

First Tourism contract on CC and TPlus 1.2 shows up ... but won't complete, the counter for time doesnt' change at all

+1

Opened an issue on the repository.

[nightingale]

@Mordrehl & @DocMop - I'll investigate that issue soon.

[CodatheSpaceFox]

Found the contract packs in CKAN again, now is everything in working order for future zero gravity roulette games?

[nightingale]

@CodatheSpaceFox - there's an outstanding issue with the timer's that affects this contract pack, but otherwise good to go.

[Terwin]

On 10/8/2016 at 1:05 AM, CodatheSpaceFox said:

Roger that, I'll save terrifying groups of unsuspecting tourists with my terrible rocket designs till then, now all I need to do is finish what non stock contracts were working (Splashed down in highlands must be the rarest biome condition on kerbin or something.) and uninstall them until then. Might take up to the release date before that happens.

Before the biome re-vamp in 1.2, I found splashed in the highlands over on the far side of Kerbin near the badlands(I was actually trying to get splashed down in the badlands for a caveman game, and was surprised to find I was splashed in highlands instead)

[Mordrehl]

9 hours ago, nightingale said:

@CodatheSpaceFox - there's an outstanding issue with the timer's that affects this contract pack, but otherwise good to go.

That's a bit of an understatement ... for the contracts to proceed you need to complete "Kick of Space Tourism" ... as it stands "Kick of Space Tourism" is impossible to complete because once in orbit the 4hr timer never changes 

[Darineth]

On 11/1/2016 at 4:36 PM, Mordrehl said:

That's a bit of an understatement ... for the contracts to proceed you need to complete "Kick of Space Tourism" ... as it stands "Kick of Space Tourism" is impossible to complete because once in orbit the 4hr timer never changes 

You should find that it's strictly an issue with the DISPLAY of the timer.  I've done loads of timed contracts, if you wait the 4 hour time it will complete even if the timer doesn't tick down.  Just watch the mission timer and you should see it does work!

[Mordrehl]

On 11/5/2016 at 5:20 PM, Darineth said:

You should find that it's strictly an issue with the DISPLAY of the timer.  I've done loads of timed contracts, if you wait the 4 hour time it will complete even if the timer doesn't tick down.  Just watch the mission timer and you should see it does work!

Either way, @nightingale fixed it in the recent contract configurator update

[Zoidos]

I eagerly awaited the update to 1.2.x, this is on of my must-have mods. Far superior to the stock tourism contracts. Thank you for this amazing mod!

Edited November 14, 2016 by Zoidos

[katateochi]

I'm just trying this mod out for the first time and really liking it so far. 
Just one Q, I've just got the investor tour available, if I choose one or the other is that it? or could I build the hotel now and then the casino later? And will I be able to build hotels/casinos in multiple locations?

[nightingale]

@katateochi - The investor tour was changed recently to be repeatable - so you can do either choice multiple times (or both choices).

[katateochi]

3 minutes ago, nightingale said:

@katateochi - The investor tour was changed recently to be repeatable - so you can do either choice multiple times (or both choices).

Awesome, thanks! 

[SkyKaptn]

@nightingale Can this pack be used with the glorious Galileo's Planet Pack? In other words, are the contracts using KSP's generic algorithm or are they hand tailored for Kerbol only?

I do not dare to load contract packs on already existing careers when uncertain just to check.

[nightingale]

On 01/12/2016 at 6:17 AM, SkyKaptn said:

@nightingale Can this pack be used with the glorious Galileo's Planet Pack? In other words, are the contracts using KSP's generic algorithm or are they hand tailored for Kerbol only?

I do not dare to load contract packs on already existing careers when uncertain just to check.

Should work just fine on Galileo.