[1.0.5] LightsOut (v0.1.5) - Day/Night Mode in VAB/SPH

[RealGecko]

I've published version 0.2.2, it's just a recompile for KSP 1.3.1, no other changes done.

[agrock]

Latest version does not work with KSP 1.3 (no menu in hangars).

Also this version 0.2.2 that you mention, its not downloadable from either site.

[Aelfhe1m]

18 minutes ago, agrock said:

Latest version does not work with KSP 1.3 (no menu in hangars).

Also this version 0.2.2 that you mention, its not downloadable from either site.

You need the RealGecko versions not the ones in the OP:

https://spacedock.info/mod/1006/Lights Out or https://github.com/Real-Gecko/LightsOut/releases

 

[agrock]

Thank you, LightsOut indeed works with KSP 1.3.  

[Jiraiyah]

@RealGecko

not sure if this is intended or not, but for some reason, the ambient light in VAB don't dim quit enough, the light on craft goes on but the ambient light is not dark enough to show the real meaning of this mod, to check the lights in darkness !

[RealGecko]

Yep, I noticed that too, but I was only recompiling the mod to make sure it's compatible with latest KSP. Anyway I wont fix it

So better luck with next maintainer.

[RealGecko]

Anyone willing to take over?

 

[Jiraiyah]

hmm, i'm not that familiar with ksp's api but i can take a look into this and see if i can figure what is going on or not

Well, looking at the original repo, looks like there are tons of hard coded light names, shader names, etc.

I don't know how to look for those names or even check if they exist or not, also, I'm not sure if the way he is handling it is right way to go for this or not, honestly, if it was possible, maybe a better approach would be to turn off everything first then find lights on the ship and turn them back on, same for shaders, as i said, I'm not that familiar with KSP some one like @linuxgurugamer would be a better person to take care of this although in linux's case, he already have tons on his plate

Edited January 28, 2018 by Jiraiyah

[linuxgurugamer]

I looked at this, but it’s dealing with things I don’t know Bout.  Best to find somebody else for this.

[Jiraiyah]

On 1/28/2018 at 11:56 AM, linuxgurugamer said:

I looked at this, but it’s dealing with things I don’t know Bout.  Best to find somebody else for this.

ouch, you where my only hope lol, not knowing many capable modders

[ZobrAA]

Looks like LightsOut v0.2.2 from @RealGecko still works fine. 

[Jiraiyah]

On 3/22/2018 at 9:55 AM, ZobrAA said:

Looks like LightsOut v0.2.2 from @RealGecko still works fine. 

honestly, i looked at the repo, but can't figure what is not working  properly from his version  that causes the lights to not be pitch dark like how it was supposed to be in older versions. any one has any idea?

honestly, this line should have done it properly :

https://github.com/Real-Gecko/LightsOut/blob/master/LightsOut/LOAmbient.cs#L121

that line is setting the ambient light to 0.15 on all RGB,  unless, they have added more lights to the VAB than what is listed here, that would explain turning off a light would not turn  the whole place dark

https://github.com/Real-Gecko/LightsOut/blob/master/LightsOut/LOExternalLights.cs#L38

because as you  can see here, if it's night mode, it will disable the light, unless again, those conditions that were checked have any problems because of updates

https://github.com/Real-Gecko/LightsOut/blob/master/LightsOut/LOExternalLights.cs#L184

this last method is being called from the main stuff in this line  :

https://github.com/Real-Gecko/LightsOut/blob/master/LightsOut/LightsOut.cs#L131

long story short, does anyone know how we can check the name and number of lights in the scene and does anyone see any problem in the logic?

thanks

Edited April 9, 2018 by Jiraiyah

[Beetlecat]

On 3/22/2018 at 2:55 AM, ZobrAA said:

Looks like LightsOut v0.2.2 from @RealGecko still works fine. 

Sometimes "good enough" is fine -- but ultimately it's probably a good idea to "do it right" as Jiraiyah has noticed. Even not total blackness still gives a good idea of light placement, visiblity, etc. I'll likely be adding the mod back to my list if it fires up in 1.4.2

[Drew Kerman]

Seems to work just fine under KSP v1.4.5 w/MH

[Fraktal]

Yep, it does. I just wish I knew how to disable the damn hotkey.