[1.5.1] Engine Lighting (1.5.1) Little Config Update (13 October)

[Alshain]

[quote name='tajampi']Hi:

Should work with no problems in 1.0.5. Anyway i'll check and update OP and related if that's the case.

Working on a new version consistent with RealPlume colors. Hopefully it will be ready soon.

Cheers! :)[/QUOTE]

Will it conflict with the new emissives on the jet engines?

[tajampi]

[quote name='Alshain']Will it conflict with the new emissives on the jet engines?[/QUOTE]
There should be no issues! Jet engines don't emit light by default, and emissives should not interfere in any way with the lighting ;)

[Svm420]

[quote name='Svm420']Did you ever figure out compatibility with Realfuel? Thanks![/QUOTE]
Maybe this was missed? I ask because of RealFuels unique engine module as opposed to the 2 stock engine modules

[tajampi]

[B]Update[/B]: Now the mod is fully compatible with KSP 1.0.5!

[quote name='Svm420']Maybe this was missed? I ask because of RealFuels unique engine module as opposed to the 2 stock engine modules[/QUOTE]
If the RealFuels engine implements Squad's Engine module, it SHOULD work by changing patches. Will investigate ;)

Cheers!

[Kerbas_ad_astra]

One suggestion (based on what I do already): instead of only stripping the EngineLight module from engines that breathe IntakeAir, you should search for IntakeA* to catch IntakeAtm as well (for e.g. electric fans, nuclear turbojets, and the like).

[Sampa]

Hey, this looks cool! Want to partner with the SSP team to get this working on the space shuttle?

[evileye.x]

Thank you for very cool mod, can't play without it!

[Pronoes]

Is this compatible with Real Fuels and subsequently RO/RSS yet? Looks fantastic and I'd love to use it but no compatibility means no dice

[Black-Talon]

FYI, I do not think KSP-AVC is setup correctly for Engine Lighting to check for updates. Searching the thread I see this was perhaps already reported:

On 6/28/2015, 10:07:55, Kolago said:

I see a version file errors in my log:

KSP-AVC -> Version file contains errors: http://forum.kerbalspaceprogram.com/threads/121987

I came to believe this after finding this error in my output_log.txt:

MiniAVC -> Version file contains errors: http://forum.kerbalspaceprogram.com/threads/121987
MiniAVC -> D:\KSP\KSP v1.00.5 (Win) - Mods\GameData\EngineLight\EngineLight.version
	NAME: Engine Lighting
	URL: http://forum.kerbalspaceprogram.com/threads/121987
	DOWNLOAD: https://kerbalstuff.com/mod/817/EngineLighting/download/1.4.1
	GITHUB: NULL
	VERSION: 1.4.1
	KSP_VERSION: 1.0.5
	KSP_VERSION_MIN: NULL
	KSP_VERSION_MAX: NULL
	CompatibleKspVersion: True
	CompatibleKspVersionMin: True
	CompatibleKspVersionMax: True
	CompatibleGitHubVersion: True
MiniAVC -> http://forum.kerbalspaceprogram.com/threads/121987
	NAME: NULL (required)
	URL: NULL
	DOWNLOAD: NULL
	GITHUB: NULL
	VERSION: NULL (required)
	KSP_VERSION: 1.0.5
	KSP_VERSION_MIN: NULL
	KSP_VERSION_MAX: NULL
	CompatibleKspVersion: True
	CompatibleKspVersionMin: True
	CompatibleKspVersionMax: True
	CompatibleGitHubVersion: True
	UpdateAvailable: False

Since I wasn't familiar with KSP-AVC or MiniAVC and how it used the .version file to even guess why it "contained errors" I did a little research and found this (from a support post in the KSP-AVC thread):

On 5/28/2015, 7:27:13, cybutek said:

The URL field should point to the remote version file, it's currently pointing to the forum thread. If you're using KSP-AVC Online, the URL will need to be "http://ksp-avc.cybutek.net/version.php?id=[version id]". Also the CHANGE_LOG_URL should point to a text file (not the forum) as this is shown under the "CHANGES" button, allowing the player to view the change log in-game (can be left blank and the button will not be shown).

This led me to the belief that the EngineLight.version file needs to have the URL parameter set to the remote version file (which will be used to signal/indicate that an update is available). It is possible you already have one setup (with http://ksp-avc.cybutek.net) and you'll want to ask in the KSP-AVC thread (or PM to cybutek) about what the id is. Looking back through this thread I see here where linuxgurugamer kindly helped. Unfortunately his example .version file had this issue with it way back then. In addition, the first version released with AVC had this issue. So MiniAVC has never been telling users about new versions if I understand correctly.

In searching the thread I also came across this, perhaps relevant, discussion/suggestion that may warrant additional investigation:

On 10/31/2015, 7:43:35, MK3424 said:

I don't want to be picky, but are you gonna drop the miniavc from the next release? Since most of the mods are on ckan, there's no need for avc..

On 10/31/2015, 8:11:49, ObsessedWithKSP said:

I don't use the CKAN and I never will - to drop AVC support (which is literally just a text file) would be, to me, stupid and short-sighted. On an objective and discussion-based note: what advantages would dropping AVC support bring?

On 11/1/2015, 6:37:32, parachutingturtle said:

AVC is good, the MiniAVC dll is pointless IMO.

On 11/19/2015, 1:48:39, ColKlonk said:

[quote name='ObsessedWithKSP']I don't use the CKAN and I never will - to drop AVC support (which is literally just a text file) would be, to me, stupid and short-sighted. On an objective and discussion-based note: what advantages would dropping AVC support bring?
I say make mods JSGME compatible.. a lot less annoying than mini-avc or CKan.

For those who like to control their mods.. that is..

 

Edited December 12, 2015 by Black-Talon

[Spheniscine]

On 5/18/2015 at 4:48 AM, tajampi said:

Known Issues:

 

• High power engines sometimes light planets up from space!

lol Funniest known issue ever.

"Enjoy your NEW SUN!"

Edited February 2, 2016 by Spheniscine

[meyerweb]

2 hours ago, Spheniscine said:

lol Funniest known issue ever.

"Enjoy your NEW SUN!"

I saw this happen just the other day, and it was GLORIOUS.  I wish I’d thought to get a screenshot.

Tajampi, if you ever find a fix for this, I hope you’ll include some way to preserve the bug as a preference or something.  No kidding.

[cortina]

BUG REPORT

 

Windows 8.1 64bit; ksp 1.05 32bit from steam; opengl;

mods installed from ckan

I have: Real Plume, Real Plume Stock Config and Engine Lightning.

edit: I also have scatterer

I was launching a sizable but not that big rocket and the engine lights were so strong that the planet was lit up, but only in map view not when i was looking at the rocket. I don't know if its the same known bug since it only happens on map view.

 

 

Edited February 6, 2016 by cortina

[ForgiLaGeord]

KerbalStuff has bitten the dust, you'll want to reupload to Spacedock.info

[Mr.Baconing]

Now that KerbalStuff is dead does anyone have a link to the mod please?

[JJayzX]

Same here, need a link. Reinstalled system and forgot to backup my mods.

[The L3mur]

On February 6, 2016 at 3:43 PM, cortina said:

BUG REPORT

 

Windows 8.1 64bit; ksp 1.05 32bit from steam; opengl;

mods installed from ckan

I have: Real Plume, Real Plume Stock Config and Engine Lightning.

edit: I also have scatterer

I was launching a sizable but not that big rocket and the engine lights were so strong that the planet was lit up, but only in map view not when i was looking at the rocket. I don't know if its the same known bug since it only happens on map view.

 

 

This is cooler than if it actually was working properly xD

[Jerry060599]

10 hours ago, JJayzX said:

Same here, need a link. Reinstalled system and forgot to backup my mods.

Here: https://drive.google.com/file/d/0B-AmS2w7GkSQZ2pzWWg3ZEZob3M/view?usp=sharing

From a partial download of the KerbalStuff torrent.

Spent around ten minutes hunting for it. Had brief moments of joy when anything with "engine" shows up followed by utter disappointment. :3 Cross fingers I won't get sued over this though. (All credits to the almighty mod maker)

Edited February 22, 2016 by Jerry060599

[JJayzX]

Thanks Jerry060599

[Beetlecat]

On 2/6/2016 at 0:43 PM, cortina said:

It's like the whole planet is simply some sort of miniature computer "Model" or something!

Edited February 23, 2016 by Beetlecat

[tajampi]

Greetings! Been away from KSP for a while, didn't notice KerbalStuff died 

 

I reuploaded the mod to SpaceDock, I will possibly rewrite the thing soon, I wrote the original code a year ago or so and everything is messy

Here is the link: http://spacedock.info/mod/272/Engine%20Lighting

 

EDIT: After I rewrite lights will be (optionally) toggled off when you enter the map. Also, no problem by the reupload

Cheers!

 

Edited February 24, 2016 by tajampi

[KvaNTy]

@tajampi, is there any hope to see engines light working with real fuels?
I was trying to figure out how to make it manage ModuleEnginesRF the same way it manages ModuleEngines, but since you're going to refactor all the code...

[stom]

I currently get a 401 Unauthorized when trying to view the mod on SpaceDock. Forgot to hit publish, tajampi?

[tajampi]

Ooops! Published

 

Also, I will try to make the mod compatible with most stuff I can after I rewrite, I believe ModuleEnginesRF is actually very similar to ModuleEngines, making code compatible SHOULD be no issue

Edited February 25, 2016 by tajampi

[KvaNTy]

I just noticed that ModuleEnginesRF is based on SolverEngines.ModuleEnginesSolver instead of stock ModuleEngines and that they share different methods/properties, but had no time to actually dig into SolverEngines.dll yet.

But yeah, they shoulda be compatible. After all they are more or less about the same.

Edited February 25, 2016 by KvaNTy

[The L3mur]

I can't seem to get to the download. It says I'm unauthorized when I click on the link and I can't find it on SpaceDock via a search.