[1.5.1] Engine Lighting (1.5.1) Little Config Update (13 October)

[tajampi]

Released a version with updated configs, but no rebuild. It should work alright, but can't test it (My GPU has not worked since a few weeks ago  ).

Edited October 13, 2017 by tajampi

[Geschosskopf]

Yay!  Good luck getting your GPU replaced.  I haven't yet updated my game to 1.3.1 but I've been sorely missing this in 1.3.0.

[Errol]

I have found an incompatibility, when this mod is installed with the new Engine Ignitor it makes Engine Ignitor stop working. 
 

I still trying to figure out how/why...

[lordcirth]

The CKAN metadata says it only supports 1.2.2.  Shouldn't be hard to fix.

[eberkain]

Why do monoprop engines emit light?  

[lordcirth]

21 minutes ago, eberkain said:

Why do monoprop engines emit light?  

Why wouldn't they?  Still quite hot.  Are you confusing MP with cold gas?

[eberkain]

32 minutes ago, lordcirth said:

Why wouldn't they?  Still quite hot.  Are you confusing MP with cold gas?

yeah my bad.  been taking care of the little one throwing up all night, i dunno where my brain is at.   

[stuff]

any chance this could be updated for latest version of ksp i do not know how to update

[UnanimousCoward]

2 hours ago, stuff said:

any chance this could be updated for latest version of ksp i do not know how to update

Two points:

1. You shouldn't come on to threads asking for mods to be updated - it's considered poor etiquette, and you'll likely be ignored or shot down (often less politely than this).

2. Before asking, you could try it yourself to see if it works or not. I just did a very quick test, and it seems to work just fine in 1.4.1, at least for the stock Kerbal 1 rocket. 

[aeroeng14]

I have tried an example craft with this mod for 1.4.1 (no MH DLC) and did not see it working. If anyone else wants to trial it and make sure I didn't try something wrong--much appreciated. Otherwise I will patiently await an update.

Edited April 1, 2018 by aeroeng14

[Morgueço]

So, With real plume installed, my engines doesnt lit like they did with stock "fireworks" rockets haha. Maybe i'm doing something wrong? Just installed them both (off to the game data they go) EL first then RP...
I'm kind of disapointed with the nerv plumes, thoug :( , so i think if this persists ill only use EL.

Thanks in advance :D

[Drew Kerman]

basic testing with a Hammer SRB and Reliant LF/O engine show lighting effects are happening. Still, did @linuxgurugamer never pick this one up as well? Seems ripe for the plucking, if only to have an official update compiled against the latest KSP

[linuxgurugamer]

It is already compiled for 1. 4. Why should I pick up something which is currently being maintained?

[Drew Kerman]

10 hours ago, linuxgurugamer said:

Why should I pick up something which is currently being maintained?

because that's the kind of stupid **** I say after being awake for almost 24 hours ¯\_(ツ)_/¯ my brain is better now

[Li0n]

FYI: this (essential) mod is still working on 1.5.1

I've tested it only on stock engine tho.

[xBuckleyx]

Hey sorry but I'm a bit confused.  Coming back to KSP after a decent size break.  I'm currently building a modded game on 1.4.3 because...reasons.

Can someone point me to the right version of Engine Lighting that works on 1.4.3?  I see 1.4.5 Real Fuels, 1.5, and some other version....

Thanks in advance.

 

[Beetlecat]

3 hours ago, xBuckleyx said:

Hey sorry but I'm a bit confused.  Coming back to KSP after a decent size break.  I'm currently building a modded game on 1.4.3 because...reasons.

Can someone point me to the right version of Engine Lighting that works on 1.4.3?  I see 1.4.5 Real Fuels, 1.5, and some other version....

Thanks in advance.

 

https://spacedock.info/mod/272/Engine Lighting

Check the changelog tab -- it shows mod versions along with KSP-appropriate versions. CKAN can do this, too if enough mod versions are tracked.

[xBuckleyx]

1 hour ago, Beetlecat said:

https://spacedock.info/mod/272/Engine Lighting

Check the changelog tab -- it shows mod versions along with KSP-appropriate versions. CKAN can do this, too if enough mod versions are tracked.

Hey thanks.

 

Yea, so I figured out the back porting version function thing with CKAN (amazing feature) but this is helpful with SpaceDock.

 

Apparently versions jump from Engine Lighting 1.5 for KSP 1.2.2 to version 1.5.1 for KSP 1.5.1.  Engine Lighting is not available via CKAN from what I can tell.  I'm curious if a version exists but is just not readily available for KSP 1.4?  There seems to be info that it is?  

 

A bit confused and can't help but think it's not available on CKAN b/c of some of the confusion between versions at the different GitHubs etc.?

 

Thanks again to whoever can shed some light...

 

 

[Gordon Dry]

Which is the up to date Github fork?

 

GameData\EngineLight\engine-configs.cfg
line 74:

@PART[microEngine|radialEngineMini]:FOR[EngineLight] {

-->

@PART[microEngine,radialEngineMini]:FOR[EngineLight] {

 

line 85:

@PART[liquidEngineMini]:smallRadialEngineFOR[EngineLight] {

-->

@PART[liquidEngineMini,smallRadialEngine]:FOR[EngineLight] {

 

[Moofrog]

22 hours ago, Gordon Dry said:

Which is the up to date Github fork?

-snip-

I think there is more lines which need changing of "|" to ","..

@whoever maintains it at the moment and keeps it up to date @Gordon Dry

So whats the difference between

@PART[part1|part2]

and

@part[part1,part]

?

Edited November 13, 2018 by Moofrog
clarification

[Moofrog]

So my question or guess is 

@PART[part1|part2]

finds either part1 or part2 and just patches the first instance it finds. And

@PART[part1,part2]

apply the patch to all the parts listed. Is that a correct assumption?

Thats atleast what I could deduct from the modulemanager wiki.

[Gordon Dry]

56 minutes ago, Moofrog said:

Is that a correct assumption?

Yes

[Moofrog]

9 minutes ago, Gordon Dry said:

Yes

Then I have changed some more lines in the config.

[JacobTheFoxx]

Found a bug a few days ago. I'm running KSP 1.5.1. At night in orbit, engines seem to light up a large area of the surface of the planet. I checked the logs, but there was nothing related to EngineLighting there. It happened with the Mammoth engine, not sure if it happens with other engines.

Here is my mod list: https://docs.google.com/spreadsheets/d/1bR-gp5K9pMMBarGM23IbkOuTWFKRJULvv64xbh0f9dY/edit?usp=sharing

 

[TranceaddicT]

ModuleManager is throwing a simple warning

 

[WRN 12:47:51.428] [ModuleManager] 1 warning related to GameData/EngineLight/engine-configs.cfg

 

My correction:

ln88
-@PART[liquidEngineMini]:smallRadialEngineFOR[EngineLight]
+@PART[liquidEngineMini&smallRadialEngine]:FOR[EngineLight]