[1.12.x] Part Commander Continued

[DerGolgo]

4 hours ago, linuxgurugamer said:

You could try using The Janitor's Closet.  It has a Mod filter setting, where you can display parts from only specified mods.  It can also hide parts you just don't want to see.  Read about it here: http://spacedock.info/mod/944/The Janitor's Closet

Thanks! I use it, but sometimes, I want to see if there's stuff from different mods.

[EstebanLB]

Hey liniuxgurugamer, is this mod working fine with 1.2.2?

 

Just found out it is, thanks!

Edited January 11, 2017 by EstebanLB

[linuxgurugamer]

7 minutes ago, EstebanLB said:

Hey liniuxgurugamer, is this mod working fine with 1.2.2?

Yes 

[SmashBrown]

So many mods I used to use and have forgotten about. Ty for continuing this @linuxgurugamer

[linuxgurugamer]

New release, 0.1.2:

• Updated for 1.3

[SpaceEnthusiast23]

Thanks for taking over this great mod. You deserve more reputation

[Drew Kerman]

had this installed for a while but just started using this under KSP v1.2.2 (Part Commander v0.1.1.1) and it's springing a serious memory leak whenever the window is showing. Eventually the game slows down to 15% normal time and I have it taking up 8GB of memory up from the 5.5GB is started with. Tested with just Squad, PC and Toolbar and if I watch the Resource Monitor I can see the RAM stabilize after flight scene load and after opening the Part Commander window it starts to tick upwards.

Hopefully this isn't an issue in the KSP v1.3 but I didn't see anything in the release notes about plugging a memory leak.

Logs, FWIW

[Aelfhe1m]

@linuxgurugamer There's a bug in Part Commander where some localization tags are being displayed instead of being formatted - the ones shown here are stock tags so I don't think it's an interaction with another mod:

[linuxgurugamer]

On 6/19/2017 at 4:35 PM, Drew Kerman said:

had this installed for a while but just started using this under KSP v1.2.2 (Part Commander v0.1.1.1) and it's springing a serious memory leak whenever the window is showing. Eventually the game slows down to 15% normal time and I have it taking up 8GB of memory up from the 5.5GB is started with. Tested with just Squad, PC and Toolbar and if I watch the Resource Monitor I can see the RAM stabilize after flight scene load and after opening the Part Commander window it starts to tick upwards.

Hopefully this isn't an issue in the KSP v1.3 but I didn't see anything in the release notes about plugging a memory leak.

Logs, FWIW

Next time ping me, I didnt see this intil now.

Ill look into it

1 hour ago, Aelfhe1m said:

@linuxgurugamer There's a bug in Part Commander where some localization tags are being displayed instead of being formatted - the ones shown here are stock tags so I don't think it's an interaction with another mod:

Thanks for the report, ill get it fixed

[awang]

How difficult would it be to implement something similar to what All Y'all does?

[linuxgurugamer]

On 8/2/2017 at 9:39 PM, awang said:

How difficult would it be to implement something similar to what All Y'all does?

to do what exactly?

[awang]

8 hours ago, linuxgurugamer said:

to do what exactly?

Sorry, should have specified. All Y'all adds a button in the right-click menu to extend/retract all solar panels/landing gear/etc all at once, even if they are part of a different symmetry group. It's certainly possible that I missed the functionality in Part Commander, though.

[linuxgurugamer]

Why should I add that functionality to this?  As you see, All Y'All does it, so just install that

[SaintWacko]

Anyone else been getting a CTD after about 15-20 minutes in flight scene? Through quite a bit of testing, I figured out that the crash goes away when I remove Part Commander, but it doesn't leave anything in the log. It also goes away for a while if I uninstall Part Commander and reinstall it.

[linuxgurugamer]

I run with it for hours and >200 mods with no problems.

You may not see anything in the log, but that doesn't mean there isn't anything there. Please post the output_log

Also, I'm wondering if you are having memory issues?

[SaintWacko]

It's definitely not a ram issue, I've checked that. I'll reinstall it and grab the log next time it crashes.

[awang]

On 8/7/2017 at 8:59 PM, linuxgurugamer said:

Why should I add that functionality to this?  As you see, All Y'All does it, so just install that

Good point. Guess I was aiming for fewer mods if possible, but doesn't seem like this is one of those times where "merges" makes sense. My bad!

[linuxgurugamer]

New release, 1.1.2:

•     Updated for KSP 1.3.1
•     Updated deploy.bat and buildRelease.bat
•     Updated version number to be in line with original mod

[Drew Kerman]

On 6/19/2017 at 4:35 PM, Drew Kerman said:

had this installed for a while but just started using this under KSP v1.2.2 (Part Commander v0.1.1.1) and it's springing a serious memory leak whenever the window is showing. Eventually the game slows down to 15% normal time and I have it taking up 8GB of memory up from the 5.5GB is started with. Tested with just Squad, PC and Toolbar and if I watch the Resource Monitor I can see the RAM stabilize after flight scene load and after opening the Part Commander window it starts to tick upwards.

Hopefully this isn't an issue in the KSP v1.3 but I didn't see anything in the release notes about plugging a memory leak.

Logs, FWIW

Yea okay I'm finally upgrading to KSP v1.3.1 and just tested with the latest release using nothing but toolbar and Squad folder - the memory leak is still there and readily apparent if you're watching out for it. I have Window's Resource Monitor open and as soon as I show a part's information using Part Commander the memory usage immediately starts to tick upwards. As soon as I either close Part Commander or just return to the parts listing (no longer showing part info but Part Commander itself is still open) the memory usage stabilizes after about a second and no longer increases.

[linuxgurugamer]

Please open an issue on github, if there is one there, add the info

 

thx

[linuxgurugamer]

On 12/25/2017 at 10:18 AM, Drew Kerman said:

Yea okay I'm finally upgrading to KSP v1.3.1 and just tested with the latest release using nothing but toolbar and Squad folder - the memory leak is still there and readily apparent if you're watching out for it. I have Window's Resource Monitor open and as soon as I show a part's information using Part Commander the memory usage immediately starts to tick upwards. As soon as I either close Part Commander or just return to the parts listing (no longer showing part info but Part Commander itself is still open) the memory usage stabilizes after about a second and no longer increases.

Ok, I've created the issue, I'll see if I can look at it this weekend.

One question, if you close the window, does the memory used get returned, or is it kept?

[Drew Kerman]

2 hours ago, linuxgurugamer said:

One question, if you close the window, does the memory used get returned, or is it kept?

It is kept. The memory increase stops, but the memory usage remains the same

[Drew Kerman]

haven't been using this much while the memory leak issue is still open but @linuxgurugamer I had reason to access a hard to reach part the other day and noticed localization strings when viewing the part fields and actions. Have created another github issue for when you get around to it

[linuxgurugamer]

Ok, I'm in a bit of a lull right now, so I hope to be able to look at it later this week

[Gordon Dry]

Also here, has anybody tested this with KSP 1.4.0 yet?