[1.12.x] TAC Self Destruct Continued

[linuxgurugamer]

On 3/6/2017 at 10:50 PM, Mitchz95 said:

Is it possible to trigger the self-destruct by destroying the part, i.e. by hitting it above its impact tolerance?

Also, the self-destruct doesn't seem to work when the countdown is set to 'invisible'.

Can you explain how you determined the self destruct not working when countdown timer not visible?

Thanks

[Mitchz95]

9 hours ago, linuxgurugamer said:

Can you explain how you determined the self destruct not working when countdown timer not visible?

Thanks

It just doesn't go off. The part is "armed"; I have an abort option, but clicking it does nothing and the part just doesn't explode.

[linuxgurugamer]

New release, 1.6.3:

• Fixed self-destruct not working if display was hidden

[linuxgurugamer]

New release, 1.6.4:

Updated for 1.3

[Abrecan]

Thank you for updating this mod!

[Geschosskopf]

@linuxgurugamer:  THANK YOU THANK YOU THANK YOU for getting this mod working.  This is absolutely my favorite mod in the whole, both very useful and extremely entertaining

[linuxgurugamer]

New release, 1.6.5:

• Updated for KSP 1.3.1

[Geschosskopf]

On 10/10/2017 at 9:46 AM, linuxgurugamer said:

New release, 1.6.5:

• Updated for KSP 1.3.1

Yay!

[1990eam]

@linuxgurugamer any plans to update this for 1.4.x?

[linuxgurugamer]

Eventually

[Gordon Dry]

@linuxgurugamer That would be great. No more need of adding control to stages to retro them to reentry burn them or even recover them - when their value isn't as much to have this to be done.

Just kaboom it after it was shot away with retro SRB and gone ...

[linuxgurugamer]

new release, 1.6.6

• Added new field to allow the PAW field to be prepended with "TacSelfDestruct".  See included parts for usage:
  • addPawIdent = true
     

[YourAgony]

great work

[linuxgurugamer]

New release, 1.6.7

• Added parts to ignore for the initial part explosion, various LaunchEscapeSystem parts
• Added yields to allow other mods to react to the initial explosions (ie:  Bob's Panic Box)

There may be some additional updates soon, as I find and add other LES parts

[icecold951]

Is this still working for others? Mine doesn't work right. Parts attached don't self destruct, and if it blows up a part, the bomb stays as debris.

[linuxgurugamer]

On 10/11/2018 at 6:44 PM, icecold951 said:

Is this still working for others? Mine doesn't work right. Parts attached don't self destruct, and if it blows up a part, the bomb stays as debris.

Rather odd, how about providing a log file?

[MalevolentNinja]

KSP: 1.5.1 Windows 64 bit

Problem: SelfDestruct leaves the bomb part and the bomb's parent part (possibly more) when activated if the bomb is not attached to the root part of the vessel.

Mods installed:  TAC Self Destruct 1.6.7.1

Reproduction steps:

Build a simple craft with a few parts and a destruct module (not attached to the root part), on the launchpad right click and initiate "Self Destruct!"

Log: output_log.txt   (the log is not from the vessel in the pictures)

I've built this vessel on its side so parts aren't destroyed from fall damage (which would confuse the issue).

From my testing, it seems to have the most problem with fuel tanks and SRBs. I think it might be hanging on parts with variants?

Edited November 15, 2018 by MalevolentNinja

[Cavscout74]

On 10/11/2018 at 10:44 PM, icecold951 said:

Is this still working for others? Mine doesn't work right. Parts attached don't self destruct, and if it blows up a part, the bomb stays as debris.

Same for me - some things don't blow at all and even if everything goes, the self-destruct gets left behind.  Not on my game computer right now, so I can't do a log at the moment.

[Sidelia]

@linuxgurugamer I'm experiencing the same problem with some parts exploding fine, but others (and notably the part with the TacSelfDestruct module) not. This is in linux player 1.5.1 with v1.6.7.1 of the mod.

Attached is a log snipped from the time TacSelfDestruct activates (via staging) to end. Player.log (pastebin)

[linuxgurugamer]

Would be helpful is a specific sequence of steps and vessel/parts could be provided for me to replicate.  This is relatively minor, and I"m busy with another mod, I don't have a lot of time to look into this, but if I can get a good way to replicate it, I would be able to see what's going on

[Sidelia]

10 hours ago, linuxgurugamer said:

Would be helpful is a specific sequence of steps and vessel/parts could be provided for me to replicate.  This is relatively minor, and I"m busy with another mod, I don't have a lot of time to look into this, but if I can get a good way to replicate it, I would be able to see what's going on

It happens to me randomly even when I just have a fuel tank, X1100, and command pod.

I appreciate the time you put into keeping mods going, and working on your own; to that end I've downloaded the source and poked around - it looks like for some reason the enumeration of vessel.parts changes during the foreach on line 344 of TacSelfDestruct.cs. Changing just that line to foreach (var p in vessel.parts.ToList()) and recompiling against ksp1.5.1 seems to correct the problem on my end in multiple tests using the problematic ships.

Edited December 10, 2018 by Sidelia

[linuxgurugamer]

2 hours ago, Sidelia said:

It happens to me randomly even when I just have a fuel tank, X1100, and command pod.

I appreciate the time you put into keeping mods going, and working on your own; to that end I've downloaded the source and poked around - it looks like for some reason the enumeration of vessel.parts changes during the foreach on line 344 of TacSelfDestruct.cs. Changing just that line to foreach (var p in vessel.parts.ToList()) and recompiling against ksp1.5.1 seems to correct the problem on my end in multiple tests using the problematic ships.

You hit the nail on the head, thank you.

What's happening is that the next line does an explode, which destroys the part and messes up the enumeration.  Unfortunately, what you did, while working, is subject to the same issue.

The correct way to fix this is to either do another while loop, similar to the one above:

                        while (vessel.parts.Count > 0)                           
                        {
                            vessel.parts[0].explode();
                            // Do a yield here in case something else (ie:  Bob's Panic Box) needs to react to the part exploding
                            yield return null;
                        }

I could also have done this:

                        // Explode the rest of the parts
                        for (int x = vessel.parts.Count - 1; x > 0; x--)          
                        {
                            vessel.parts[x].explode();
                            // Do a yield here in case something else (ie:  Bob's Panic Box) needs to react to the part exploding
                            yield return null;
                        }

Either of these work safely, without any issue with parts disappearing from an enumerated list.  I like the first one, it's a bit more efficient

[linuxgurugamer]

18 hours ago, Sidelia said:

@linuxgurugamer I'm experiencing the same problem with some parts exploding fine, but others (and notably the part with the TacSelfDestruct module) not. This is in linux player 1.5.1 with v1.6.7.1 of the mod.

Attached is a log snipped from the time TacSelfDestruct activates (via staging) to end. Player.log (pastebin)

I just looked at the log, which actually shows the error:

InvalidOperationException: Collection was modified; enumeration operation may not execute.
  at System.Collections.Generic.List`1+Enumerator[Part].VerifyState () [0x00000] in <filename unknown>:0 
  at System.Collections.Generic.List`1+Enumerator[Part].MoveNext () [0x00000] in <filename unknown>:0 
  at Tac.TacSelfDestruct+<DoSelfDestruct>c__Iterator0.MoveNext () [0x00000] in <filename unknown>:0 
  at UnityEngine.SetupCoroutine.InvokeMoveNext (IEnumerator enumerator, IntPtr returnValueAddress) [0x00000] in <filename unknown>:0 

Sorry, I was busy yesterday getting ready for my stream.  I appreciate what you did, both in posting the log and recompiling it to test your fix

[linuxgurugamer]

New release, 1.6.8

• Fixed bug causing some parts to not be destroyed
• Removed max version from .version file
• Removed some log spam

For people who haven't yet updated to 1.5.1, you can get a compiled version of the mod for 1.4.5 at the following URL: https://github.com/linuxgurugamer/TacSelfDestruct/releases/download/1.6.8/TacSelfDestruct-1.4.5-1.6.8.zip

 

[Sidelia]

5 hours ago, linuxgurugamer said:

You hit the nail on the head, thank you.

What's happening is that the next line does an explode, which destroys the part and messes up the enumeration.  Unfortunately, what you did, while working, is subject to the same issue.

The correct way to fix this is to either do another while loop, similar to the one above:

                        while (vessel.parts.Count > 0)                           
                        {
                            vessel.parts[0].explode();
                            // Do a yield here in case something else (ie:  Bob's Panic Box) needs to react to the part exploding
                            yield return null;
                        }

I could also have done this:

                        // Explode the rest of the parts
                        for (int x = vessel.parts.Count - 1; x > 0; x--)          
                        {
                            vessel.parts[x].explode();
                            // Do a yield here in case something else (ie:  Bob's Panic Box) needs to react to the part exploding
                            yield return null;
                        }

Either of these work safely, without any issue with parts disappearing from an enumerated list.  I like the first one, it's a bit more efficient

Awesome! Glad to contribute and thanks for the feedback.