[1.12.x] Precise Node Continued - Precisely edit your maneuver nodes

[GFX5000i]

On 8/26/2020 at 8:10 AM, linuxgurugamer said:

Ok, so, it both works AND causes the log spam?

So here is the thing:  I just tested it on a 1.9.1 install.  I tested both a locally compiled version and the download using CKAN.

No log spam using either copy.

So, either you all are crazy (NOT), or the scenario I'm testing is not what you are using.

So I need more info.  I'l start with describing what I'm testing so you can reproduce the test:

1. KSP 1.9.1, with some mods installed, Sandbox game
2. Loaded stock vessel AeroEquus
3. Launched, used MechJeb to get into orbit
4. Switched to Map view
5. Added Maneuver Node, PreciseNode window opened
6. Clicked O for options
7. Enabled the Use intuitive maneuver node handle behaviour toggle

No log spam

I repeat it in a career game, still no problem.

So, I need to know what you are doing.  A save file would be helpful, along with instructions as to what to do, which vessel, etc.

 

Edit:  I took a look at the code, and while I can't replicate the problem, I did see what might be happening.  I also saw an inefficiency which I fixed, which incidentally will fix this issue if it's what I think it is.  Once I can replicate the problem, I can verify (or not) that this will fix it and be able to release.  I'd rather avoid a beta on this.  Please ping me with the  @  sign so I will be notified.

There, I fixed it.

The issue seemed to be the logic that tried to find the nodes and the active Gizmo to override the stock behavior. The way that setup ended up with nothing happening, neither the logic activated nor any errors popped up.
I tested the new logic by creating and deleting multiple nodes while orbiting Kerbin, but I don't know any edge cases to test more.

As a bonus I also fixed the translation for the button "+ Orb" that was displays as "- + Orb".

On another note, I found that the Descending Node button is behaving strangely when there is no target (equatorial DN).
While in an inclined orbit the AN button will always move the node to the same place, but the DN button will always select a new place depending on the vessel position.

I couldn't fix this since the calculation was completely cryptic to me
What I could see is that the KSP provides a function to get the equatorial AN, but not one to the DN, so the manual calculation is probably doing something wrong.

Edit: I shamelessly copied the code for "Eq Desc" from Maneuver Node Evolved and it worked like DMagic.

Edited March 25, 2022 by GFX5000i
Quick update

[pwn]

is there a trick to prevent it from clearing your target when you left-click one of the buttons quickly?

[VegetableMatter]

On 3/25/2022 at 6:24 PM, pwn said:

is there a trick to prevent it from clearing your target when you left-click one of the buttons quickly?

I get the same, it's as if this mod doesn't work with click through blocker (which is a dependency and is installed in my case).

I'm using: -

1.12 KSP

1.2.11.3 Precise Node Continued

0.1.10.17 Click Through Blocker

Steps to reproduce:  create a node on a path, the usual handles appear as does the Precise Node window.  Then left click on the Precise Node window (e.g. a button to add Dv) and the node will deselect because I'm effectively clicking through the menu into space.  Clicking quickly deselects the target because it's an effective double click on space.  This bug occurs with both modes of Click Through Blocker, the follow mouse and click menu first to select.  It seems this mod just doesn't work with Click Through Blocker, which makes me wonder if I'm doing something wrong since the writeup says CTB is a hard dependency.

[linuxgurugamer]

5 hours ago, VegetableMatter said:

I get the same, it's as if this mod doesn't work with click through blocker (which is a dependency and is installed in my case).

I'm using: -

1.12 KSP

1.2.11.3 Precise Node Continued

0.1.10.17 Click Through Blocker

Steps to reproduce:  create a node on a path, the usual handles appear as does the Precise Node window.  Then left click on the Precise Node window (e.g. a button to add Dv) and the node will deselect because I'm effectively clicking through the menu into space.  Clicking quickly deselects the target because it's an effective double click on space.  This bug occurs with both modes of Click Through Blocker, the follow mouse and click menu first to select.  It seems this mod just doesn't work with Click Through Blocker, which makes me wonder if I'm doing something wrong since the writeup says CTB is a hard dependency.

I'll take a look at this, in the meantime, a log file would be useful

[VegetableMatter]

1 hour ago, linuxgurugamer said:

I'll take a look at this, in the meantime, a log file would be useful

 

Thanks for helping, I hope these are satisfactory: -
https://www.dropbox.com/s/6o87g57p6o2hvqu/KSP.log?dl=0
https://www.dropbox.com/s/52d63n4hqaolukt/Player.log?dl=0

Verbose logging was turned on.  I don't have the KSP_x64_Data\output_log.txt, I'm assuming that is for an older version of KSP.

Environment:  I cleared out all my mods except for precise node, click through,  and toolbar control to get a pure testbed, started a new sandbox game, and repeated the issue.  Tested with clicking through one to deselect the node, and quicker clicking to deselect the target.
 

[linuxgurugamer]

New release, 1.2.12

• Thanks to Github user @WagnerGFX for this:
  • Fixed the Intuitive Maneuvers feature. The logic itself is intact, what I changed was another logic that detected new maneuver nodes to add the handler to override the stock behavior.
  • Added a fix to the "+ Orb" button that was displaying as "- + Orb" while only incrementing.
    • This issue was in the English, Spanish and Russian translation, but not on the Chinese one.

[VegetableMatter]

Did you have any luck with the click through issue I reported in the previous posts?  I've downloaded the new 1.2.12 just in case, but the issue persists.

[val778]

Hello,

Thanks for the mod, really useful.

I have one issue though. I was orbiting the Mun and wanted to dock with a space station. So I set it as target, created a manoeuver node and wanted to align my inclination by moving the manoeuver to the ascending node.

However when I click on AN or DN, the manoeuver node moves a bit but ends up not at all aligned with it.  It seems like it tries to align with something else but I don't know what it may be.

Thanks

 

 

[W.O.P.R.]

I'm not sure it's this mod - or rather I suspect it isn't - but I can't create a new maneuver node on the orbital map pane. I have another mod (KSP Resonant Orbit Calculator) that can create one at the AP/PE. So I know I can still use precise node to tweak it - and drag it, etc.

And I know I've had this issue in the past - but I don't remember the fix for it. Anyone have an idea?

Mod LIST: Danger this is large.

Spoiler

[x] Science! Continued (xScienceContinued 6.0.2)
Active Struts (ActiveStruts v3.0.0)
Alarm Enhancements (AlarmEnhancements 1.0.2)
Alternate Resource Panel (AlternateResourcePanel 1:v2.11.0.0)
Antenna Helper (AntennaHelper 2:1.0.7.7)
AutoHibernate (AutoHibernate 1.12.3)
Background Resources (BackgroundResources 1:v0.18.0.0)
BahamutoD Animation Modules (BDAnimationModules 1:v0.6.7.1)
Better Load Save Game Renewed (BetterLoadSaveGame 2.5.3.5)
Better Science Labs Continued (BetterScienceLabsContinued 0.2.1)
Breaking Ground (BreakingGround-DLC 1.7.1)
Champagne Bottle Redux (ChampagneBottleRedux 0.3.11.5)
ClickThrough Blocker (ClickThroughBlocker 1:2.1.10.21)
CommNet Antennas Consumptor (CommNetAntennasConsumptor 3.5.5)
CommNet Antennas Extension (CommNetAntennasExtension 2.1.7)
CommNet Antennas Info (CommNetAntennasInfo 3.1.2)
CommNet Relays (ContractConfigurator-CommNetRelays v2.1.0)
Community Category Kit (CommunityCategoryKit v112.0.1)
Community Parts Titles (CommunityPartsTitles 0.10.2)
Community Parts Titles Extras: Categories (CommunityPartsTitlesExtrasCategory 0.10.2)
Community Parts Titles Extras: CCK - No Duplicates (CommunityPartsTitlesExtrasNoCCKDup 0.10.2)
Community Resource Pack (CommunityResourcePack v112.0.1)
Community Terrain Texture Pack (CommunityTerrainTexturePack 1:1.0.5)
Connected Living Space (ConnectedLivingSpace v2.0.2.0)
Contract Configurator (ContractConfigurator v2.9.2.0)
Crowd Sourced Science (CrowdSourcedScience v6.1)
Custom Barn Kit (CustomBarnKit 1.1.22.0)
Deadly Reentry Continued (DeadlyReentry 1:v.7.9.0)
DeepFreeze Continued... (DeepFreeze V0.31.0.0)
Distant Object Enhancement /L (DistantObject v2.1.1.16)
Distant Object Enhancement /L default config (DistantObject-default v2.1.1.16)
Docking Port Alignment Indicator (DockingPortAlignmentIndicator 6.10.0.0)
Dynamic Battery Storage (DynamicBatteryStorage 2:2.2.5.0)
Easy Vessel Switch (EVS) (EasyVesselSwitch 2.3)
Environmental Visual Enhancements Redux (EnvironmentalVisualEnhancements 3:1.11.7.1)
EVE - Stock Planet Configs (EnvironmentalVisualEnhancements-HR 2:EVE-1.2.2-1)
Extraplanetary Launchpads (ExtraPlanetaryLaunchpads 6.99.3.0)
Ferram Aerospace Research Continued (FerramAerospaceResearchContinued 3:0.16.1.2)
Firespitter Core (FirespitterCore v7.17)
Firespitter Resources config (FirespitterResourcesConfig v7.17)
ForScience! (ForScienceUpdated 1.6.0)
Fuel My Ship (FuelMyShip 1.4)
Harmony 2 (Harmony2 2.2.1.0)
Interstellar Fuel Switch Core (InterstellarFuelSwitch-Core 3.30.0)
ISRU Thanks But No Tanks (ISRUThanksButNoTanks 1:0.1.4.2)
K2 Command Pod Continued (K2CommandPodCont 1.1.11.1)
Kerbal Aircraft Expansion (KerbalAircraftExpansion 4:2.8.1.0)
Kerbal Attachment System (KAS 1.12)
Kerbal Changelog (KerbalChangelog v1.4.2)
Kerbal Engineer Redux (KerbalEngineerRedux 1.1.9.0)
Kerbal Hacks: Droptank "Wrapper" (KerbalHacksDroptankWrapper 1.0)
Kerbal Inventory System (KIS 1.29)
Kerbal Inventory System - No Fun (KerbalInventorySystemNoFun 1:0.1.11.0)
Kerbal Joint Reinforcement Continued (KerbalJointReinforcementContinued v3.7.5.0)
Kerbal Planetary Base Systems (KerbalPlanetaryBaseSystems v1.6.16)
Kerbal Renamer (KerbalRenamer v1.7.0.0)
Kerbal Space Transport System (KSTS 2.0.3.1)
Kethane Mining (Kethane 0.11.0)
Kopernicus Planetary System Modifier (Kopernicus 2:release-1.12.1-204)
KSP AVC (KSP-AVC 1.4.1.9)
KSP Community Fixes (KSPCommunityFixes 1.35.2)
KSP ExtendedAntennaProgression (ExtendedAntennaProgression v0.1.2)
KSP Recall (KSP-Recall v0.5.0.2)
KSP Resonant Orbit Calculator (ResonantOrbitCalculator 0.0.7)
KSPBurst (KSPBurst v1.5.5.1)
Launch Numbering (LaunchNumbering 0.5.4.2)
lfo balancer (LFOBalancer 1.2.2)
Making History (MakingHistory-DLC 1.12.1)
MechJeb 2 (MechJeb2 2.14.3.0)
Milkyway Skybox - SpaceEngine (Milkyway-Skybox-SpaceEngine 1.0)
ModularFlightIntegrator (ModularFlightIntegrator 1.2.10.0)
Module Manager (ModuleManager 4.2.3)
Night Shift (NightShift v0.8.0)
Notes (notes 0.17.0.0-adoption)
NovaPunch Rebalanced (NovaPunchRebalanced 0.1.7.3)
NovaPunchRebalanced Freyja (NovaPunchRebalanced-Freyja 0.1.7.3)
NovaPunchRebalanced Odin (NovaPunchRebalanced-Odin 0.1.7.3)
NovaPunchRebalanced Thor (NovaPunchRebalanced-Thor 0.1.7.3)
OctoSat Continued (OctosatContinued 1:0.1.14.1)
OPM All-in-One KSPedia Delta-V Map  (OPMAllinOneKSPediaDeltaVMap 1.0.1)
OSE Workshop Reworked (OSEWorkShopReworked 1.2.14.3)
Outer Planets Mod (OuterPlanetsMod 2:2.2.10)
Outer Planets Mod - Parallax with Scatters (Parallax-OuterPlanetsMod v1.0.5)
Parallax (Parallax 2.0.6)
Parallax - Stock Planet Textures (Parallax-StockTextures 2.0.0)
Parallax - Stock Scatter Textures (Parallax-StockScatterTextures 2.0.1)
Part Overhaul Integration (PartOverhaulIntegration v0.2.3)
Patch Manager (PatchManager 0.0.17.6)
PlanetShine (PlanetShine 0.2.6.6)
PlanetShine - Default configuration (PlanetShine-Config-Default 0.2.6.6)
Precise Node (PreciseNode 1.2.12)
Procedural Fairings (ProceduralFairings 1:v6.6.0.0)
Procedural Parts (ProceduralParts v2.5.9.0)
Procedural Parts - Hazard Tanks Textures (HazardTanksTextures 1.0)
Procedural Parts - MainSailor's Procedural Textures - Complete Texture Pack (MainSailorTextures-Complete 2.0.0.0.1)
Procedural Parts - MainSailor's Procedural Textures - Essential Textures and Flag (MainSailorTextures-Essentials 2.0.0.0.1)
Procedural Parts - Saturn / Nova Texture Pack (ProceduralParts-Textures-SaturnNova 1.2)
Procedural Parts - Ven's Revamp Style Textures (VensStylePPTextures 1.1)
QuickExit (QuickExit 1:2.2.0.10)
RCS Build Aid (RCSBuildAid v1.0.6)
Real Antennas (RealAntennas v2.2)
RealChute for Stock (RealChuteForStock v1.4.9.4)
RealChute Parachute Systems (RealChute v1.4.9.4)
RealHeat (RealHeat v5.1)
RemoteTech Redev Antennas (RemoteTechRedevAntennas 0.1.1)
REPOSoftTech-Agencies (REPOSoftTech-Agencies V1.5.9.0)
Routine Mission Manager (RoutineMissionManager 1:0.4.0.2)
Scatterer (Scatterer 3:v0.0838)
Scatterer Default Config (Scatterer-config 3:v0.0838)
Scatterer Sunflare (Scatterer-sunflare 3:v0.0838)
Science - Full Reward! (Continued) (Science-Full-Reward v5.2)
Science - Full Transmit! (Science-Full-Transmit v1.1)
Science Lab Info (and 6 Crew Lab) (ScienceLabInfo 2.0.2)
SETI-Greenhouse (SETI-Greenhouse 1.2.1.0)
Ship Manifest (ShipManifest 6.0.8.0)
Smart Parts (SmartParts 1.10)
SmartStage (SmartStage 1:2.9.14.2)
SpaceTux Library (SpaceTuxLibrary 0.0.8.6)
SpacetuxSA (SpacetuxSA 0.3.13.1)
Speed Unit Annex (SpeedUnitAnnex 1.6.0)
SSTO Project (SSTOProject 2.0.2)
StageRecovery (StageRecovery 1.9.7)
Station Keeping (StationKeeping 1:0.2.3.1)
TAC Fuel Balancer (TacFuelBalancer v2.21.5.3)
TAC Life Support (TACLS) (TACLS 1:v0.18.0.0)
TextureReplacer (TextureReplacer v4.5.3)
The Janitor's Closet (JanitorsCloset 0.3.8)
The SSR MicroSat: 0.35m Probe Parts Revived (MicroSatRevived 0.1.4.1)
Toolbar (Toolbar 1:1.8.1.1)
Toolbar Controller (ToolbarController 1:0.1.9.11)
Tracking Station Evolved (TrackingStationEvolved 7.0)
Trajectories (Trajectories v2.4.5.3)
Transfer Window Planner - Fork (TransferWindowPlannerFork v1.9.1.0)
Trim Indicator (TrimIndicator 1.12.0.0)
TweakScale - Rescale Everything! (TweakScale v2.4.8.3)
TweakScale Companion (the "UberPaket") (TweakScaleCompanion 2024.02.20.0)
TweakScale Redistributable (TweakScale-Redist v2.4.8.3)
Universal Storage II Finalized (UniversalStorage2 4.0.1.1)
Ven's New Parts (VenStockRevamp-NewParts v1.16.0)
Ven's Stock Part Revamp (VenStockRevamp v1.16.0)
Ven's Stock Part Revamp Core (VenStockRevamp-Core v1.16.0)

 

[LTQ90]

Hi W.O.P.R.

One possible reason : you re too low in the upgrade of buildings at KSC. it depends on your game mode.

[W.O.P.R.]

Thank you for the reply, I found my issue:

Removing mods via ckan is not as smooth as I would like. I somehow managed to screw up stock config files (likely from MM making edits). Validating those files through steam fixed my save. Though I had to restart due to part conflicts related to the same root cause.