Jump to content

[KSP >= 1.3.0] TweakScale - Under Lisias' Management - 2.4.8.8 - 2024-1117

Lisias

By Lisias
in KSP1 Mod Releases

 Share

Recommended Posts

Turbo Ben

Turbo Ben

Posted
Posted
17 hours ago, Lisias said:

— — POST POST EDIT — — 

Found the misbehaviour - and it explains the whole issue. A fix is work in progress, will be deployed ASAP.

That's great, happy I could help you find the problem. And nicely done! A solution found within 12 hours of me raising the issue, I'm impressed!

It was everything working in sandbox that led me down the techrequired route. Thankfully I haven't noticed the issue with any other parts (yet), but at least I know what to do now. I've kept a copy of the original TriAlpha.cfg file so I can easily test the fix when released.

While I'm here, could I offer a feature suggestion? Is it possible to add tweakscale functionality to parts placed into inventories? ie placing a scaled cargo part into inventories scales mass and volume. I've had a couple of occasions where a part that has been scaled right down takes up half of my cargo space. Don't know how difficult it would be to add, or even if it's possible.

Link to comment
Share on other sites
Lisias

Lisias

Posted
  • Author
Posted (edited)
On 2/13/2024 at 12:05 PM, Turbo Ben said:

That's great, happy I could help you find the problem. And nicely done! A solution found within 12 hours of me raising the issue, I'm impressed!

Don't tell anyone, but me too. :sticktongue:

Seriously, this was one of that absolutely obvious mistakes that only was there for so much time because I didn't noticed the problem before - but once I was aware of it, all I had to do is to sniff my way into the sh… hummm… mess. :)

 

On 2/13/2024 at 12:05 PM, Turbo Ben said:

It was everything working in sandbox that led me down the techrequired route. Thankfully I haven't noticed the issue with any other parts (yet), but at least I know what to do now. I've kept a copy of the original TriAlpha.cfg file so I can easily test the fix when released.

I didn't released it yet because I needed to do an adjustment on KSPe.Light, and also test the damned feature against regressions - I removed a brute force approach that was proved to work (99% of the time, congrats, you found that 1%!!) by a more resilient (and perhaps even performatic) solution - but using things on KSP that I never used before, so I don't know if there's any caveats yet.

The KSPe adjustment is already published, TweakScale will follow in the next hour.

 

On 2/13/2024 at 12:05 PM, Turbo Ben said:

While I'm here, could I offer a feature suggestion? Is it possible to add tweakscale functionality to parts placed into inventories? ie placing a scaled cargo part into inventories scales mass and volume. I've had a couple of occasions where a part that has been scaled right down takes up half of my cargo space. Don't know how difficult it would be to add, or even if it's possible.

Yeah, this is a problem I'm scratching my head about for some time already.

Problem; You can only put into the Inventory stateless parts, i.e., parts that doesn't have a state or, in plain english, parts that just never changes. This is needed because the part is literally destroyed when put into the Inventory, and a prototype with the basic physics' attributes and a link to the prefab's entry for a new pristine part is added to the Inventory instead.

When you scale a part, you change its state. And this state is lost once the part is destroyed - and, so, scaled parts are screwed when shoved into an Inventory.

I have some ideas to implement this feature, but unfortunately, I also have a significant backlog to tackle down too. :( 

But I have it registered on a Issue, so I will not forget about it: https://github.com/TweakScale/TweakScale/issues/320

Cheers!

 

Edited by Lisias
tyops!
Link to comment
Share on other sites
Lisias

Lisias

Posted
  • Author
Posted (edited)

ANNOUNCE

Release 2.4.7.5 is available for downloading, with the following changes:

  • An insidious bug screwing parts that use techRequired was fixed.

Fellow Kerbonaut @Turbo Ben detected and diagnosed a problem on parts using the TweakScale's techRequired attribute (a thingy used to limit some scales to have a tech unlocked). They detected what was happening with precision, and this made my life way easier on diagnosing where and why. Thanks! :)

Since I had to review that code, I decided it's finally the time to get rid of a brute force approach that, besides being there since Kraken knows when and being proved rock solid in the field, had their potential weaknesses that wasn't exploited yet by plain luck.

So I rewrote the thing "the proper way". Problem: I'm using now a KSP's artefact that I never used before, and I don't know exactly how it behaves. So there's a chance this thing goes South on BorderLine situations.

I made some quick Smoke Tests on the thing, and it appears to work fine (including on KSPIE, the known victim of the problem), but really thoughtfully tests  using KSPIE (and anything else that makes good use of techRequired) are needed - mainly looking for borderline situations, since the Happy Path is already known to work fine.

So I'm going to drag my feet on widely publishing this release on CurseForce and SpaceDock while I find time to try to break the thing in new and absurd ways (where KSP, historically, excels!!!). Only KSPIE (that I'm aware) would need it, so it makes sense to delay it to the wide public until I'm confident that I will not get burnt by these new shinny thingy I'm using now.

Know Issues

  • Attachment nodes are being reset when changing Variant on a scaled part. Please change the Variant before scaling the part as a temporary workaround.
    • See issues #307 and #314 for the gory details.
  • There's a long standing issue on TweakScale about scaling ModuleEnginesFX's plumes - some engines' plumes is just not scaled, while others scaled pretty badly. It's something that never worked right on TweakScale, and it will only be really fixed on TweakScale 2.5 (when this thing goes gold)
    • The best workaround (and also the reason I'm dragging my feet on this) is to use SmokeScreen or Waterfall.
      • For SmokeScreen, you need:
        • SmokeScreen itself.
        • Real Plumes (to enable SmokeScreen on Stock parts)
          • Additional Part Sets and Add'Ons may need specialised support not included on Real Plumes.
      • For Waterfall, you need:
        • Waterfall itself.
        • StockWaterfallEffects (to enable SmokeScreen on Stock parts)
          • Additional Part Sets and Add'Ons may need specialised support not included on StockWaterfallEffects.
    • See Issue #27

Disclaimer

By last, but not the least...

Spoiler

No Module Manager, EULA or Forum Publishing Guidelines were harmed during the development of TweakScale.

 

This Release will be published using the following Schedule:

  • GitHub, reaching first manual installers and users of KSP-AVC. Right now.
  • CurseForge. Right now.
  • SpaceDock. Right now.
Edited by Lisias
All your Distribution Channels belongs to us!
Link to comment
Share on other sites
guyontheinternet2000

guyontheinternet2000

Posted
Posted

Getting back into KSP so I downloaded all the CTT mods. One of them is tweakscale and for the past month I've been getting a splash-screen thing like this but I thought I could ignore it. Then my save of 15 hours got deleted so... help? Please?

https://imgur.com/a/nxagj8jfile:/

not sure how to share my log file so... help with that as well, thanks

Link to comment
Share on other sites
Aelfhe1m

Aelfhe1m

Posted
Posted
29 minutes ago, guyontheinternet2000 said:

Getting back into KSP so I downloaded all the CTT mods. One of them is tweakscale and for the past month I've been getting a splash-screen thing like this but I thought I could ignore it. Then my save of 15 hours got deleted so... help? Please?

https://imgur.com/a/nxagj8jfile:/

not sure how to share my log file so... help with that as well, thanks

Share log files by uploading  to a file sharing web service like Dropbox or Google Drive

 

You may be able to recover a backup of your save game. KSP keeps several recent copies in <KSP>/saves/<savename>/Backup. Copy these to a safe place before trying to debug this issue any further. When you have a working version of KSP without the error then copy one of the backup files into the <savename> and rename it to persistent.sfs (after deleting the persistent file that was there previously)

Link to comment
Share on other sites
guyontheinternet2000

guyontheinternet2000

Posted
Posted
38 minutes ago, Aelfhe1m said:

Share log files by uploading  to a file sharing web service like Dropbox or Google Drive

 

You may be able to recover a backup of your save game. KSP keeps several recent copies in <KSP>/saves/<savename>/Backup. Copy these to a safe place before trying to debug this issue any further. When you have a working version of KSP without the error then copy one of the backup files into the <savename> and rename it to persistent.sfs (after deleting the persistent file that was there previously)

https://drive.google.com/file/d/1Ewqbc8EcdwTcl45arZXlsUDeA2I-gX6f/view?usp=sharing

Link to comment
Share on other sites
Lisias

Lisias

Posted
  • Author
Posted (edited)
3 hours ago, guyontheinternet2000 said:

Getting back into KSP so I downloaded all the CTT mods. One of them is tweakscale and for the past month I've been getting a splash-screen thing like this but I thought I could ignore it. Then my save of 15 hours got deleted so... help? Please?

https://imgur.com/a/nxagj8jfile:/

not sure how to share my log file so... help with that as well, thanks

UGH, really UGH… I had coded that message for a reason, sorry. :(   I hope one of the backups mentioned by @Aelfhe1m can restore your game - but I would advise to COPY & PASTE the file, and then rename the copy instead of just rename an "original'. If by a bad of luck another disaster happens, you may lose one of the backups - and, yeah, I was bitten by this before (I really had coded that message for a reason!)

As @Aelfhe1m said above, in order to diagnose your problem I need access to your KSP.log (the whole one, so you need to quit KSP before copying it - trying to copy it with KSP running sometimes truncate the file, rendering it useless). You can use any file sharing service you want, as google drive (remember to allow people to download the file, or I will have to ask permission first and this will made things slower).

If you have a github account, you can create a new discussion here: https://github.com/TweakScale/TweakScale/discussions/categories/support

— — POST EDIT — --

The user's post were approved after I'm posting. :)

So, @guyontheinternet2000, lets dig into your log:

2 hours ago, guyontheinternet2000 said:

https://drive.google.com/file/d/1Ewqbc8EcdwTcl45arZXlsUDeA2I-gX6f/view?usp=sharing

Anyway, let's dig on it. I found the parts mentioned by the FATALity: 

[LOG 13:58:29.334] [TweakScale] ERROR: **FATAL** Part NB0mLFOengine1 (MRS Liquid Fuel Engine, 0.625m "Sparkler") has a fatal problem due having duplicated properties - see issue [#34]( https://github.com/net-lisias-ksp/TweakScale/issues/34 ). at error:0
[LOG 13:58:29.335] [TweakScale] ERROR: **FATAL** Part NBfuelCell1m (MRS Inline Fuel Cell Array) has a fatal problem due having duplicated properties - see issue [#34]( https://github.com/net-lisias-ksp/TweakScale/issues/34 ). at error:0

Duplicated properties was a problem in the part, but nowadays they shouldn't be causing so much trouble. I don't know why your savegame got corrupted, it's some years since I duplicated module caused trouble.

In a way or another, lets see who is patching your parts twice. Follow every patch applied into NB0mLFOengine1: 

[LOG 13:53:50.344] Applying update 999_KSP-Recall/patches/fundskeeper/@PART[*]:HAS[!MODULE[ModuleAsteroid],!MODULE[ModuleComet],!MODULE[KerbalEVA]]:NEEDS[KSPRECALL-FUNDSKEEPER] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:53:51.448] Applying update 999_KSP-Recall/patches/refunding/@PART[*]:HAS[!MODULE[ModuleAsteroid],!MODULE[ModuleComet],!MODULE[KerbalEVA]]:NEEDS[KSPRECALL-REFUNDING] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:53:52.075] Applying update 999_KSP-Recall/patches/stealbackfunds/@PART[*]:HAS[!MODULE[ModuleAsteroid],!MODULE[ModuleComet],!MODULE[KerbalEVA]]:NEEDS[KSPRECALL-STEALBACKFUNDS] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:10.602] Applying update UmbraSpaceIndustries/MKS/Patches/ScrapParts/@PART[*]:HAS[!MODULE[FlagSite],!MODULE[KerbalEVA]] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:28.420] Applying update NecroBones/ModularRocketSystems/Patches/TweakScale/@PART[NB0mLFOengine1]:NEEDS[TweakScale]:FOR[ModularRocketSystems] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:28.610] Applying update NecroBones/ModularRocketSystems/Patches/TweakScale/@PART[NB0mLFOengine1]:NEEDS[TweakScale]:FOR[ModularRocketSystems] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:33.693] Applying update SigmaDimensions/Configs/ReDimension/rescaleAntennas/@PART:FOR[SigDim2] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:35.754] Applying update SigmaDimensions/Configs/ReDimension/rescaleSCANsat/@PART:FOR[SigDim2] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:59.450] Applying update KSPCommunityFixes/MMPatches/ModSupport/KSPRecall/@PART[*]:HAS[@MODULE[Refunding]]:LAST[999_KSP-Recall] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:55:01.073] Applying update KSPCommunityFixes/MMPatches/ModSupport/KSPRecall/@PART[*]:HAS[#hasRefundingOnRecovery[?rue]]:LAST[999_KSP-Recall] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:55:01.302] Applying update KSPCommunityFixes/MMPatches/ModSupport/KSPRecall/@PART[*]:HAS[#hasRefundingOnRecovery]:LAST[999_KSP-Recall] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:55:02.008] Applying update 999_KSP-Recall/patches/attached-on-editor/@PART[*]:HAS[!MODULE[ProceduralPart],!MODULE[WingProcedural],!MODULE[ModuleAsteroid],!MODULE[ModuleComet],!MODULE[KerbalEVA]]:LAST[KSPRECALL-ATTACHED-ON-EDITOR]:NEEDS[TweakScale] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:55:03.329] Applying update InterstellarFuelSwitch/PatchManager/ActiveMMPatches/IntegratedDecoupler/@PART[*]:FINAL to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:55:06.792] Applying update UmbraSpaceIndustries/Konstruction/Patches/EVAConstructionTweaks/@PART[*]:HAS[!MODULE[ModuleCargoPart],#mass]:Final to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:55:08.767] Applying update WarpPlugin/Patches/OreTanksFix/@PART[*]:FINAL to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]

And I found it: 

[LOG 13:54:28.420] Applying update NecroBones/ModularRocketSystems/Patches/TweakScale/@PART[NB0mLFOengine1]:NEEDS[TweakScale]:FOR[ModularRocketSystems] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:28.610] Applying update NecroBones/ModularRocketSystems/Patches/TweakScale/@PART[NB0mLFOengine1]:NEEDS[TweakScale]:FOR[ModularRocketSystems] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]

Let's see the NBfuelCell1m: 

[LOG 13:54:28.427] Applying update NecroBones/ModularRocketSystems/Patches/TweakScale/@PART[NBfuelCell1m]:NEEDS[TweakScale]:FOR[ModularRocketSystems] to NecroBones/ModularRocketSystems/Parts/FuelCell/NBfuelCell1m.cfg/PART[NBfuelCell1m]
[LOG 13:54:28.820] Applying update NecroBones/ModularRocketSystems/Patches/TweakScale/@PART[NBfuelCell1m]:NEEDS[TweakScale]:FOR[ModularRocketSystems] to NecroBones/ModularRocketSystems/Parts/FuelCell/NBfuelCell1m.cfg/PART[NBfuelCell1m]

And, yep, same thing. The problematic patch is on <KSP_ROOT>/GameData/NecroBones/ModularRocketSystems/Patches/TweakScale.cfg. Curiously, I checked the repository for this patch https://github.com/zer0Kerbal/ModularRocketSystems/tree/master/GameData/NecroBones/ModularRocketSystems and didn't found any patches on it!

What's not a surprise because this was already diagnosed and the author removed the problematic patch, that was removed on release 1.13.99.0 (the current one is 1.13.99.2). So you installed an older version, before the fix.

Digging deeper, I detected you are using CKAN, and… Yeah.

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/ModularRocketSystem.netkan

CKAN is pointing to the rigtht place (Necrobones had passed the torch to @zer0Kerbal). The current maintainer fixed the problem but didn't updated SpaceDock. I will enter in touch with him.

Until there, right now your quickest way our of the mess is to manually delete <KSP_ROOT>/GameData/NecroBones/ModularRocketSystems/Patches/TweakScale.cfg.

Additionally, I strongly recommend you remove every instance of "MiniAVC.dll" from your rig. Your KSP.log is littered with exceptions like this: 

[LOG 13:53:40.794] MiniAVC -> System.IO.IOException: Sharing violation on path /home/deck/.local/share/Steam/steamapps/common/Kerbal Space Program/GameData/ContractPacks/GAP/MiniAVC.xml
  at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize,
 System.Boolean anonymous, System.IO.FileOptions options) [0x0019e] in <9577ac7a62ef43179789031239ba8798>:0
  at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode) [0x00000] in <9577ac7a62ef43179789031239ba8798>:0
  at (wrapper remoting-invoke-with-check) System.IO.FileStream..ctor(string,System.IO.FileMode)
  at MiniAVC.AddonSettings.Load (System.String rootPath) [0x0001b] in <ad9b32d02f1147feadee20ffab2cf737>:0
  at MiniAVC.AddonLibrary.ProcessAddonPopulation (System.Object state) [0x0006c] in <ad9b32d02f1147feadee20ffab2cf737>:0

I would also recommend to install the latest TweakScale Companion The ÜberPaket. You have only a handful of Companions installed (FS, PKMC and Restock_Plus), but some add'ons in your rig needs updated patches, like:

Quote

[LOG 13:53:24.964] [TweakScale] WARNING: Kerbal Inventory System (KIS) is installed, but the respective Companion TweakScaleCompanion_KIAS is not! (mandatory?=False
[LOG 13:53:35.398] [TweakScale] WARNING: Cryo Tanks is installed, but the respective Companion TweakScaleCompanion_Frameworks is not! (mandatory?=False
[LOG 13:53:36.464] [TweakScale] WARNING: Waterfall FX is installed, but the respective Companion TweakScaleCompanion_Frameworks is not! (mandatory?=False

None of these are mandatory installs (there's a few add'ons that must have the respective Companion when TweakScale is present), but I think you would like to have them installed nevertheless - at least I think you would like to have your Engines' FX scaled. :)

Cheers!

Edited by Lisias
answering the guy.
Link to comment
Share on other sites
guyontheinternet2000

guyontheinternet2000

Posted
Posted
3 hours ago, Lisias said:

UGH, really UGH… I had coded that message for a reason, sorry. :(   I hope one of the backups mentioned by @Aelfhe1m can restore your game - but I would advise to COPY & PASTE the file, and then rename the copy instead of just rename an "original'. If by a bad of luck another disaster happens, you may lose one of the backups - and, yeah, I was bitten by this before (I really had coded that message for a reason!)

As @Aelfhe1m said above, in order to diagnose your problem I need access to your KSP.log (the whole one, so you need to quit KSP before copying it - trying to copy it with KSP running sometimes truncate the file, rendering it useless). You can use any file sharing service you want, as google drive (remember to allow people to download the file, or I will have to ask permission first and this will made things slower).

If you have a github account, you can create a new discussion here: https://github.com/TweakScale/TweakScale/discussions/categories/support

— — POST EDIT — --

The user's post were approved after I'm posting. :)

So, @guyontheinternet2000, lets dig into your log:

Anyway, let's dig on it. I found the parts mentioned by the FATALity: 

[LOG 13:58:29.334] [TweakScale] ERROR: **FATAL** Part NB0mLFOengine1 (MRS Liquid Fuel Engine, 0.625m "Sparkler") has a fatal problem due having duplicated properties - see issue [#34]( https://github.com/net-lisias-ksp/TweakScale/issues/34 ). at error:0
[LOG 13:58:29.335] [TweakScale] ERROR: **FATAL** Part NBfuelCell1m (MRS Inline Fuel Cell Array) has a fatal problem due having duplicated properties - see issue [#34]( https://github.com/net-lisias-ksp/TweakScale/issues/34 ). at error:0

Duplicated properties was a problem in the part, but nowadays they shouldn't be causing so much trouble. I don't know why your savegame got corrupted, it's some years since I duplicated module caused trouble.

In a way or another, lets see who is patching your parts twice. Follow every patch applied into NB0mLFOengine1: 

[LOG 13:53:50.344] Applying update 999_KSP-Recall/patches/fundskeeper/@PART[*]:HAS[!MODULE[ModuleAsteroid],!MODULE[ModuleComet],!MODULE[KerbalEVA]]:NEEDS[KSPRECALL-FUNDSKEEPER] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:53:51.448] Applying update 999_KSP-Recall/patches/refunding/@PART[*]:HAS[!MODULE[ModuleAsteroid],!MODULE[ModuleComet],!MODULE[KerbalEVA]]:NEEDS[KSPRECALL-REFUNDING] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:53:52.075] Applying update 999_KSP-Recall/patches/stealbackfunds/@PART[*]:HAS[!MODULE[ModuleAsteroid],!MODULE[ModuleComet],!MODULE[KerbalEVA]]:NEEDS[KSPRECALL-STEALBACKFUNDS] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:10.602] Applying update UmbraSpaceIndustries/MKS/Patches/ScrapParts/@PART[*]:HAS[!MODULE[FlagSite],!MODULE[KerbalEVA]] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:28.420] Applying update NecroBones/ModularRocketSystems/Patches/TweakScale/@PART[NB0mLFOengine1]:NEEDS[TweakScale]:FOR[ModularRocketSystems] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:28.610] Applying update NecroBones/ModularRocketSystems/Patches/TweakScale/@PART[NB0mLFOengine1]:NEEDS[TweakScale]:FOR[ModularRocketSystems] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:33.693] Applying update SigmaDimensions/Configs/ReDimension/rescaleAntennas/@PART:FOR[SigDim2] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:35.754] Applying update SigmaDimensions/Configs/ReDimension/rescaleSCANsat/@PART:FOR[SigDim2] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:59.450] Applying update KSPCommunityFixes/MMPatches/ModSupport/KSPRecall/@PART[*]:HAS[@MODULE[Refunding]]:LAST[999_KSP-Recall] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:55:01.073] Applying update KSPCommunityFixes/MMPatches/ModSupport/KSPRecall/@PART[*]:HAS[#hasRefundingOnRecovery[?rue]]:LAST[999_KSP-Recall] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:55:01.302] Applying update KSPCommunityFixes/MMPatches/ModSupport/KSPRecall/@PART[*]:HAS[#hasRefundingOnRecovery]:LAST[999_KSP-Recall] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:55:02.008] Applying update 999_KSP-Recall/patches/attached-on-editor/@PART[*]:HAS[!MODULE[ProceduralPart],!MODULE[WingProcedural],!MODULE[ModuleAsteroid],!MODULE[ModuleComet],!MODULE[KerbalEVA]]:LAST[KSPRECALL-ATTACHED-ON-EDITOR]:NEEDS[TweakScale] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:55:03.329] Applying update InterstellarFuelSwitch/PatchManager/ActiveMMPatches/IntegratedDecoupler/@PART[*]:FINAL to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:55:06.792] Applying update UmbraSpaceIndustries/Konstruction/Patches/EVAConstructionTweaks/@PART[*]:HAS[!MODULE[ModuleCargoPart],#mass]:Final to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:55:08.767] Applying update WarpPlugin/Patches/OreTanksFix/@PART[*]:FINAL to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]

And I found it: 

[LOG 13:54:28.420] Applying update NecroBones/ModularRocketSystems/Patches/TweakScale/@PART[NB0mLFOengine1]:NEEDS[TweakScale]:FOR[ModularRocketSystems] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]
[LOG 13:54:28.610] Applying update NecroBones/ModularRocketSystems/Patches/TweakScale/@PART[NB0mLFOengine1]:NEEDS[TweakScale]:FOR[ModularRocketSystems] to NecroBones/ModularRocketSystems/Parts/Engine/NB0mLFOengine1/part.cfg/PART[NB0mLFOengine1]

Let's see the NBfuelCell1m: 

[LOG 13:54:28.427] Applying update NecroBones/ModularRocketSystems/Patches/TweakScale/@PART[NBfuelCell1m]:NEEDS[TweakScale]:FOR[ModularRocketSystems] to NecroBones/ModularRocketSystems/Parts/FuelCell/NBfuelCell1m.cfg/PART[NBfuelCell1m]
[LOG 13:54:28.820] Applying update NecroBones/ModularRocketSystems/Patches/TweakScale/@PART[NBfuelCell1m]:NEEDS[TweakScale]:FOR[ModularRocketSystems] to NecroBones/ModularRocketSystems/Parts/FuelCell/NBfuelCell1m.cfg/PART[NBfuelCell1m]

And, yep, same thing. The problematic patch is on <KSP_ROOT>/GameData/NecroBones/ModularRocketSystems/Patches/TweakScale.cfg. Curiously, I checked the repository for this patch https://github.com/zer0Kerbal/ModularRocketSystems/tree/master/GameData/NecroBones/ModularRocketSystems and didn't found any patches on it!

What's not a surprise because this was already diagnosed and the author removed the problematic patch, that was removed on release 1.13.99.0 (the current one is 1.13.99.2). So you installed an older version, before the fix.

Digging deeper, I detected you are using CKAN, and… Yeah.

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/ModularRocketSystem.netkan

CKAN is pointing to the rigtht place (Necrobones had passed the torch to @zer0Kerbal). The current maintainer fixed the problem but didn't updated SpaceDock. I will enter in touch with him.

Until there, right now your quickest way our of the mess is to manually delete <KSP_ROOT>/GameData/NecroBones/ModularRocketSystems/Patches/TweakScale.cfg.

Additionally, I strongly recommend you remove every instance of "MiniAVC.dll" from your rig. Your KSP.log is littered with exceptions like this: 

[LOG 13:53:40.794] MiniAVC -> System.IO.IOException: Sharing violation on path /home/deck/.local/share/Steam/steamapps/common/Kerbal Space Program/GameData/ContractPacks/GAP/MiniAVC.xml
  at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize,
 System.Boolean anonymous, System.IO.FileOptions options) [0x0019e] in <9577ac7a62ef43179789031239ba8798>:0
  at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode) [0x00000] in <9577ac7a62ef43179789031239ba8798>:0
  at (wrapper remoting-invoke-with-check) System.IO.FileStream..ctor(string,System.IO.FileMode)
  at MiniAVC.AddonSettings.Load (System.String rootPath) [0x0001b] in <ad9b32d02f1147feadee20ffab2cf737>:0
  at MiniAVC.AddonLibrary.ProcessAddonPopulation (System.Object state) [0x0006c] in <ad9b32d02f1147feadee20ffab2cf737>:0

I would also recommend to install the latest TweakScale Companion The ÜberPaket. You have only a handful of Companions installed (FS, PKMC and Restock_Plus), but some add'ons in your rig needs updated patches, like:

None of these are mandatory installs (there's a few add'ons that must have the respective Companion when TweakScale is present), but I think you would like to have them installed nevertheless - at least I think you would like to have your Engines' FX scaled. :)

Cheers!

Thank you ; ;

Unironically, seems pretty neat to have all this knowledge. Ill do all that stuff you asked me to do and see if itll work. Thanks again!

Link to comment
Share on other sites
TRW

TRW

Posted
Posted

In the post linked below I have made the Tantares Tweakscale config and also an automatic script that searches for all the part files in a mod and creates the relevant cfg for TweakScale. I write it here in case someone searches in this thread for the Tantares (and TantaresLV) config,  or a way to automatically write the TweakScale config.

 

Link to comment
Share on other sites
  • 1 month later...
Lisias

Lisias

Posted
  • Author
Posted

  

ANNOUNCE

Release 2.4.7.6 is available for downloading, with the following changes:

  • Backports from Beta a long standing bug on AutoScale when attaching parts with different scaling methods.
  • Found an idiocy of mine while trying to prevent a hypothetical problem - and ended up creating a concrete one instead.
  • Closes Issues:
    • #323 Auto-Scale is screwed since 2.4.7.0

A major screw up of mine was (finally) detected and fixed.

When I diagnosed yet another misbehaviour on Editor on KSP-Recall, "I thought if could be a good idea"® to really remove TweakScale from the Parts Life Cycle when the part is on the default size. At very least, it would be a module less to debug when weird behaviours like the one on KSP-Recall#61 are detected. BUT...

I completely forgot that unescaled parts can be called to be scaled up or down when Auto-Scale is active, and, so, I broke the toy.

"Fix is pretty obvious." ©2018 Elon Musk, so fixed it I did.

Since I was here, I remembered to backport another Auto-Scale fix into the mainstream branch, this one related to AutoScaling parts scaled with Percentages on Parts scaled in Meters (and vice versa).

KeepWalking.jpg

Thing are slow, but still ongoing. Keep scaling walking.

Know Issues

  • Attachment nodes are being reset when changing Variant on a scaled part. Please change the Variant before scaling the part as a temporary workaround.
    • See issues #307 and #314 for the gory details.
  • There's a long standing issue on TweakScale about scaling ModuleEnginesFX's plumes - some engines' plumes is just not scaled, while others scaled pretty badly. It's something that never worked right on TweakScale, and it will only be really fixed on TweakScale 2.5 (when this thing goes gold)
    • The best workaround (and also the reason I'm dragging my feet on this) is to use SmokeScreen or Waterfall.
      • For SmokeScreen, you need:
        • SmokeScreen itself.
        • Real Plumes (to enable SmokeScreen on Stock parts)
          • Additional Part Sets and Add'Ons may need specialised support not included on Real Plumes.
      • For Waterfall, you need:
        • Waterfall itself.
        • StockWaterfallEffects (to enable SmokeScreen on Stock parts)
          • Additional Part Sets and Add'Ons may need specialised support not included on StockWaterfallEffects.
    • See Issue #27

Disclaimer

By last, but not the least...

Spoiler

No Module Manager, EULA or Forum Publishing Guidelines were harmed during the development of TweakScale.

But a priest may had...

 

This Release will be published using the following Schedule:

  • GitHub, reaching first manual installers and users of KSP-AVC. Right now.
  • CurseForge. Right now.
  • SpaceDock. Right now.

Since this is a minor fix (for a major bug), all the Distributions Channels were updated at once.

Link to comment
Share on other sites
  • 1 month later...
Lisias

Lisias

Posted
  • Author
Posted (edited)
2 hours ago, BronzeShoe20968 said:

I just got 2 fatal errors on my install after downloading some mods and was directed here. (ckan)

logs:

https://drive.google.com/file/d/1mJUWyvusffbvwkMXVo64Rgr7YryjGT8W/view?usp=sharing

Hi!

Yes, I found the problem: 

[LOG 09:29:37.554] [TweakScale] ERROR: **FATAL** Part MEMLander (Munar Excursion Module (M.E.M.)) has a fatal problem due having duplicated properties - see issue [#34]( https://github.com/net-lisias-ksp/TweakScale/issues/34 ). at error:0

You are using an old version of SXT, like.. Older then Making History. MH introduced a part called MEMLander itself, and this screwed people using SXT (classic), because now we have conflicts and add'os like TweakScale gets confused.

I suggest you to update SXT to the "SXT Continued", as it introduces some fixes (not only on renaming the MEMLander) that are handy for modern KSPs, where "modern" is anything after KSP 1.4.3... :)

Let me know if this really fixes the problem!

Edited by Lisias
Let me know...
Link to comment
Share on other sites
Lisias

Lisias

Posted
  • Author
Posted (edited)
15 hours ago, by_HOY_ said:

I ran into a problem. The return price after scaling does not match.
 

  Hide contents

https://prnt.sc/eahNnM2Af0z- The price of the part: 25056

https://prnt.sc/84OGZLzlhLgG Price after return: -17944

 

You are right, I confirm the problem!

There's something wrong on KSP-Recall, as it appears.

Working on it: https://github.com/TweakScale/TweakScale/issues/329

=== == = POST EDIT = == ===

The thing is working on previous KSPs.

https://github.com/TweakScale/TweakScale/issues/329#issuecomment-2095104416

I'm trying to figure out what changed, when and how.

=== == = POST POST EDIT = == ===

It doesn't makes sense. Refunding is not being loaded into a new part, and without it the KSP 1.12.x bug relate to ICostModifier is not handled, screwing TweakScale.

So I moved the issue to there: https://github.com/net-lisias-ksp/KSP-Recall/issues/77

@by_HOY_, do you know exactly when this started to happening? I'm kinda puzzled, because I have remembrances of testing this on the 1.12 KSP series... (besides not impossible I'm wrong - but, dude...)

Edited by Lisias
POST POST EDIT
Link to comment
Share on other sites
by_HOY_

by_HOY_

Posted
Posted (edited)

According to my impression, this happened in some of the recent updates.
Recently, I started my career with 0.2 funds and noticed that something was wrong with the returned funds.
I will try to experiment.

add
https://prnt.sc/bk4fyojTPbER KSP Recall v0.3.0.10 - OK

KSP Recall v0.4.0.0 - OK

KSP Recall v0.4.0.1 - OK

KSP Recall v0.4.0.3 - Fail

Edited by by_HOY_
Link to comment
Share on other sites
Lisias

Lisias

Posted
  • Author
Posted (edited)
8 hours ago, by_HOY_ said:

According to my impression, this happened in some of the recent updates.
Recently, I started my career with 0.2 funds and noticed that something was wrong with the returned funds.
I will try to experiment.

It's odd. StealBackMyFunds is working, and it uses essentially the same mechanisms.

I managed to make the damned Refunding to be loaded by renaming it, besides it didn't recovered any funds. It's like the name "Refunding" became cursed somehow.

DayJob© is calling now, but I will go back to this issue ASAP. I think I need to do some regression tests using previous KSP-Recall releases to see what I find.

=== == = POST EDIT = == ===

KSP Recall 0.3.0.12 is working as expected. So this is something related to a change on newer KSP-Recall that worked fine on KSP 1.11.2 and olders, but some internal change on KSP 1.12.0 ended up screwing it.

The fault of Schrödinger: it's not my fault, but it's my fault.

--- -- - post post eidt - -- ---

This mess started at 0.4.0.3.

@by_HOY_, roll back to 0.4.0.2 for a temporary workaround. Until the end of the day, I will publish something that will solve this issue on a way or another.

--------

Fixed on KSP-Recall 0.5.0.0 .

 

Edited by Lisias
POST EDIT
Link to comment
Share on other sites
by_HOY_

by_HOY_

Posted
Posted (edited)

Works great, but there is one more caveat with the Stage Recovery mod.
With increased details, additional "funds" (Refunding) go as +"fuel".
When reducing (Refunding) has a negative number and is ignored, which makes the return more expensive than the launch itself.

https://prnt.sc/LeWe7PAEkbkO

Temporary solution for me, don't reduce details :)

Edited by by_HOY_
Link to comment
Share on other sites
Lisias

Lisias

Posted
  • Author
Posted (edited)
49 minutes ago, by_HOY_ said:

Works great, but there is one more caveat with the Stage Recovery mod.
With increased details, additional "funds" (Refunding) go as +"fuel".
When reducing (Refunding) has a negative number and is ignored, which makes the return more expensive than the launch itself.

https://prnt.sc/LeWe7PAEkbkO

Temporary solution for me, don't reduce details :)

The Refunding resource is defined to be invisible, nontransferable, untweakble and undrainable: 

RESOURCE_DEFINITION
{
    name = RefundingForKSP111x
    displayName = Refunding
    ...
    flowMode = NO_FLOW
    transfer = NONE
    isTweakable = false
    isVisible = false
    RESOURCE_DRAIN_DEFINITION
    {
        isDrainable = false
        showDrainFX = false
    }
}

It's even more restricted than ElectricCharge: 

RESOURCE_DEFINITION
{
  name = ElectricCharge
  ...
  flowMode = STAGE_PRIORITY_FLOW
  transfer = PUMP
  isTweakable = true
}

So I think this is something to be handled on StageRecovery.

I will check SR source code and see what can be done. The fact is that this will be useful to any other add'on that wants to add resources that should be hidden from the user.

https://github.com/net-lisias-ksp/KSP-Recall/issues/79

Edited by Lisias
link to github issue
Link to comment
Share on other sites
Trollkowski

Trollkowski

Posted
Posted

Hi! Im experiencing an issue with rescaling breaking ground robotics, when I do they appear fine at first but after launching the craft and going back to the sph the nodes are floating way in the distance and after launching the cylinders/hinges and whatnot still have the same range of motion making the whole thing look very weird

NfwAQLb.png

The diameter in the scaling option also doesnt match whatever its connected to, the rotor for example shows 0.800m while connected to structural pieces that are 0.190m

I have quite a lot of mods installed but I was mainly wondering if this is a known issue and if there is any fix for it or if there might be some kind of conflict in the mods? I can provide logs and whatever is necessary

IR seems to scale well but is limited to a few different sizes sadly

Link to comment
Share on other sites
Lisias

Lisias

Posted
  • Author
Posted
2 hours ago, Trollkowski said:

Hi! Im experiencing an issue with rescaling breaking ground robotics, when I do they appear fine at first but after launching the craft and going back to the sph the nodes are floating way in the distance and after launching the cylinders/hinges and whatnot still have the same range of motion making the whole thing look very weird

Are you using the TweakScaleExperimental trick?  The problem with it is that, well, it's experimental and I didn't gave it any serious thought while trying to nailing some pesky mishaps on Editor (what I finally did this month!!! #HURRAY!!!).

On the bright side, it's perfectly possible that by solving these last problems on TweakScale Beta, I ended up solving these ones too by "accident". I'm working on a release for TS "mainstream" this week.

On the other hand, if you don't know what's this Experimental thingy, I'm afraid you are barking on the wrong tree. :)

 

2 hours ago, Trollkowski said:

IR seems to scale well but is limited to a few different sizes sadly

It's IR's maintainer decision. I may override it, but by then you will probably lose support from the maintainer - so I refrained myself from publishing anything on the matter.

But I agree with you, we would do good use of a more versatile resizing options.

Link to comment
Share on other sites
Trollkowski

Trollkowski

Posted
Posted
6 minutes ago, Lisias said:

Are you using the TweakScaleExperimental trick?  The problem with it is that, well, it's experimental and I didn't gave it any serious thought while trying to nailing some pesky mishaps on Editor (what I finally did this month!!! #HURRAY!!!).

On the bright side, it's perfectly possible that by solving these last problems on TweakScale Beta, I ended up solving these ones too by "accident". I'm working on a release for TS "mainstream" this week.

On the other hand, if you don't know what's this Experimental thingy, I'm afraid you are barking on the wrong tree. :)

 

It's IR's maintainer decision. I may override it, but by then you will probably lose support from the maintainer - so I refrained myself from publishing anything on the matter.

But I agree with you, we would do good use of a more versatile resizing options.

Sadly dont know what that is, Ive simply installed the latest version of tweakscale and have done no editing in the configs for tweakscale

 

Link to comment
Share on other sites
Lisias

Lisias

Posted
  • Author
Posted
2 minutes ago, Trollkowski said:

Sadly dont know what that is, Ive simply installed the latest version of tweakscale and have done no editing in the configs for tweakscale

So you are on the wrong thread, or you have something extra on your Rig - send me your KSP.log and I  will check it and pinpoint you to the right direction, or try whatever you are using on the TweakScale 2.4.8.0 that I'm currently testing before kicking it thought the doors (or window, sometimes this thing just drive me nuts! :sticktongue:)

Link to comment
Share on other sites
Trollkowski

Trollkowski

Posted
Posted
12 minutes ago, Lisias said:

So you are on the wrong thread, or you have something extra on your Rig - send me your KSP.log and I  will check it and pinpoint you to the right direction, or try whatever you are using on the TweakScale 2.4.8.0 that I'm currently testing before kicking it thought the doors (or window, sometimes this thing just drive me nuts! :sticktongue:)

Gotcha, so its most likely another mod interfering? Heres my KSP.log  file if you would like to take a peek! :D

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...