Jump to content

[1.9.x] CollisionFX- ReUpdated -1.1.0 (29th/May/2020)


Recommended Posts

I can confirm at least two bugs in version 1.1.0 - I didn't look any further into this than those.

The first is that on initially landing with the wheels, the screech sound keeps playing. This issue does not appear to occur after the gear is retracted and extended.

The second is the horrible framerate drop that starts when sliding on the ground and gets worse the longer the effects are active. This was observed when sliding, specifically with Mk2 plane parts, on the grass just outside the runway.

Only this mod and modulemanger were installed, on a fresh install on Windows 10. My system runs on a Samsung 950 EVO SSD, NVIDIA GTX 1080 graphics card, Intel Core i7-4771, and 16GB of DDR3 RAM. The logs are here, featuring a spam of NotImplementedException errors. I know you're aware of these issues, but I thought maybe more logs from a wider variety of systems might help.

Edited by RyanRising
Link to post
Share on other sites
2 hours ago, SomeoneWhoLikesTrains said:

How do i post Gifs here? Need to know so i can post gifs demonstrating this

Upload them to an image hosting site and post a link here.

or you could create an issue on the github page and just drop your image there.

the forums don’t directly host images.

Link to post
Share on other sites

Hello. I've tried using this mod and whenever i crashed something my console pushed out messages in red saying:

Exception: NotImplementedException: The method or operation is not implemented.

NoYqDRH.png

When i removed this mod i no longer got this messages when crashing. Any ideas?

My modlist and Player.log

https://www.dropbox.com/s/cctd5dlak7m86lb/Player.log?dl=0

Spoiler

AECS_Motion_Suppressor (air brake, engine, & control surface) (AECS-Motion-Suppressor 1.3.2.3)
AlphaMensae's Modular Launch Pads (ModularLaunchPads 2.0.8)
Antenna Helper (AntennaHelper 2:1.0.7.2)
ASET Agency  (ASETAgency 1.0)
ASET Avionics (ASETAvionics 2.1)
ASET Props (ASETProps 1.5)
Astronomer's Visual Pack (AstronomersVisualPack 2:v4.04)
Astronomer's Visual Pack-8k Textures (AVP-8kTextures v1.11)
AtmosphereAutopilot (Fly-By-Wire) (AtmosphereAutopilot v1.5.16)
AutoAGL (AutoAGL 1.2)
B9 Part Switch (B9PartSwitch v2.16.0)
BetterBurnTime (BetterBurnTime 1.10)
BetterTimeWarpContinued (BetterTimeWarpCont 2.3.12.6)
BonVoyage (BonVoyage 1:1.0.1.1)
Camera Focus Changer (CameraFocusChanger 1:1.1.0)
Camera Tools (CameraTools v1.14.0)
Chatterer (Chatterer 0.9.99)
Chatterer Extended (ChattererExtended 0.6.2)
ClickThrough Blocker (ClickThroughBlocker 0.1.9.5)
Community Category Kit (CommunityCategoryKit 5.1.0.0)
Community Delta-V Maps (CommunityDeltaVMaps v2.6.0)
Community Resource Pack (CommunityResourcePack 1.3.0.0)
Contract Configurator (ContractConfigurator 1.28.0)
Contract Parser (ContractParser 9.0)
Contracts Window + (ContractsWindowPlus 9.4)
Craft Manager (CraftManager 1.2.0)
Critical Temperature Gauge (CriticalTemperatureGauge 1.9.1.1)
Custom Barn Kit (CustomBarnKit 1.1.20.0)
Custom Pre Lauch Checks (CustomPreLaunchChecks 1.8.1)
DE IVAExtension (DE-IVAExtension v1.0.2)
Decoupler Shroud (DecouplerShroud 0.7.2)
Destruction Effects (DestructionEffects 2:v1.11.0)
Distant Object Enhancement Continued (DistantObject v2.0.0.2)
Distant Object Enhancement Continued default config (DistantObject-default v2.0.0.2)
Docking Port Alignment Indicator (DockingPortAlignmentIndicator 6.9.1)
Docking Port Descriptions (DockingPortDescriptions 1.0.1.1)
Docking Port Sound FX (DockingPortSoundFX v2.1.12)
Earn Your Stripes! (EarnYourStripes 4.0.2)
Easy Vessel Switch (EVS) (EasyVesselSwitch 2.1)
Engine Lighting Relit (EngineLightRelit 1.6.2.3)
Environmental Visual Enhancements (EnvironmentalVisualEnhancements 2:EVE-1.8.0-2)
EvaFollower (EvaFollower 1:1.1.1.5)
Extended information about scientific experiments in VAB (ScienceSituationInfo 1:1.3.4)
Field Training Facility (FieldTrainingFacility 1.2.0.0)
Filter Extensions - Plugin (FilterExtensions 3.2.5)
Final Frontier (FinalFrontier 1.8.1-3479)
Flight Tracker (FlightTracker 3.0.0.1)
HeapPadder (HeapPadder 0.0.2)
HullcamVDS Continued (HullcamVDSContinued 0.2.0)
Improved and Updated Chase Camera (ImprovedUpdatedChaseCam 1.6.4)
Jet Sounds Continued (JetSoundsContinued 1.3.0.6)
JSIPartUtilities (JSIPartUtilities 0.5.0.4)
Kerbal Alarm Clock (KerbalAlarmClock v3.13.0.0)
Kerbal Attachment System (KAS 1.6)
Kerbal Changelog (KerbalChangelog v1.3.0)
Kerbal Construction Time (KerbalConstructionTime 1:1.4.7.13)
Kerbal Engineer Redux (KerbalEngineerRedux 1.1.7.1)
Kerbal Inventory System (KIS 1.25)
Kerbal Joint Reinforcement - Next (KerbalJointReinforcementNext v4.1.15)
Kerbalism (Kerbalism 3.9)
Kerbalism - Default Config (Kerbalism-Config-Default 3.9)
Kerbal-Konstructs (KerbalKonstructs 1.8.1.15)
Kourageous Tourists (KourageousTourists 0.5.2)
KRASH - Kerbal Ramification Artifical Simulation Hub (simulation mod for KSP) (KRASH 0.5.33)
Kronal Vessel Viewer Continued (KVVContinued 0.1.1)
KSC Extended (KSCExtended 2.2)
KSP AVC (KSP-AVC 1.4.1.4)
KXAPI (KXAPI 1.2.0)
LightsOut Relit (LightsOutRelit v0.3.0.1)
MagiCore (MagiCore 1.3.2.3)
Magpie Mods (MagpieMods 1.5.5)
MechJeb 2 (MechJeb2 2.9.2.0)
Minimum Ambient Lighting Updated (MinAmbLightUpd 1.2.6)
Module Manager (ModuleManager 4.1.3)
Navball Docking Alignment Indicator CE-2 (NavballDockAlignIndCE 1.1.0)
NavHud (NavHudRenewed 1.4.0.4)
NavUtilities continued (NavUtilitiesContinued 0.7.2)
Omega's Stockalike Structures: No Textures Required (StockalikeStructures 0.0.12)
One Window (OneWindow 4.0)
PersistentRotation (PersistentRotation 1.8.7)
PlanetShine (PlanetShine 0.2.6.3)
PlanetShine - Default configuration (PlanetShine-Config-Default 0.2.6.3)
Progress Parser (ProgressParser 11.0)
RasterPropMonitor (RasterPropMonitor 1:v0.31.3)
RasterPropMonitor Core (RasterPropMonitor-Core 1:v0.31.3)
RCS Build Aid Continued (RCSBuildAidCont 1:0.10.0)
Real Plume (RealPlume 2:v13.3.1)
Real Plume - Stock Configs (RealPlume-StockConfigs v4.0.1)
Reentry Particle Effect Renewed (ReentryParticleEffect 1.9.1.1)
ReStock (ReStock 1.1.2)
ReStock Extra - Rigid Legs (RestockRigidLegs 1.1.2)
ReStock+ (ReStockPlus 1.1.2)
SafeChute (SafeChute v2.1.19)
SCANsat (SCANsat v20.1)
scatterer (Scatterer 3:v0.0610)
Scatterer Default Config (Scatterer-config 3:v0.0610)
Scatterer Sunflare (Scatterer-sunflare 3:v0.0610)
ScrapYard (ScrapYard 2.1.0.0)
Ship Effects Continued (ShipEffectsContinued 1.0.11)
SIMPLEX TechTree (SimplexTechTree 1:1.16.2020)
SmokeScreen - Extended FX Plugin (SmokeScreen 2.8.14.0)
StageRecovery (StageRecovery 1.9.2.2)
Strategia (Strategia 1.8.0)
TextureReplacer (TextureReplacer v4.1.3)
Textures Unlimited (TexturesUnlimited 1.5.10.25)
The Janitor's Closet (JanitorsCloset 0.3.7)
Time Control (TimeControl 1:2.9.8)
Toolbar Controller (ToolbarController 1:0.1.9.4)
Tracking Station Evolved (TrackingStationEvolved 6.0)
Training Laboratory (FieldTrainingLaboratory 1.2.0.0)
Tundra's Space Center (TundraSpaceCenter 2.0.1)
Vessel Viewer Continued (VesselView 2:0.8.8.3)
VesselView-UI-RasterPropMonitor (VesselView-UI-RasterPropMonitor 1:0.8.8.3)
Waypoint Manager (WaypointManager 2.8.1)
Zero MiniAVC (ZeroMiniAVC 1:1.1.0.1)
 

 

Link to post
Share on other sites

Bump to second removing the effect for walking Kerbals.

I also experienced the landing screech sound playing over and over after my rover got a little air on a jump.  The rover hopped into the air just a bit when climbing the runway apron at KSC.  The sound played, then kept playing as I drove forward.  Coming to a complete stop and starting forward again made the sound stop.  It was a few sessions ago so, no log unfortunately.  If it happens again I'll grab the log.

Thanks for your work on the mod.

Edit:  TL;DR - I was able to fix the Kerbal EVA sparks issue.  Solution follows.  Pull request sent.

I decided to do a little digging when I noticed that you already had an exemption for KerbalEVA in the settings file.  That prompted me to search my ModuleManager.ConfigCache file to see if those settings were being applied.  Over the course of that expedition, I found the following. 

There are four KerbalEVA "parts" with incorrect CollisionFX module parameters:

  • GameData/SquadExpansion/Serenity/Parts/Prebuilt/KerbalEVA.cfg
  • GameData/SquadExpansion/Serenity/Parts/Prebuilt/KerbalEVAfemale.cfg
  • GameData/SquadExpansion/Serenity/Parts/Prebuilt/KerbalEVAfemaleVintage.cfg
  • GameData/SquadExpansion/Serenity/Parts/Prebuilt/KerbalEVAVintage.cfg

The code in question is:

        MODULE
        {
            name = CollisionFX
            scrapeSparks = true
            collisionSound = CollisionFXReUpdated/Sounds/Bang1
            scrapeSound = CollisionFXReUpdated/Sounds/GroundSkid
            sparkSound = CollisionFXReUpdated/Sounds/SparkSqueal
        }


It should be:

	MODULE
	{
		name = CollisionFX
		scrapeSparks = false
		collisionSound = CollisionFXReUpdated/Sounds/Oof
	}


I also noted that the other parts using the KerbalEVA module had no CollisionFX module parameters at all.  So, in an attempt to correct both situations, I added the following code to GameData\CollisionFXReUpdated\ModuleManager_CollisionFX.cfg:

@PART[*]:HAS[@MODULE[KerbalEVA]]
{        
    MODULE
    {
        name = CollisionFX
        scrapeSparks = false
        collisionSound = CollisionFXReUpdated/Sounds/Oof
    }
}


It works.  :D  I no longer have firey Kerbalian moon boots.  I tested using the same save I've been playing with all week.  It definitely included fire boots prior to this change and it definitely does not, after. 

The GitHub repo for this isn't exactly a repo... just a zip file containing both the source and built files.  I did not want to set up a repo so the best I could do was to fork it, fix the source and prebuilt files in the zip, and then upload the fixed zip compilation.  I put in a pull request to the official repo.  Recommend setting up a proper GitHub when possible to make collaboration easier and changes more transparent.

Until the pull is tested and approved, anyone wishing to try the new, no fire boots version can simply modify their ModuleManager_CollisionFX.cfg file per the code above or download an UNOFFICIAL copy of the mod from my fork at the link below.

CollisionFX-ReUpdated UNOFFICIAL (Fix For Kerbal EVA Sparks)

P.S. It's worth noting I still do not hear the "Oof" sound when a Kerbal collides with something.  I'm not really missing it so, I'll leave that fix for another intrepid community member.  Cheers!

 

Edited by Bearfight
Found a solution to the Kerbal EVA sparks issue.
Link to post
Share on other sites
2 hours ago, Bearfight said:

Bump to second removing the effect for walking Kerbals.

I also experienced the landing screech sound playing over and over after my rover got a little air on a jump.  The rover hopped into the air just a bit when climbing the runway apron at KSC.  The sound played, then kept playing as I drove forward.  Coming to a complete stop and starting forward again made the sound stop.  It was a few sessions ago so, no log unfortunately.  If it happens again I'll grab the log.

Thanks for your work on the mod.

As I have told many, please give me some time till at least 11th July. I will release the release as a beta first

Link to post
Share on other sites
2 minutes ago, VoidCosmos said:

As I have told many, please give me some time till at least 11th July. I will release the release as a beta first

No worries, friend.  Was just reporting and thanking... not rushing.  Hopefully my fix makes one less thing you need to worry about.  Be well!

Link to post
Share on other sites

So I am back at work. Only 1 problem

Spoiler

1>E:\CollisionFX-master\CollisionFX\CollisionFX.cs(54,9,54,25): error CS0246: The type or namespace name 'ParticleAnimator' could not be found (are you missing a using directive or an assembly reference?)

@linuxgurugamer could you please help?

Link to post
Share on other sites
9 hours ago, VoidCosmos said:

So I am back at work. Only 1 problem

  Hide contents

1>E:\CollisionFX-master\CollisionFX\CollisionFX.cs(54,9,54,25): error CS0246: The type or namespace name 'ParticleAnimator' could not be found (are you missing a using directive or an assembly reference?)

@linuxgurugamer could you please help?

What do you need?  Kind of short on information, no source, no full log, no idea of what version of the game, etc.

Link to post
Share on other sites
48 minutes ago, linuxgurugamer said:

What do you need?  Kind of short on information, no source, no full log, no idea of what version of the game, etc.

Like I am getting this error in visual studio. How do I fix it?

Link to post
Share on other sites
2 hours ago, VoidCosmos said:

https://github.com/VoidCosmo/CollisionFX-ReUpdated/releases/tag/2.0

Beta release. I haven't tested it a lot yet. Use at your risk

Quick question, can you elaborate on "Redone the plugin from scratch". Does that mean you rewrote/re-coded the whole plugin from start to end? Or does that mean you recompiled it against the source code of Grigetio/pizzaoverhead?
 

Link to post
Share on other sites
7 hours ago, ValiZockt said:

rewrote/re-coded the whole plugin from start to end?

Mostly. In the sense like I copied the code from the original to a new .cs project in Visual Studio

Link to post
Share on other sites

@VoidCosmos I couldn't help but notice that the GitHub repo consists of the License, Readme, and a single zip file. This goes against the point of Git, so I submitted a Pull Request to move the files out of the zip. (it also explains just why this is bad and recommends GitHub Desktop to make changing the state of the repo easier)

Link to post
Share on other sites
15 hours ago, VoidCosmos said:

https://github.com/VoidCosmo/CollisionFX-ReUpdated/releases/tag/2.0

Beta release. I haven't tested it a lot yet. Use at your risk

So anyone, does it work?

2 hours ago, DeltaDizzy said:

@VoidCosmos I couldn't help but notice that the GitHub repo consists of the License, Readme, and a single zip file. This goes against the point of Git, so I submitted a Pull Request to move the files out of the zip. (it also explains just why this is bad and recommends GitHub Desktop to make changing the state of the repo easier)

Could you please explain how? Thanks

 

15 hours ago, VoidCosmos said:

https://github.com/VoidCosmo/CollisionFX-ReUpdated/releases/tag/2.0

Beta release. I haven't tested it a lot yet. Use at your risk

So anyone, does it work?

2 hours ago, DeltaDizzy said:

@VoidCosmos I couldn't help but notice that the GitHub repo consists of the License, Readme, and a single zip file. This goes against the point of Git, so I submitted a Pull Request to move the files out of the zip. (it also explains just why this is bad and recommends GitHub Desktop to make changing the state of the repo easier)

Could you please explain how? Thanks

 

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...