[KSP 1.2.2][2016-12-13] All Y'All [v0.10.1] One-Button Common Action Grouping

[nightingale]

  On 10/8/2016 at 2:24 AM, 5thHorseman said:

ScienceResetSkill doesn't seem to be a thing. I tried looking for all 3 words and don't see anything that looks reasonable to think is it.

Is it perhaps ultra-new? As in not in the current Steam build?

Expand  

Not that new.  Use either of the following:

using Experience.Effects;
...
crewMember.HasEffect<ScienceResetSkill>();

crewMember.HasEffect<Experience.Effects.ScienceResetSkill>();

 

[Superfluous J]

EDIT NEVER MIND

I lost the () at the end Putting that in fixes all errors.

#CodeNoob

Edited October 8, 2016 by 5thHorseman

[Superfluous J]

Version 0.8 is now on SpaceDock and will be on CKAN whenever that kind of thing happens. It's the same file, so no need to redownload or anything if you already updated manually.

[Skalou]

does it check if the onboard guy with the ScienceResetSkill can perform an EVA in career?(unlocked in the astronaut complex)

[Superfluous J]

  On 10/14/2016 at 11:33 AM, Skalou said:

does it check if the onboard guy with the ScienceResetSkill can perform an EVA in career?(unlocked in the astronaut complex)

Expand  

Note: Right now it doesn't even check for the reset skill, but for the person being a Scientist. I've got the code working but haven't bothered updating.

Anyway, as to the question... It does not. It probably should, but the whole functionality is already in the bounds of cheating and it's not like I'm going to check to see if you're flying in atmosphere, really close to the ground, or experiencing high gee forces as well. Gotta draw the line somewhere, you know? Eventually you have to accept that this is actually side-stepping the whole "get out of the capsule and reset the experiments manually" mechanism. Which IMO is dumb anyway. It's not like the people in the ISS have to hop out on EVA every time they do an experiment.

[Skalou]

  On 10/14/2016 at 12:04 PM, 5thHorseman said:

 it's not like I'm going to check to see if you're flying in atmosphere, really close to the ground, or experiencing high gee forces as well.

Expand  

great ideas though

[dtoxic]

  Reveal hidden contents

[EXC 01:05:14.309] NullReferenceException: Object reference not set to an instance of an object
    ModuleDeployablePart.updateFSM ()
    ModuleDeployablePart.FixedUpdate ()
    ModuleDeployableSolarPanel.FixedUpdate ()
[EXC 01:05:14.325] NullReferenceException: Object reference not set to an instance of an object

Was using Soviet Probe Pack and accidentally clicked on extend all (cant remember the probe name, it has solar panels on it) here is the image of the probe

Maybe you can implement some kind of safety into the code so it does not spam the log if clicked accidentally on this kind of probes with integrated solar panels.

http://i.imgur.com/J8KtVFF.png

 

[Superfluous J]

  On 10/23/2016 at 11:22 PM, dtoxic said:

  Reveal hidden contents

[EXC 01:05:14.309] NullReferenceException: Object reference not set to an instance of an object
    ModuleDeployablePart.updateFSM ()
    ModuleDeployablePart.FixedUpdate ()
    ModuleDeployableSolarPanel.FixedUpdate ()
[EXC 01:05:14.325] NullReferenceException: Object reference not set to an instance of an object

Was using Soviet Probe Pack and accidentally clicked on extend all (cant remember the probe name, it has solar panels on it) here is the image of the probe

Maybe you can implement some kind of safety into the code so it does not spam the log if clicked accidentally on this kind of probes with integrated solar panels.

http://i.imgur.com/J8KtVFF.png

 

Expand  

Hmmm. I may have to make another exception for those like I did for MOLE. Or perhaps do a check to make sure the part actually is deployable. It seems that SPP puts that on solar panels that are not, in fact, deployable.

I've never used it so that's a guess. I'll poke around at it some time this week. Thanks for the report!

[dtoxic]

  On 10/24/2016 at 11:40 PM, 5thHorseman said:

Hmmm. I may have to make another exception for those like I did for MOLE. Or perhaps do a check to make sure the part actually is deployable. It seems that SPP puts that on solar panels that are not, in fact, deployable.

I've never used it so that's a guess. I'll poke around at it some time this week. Thanks for the report!

Expand  

One more thing it also spams the log when you click on Retract all, Also a suggestion if it's possible, to merge Extend All/Refract All into single button?

Edited October 24, 2016 by dtoxic

[Superfluous J]

  On 10/24/2016 at 11:44 PM, dtoxic said:

One more thing it also spams the log when you click on Retract all, Also a suggestion if it's possible, to merge Extract All/Refract All into single button?

Expand  

That's covered in the "Won't Do" in the first post:

Disappearing/reappearing buttons. After a LOT of struggling I've come to the conclusion that I'm just not smart enough for anything more than quick hacks. Every hurdle I cleared trying to get this to work, a dump truck pulled up and dumped a thousand more hurdles. On top of me.

[dtoxic]

  On 10/25/2016 at 12:17 AM, 5thHorseman said:

That's covered in the "Won't Do" in the first post:

Disappearing/reappearing buttons. After a LOT of struggling I've come to the conclusion that I'm just not smart enough for anything more than quick hacks. Every hurdle I cleared trying to get this to work, a dump truck pulled up and dumped a thousand more hurdles. On top of me.

Expand  

Ahhh ok, sorry was to lazy to read the OP

Edit: did you try Toggle button?

Edited October 25, 2016 by dtoxic

[Superfluous J]

  On 10/25/2016 at 12:18 AM, dtoxic said:

Edit: did you try Toggle button?

Expand  

I haven't. I will, when I get time but that could be who knows when.

----

Regarding the mod in general, I've added a download link to GitHub considering SpaceDock seems to have fallen onto hard times.

[linuxgurugamer]

Is this 1.2.1 compatible?  If so, can you get the version info updated so that CKAN can install it?

Thanks

[Superfluous J]

It's a Christmas Miracle!

0.9: MASSIVE rewrite with major additions, all by linuxgurugamer:

• Updated to 1.2.1
• Added Cargo Bays, Drills, Reaction Wheels, Fuel Cells
• Set up single-button functionality.
• Was - in general - awesome.

[Red Shirt]

Is it possible this cool mod would prevent me from adding a simple working cfg to make non-shrouded solar panels retractable?

Here is what I've done (it doesn't work):

@PART[solarPanels3] {
    @retractable = true
}

[monstah]

  On 12/1/2016 at 7:19 PM, Red Shirt said:

Is it possible this cool mod would prevent me from adding a simple working cfg to make non-shrouded solar panels retractable?

Here is what I've done (it doesn't work):

@PART[solarPanels3] {
    @retractable = true
}

Expand  

You're missing the module. I don't have the files to look at right now, but it's something like this:

@PART[solarPanels3] {
    @MODULE[ModuleDeployableSolarPanel]{
        @retractable = true
    }
}

 

[Red Shirt]

  On 12/1/2016 at 7:25 PM, monstah said:

You're missing the module

Expand  

Thank you for following me over here from my original question. Obviously it was slightly more involved than I thought. Now it works!

[dtoxic]

Is there a way to make it so that All Y All ignores non deployable solar panels throu MM patch?

 

[Superfluous J]

  On 12/6/2016 at 6:47 PM, dtoxic said:

Is there a way to make it so that All Y All ignores non deployable solar panels throu MM patch?

 

Expand  

I'm on my phone right now but when I can look at it in need to know, do you want them to not have the menu option? like on ox stats? Do those even have the menu? I'd think not but don't recall ever checking. Or do you want to not "deploy all" on the panels that can't retract?

[dtoxic]

  On 12/6/2016 at 6:56 PM, 5thHorseman said:

I'm on my phone right now but when I can look at it in need to know, do you want them to not have the menu option? like on ox stats? Do those even have the menu? I'd think not but don't recall ever checking. Or do you want to not "deploy all" on the panels that can't retract?

Expand  

Hmm ill have to chek, but here is my scenario, i got deploaybel panels and non deployable, when i click extend all on deployable i get null refs because i guess it tries to extend the other non deployable panels to. my take on it is can we makee it so the mod ignores them all together?

[Superfluous J]

  On 12/6/2016 at 7:03 PM, dtoxic said:

Hmm ill have to chek, but here is my scenario, i got deploaybel panels and non deployable, when i click extend all on deployable i get null refs because i guess it tries to extend the other non deployable panels to. my take on it is can we makee it so the mod ignores them all together?

Expand  

Hmm that's a bug. annoyingly it means that those non deployable panels have the module DeployableSolarPanel which not only grinds my gears, but makes it a bit tricky to code around.

You can't fix that with a config, sadly. it'll require a code change.

Edited December 6, 2016 by 5thHorseman

[monstah]

Seems to me the key difference is that it does not have a animationName attribute on the ModuleDeployableSolarPanel module  

[Superfluous J]

  On 12/6/2016 at 7:14 PM, monstah said:

Seems to me the key difference is that it does not have a animationName attribute on the ModuleDeployableSolarPanel module  

Expand  

...which I can probably use as a check.

[dtoxic]

  On 12/6/2016 at 7:14 PM, monstah said:

Seems to me the key difference is that it does not have a animationName attribute on the ModuleDeployableSolarPanel module  

Expand  

Nice was about to suggest the same thing!

 

 

[Superfluous J]

@dtoxic Wow that's a lot of null ref's. I was expecting one per ox-stat per activation, but it seems to go in a crazy loop.

I've got a fix in place, but I'm fixing something else as well as soon as I figure out how, then I'll do a release with those in it for KSP 1.2.2 (which should work in 1.2.1). Hopefully tonight.

In the meantime, here's the dll. I will fully admit I put it up on my own website because I couldn't figure out where to put it on GitHub:

[defunct site link removed by moderator]

It has some logging in it that is harmless and not too spammy. It won't be in the release dll.