Jump to content

KIS/KAS for 1.1 alpha testing

IgorZ

By IgorZ
in KSP1 Mod Releases

 Share

Recommended Posts

IgorZ

IgorZ

Posted
Posted (edited)

This thread is a temporary place to test pre-release version of KIS/KAS. Once testing is over and stable releases are out this thread is to be closed.

Please, do not consider the binaries posted here as early versions of the the mods. If you just installed them and discovered non-working please do not report it here. It's a know fact that they don't work as expected. On the other hand, if you're willing to help finding and fixing bugs you're more than welcome to post the feedback. Though, in order to make this feedback useful the following is required from you:

  1. Verify that the behavior you're going to report is not in the list of known problems (see a section below).
  2. Ensure it's an issue of the 1.1 version and not generic problem/feature/enhancement/lack of functionality in the 1.0.5 versions.
  3. Provide full list of the other mods installed in the game. For the purpose of testing try to keep the bare minimum of the mods.
  4. Version of your KIS/KAS mods. It's expected you test the latest ones, though.
  5. A very detailed description of what you did and what was the output. Screenshots are very welcome. The more detailed description you give the more chances the bug will be reproduced and fixed.
  6. Try verifying debug logs and if you see anything suspicious - add them into the report. Logs can be seen via UI by pressing Alt+F12, and choosing "Debug". All logs are also written into a file for the current session and can be found in the game's folder under the name `KSP.log`.
  7. Before reporting an issue go thru 1-2 last pages to verify nobody else has reported it already.

Current efforts are tracked on GitHub in branches "KSP-1.1". Current builds:

  • KIS: 2016-04-21 Alpha 5:
    • [Fix] Match rendering queue of KIS pointer to the part's highlight renderers to prevent overlapping issue.
    • [Fix] Restore highlighting of the hovered part when deselecting a hierarchy.
    • [Change] Increase static attach strength on ground base to prevent joint breakage.
    • [Fix] Fix bottom attach node on ground base to make it more stable and prevent explosions on physics start.
    • [Change] Revert turning static attached items kinematic.
  • KAS: 2016-04-21 Alpha 6:
    • [Change] Increase static attach strength on pylon to prevent joint breakage.
    • [Fix] Fix bottom & srf attach nodes on pylon to make it more stable and prevent explosions on physics start.

Always do clean install of every version. I.e. delete whole old folder from the game and then unpack the new version.

Known issues:

  • KIS
    • Ground base only behaves correctly on the ground when attached to the bottom of the part.
  • KAS
    • Some harpoons and ports breaking force can be a little to weak.
    • Ground pylon only behaves correctly on the ground when attached to the bottom of the part.

Previous alpha releases:

  Reveal hidden contents
Edited by IgorZ
Link to comment
Share on other sites
Grumman

Grumman

Posted
Posted

I'll do some proper testing later today, but for now I'll just mention that the KIS compressed folder is misnamed KAS, and that a simple winch test rig (probe core -> inline winch -> port -> weight, all suspended by a launch gantry) is working as expected.

Link to comment
Share on other sites
CraveMode

CraveMode

Posted
Posted (edited)

Thank you for allowing us to help get this ready for 1.1 release. :)

 

By the way, you have the filenames as KAS_v0.6.7_build2 and KAS_v1.2.7_build1.zip. I assume build 1 is KIS, right? Nevermind, I see @Grumman caught it already.

Edited by CraveMode
Link to comment
Share on other sites
Apollo13

Apollo13

Posted
Posted (edited)

Thank you for releasing this.  Will start testing now.

EDIT:  Bill, the Engineer, was working at the launchpad installing stuff on the vessel, and wanted to chill out with some hip-hop while doing so.  So, he placed the Ghetto Blaster, and cranked it to the max.  So, what's he get?  Kanye?  Tupac?  Run DMC?  Nope.  Scott Joplin's "The Entertainer".  NOT IN MY HOOD!!!  Ya know what I'm sayin'?  Meanwhile nearby, Jeb tried to calm him, strumming the Guitar, and singing "Kum Ba Yah".  Who doesn't love Kum Ba Yah?

CdAqSmZ.jpg

Edited by Apollo13
Link to comment
Share on other sites
Koritastic

Koritastic

Posted
Posted (edited)
  On 4/11/2016 at 6:59 AM, IgorZ said:

 

    • Dragging parts with left mouse pressed doesn't work in editor category list. Dragging mode is not supported anymore for the category part list since it's used by Unity for view scrolling. Use Alt+Right click, then drop the part to the desired inventory. Dragging between non-editor inventories works as usual.
Expand  

 

I seriously recommend reverting this and instead forcing the parts list to stop scrolling during the dragging of a part. It feels far more intuitive than the current hold alt and right click method.

 

I added comments to direct you to the changes specifically for fixing this in the old code from 1.0.5

https://github.com/Koritastic/KIS/blob/master/Plugins/Source/KISAddonPickup.cs

Search for any line that has 

// IgorZ:

above it to see what was changed.

 

Hopefully this can help.

Edited by Koritastic
Link to comment
Share on other sites
Apollo13

Apollo13

Posted
Posted (edited)

Question: in previous versions, the Engineer was able to carry an item on his back.  Move to a location, then install it.  I refer to items too large for individual inventory, such as the Gigantor Solar Panel.  I would remove the large item from the SC-62 Storage Unit, and carry it it (visible on the Engineer's back).  Move to the installation site.  Drag and install (H-key) to the vessel.  I am not referring to the Engineer carrying the SC-62 unit on his back to the installation site; just the part itself.

I examined the PDF instructions, and I could not find the instructions on how to do this.  Perhaps, I'm missing something?

Sidebar: +! to Koritastic's suggestion, if doable.

Edited by Apollo13
Link to comment
Share on other sites
IgorZ

IgorZ

Posted
  • Author
Posted
  On 4/11/2016 at 9:26 AM, Grumman said:

I'll do some proper testing later today, but for now I'll just mention that the KIS compressed folder is misnamed KAS, and that a simple winch test rig (probe core -> inline winch -> port -> weight, all suspended by a launch gantry) is working as expected.

Expand  

Thanks for reporting the naming issue. Will be fixed in the next release.

  On 4/11/2016 at 1:55 PM, Koritastic said:

I seriously recommend reverting this and instead forcing the parts list to stop scrolling during the dragging of a part. It feels far more intuitive than the current hold alt and right click method.

 

Expand  

This isn't about technical feasibility only. Dragging feature in the editor is a part of new Unity UI. I'd suggest it's designed for touch screens where "drag-n-scroll" is a natural way to scroll items in the lists. Given there are no scroll buttons anymore it's the only way to scroll parts in the editor if you're on touch screen or your mouse doesn't have wheel. Though, your solution can be used together with a key modifier in which case touchscreen functionality won't be impacted. Anyone have preferences for the modifier: ctrl, alt, or shift? Thanks for the code!

Link to comment
Share on other sites
Koritastic

Koritastic

Posted
Posted
  On 4/11/2016 at 5:49 PM, IgorZ said:

This isn't about technical feasibility only. Dragging feature in the editor is a part of new Unity UI. I'd suggest it's designed for touch screens where "drag-n-scroll" is a natural way to scroll items in the lists. Given there are no scroll buttons anymore it's the only way to scroll parts in the editor if you're on touch screen or your mouse doesn't have wheel. Though, your solution can be used together with a key modifier in which case touchscreen functionality won't be impacted. Anyone have preferences for the modifier: ctrl, alt, or shift? Thanks for the code!

Expand  

Wouldn't this be a moot point considering that KSP can't be played via touch screen only? It feels like trying to create a solution for a problem that doesn't exist and never will with KSP as a whole.

Not to mention that the way I had it setup only blocks scrolling when a part is being dragged AND a KIS inventory is open.

 

Also, there IS a small scrollbar on the side that is draggable when the parts list is longer than a single "page".

Link to comment
Share on other sites
Bombaatu

Bombaatu

Posted
Posted (edited)

Part replication can occur if an item is attached to a node on a part that was added with radial symmetry. The screenshots below show what occurs. The radial attachment points had been added to the craft in the VAB using 2-way symmetry. A MK-V Airlock (from MKS) was attached to one of the radial attachment points and was immediately replicated, able to be attached to another node (had one been in range). This behavior was also observed with the UKS Docking port. 

 

Behavior is slightly different with surface-attach parts attaching to nodes. Using the same test ship, I tried to attach the Z-400 Rechargeable Battery to one of the Radial Attachment Points. The battery would not attach but would replicate with every click (the screwdriver was equipped and X press for the clicking). Replicated parts could then be picked up and surface attached to other locations.

 

KSP 1.1 Build ID 1063499

Mods: KAS v0.5.6 Build 2, KIS v1.2.7 build 1,  USI Kolinization System v 1.0.40.0.0, Community Resource Pack 0.5.0.0, Firespitter Core v7.2.0, Module Manager 2.6.21, USI Core 0.2.0.0, USI Kolinization Core 0.2.0.0, USI Tools 0.7.0.0

EDIT: Reattempted test using just KAS & KIS mods listed above; same KSP build, no other mods. Used a MK-1 Landing can build in VAB with two Radial Attachment Points added with 2-way symmetry. Slightly different behavior; parts would not attach to node  and would replicate, but could not subsequently be grabbed. 

 

 

Here is the log from that test:

  Reveal hidden contents

 

Edited by Bombaatu
Additional information for bug
Link to comment
Share on other sites
Billy_Is_Dead

Billy_Is_Dead

Posted
Posted (edited)

@IgorZ I created a patch just now to fix some of the grammar and stuff in part descriptions and names as well as add search tags to help blend in with the new 1.1 update. To install, drag into the KIS folder. If anyone isn't down for it, I can create some KSPedia entries for the mod as well that blends in with the existing ones (as long as pictures are provided to use).

Edited by Billy_Is_Dead
Link to comment
Share on other sites
blorgon

blorgon

Posted
Posted
  On 4/11/2016 at 6:46 PM, Bombaatu said:

Part replication can occur if an item is attached to a node on a part that was added with radial symmetry. The screenshots below show what occurs. The radial attachment points had been added to the craft in the VAB using 2-way symmetry. A MK-V Airlock (from MKS) was attached to one of the radial attachment points and was immediately replicated, able to be attached to another node (had one been in range). This behavior was also observed with the UKS Docking port. 

Behavior is slightly different with surface-attach parts attaching to nodes. Using the same test ship, I tried to attach the Z-400 Rechargeable Battery to one of the Radial Attachment Points. The battery would not attach but would replicate with every click (the screwdriver was equipped and X press for the clicking). Replicated parts could then be picked up and surface attached to other locations.

KSP 1.1 Build ID 1063499

Mods: KAS v0.5.6 Build 2, KIS v1.2.7 build 1,  USI Kolinization System v 1.0.40.0.0, Community Resource Pack 0.5.0.0, Firespitter Core v7.2.0, Module Manager 2.6.21, USI Core 0.2.0.0, USI Kolinization Core 0.2.0.0, USI Tools 0.7.0.0

EDIT: Reattempted test using just KAS & KIS mods listed above; same KSP build, no other mods. Used a MK-1 Landing can build in VAB with two Radial Attachment Points added with 2-way symmetry. Slightly different behavior; parts would not attach to node  and would replicate, but could not subsequently be grabbed. 

Here is the log from that test:

  Reveal hidden contents

 

Expand  

For what it's worth, I actually had this problem (part replicating after attaching to radial attachment point that was placed in VAB) back in 1.0.5. Just a heads up.

Link to comment
Share on other sites
Apollo13

Apollo13

Posted
Posted (edited)

BUG;  Anchor

The Anchor can be installed on the Winch only with the points facing the Winch.  The anchor cannot be grabbed during EVA.

oeFs5ON.png

I may play with the CFG file to see if I can correct it.

Edited by Apollo13
Link to comment
Share on other sites
Grumman

Grumman

Posted
Posted
  On 4/12/2016 at 2:27 AM, Apollo13 said:

BUG;  Anchor

The Anchor can be installed on the Winch only with the points facing the Winch.  The anchor cannot be grabbed during EVA.

oeFs5ON.png

I may play with the CFG file to see if I can correct it.

Expand  

Are you confusing the anchor with the claw? The anchor works by producing drag if it's resting on something, points up. The claw works by hitting something and getting stuck to it, points down.

Link to comment
Share on other sites
IgorZ

IgorZ

Posted
  • Author
Posted
  On 4/11/2016 at 5:55 PM, Koritastic said:

Wouldn't this be a moot point considering that KSP can't be played via touch screen only? It feels like trying to create a solution for a problem that doesn't exist and never will with KSP as a whole.

Not to mention that the way I had it setup only blocks scrolling when a part is being dragged AND a KIS inventory is open.

Expand  

If I was developer of KSP I would be disappointed when someone tries to ruin my UI concept :) Golden rule in IT world says: don't touch it if it works. And we're going to do quite the opposite. Though, I agree that there are many people who get used to the left mouse dragging in KIS (not to mention it's very convenient). The compromise is to make modifier configurable, including "None" option. And so I'm going to do with default set to "None".

As for the conditions to block the scrolling, keep in mind that KIS "dragging" is not actually a dragging. In KIS it starts right on the left mouse press event. While normally dragging event in UI starts from moving pointer with mouse button pressed. That said, if one have KIS inventory open then any click on the sidebar will trigger scroll blocking.

  On 4/11/2016 at 6:46 PM, Bombaatu said:

Part replication can occur if an item is attached to a node on a part that was added with radial symmetry. The screenshots below show what occurs. The radial attachment points had been added to the craft in the VAB using 2-way symmetry. A MK-V Airlock (from MKS) was attached to one of the radial attachment points and was immediately replicated, able to be attached to another node (had one been in range). This behavior was also observed with the UKS Docking port. ehavior is slightly different with surface-attach parts attaching to nodes. Using the same test ship, I tried to attach the Z-400 Rechargeable Battery to one of the Radial Attachment Points. The battery would not attach but would replicate with every click (the screwdriver was equipped and X press for the clicking). Replicated parts could then be picked up and surface attached to other locations.

Expand  

Thanks for the super awesome bug description! I was able to reproduce it. I wish all the reports were as detailed as this one :)

  On 4/11/2016 at 7:44 PM, Billy_Is_Dead said:

@IgorZ I created a patch just now to fix some of the grammar and stuff in part descriptions and names as well as add search tags to help blend in with the new 1.1 update. To install, drag into the KIS folder. If anyone isn't down for it, I can create some KSPedia entries for the mod as well that blends in with the existing ones (as long as pictures are provided to use).

Expand  

I like the change. Except, may be, description of the EVA tank. It used to be providing useful info on the usage. Now it's not.

  On 4/11/2016 at 9:11 PM, CraveMode said:

If you stick with the key modifier, I naturally like Shift.

Expand  

I'm going to make it configurable.

  On 4/12/2016 at 2:22 AM, teag2 said:

I found a problem

When putting a KAS winch inside a KIS container, it has negative volume. It decreases the volume taken up in a container when you add it...

Expand  

I've put KAS winch into a KIS inventory, and found no problems. I guess, there are more conditions to reproduce the problem which you haven't mentioned. Please, follow the steps in the header of the thread to provide more details on your situation. No repro - no fix, sorry :(

  On 4/12/2016 at 2:27 AM, Apollo13 said:

BUG;  Anchor

The Anchor can be installed on the Winch only with the points facing the Winch.  The anchor cannot be grabbed during EVA.

oeFs5ON.png

I may play with the CFG file to see if I can correct it.

Expand  

Why do you believe an anchor should be installed differently? If it was "HG-02 Grappling hook" I would understand the problem. The anchors, to the best of my knowledge, are usually deployed exactly like this (take a look at the image of any ship).

  On 4/11/2016 at 11:12 PM, Billy_Is_Dead said:

Turns out the part search is being a bit wonky, I'll have to work on it.

However, I realized something. @IgorZ already has KSPedia entries! The PDF has everything needed, all you have to do is resize a bit and convert it into the entries.

Expand  

Well, decomposing PDF into images, and then composing different images from them is not exactly my skill set. Unless there are people who're willing to take this task let's postpone it till the new version release. There are more important things to change.

Link to comment
Share on other sites
Grumman

Grumman

Posted
Posted
  On 4/12/2016 at 4:37 AM, IgorZ said:

Well, decomposing PDF into images, and then composing different images from them is not exactly my skill set. Unless there are people who're willing to take this task let's postpone it till the new version release. There are more important things to change.

Expand  

When somebody does decide to do this, you should know that the GameData/KIS/Parts/Guide folder has the same content as the PDF as DDS image files.

Link to comment
Share on other sites
CraveMode

CraveMode

Posted
Posted (edited)
  On 4/12/2016 at 6:49 AM, Grumman said:

When somebody does decide to do this, you should know that the GameData/KIS/Parts/Guide folder has the same content as the PDF as DDS image files.

Expand  

I won't mind doing this, thanks for pointing out the images in the guide folder. Although, I will probably just export the images and text from the PDF and add them to the panels in Unity so we can get it formatted right and so it can resize properly when the window is resized.

Edited by CraveMode
Link to comment
Share on other sites
Apollo13

Apollo13

Posted
Posted

I was mistaking it for the Grappling Hook.  New problem: I cannot grab the Grappling Hook when attached to a Winch.  Previously, I grabbed the Grappling Hook, and it was attached to the Kerbal's back.  Now, I get a message that says I can't grab it.  I have the same problem with the Anchor; I cannot grab it either if attached to a Winch.

ThzKd5h.png

 

If I'm doing something wrong, then tell me the correct method.

Link to comment
Share on other sites
ExplorerKlatt

ExplorerKlatt

Posted
Posted
  On 4/12/2016 at 12:18 PM, Apollo13 said:

I was mistaking it for the Grappling Hook.  New problem: I cannot grab the Grappling Hook when attached to a Winch.  Previously, I grabbed the Grappling Hook, and it was attached to the Kerbal's back.  Now, I get a message that says I can't grab it.  I have the same problem with the Anchor; I cannot grab it either if attached to a Winch.

 

If I'm doing something wrong, then tell me the correct method.

Expand  

KAS no longer has the grab function. You use KIS functionality to grab the winch heads now. 

Link to comment
Share on other sites
Guest
This topic is now closed to further replies.
 Share
Go to topic listing
×
×
  • Create New...