Jump to content

[KSP >= 1.3.0] TweakScale - Under Lisias' Management - 2.4.8.6 - 2024-0921

Lisias

By Lisias
in KSP1 Mod Releases

 Share

Recommended Posts

Lisias

Lisias

Posted
  • Author
Posted (edited)
2 hours ago, zer0Kerbal said:

 

:NEEDS[SquadExpansion/Serenity] works.

Now I get it! I used the filename too, but only directories count!

Edited by Lisias
Kraken damned Autocorrectors
Link to comment
Share on other sites
Buflak

Buflak

Posted
Posted
10 minutes ago, Gremillion said:

Still getting this message and I've added 

By added you mean you changed that line right?

Make sure the file looks exactly like this: https://github.com/net-lisias-ksp/TweakScale/blob/dev/emergencial/2.4.3.4/Extras/TweakScale/HotFixes/RO-Stock_Electrical.cfg

It works for me, and i've had the exact same problem as you, with the batteryBankMini part.

 

Link to comment
Share on other sites
Gremillion

Gremillion

Posted
Posted
1 minute ago, Buflak said:

By added you mean you changed that line right?

Make sure the file looks exactly like this: https://github.com/net-lisias-ksp/TweakScale/blob/dev/emergencial/2.4.3.4/Extras/TweakScale/HotFixes/RO-Stock_Electrical.cfg

It works for me, and i've had the exact same problem as you, with the batteryBankMini part.

 

Yes I added that file with that line configuration.

Link to comment
Share on other sites
Buflak

Buflak

Posted
Posted (edited)

And the file is somewhere inside your GameData folder and it's extension is .cfg i assume?

Oh, and this path: "RealismOverhaul/RO_SuggestedMods/Squad" does exist in your install?

It looks like maybe the hotfix doesn't even load for some reason.

Unfortunately that's all i got. You might want to post your MM cache so when Lisias gets here he can take a look at it.

Edited by Buflak
Link to comment
Share on other sites
Buflak

Buflak

Posted
Posted (edited)

That's the one. It does indeed look like the hotfix is not loaded.

I assume this path:  "RealismOverhaul/RO_SuggestedMods/Squad" exists in your install?

There are also slight differences for this part in your MM cache and mine, i assume that's because you use different mods.

For comparison:

Spoiler 

mine, works:

UrlConfig
{
	parentUrl = Squad/Parts/Electrical/z-200Battery/z-200Battery
	PART
	{
		name = batteryBankMini
		module = Part
		author = Squad
		mesh = model.mu
		rescaleFactor = 1.0
		node_stack_top = 0.0, 0.1, 0.0, 0.0, 1.0, 0.0, 0
		node_stack_bottom = 0.0, -0.1, 0.0, 0.0, -1.0, 0.0, 0
		node_attach = 0.0, 0.0, 0.3125, 0.0, 1.0, 0.0
		TechRequired = electrics
		entryCost = 3200
		cost = 360
		category = Electrical
		subcategory = 0
		title = Z-200 Rechargeable Battery Bank
		manufacturer = Zaltonic Electronics
		description = The Z-200 is a stackable variant of the Z-100 battery pack, with increased capacity. In emergency situations, please refrain from "reversing the polarity".
		attachRules = 1,1,1,1,0
		mass = 0.07731
		dragModelType = default
		maximum_drag = 0.2
		minimum_drag = 0.2
		angularDrag = 1
		bulkheadProfiles = size0
		tags = bank capacitor cell charge e/c elect pack power volt watt
		maxTemp = 1073.15
		crashTolerance = 12
		gTolerance = 100
		maxPressure = 20000
		breakingForce = 250
		breakingTorque = 250
		RESOURCE
		{
			name = ElectricCharge
			amount = 20500
			maxAmount = 20500
		}
		MODULE
		{
			name = AYPart
		}
		MODULE
		{
			name = TweakScale
			type = stack
			defaultScale = 0.625
			type = RealismOverhaulStackSolid
			name = TweakScale
			defaultScale = 0.625
			type = RealismOverhaulStackSolid
			HOTFIX = https:
		}
		MODULE
		{
			name = GeometryPartModule
		}
		MODULE
		{
			name = FARAeroPartModule
		}
		MODULE
		{
			name = FARPartModule
		}
	}
}

yours, doesn't work:

UrlConfig
{
	parentUrl = Squad/Parts/Electrical/z-200Battery/z-200Battery.cfg
	PART
	{
		name = batteryBankMini
		module = Part
		author = Squad
		mesh = model.mu
		rescaleFactor = 1.0
		node_stack_top = 0.0, 0.1, 0.0, 0.0, 1.0, 0.0, 0
		node_stack_bottom = 0.0, -0.1, 0.0, 0.0, -1.0, 0.0, 0
		node_attach = 0.0, 0.0, 0.3125, 0.0, 1.0, 0.0
		TechRequired = electrics
		entryCost = 3200
		cost = 360
		category = Electrical
		subcategory = 0
		title = Z-200 Rechargeable Battery Bank
		manufacturer = Zaltonic Electronics
		description = The Z-200 is a stackable variant of the Z-100 battery pack, with increased capacity. In emergency situations, please refrain from "reversing the polarity".
		attachRules = 1,1,1,1,0
		mass = 0.07731
		dragModelType = default
		maximum_drag = 0.2
		minimum_drag = 0.2
		angularDrag = 1
		bulkheadProfiles = size0
		tags = bank capacitor cell charge e/c elect pack power volt watt
		maxTemp = 1073.15
		crashTolerance = 12
		gTolerance = 100
		maxPressure = 20000
		breakingForce = 250
		breakingTorque = 250
		RESOURCE
		{
			name = ElectricCharge
			amount = 20500
			maxAmount = 20500
		}
		MODULE
		{
			name = FMRS_PM
			parent_vessel = 0
		}
		MODULE
		{
			name = TweakScale
			type = stack
			defaultScale = 0.625
			type = RealismOverhaulStackSolid
		}
		MODULE
		{
			name = GeometryPartModule
		}
		MODULE
		{
			name = FARAeroPartModule
		}
		MODULE
		{
			name = FARPartModule
		}
		MODULE
		{
			name = ModuleAeroReentry
			skinHeatConductivity = 0.001
			leaveTemp = True
		}
		MODULE
		{
			name = ModuleB9PropagateCopyEvents
		}
	}
}

 

The modules you have and i don't:

"name = FMRS_PM" - flight manager for reusable stages?

"name = ModuleAeroReentry" - deadly reentry?

"name = ModuleB9PropagateCopyEvents" - b9 partswitch?

Could you try removing these mods to see what happens?

Edited by Buflak
Link to comment
Share on other sites
Gremillion

Gremillion

Posted
Posted (edited)
14 minutes ago, Buflak said:

That's the one. It does indeed look like the hotfix is not loaded.

I assume this path:  "RealismOverhaul/RO_SuggestedMods/Squad" exists in your install?

There are also slight differences for this part in your MM cache and mine, i assume that's because you use different mods.

For comparison:

  Hide contents 


mine, works:

UrlConfig
{
	parentUrl = Squad/Parts/Electrical/z-200Battery/z-200Battery
	PART
	{
		name = batteryBankMini
		module = Part
		author = Squad
		mesh = model.mu
		rescaleFactor = 1.0
		node_stack_top = 0.0, 0.1, 0.0, 0.0, 1.0, 0.0, 0
		node_stack_bottom = 0.0, -0.1, 0.0, 0.0, -1.0, 0.0, 0
		node_attach = 0.0, 0.0, 0.3125, 0.0, 1.0, 0.0
		TechRequired = electrics
		entryCost = 3200
		cost = 360
		category = Electrical
		subcategory = 0
		title = Z-200 Rechargeable Battery Bank
		manufacturer = Zaltonic Electronics
		description = The Z-200 is a stackable variant of the Z-100 battery pack, with increased capacity. In emergency situations, please refrain from "reversing the polarity".
		attachRules = 1,1,1,1,0
		mass = 0.07731
		dragModelType = default
		maximum_drag = 0.2
		minimum_drag = 0.2
		angularDrag = 1
		bulkheadProfiles = size0
		tags = bank capacitor cell charge e/c elect pack power volt watt
		maxTemp = 1073.15
		crashTolerance = 12
		gTolerance = 100
		maxPressure = 20000
		breakingForce = 250
		breakingTorque = 250
		RESOURCE
		{
			name = ElectricCharge
			amount = 20500
			maxAmount = 20500
		}
		MODULE
		{
			name = AYPart
		}
		MODULE
		{
			name = TweakScale
			type = stack
			defaultScale = 0.625
			type = RealismOverhaulStackSolid
			name = TweakScale
			defaultScale = 0.625
			type = RealismOverhaulStackSolid
			HOTFIX = https:
		}
		MODULE
		{
			name = GeometryPartModule
		}
		MODULE
		{
			name = FARAeroPartModule
		}
		MODULE
		{
			name = FARPartModule
		}
	}
}

yours, doesn't work:

UrlConfig
{
	parentUrl = Squad/Parts/Electrical/z-200Battery/z-200Battery.cfg
	PART
	{
		name = batteryBankMini
		module = Part
		author = Squad
		mesh = model.mu
		rescaleFactor = 1.0
		node_stack_top = 0.0, 0.1, 0.0, 0.0, 1.0, 0.0, 0
		node_stack_bottom = 0.0, -0.1, 0.0, 0.0, -1.0, 0.0, 0
		node_attach = 0.0, 0.0, 0.3125, 0.0, 1.0, 0.0
		TechRequired = electrics
		entryCost = 3200
		cost = 360
		category = Electrical
		subcategory = 0
		title = Z-200 Rechargeable Battery Bank
		manufacturer = Zaltonic Electronics
		description = The Z-200 is a stackable variant of the Z-100 battery pack, with increased capacity. In emergency situations, please refrain from "reversing the polarity".
		attachRules = 1,1,1,1,0
		mass = 0.07731
		dragModelType = default
		maximum_drag = 0.2
		minimum_drag = 0.2
		angularDrag = 1
		bulkheadProfiles = size0
		tags = bank capacitor cell charge e/c elect pack power volt watt
		maxTemp = 1073.15
		crashTolerance = 12
		gTolerance = 100
		maxPressure = 20000
		breakingForce = 250
		breakingTorque = 250
		RESOURCE
		{
			name = ElectricCharge
			amount = 20500
			maxAmount = 20500
		}
		MODULE
		{
			name = FMRS_PM
			parent_vessel = 0
		}
		MODULE
		{
			name = TweakScale
			type = stack
			defaultScale = 0.625
			type = RealismOverhaulStackSolid
		}
		MODULE
		{
			name = GeometryPartModule
		}
		MODULE
		{
			name = FARAeroPartModule
		}
		MODULE
		{
			name = FARPartModule
		}
		MODULE
		{
			name = ModuleAeroReentry
			skinHeatConductivity = 0.001
			leaveTemp = True
		}
		MODULE
		{
			name = ModuleB9PropagateCopyEvents
		}
	}
}

 

The modules you have and i don't:

name = FMRS_PM - flight manager for reusable stages?

name = ModuleAeroReentry - deadly reentry?

ModuleB9PropagateCopyEvents - b9 partswitch?

 

Could you try what happens if you remove these mods?

 

Answering questions:

Yes that path exists.

Correct on all 3 counts. I'll try removing  DR and FMRS. Can't remove B9 without removing other dependencies.

Still getting it after removing DR and FMRS:
 

vteTW2h.jpg

Edited by Gremillion
Link to comment
Share on other sites
Gremillion

Gremillion

Posted
Posted

It's a lot of dependencies. We'll see.
 

@Starwaster tagging you here because it's related (same build).

10 minutes ago, Buflak said:

So the last thing i can suggest is to remove B9, don't worry about the dependencies for now.

Just want to narrow it down as to what might be causing that hotfix to not load.

Still not happy:

kQoMQNg.jpg

Link to comment
Share on other sites
Starwaster

Starwaster

Posted
Posted (edited)

What is being

18 minutes ago, Gremillion said:

It's a lot of dependencies. We'll see.
 

@Starwaster tagging you here because it's related (same build).

Ok, not understanding what's being inquired of me...

Though I do see some serious glaring error in @Buflak 's config snippet there. Whatever patched that config needs to be taken behind the woodshed and executed with a gunshot to the head regardless of whether it worked or not, SOMETHING did not patch that in correctly and it needs looking at. Yes it worked because the first name, type and defaultScale are all that got used but the fact that it's in that condition says it was written badly. 

Spoiler 

		MODULE
		{
			name = TweakScale
			type = stack
			defaultScale = 0.625
			type = RealismOverhaulStackSolid
			name = TweakScale
			defaultScale = 0.625
			type = RealismOverhaulStackSolid
			HOTFIX = https:
		}

 

 

Edited by Starwaster
Link to comment
Share on other sites
Lisias

Lisias

Posted
  • Author
Posted
24 minutes ago, Starwaster said:

Whatever patched that config needs to be taken behind the woodshed and executed with a gunshot to the head regardless of whether it worked or not, SOMETHING did not patch that in correctly and it needs looking at.

On that we have an agreement! :) 

@PART[batteryBankMini]:FOR[RealismOverhaul] // Good for ReStock
{
	%RSSROConfig = True
	@RESOURCE[ElectricCharge]
	{
		@amount = 20500
		@maxAmount = 20500
	}
	@mass = 0.07731
	@MODULE[TweakScale]
	{
		type = RealismOverhaulStackSolid
	}
}

https://github.com/KSP-RO/RealismOverhaul/blob/master/GameData/RealismOverhaul/RO_SuggestedMods/Squad/RO_Squad_Electrical.cfg

Link to comment
Share on other sites
Gremillion

Gremillion

Posted
Posted
16 minutes ago, Lisias said:

On that we have an agreement! :) 


@PART[batteryBankMini]:FOR[RealismOverhaul] // Good for ReStock
{
	%RSSROConfig = True
	@RESOURCE[ElectricCharge]
	{
		@amount = 20500
		@maxAmount = 20500
	}
	@mass = 0.07731
	@MODULE[TweakScale]
	{
		type = RealismOverhaulStackSolid
	}
}

https://github.com/KSP-RO/RealismOverhaul/blob/master/GameData/RealismOverhaul/RO_SuggestedMods/Squad/RO_Squad_Electrical.cfg

Uh, for the less... observant in the thread, what should we be doing with that?

Link to comment
Share on other sites
Lisias

Lisias

Posted
  • Author
Posted (edited)
17 hours ago, Gremillion said:

Uh, for the less... observant in the thread, what should we be doing with that?

Well… If the RO guys would agree on following the MM rules for patching, that would help. We would not had the need to applying that patch at first place. :) The patch needs a :NEEDS to avoid patching TweakScale on systems without it, and a way to make sure it is applied after TweakScale ones.

— post edit — 

I failed to correctly explain all the problems with that patches. The :NEEDS is the lesser of them, the real problems are that RO's patches are being applied without using "%", what ends up adding up a new "type" datum on the module's section. This is what triggering the #34 FATAL error, as this is, essentially, what makes things indeterministic while patching: relying on Module Manager's legacy patching, then blindly applying new values without deleting/editing the older ones disregarding whatever is there.

And this is also the reason I can't, now, just shove the "::FOR" on TweakScale patches and solve some problems for good. A lot of patches are doing exactly like this, and the exactly instant I publish patches using ":FOR", TweakScale will not be run on legacy anymore, and an awful amount of patches will silently FAIL and then people will say "TweakScale works funny with specific parts." :confused: 

"T" is on the end of the alphanumerical ordering, right? Everything named before TweakScale will just break. :P

— — post post edit — — 

A full explanation about how to fix these patches were already discussed on this post.

Edited by Lisias
post edit
Link to comment
Share on other sites
Gremillion

Gremillion

Posted
Posted
Just now, Lisias said:

Well… If the RO guys would agree on following the MM rules for patching, that would help. We would not had the need to applying that patch at first place. :) The patch needs a :NEEDS to avoid patching TweakScale on systems without it, and a way to make sure it is applied after TweakScale ones.

Just a notepad file in the same place as the previous patch?

Link to comment
Share on other sites
Lisias

Lisias

Posted
  • Author
Posted (edited)
17 hours ago, The Kerbal King said:

I'm getting a fatal error warning on the loading screen running KSP 1.6.1 with RSS, RO, RP1 and Tweak Scale 2.4.3.3. I can find the output_txt log but here is my ksp log: https://drive.google.com/open?id=1WdFXf_Tn7NV3YSQFf3P84pXTciDCzfme

Got it. Sorry for that. Your log says: 

[LOG 23:52:43.579] [TweakScale] WARNING: **FATAL** Found a showstopper problem on batteryBankMini (Z-200 Rechargeable Battery Bank).
[LOG 23:52:43.580] [TweakScale] ERROR: **FATAL** Part batteryBankMini (Z-200 Rechargeable Battery Bank) has a fatal problem due having duplicated properties - see issue [#34]( https://github.com/net-lisias-ksp/TweakScale/issues/34 ).
[LOG 23:52:59.754] [TweakScale] WARNING: **FATAL** Found a showstopper problem on SXTInlineAirIntake (XM-600 1.25m Air Intake).
[LOG 23:52:59.754] [TweakScale] ERROR: **FATAL** Part SXTInlineAirIntake (XM-600 1.25m Air Intake) has a fatal problem due having duplicated properties - see issue [#34]( https://github.com/net-lisias-ksp/TweakScale/issues/34 ).
[LOG 23:53:27.954] [TweakScale] WARNING: **FATAL** Found a showstopper problem on SXTOsaulNoseCockpitAn225 (An-124 Cockpit).
[LOG 23:53:27.954] [TweakScale] ERROR: **FATAL** Part SXTOsaulNoseCockpitAn225 (An-124 Cockpit) has a fatal problem due having duplicated properties - see issue [#34]( https://github.com/net-lisias-ksp/TweakScale/issues/34 ).
[LOG 23:53:27.955] [TweakScale] WARNING: **FATAL** Found a showstopper problem on SXTOsualRadCockpit (An-124 Cockpit Radial).
[LOG 23:53:27.955] [TweakScale] ERROR: **FATAL** Part SXTOsualRadCockpit (An-124 Cockpit Radial) has a fatal problem due having duplicated properties - see issue [#34]( https://github.com/net-lisias-ksp/TweakScale/issues/34 ).

These are essentially two problems: a older SXT version (the newest release has this fixed, pleas update it), but also the exact problem of the fellow Kerbonaut above.

I have a patch for this problem, however by some reason that patch is not working exactly as I expect, and I'm tweaking it to make it work properly. Stay tuned, I'm working on it right now.

In the mean time, update your SXT to the latest (link to SpaceDock). This will solve all the FATALities, but one - the one I'm working on the patch now.

— — post edit — — 

I finally came to terms with the patch - it was, well… a kind of silly typo - I used a "@" when should had used a "%", and didn't realized the mistake until our fellow Kerbonaut @Buflak found a second way to solve the problem - and then a ring did bell somewhere in my dull head. :P

@The Kerbal King, this will solve the RO glitches on your installment:

  1. Download this file. (click on "Raw").
  2. Move it to a directory under your GameData.
    1. I suggest GameData/__LOCAL/TweakScale/HotFixes - but anyone will do. You must remember where  you put, however, as eventually it will not be more necessary and then it can harm the game. It's the reason an Advise will popup on startup when HotFixes are active.

Sorry the late. I intended to publish this by morning, but ended up waking a bit late today and just managed to find time now. :P 

Kick me here if you need more assistance.

Scale safe! :sticktongue:

Edited by Lisias
Post edit
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...