I'm confused (can't think of a better title)

[OrdinaryKerman]

@PART[tbee-taerobee-aerobee]
{
	@maxTemp = 2000
	@cost = 90
	@MODULE[ModuleEngines]
	{
		@atmosphereCurve
		{
			@key,0 = 0 240
			@key,1 = 1 210
			key,2 = 5 0
		{
	{
{

@PART[tbee-bumper-engine]
{
	@cost = 210
	@MODULE[ModuleEnginesFX]
	{
		@atmosphereCurve
		{
			@key,0 = 0 235
			@key,1 = 1 205
			key,2 = 5 0
		{
	{
{

@PART[tbee-bumper-engine-unclad]
{
	@cost = 190
	@MODULE[ModuleEnginesFX]
	{
		@atmosphereCurve
		{
			@key,0 = 0 235
			@key,1 = 1 205
			key,2 = 5 0
		{
	{
{

//taerobee control computer

@PART[tbee-taerobee-control]
{
	@cost = 300
	!MODULE[ModuleReactionWheel] {}
	!MODULE[ModuleSAS] {}
}

Is there some basic mistake I've missed in the second, third, and fourth patches that makes ModuleManager not apply them as it did with the first?

[HebaruSan]

42 minutes ago, OrdinaryKerman said:

Is there some basic mistake I've missed in the second, third, and fourth patches that makes ModuleManager not apply them as it did with the first?

Yes. All of your braces are open braces ("{"), until the last three lines. The ones at the ends of blocks should be close braces ("}").

[OrdinaryKerman]

2 hours ago, HebaruSan said:

Yes. All of your braces are open braces ("{"), until the last three lines. The ones at the ends of blocks should be close braces ("}").

Oh, right. Thanks! Don't know how I missed that.

[zer0Kerbal]

@OrdinaryKerman that is a new one for me.

Why not just put a PR or an issue here (GitHub) and I can just fix the issues. too high temp/too low price etc?

Constructive Feedback is something sadly lacking in my kerbal existence

[OrdinaryKerman]

On 8/20/2022 at 1:47 PM, zer0Kerbal said:

@OrdinaryKerman that is a new one for me.

Why not just put a PR or an issue here (GitHub) and I can just fix the issues. too high temp/too low price etc?

Constructive Feedback is something sadly lacking in my kerbal existence

No problems with the mod itself, just my patches

[zer0Kerbal]

Just now, OrdinaryKerman said:

No problems with the mod itself, just my patches

agree not a problem, just that I agree with your patches - they seem more balanced.

Edited August 21, 2022 by zer0Kerbal

[OrdinaryKerman]

@zer0Kerbal here is the patch:

Quote

EXTRA_PartRebalance.cfg

//Minor rebalance patch for Taerobee
// by OrdinaryKerman

//Isp reductions for engines to be more "realistic" (emphasis on airquotes there)
//Other misc adjustments

@PART[tbee-taerobee-aerobee]:AFTER[Taerobee]
{
	@maxtemp = 2000
	@cost = 90
	@MODULE[ModuleEngine*]
	{
		@atmosphereCurve
		{
			@key,0 = 0 240
			@key,1 = 1 210
			key,2 = 5 0
		}
	}
}

@PART[tbee-bumper-engine]:AFTER[Taerobee]
{
	@cost = 210 //48-7S 'Spark' costs 240. Why should this first-tier POS cost more?
}
@PART[tbee-bumper-engine-unclad,tbee-bumper-engine-slimJim]:AFTER[Taerobee]
{
	@cost = 190 //A bit cheaper that its structurally sound twin
}
@PART[tbee-bumper-engin*]:AFTER[Taerobee]
{
	@MODULE[ModuleEngine*]
	{
		@atmosphereCurve
		{
			@key,0 = 0 235
			@key,1 = 1 205
			key,2 = 5 0
		}
	}
}

//taerobee control computer

@PART[tbee-taerobee-control]:AFTER[Taerobee]
{
	@cost = 300 //same as Stayputnik
	!MODULE[ModuleReactionWheel] {} // fin rocket doesn't need reaction wheels
	!MODULE[ModuleSAS] {} // despin module has SAS
}


//adjust Thumper parts for more stockalike mass/cost/volume

//main tank vol: 334.45l, (I think)
//between Oscar-D (vol:72, 427.1l, mass:0.045t, cost:72) l = 0.16858u, vol/mass = 1600 litre/ton
//and Oscar-C (vol:36, 214l, mass: 0.0225, cost: 36) l = 0.16822u
//after arbitrary adjustment, we have tank volume = 334 litres * 0.168 = about 56 units = dry mass 0.035

@PART[tbee-bumper-body]:AFTER[Taerobee]
{
	@cost = 56
	@mass = 0.035
	@crashTolerance = 10
	@RESOURCE[LiquidFuel]
	{
		@amount = 25.2
		@maxAmount = 25.2
	}
	@RESOURCE[Oxidizer]
	{
		@amount = 30.8
		@maxAmount = 30.8
	}
}

//(assume cone shape) nose tank vol: 240.866l. 240 * 0.168 = about 40 units = dry mass 0.025
@PART[tbee-bumper-body]:AFTER[Taerobee]
{
	@cost = 40
	@mass = 0.025
	@crashTolerance = 10
	@RESOURCE[LiquidFuel]
	{
		@amount = 18
		@maxAmount = 18
	}
	@RESOURCE[Oxidizer]
	{
		@amount = 22
		@maxAmount = 22
	}
}

@PART[tbee-bumper-control]:AFTER[Taerobee]
{
	@cost = 300 // same as Stayputnik
	@MODULE[ModuleDataTransmitter]
	{
		@antennaPower = 250 //it's got to be rubbish somewhere.
	}
	!MODULE[ModuleReactionWheel] {} // fin rocket doesn't need reaction wheels
}

@PART[tbee-bumper-fin]:AFTER[Taerobee]
{
	@cost = 50 //a bit more expensive than a Basic Fin because slightly larger + actuator and flappy bit
}


//X-1, with atrociously high Isp and heat tolerance (for its kind)

@PART[tbee-x1-engine]:AFTER[Taerobee]
{
	@cost = 250
	@MODULE[ModuleEnginesFX]
	{
		@atmosphereCurve //Don't remember where I got these values, but they seem more reasonable for this engine than 290-something
		{
			@key,0 = 0 225
			@key,1 = 1 208
			key,2 = 5 0
		}
	}
}

@PART[tbee-x1-crew]:AFTER[Taerobee]
{
	@maxTemp = 2000
}

@PART[tbee-x1-body]:AFTER[Taerobee]
{
	@cost = 440 //based on fuel capacity
}

 

 

 

I  a: don't have a GitHub account, b: don't have any intention (so far) of learning how to use it, and c: don't want to possibly mess stuff up, so I'd just post the patch here

I think it'd better stay as an extras patch (maybe rewritten), and not be edited into the part configs themselves because of the alterations to the parts, but it's your mod and I don't think I should be dictating anything

I apologise for the slight rambling

Edited August 22, 2022 by OrdinaryKerman
included slim jim engine