Jump to content

[1.12.x] End your parts list nightmare - Introducing The Janitor's Closet

linuxgurugamer

By linuxgurugamer
in KSP1 Mod Releases

 Share

Recommended Posts

Probus

Probus

Posted
Posted
  On 5/4/2017 at 12:28 AM, linuxgurugamer said:

New release, 0.2.18:

  • Fixed bug where the blocked part titles weren't being shown in the editor after leaving the editor and returning
  • Added HideUnpurchased button to Mod Filter window, only active when in Science or Career
     
Expand  

Really like the Hide Unpurchased feature.  That could be a whole mod in itself.

Link to comment
Share on other sites
Nansuchao

Nansuchao

Posted
Posted

I guess this is a problem on my side, since no one else is reporting it, however Janitor's Closet stopped to work for me. The icon is present, if I click on it the help page will display but I can't block any parts in VAB/SPH and on mouseover, the GUI of JC doesn't show up.

I found this and a ton of other NRE in my KSP.log 

[ERR 19:44:13.782] Exception handling event onLevelWasLoadedGUIReady in class JanitorsCloset:System.NullReferenceException: Object reference not set to an instance of an object
  at JanitorsCloset.FileOperations.loadData (System.String fname) [0x00000] in <filename unknown>:0 
  at JanitorsCloset.FileOperations.loadBlackListData () [0x00000] in <filename unknown>:0 
  at JanitorsCloset.JanitorsCloset.OnSceneLoadedGUIReady (GameScenes scene) [0x00000] in <filename unknown>:0 
  at EventData`1[GameScenes].Fire (GameScenes data) [0x00000] in <filename unknown>:0

Here's my KSP.log and Output.log. I hope I can find a solution, this install is really important for me.

https://www.dropbox.com/sh/aiux3jvi563h0h8/AABfsGLCMubhROZqZIWkNq_za?dl=0

Link to comment
Share on other sites
Gribbleshnibit8

Gribbleshnibit8

Posted
Posted

I've found a repeatable issue with this mod and Crew R&R. Having Crew R&R installed causes Janitor's Closet to be unable to hide icons. It will still generate the its own versions, but will not remove them from the app launcher.

Installed mods:

  1. BetterTimeWarpContinued
  2. Crew R&R
  3. MechJeb
  4. Janitor's Closet
  5. Transfer Window Planner

Tested by first installing everything but Crew R&R. Hid everything with JC and then relaunched the game to confirm that they remained hidden. Installed Crew R&R and launched game, app launcher buttons no longer hidden, but exist in both places now.

Log

Link to comment
Share on other sites
linuxgurugamer

linuxgurugamer

Posted
  • Author
Posted
  On 5/6/2017 at 6:52 PM, Gribbleshnibit8 said:

I've found a repeatable issue with this mod and Crew R&R. Having Crew R&R installed causes Janitor's Closet to be unable to hide icons. It will still generate the its own versions, but will not remove them from the app launcher.

Installed mods:

  1. BetterTimeWarpContinued
  2. Crew R&R
  3. MechJeb
  4. Janitor's Closet
  5. Transfer Window Planner

Tested by first installing everything but Crew R&R. Hid everything with JC and then relaunched the game to confirm that they remained hidden. Installed Crew R&R and launched game, app launcher buttons no longer hidden, but exist in both places now.

Log

Expand  

Thank you.

Is JC unable to hide ALL icons or just Crew R&R?

Link to comment
Share on other sites
DStaal

DStaal

Posted
Posted
  On 5/6/2017 at 5:55 PM, Nansuchao said:

I guess this is a problem on my side, since no one else is reporting it, however Janitor's Closet stopped to work for me. The icon is present, if I click on it the help page will display but I can't block any parts in VAB/SPH and on mouseover, the GUI of JC doesn't show up.

I found this and a ton of other NRE in my KSP.log 

[ERR 19:44:13.782] Exception handling event onLevelWasLoadedGUIReady in class JanitorsCloset:System.NullReferenceException: Object reference not set to an instance of an object
  at JanitorsCloset.FileOperations.loadData (System.String fname) [0x00000] in <filename unknown>:0 
  at JanitorsCloset.FileOperations.loadBlackListData () [0x00000] in <filename unknown>:0 
  at JanitorsCloset.JanitorsCloset.OnSceneLoadedGUIReady (GameScenes scene) [0x00000] in <filename unknown>:0 
  at EventData`1[GameScenes].Fire (GameScenes data) [0x00000] in <filename unknown>:0

Here's my KSP.log and Output.log. I hope I can find a solution, this install is really important for me.

https://www.dropbox.com/sh/aiux3jvi563h0h8/AABfsGLCMubhROZqZIWkNq_za?dl=0

Expand  

Since I only use this intermittently (to prune my massive partlist...), I hadn't noticed - but I'm getting the same thing with the latest version.

I reverted back a version, and things went back to normal.

Link to comment
Share on other sites
Nansuchao

Nansuchao

Posted
Posted
  On 5/9/2017 at 6:28 PM, DStaal said:

Since I only use this intermittently (to prune my massive partlist...), I hadn't noticed - but I'm getting the same thing with the latest version.

I reverted back a version, and things went back to normal.

Expand  

I noticed something really weird. In the same install, but another save, it works flawlessly. Can you try if it's the same for you?

Link to comment
Share on other sites
DStaal

DStaal

Posted
Posted
  On 5/9/2017 at 6:37 PM, Nansuchao said:

I noticed something really weird. In the same install, but another save, it works flawlessly. Can you try if it's the same for you?

Expand  

Ok, very interesting...  I have several test saves as well as my main save in my install, and it works in about 50% of my saves.  (This after re-upgrading to the latest version.)

Link to comment
Share on other sites
Nansuchao

Nansuchao

Posted
Posted (edited)
  On 5/9/2017 at 10:28 PM, linuxgurugamer said:

I'll make an install.  If it was a CKAN install, send along that file as well

Expand  

I'm uploading the save on Dropbox, but none of my mods are installed by CKAN, I do everything manually...

Here you have: https://www.dropbox.com/sh/h2mg1r33byc4cao/AABGAMETID6fJXd5uV_4E8jla?dl=0

If you want the modlist, I can share it

  Reveal hidden contents

Many of them are mods that you're maintaining. Thanks for all your hard work!

Edited by Nansuchao
Link to comment
Share on other sites
linuxgurugamer

linuxgurugamer

Posted
  • Author
Posted (edited)

New release, 0.2.19:

  • Added check when loading blacklist to be sure part isn't pruned, avoids nullref

Many thanks to @Nansuchao for working with me to get a complete copy of his GameData directory.  It took several tries, Dropbox and GoogleDrive weren't able to do it properly, and without it, I would not have found this bug

Edited by linuxgurugamer
Link to comment
Share on other sites
Crusoe

Crusoe

Posted
Posted

I just made a new install (RSS+SMURFF+SSTU+a good few other mods), and so many parts are in so I tried use Janitor's closet to clean up. But left alt+click, or right alt+click (ctrl+l.alt or r. alt.. I tried everything) doesnt work for me. Windows 10 running the 64 bit. etc.
log here:
https://www.dropbox.com/s/gby1ui6ddrviddf/output_log.txt?dl=0

 

Thanks if you can look at it,

Cruz0e

Link to comment
Share on other sites
Crusoe

Crusoe

Posted
Posted

Ah, uhm, probably You can ignore my last post. I did not test the most obvious "fix" ... restart windows. Now I did restart and everything works again. It had to do something with the windows. (btw I'm using a new mouse for few days, a Logitech Anywhere MX 2). /The middle wheel had problem too, it didn't work in Chrome this morning (I tested in other programs it worked), thats why I restarted now it works everywhere, and the mod works too in KSP/

Cruz0e

Link to comment
Share on other sites
maculator

maculator

Posted
Posted

Premium Bug Report:

Situation: Testing partmods in a clean install. Squad "mod" hidden only Modular Rocket System showing

Mods: Janitors Closet, ModuleManager (idle - no patches in this test), Modular rocket system (only parts folder in correct subfolder -> GameData/ModRocketSys/Parts)

Bug: When selecting a part from the list it places it as root and pins a copy to the mouse wich is placeable but after that no part in the list is selectable. Renders game unplayable without restart.

How to reproduce: Alt+Tab out of KSP, delete a few parts from the ModRocketSys folder, back to game, leave VAB, Reload database via console, enter VAB and it happens.

Log: https://github.com/maculator/Crafts/blob/master/log.cfg

Link to comment
Share on other sites
DStaal

DStaal

Posted
Posted
  On 5/21/2017 at 12:48 AM, maculator said:

Premium Bug Report:

Situation: Testing partmods in a clean install. Squad "mod" hidden only Modular Rocket System showing

Mods: Janitors Closet, ModuleManager (idle - no patches in this test), Modular rocket system (only parts folder in correct subfolder -> GameData/ModRocketSys/Parts)

Bug: When selecting a part from the list it places it as root and pins a copy to the mouse wich is placeable but after that no part in the list is selectable. Renders game unplayable without restart.

How to reproduce: Alt+Tab out of KSP, delete a few parts from the ModRocketSys folder, back to game, leave VAB, Reload database via console, enter VAB and it happens.

Log: https://github.com/maculator/Crafts/blob/master/log.cfg

Expand  

Um, quick question: What's the *expected* behavior when you delete files from GameData while KSP is running?  Because 'random weirdness' would kinda be my expectation...

Link to comment
Share on other sites
This thread is quite old. Please consider starting a new thread rather than reviving this one.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...