[1.8.1 - 1.9.x] KerbalKomets - Add komets to your game!

[Daniel Prates]

9 hours ago, Angel-125 said:

Now that KSP 1.10 is out, we can see that the in-game comets do everything that I wanted to do with Kerbal Komets. I'm happy to say that I won't provide Kerbal Komets support for KSP 1.10. There are still people, including me, that use older versions so the mod will be around, but use it in KSP 1.10 at your own risk.

This mod is dying a very honorable death after a long(ish) and useful life. Many thanks @Angel-125. 

[linuxgurugamer]

21 hours ago, Angel-125 said:

Now that KSP 1.10 is out, we can see that the in-game comets do everything that I wanted to do with Kerbal Komets. I'm happy to say that I won't provide Kerbal Komets support for KSP 1.10. There are still people, including me, that use older versions so the mod will be around, but use it in KSP 1.10 at your own risk.

@Angel-125 It's always bittersweet when a mod you've slaved over suddenly appears in stock.  On the one hand, there is all that work, on the other, vindication.  It's happened to me several times.

Thank you for all the work you've done on this and other mods.

[jlcarneiro]

I think I speak for all KSP players (KSPers?) that haven't seen this yet when I second each of these compliments and thanks.

So long KerbalKomets! Thank you, @Angel-125!

Edited July 3, 2020 by jlcarneiro

[Angelo Kerman]

It’s all good guys, no complaints here. Squad did good with the comets.  plus the mod will still be around for older games...

Thanks for the Kudos!

Edited July 3, 2020 by Angel-125

[linuxgurugamer]

@Angel-125

I was testing my 1.9.1 game in 1.10.1, and got a lot of errors in flight:

NullReferenceException: Object reference not set to an instance of an object
  at CometVFXController.LateUpdate () [0x00156] in <c1858a3f77504bd1aaa946fdccf84670>:0 
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)
 

I looked at your code, it doesn't appear to be in there (it was a fast look).  Would there be a compatiblity issue between this mod and 10.1?

[Angelo Kerman]

43 minutes ago, linuxgurugamer said:

@Angel-125

I was testing my 1.9.1 game in 1.10.1, and got a lot of errors in flight:

NullReferenceException: Object reference not set to an instance of an object
  at CometVFXController.LateUpdate () [0x00156] in <c1858a3f77504bd1aaa946fdccf84670>:0 
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)
 

I looked at your code, it doesn't appear to be in there (it was a fast look).  Would there be a compatiblity issue between this mod and 10.1?

It could be, yeah.

[linuxgurugamer]

24 minutes ago, Angel-125 said:

It could be, yeah.

Well, if there is, I can't find it.

I removed your mod, and the issue still happens.  I created a new save as a test and no problem.

So all I can think of is that there is something initialized in a new game which is missing in older saves.

Yuck.  Lots of text reading ahead of me

[linuxgurugamer]

Hmmm.  There was an UnknownComet in the save file, I deleted it and the errors stopped.

I guess that somehow it was created incompletely because of the update