[1.12.x PlanetShine 0.2.6.6, Feb 22, 2022

[Papa_Joe]

Just now, mario-sov said:

1. Broken blizzy toolbar (the exception prevents from button appearing at all)

[EXC 20:30:13.386] ArgumentNullException: Value cannot be null.
Parameter name: method
    System.Delegate.CreateDelegate (System.Type type, System.Object firstArgument, System.Reflection.MethodInfo method, System.Boolean throwOnBindFailure, System.Boolean allowClosed) (at <9577ac7a62ef43179789031239ba8798>:0)
    System.Delegate.CreateDelegate (System.Type type, System.Object firstArgument, System.Reflection.MethodInfo method) (at <9577ac7a62ef43179789031239ba8798>:0)
    PlanetShine.Utils.Button.AttachEventHandler (System.Reflection.EventInfo event, System.String methodName, System.Object realButton) (at <2b12c5ac0a4d4274817dacc52f772def>:0)
    PlanetShine.Utils.Button..ctor (System.Object realButton, PlanetShine.Utils.ToolbarTypes types) (at <2b12c5ac0a4d4274817dacc52f772def>:0)
    PlanetShine.Utils.ToolbarManager.Add (System.String ns, System.String id) (at <2b12c5ac0a4d4274817dacc52f772def>:0)
    PlanetShine.Gui.GuiManager.UpdateToolbarBlizzy () (at <2b12c5ac0a4d4274817dacc52f772def>:0)
    PlanetShine.Gui.GuiManager.Start () (at <2b12c5ac0a4d4274817dacc52f772def>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

2. Now instead of pink square you got this

  Hide contents

Version compiled for 1.8 still works though

Can you send my your player log?

[mario-sov]

9 minutes ago, Papa_Joe said:

Can you send my your player log?

When I get the chance sure (gotta reinstall the latest version and spin up KSP to generate log). I forgot to mention the other thing (if that helps in the meantime though). Last night I went in and reverted the old toolbar wrapper code as seen here: https://github.com/prestja/ksp-planetshine/blob/master/PlanetShine/Utils/ToolbarWrapper.cs and recompiled. It worked. So I'm guessing it's related to reflection somewhere in the toolbar code.

Edited February 20, 2022 by mario-sov

[Papa_Joe]

19 minutes ago, mario-sov said:

When I get the chance sure (gotta reinstall the latest version and spin up KSP to generate log). I forgot to mention the other thing (if that helps in the meantime though). Last night I went in and reverted the old toolbar wrapper code as seen here: https://github.com/prestja/ksp-planetshine/blob/master/PlanetShine/Utils/ToolbarWrapper.cs and recompiled. It worked. So I'm guessing it's related to reflection somewhere in the toolbar code.

I did do some refactoring in that area, unintentionally while working other sections of code.  I'll see what I broke.

[dprostock]

No problem.

errare humanum est

[Krazy1]

I just realized there are 2 planetshine threads... I'm not going krazy. Reposting feature request here just so it doesn't get lost. Thanks for maintaining this mod.

"I have eclipses active in Scatterer 0.0831 and I'm orbiting the Mun and Kerbin is eclipsing the sun. That works, Mun is dark, but PlanetShine is still illuminating the Mun side of the ship. It would nice if it integrated with Scatterer eclipses so it's totally dark. "

[Papa_Joe]

15 hours ago, Krazy1 said:

I just realized there are 2 planetshine threads... I'm not going krazy. Reposting feature request here just so it doesn't get lost. Thanks for maintaining this mod.

"I have eclipses active in Scatterer 0.0831 and I'm orbiting the Mun and Kerbin is eclipsing the sun. That works, Mun is dark, but PlanetShine is still illuminating the Mun side of the ship. It would nice if it integrated with Scatterer eclipses so it's totally dark. "

Yes, @prestja took over support during my absence.  I'm indebted to him for that support.  Now that I'm back, I'm resuming support of most of the mods I used to support.

[Zaffre]

Welcome back! I was wondering if I was seeing stars like the usual.

[Grem]

On 2/21/2022 at 5:40 AM, mario-sov said:

1. Broken blizzy toolbar (the exception prevents from button appearing at all)

[EXC 20:30:13.386] ArgumentNullException: Value cannot be null.
Parameter name: method
    System.Delegate.CreateDelegate (System.Type type, System.Object firstArgument, System.Reflection.MethodInfo method, System.Boolean throwOnBindFailure, System.Boolean allowClosed) (at <9577ac7a62ef43179789031239ba8798>:0)
    System.Delegate.CreateDelegate (System.Type type, System.Object firstArgument, System.Reflection.MethodInfo method) (at <9577ac7a62ef43179789031239ba8798>:0)
    PlanetShine.Utils.Button.AttachEventHandler (System.Reflection.EventInfo event, System.String methodName, System.Object realButton) (at <2b12c5ac0a4d4274817dacc52f772def>:0)
    PlanetShine.Utils.Button..ctor (System.Object realButton, PlanetShine.Utils.ToolbarTypes types) (at <2b12c5ac0a4d4274817dacc52f772def>:0)
    PlanetShine.Utils.ToolbarManager.Add (System.String ns, System.String id) (at <2b12c5ac0a4d4274817dacc52f772def>:0)
    PlanetShine.Gui.GuiManager.UpdateToolbarBlizzy () (at <2b12c5ac0a4d4274817dacc52f772def>:0)
    PlanetShine.Gui.GuiManager.Start () (at <2b12c5ac0a4d4274817dacc52f772def>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

2. Now instead of pink square you got this

  Reveal hidden contents

Version compiled for 1.8 still works though

I confirm, I have the same problem.

[geostationary_coffee]

Latest version appears to cause a white bar to appear on probe cores:

https://imgur.com/a/iXe55bz

I'm on Linux, if that helps.

[Krazy1]

26 minutes ago, geostationary_coffee said:

a white bar

It also does it on the launch pad without a probe core, Win 10. 

Spoiler

 

[Biggen]

Also seeing white bar.

[FDAUT]

Getting white bar same as others. 

[Glimmerglint]

Im getting the bar too after updating, it appears on eva kerbals and it also appears to 'fall off' a plane im piloting  and fall behind it.

[Biggen]

Yup, it falls off when I'm parachuting back into Kerbin as well.

[ble210]

Can also confirm the white bars.

[mario-sov]

On 2/20/2022 at 9:17 PM, Papa_Joe said:

I did do some refactoring in that area, unintentionally while working other sections of code.  I'll see what I broke.

Hey,

So I looked in the ILSpy why these lines are not there in the older version and they're there in the new version. CreateDebugLines method in the last valid release is empty so these debug lines don't show (not reflected in the source code though).  White line won't show though if you enable this line https://github.com/PapaJoesSoup/ksp-planetshine/blob/f95276d6e46d33410a593ff59950e50da9e0f34a/PlanetShine/PlanetShine.cs#L313
So when you compile them due to the commented out line the values are not updated hence you get the white line. So either remove debug lines completely in CreateDebugLines method or reenable the commented out line of code. 

As for the toolbar issue I recommend reverting the logic it is even mentioned by the author of the code not to touch it: https://github.com/PapaJoesSoup/ksp-planetshine/blob/f95276d6e46d33410a593ff59950e50da9e0f34a/PlanetShine/Utils/ToolbarWrapper.cs#L39-L49

Also the fellow who suggested changing:  light.cullingMask = (1 << 0); to light.cullingMask = (1 << 0) | (1 << 16) is partially correct I guess. What you want per docs is the EVA layer so perhaps use: light.cullingMask = (1 << 0) | (1 << 16) | (1 << 17)?

So the end result is this: https://giant.gfycat.com/InsidiousApprehensiveDove.mp4
1. I've got my button back
2. No white line and debug lines actually work
3. Light is visible on Kerbals in EVA

Edited February 22, 2022 by mario-sov
Mistake

[Papa_Joe]

1 hour ago, mario-sov said:

Hey,

So I looked in the ILSpy why these lines are not there in the older version and they're there in the new version. CreateDebugLines method in the last valid release is empty so these debug lines don't show (not reflected in the source code though).  White line won't show though if you enable this line https://github.com/PapaJoesSoup/ksp-planetshine/blob/f95276d6e46d33410a593ff59950e50da9e0f34a/PlanetShine/PlanetShine.cs#L313
So when you compile them due to the commented out line the values are not updated hence you get the white line. So either remove debug lines completely in CreateDebugLines method or reenable the commented out line of code. 

As for the toolbar issue I recommend reverting the logic it is even mentioned by the author of the code not to touch it: https://github.com/PapaJoesSoup/ksp-planetshine/blob/f95276d6e46d33410a593ff59950e50da9e0f34a/PlanetShine/Utils/ToolbarWrapper.cs#L39-L49

Also the fellow who suggested changing:  light.cullingMask = (1 << 0); to light.cullingMask = (1 << 0) | (1 << 16) is partially correct I guess. What you want per docs is the EVA layer so perhaps use: light.cullingMask = (1 << 0) | (1 << 16) | (1 << 17)?

So the end result is this: https://giant.gfycat.com/InsidiousApprehensiveDove.mp4
1. I've got my button back
2. No white line and debug lines actually work
3. Light is visible on Kerbals in EVA

Looks awesome.  I suspected that the debug lines were the culprit.  I've already reverted the blizzy code and the culling mask is a great find.  Thanks!  I'll look at issuing a release later today.

[Papa_Joe]

Ok new release.  

v0.2.6.6 Feb 22, 2022
- Add support for Kerbals EVA to experience planetshine
- Fix broken Blizzy Toolbar support. File was refactored accidentally.
- Correct white line visible.
- @mario-sov and others that contributed to the solutions, Thanks for the support!

Enjoy, and as always, let me know if there are issues.  Lord knows I'm not perfect.  

Edited February 23, 2022 by Papa_Joe

[dok_377]

5 hours ago, Papa_Joe said:

- Add support for Kerbals EVA to experience planetshine

You fixed it! Thank you so much!

[Papa_Joe]

9 hours ago, dok_377 said:

You fixed it! Thank you so much!

No, WE fixed it.  What a great community.

[Efrenlee]

Does it fit with RSS?

[zhishengji]

it can used with RSS?

Edited May 25, 2022 by zhishengji

[CFYL]

From my personal point of view, it doesn't cause issues when running with RSS installed. However I don't see much light reflected from the Earth in LEO. This might be because 1) mod not working properly 2) light is too faint and I can't see.

EDIT: Just looked at the config files. I have RSS v18.5.0 installed. It contains a file GameData/RealSolarSystem/Compatibility/PlanetShineColors.cfg. So it will work. I'm just seeing very dim lights -- realistic enough.

With RSS installed, planet shine will work. DistantObjectEnhacement will also work, because it seems to share the "PlanetColours" system with PlanetShine.

[italon]

I am unable to save config settings ingame nor directly from the .cfg file. Could someone assist? I can make the changes via the config file and save the file, reopen it and it is obviously saved, but the game doesn't reflect the changes either.

[Makrom]

Hello.

I´m having the issue of the pink square, I´m using the last version of planet shine (0.2.6.6) I tried with the previous one too (2.6.5), I reinstall the mods twice and the little pink square stays there.

https://imgur.com/h6dtu5S

https://imgur.com/WZYeXKm

Ksp 1.12.3

As for visual stuff, I´m using RSS,  EVE 1.11.6.1, scatterer 0.0772, astroniki sunflare for RSS 1.0, REO 0.3.2, Distant object 2.0.2

thanks in advance

Edited February 3, 2023 by Makrom
typos