[1.12.5] Restock - Revamping KSP's art (August 28)

[kerbalxploder]

23 hours ago, TBenz said:

Try:

@PART[fuelTankSmallFlat|fuelTankSmall|fuelTank|fuelTank_long]:BEFORE[000_ReStock]
{
	RestockIgnore = True
}

MM expects an actual part name in between the square brackets. Giving it a file name (that isn't even directly related to the source parts) will just confuse it. The pipe character is interpreted as an or, so this code is telling MM to look for parts with the name "fuelTankSmallFlat" or "fuelTankSmall" or "fuelTank" or "fuelTank_long" and apply the RestockIgnore tag to them. And since those are the names of the size 1 stock tanks, the restock ignore should correctly get applied to all of them (and nothing else). 

Thanks so much for your help. I will try it tomorrow, and if I have any problems I'll know where to speak up

[kerbalxploder]

On 12/1/2020 at 8:13 PM, Fusion confusion said:

I have a problem. I loaded Restock on ksp, and when I went in to the VAB, all the revamped parts were gone. Rest in peace Arecibo. 

Does this mean the parts were replaced with the stock counterparts, or was there nothing at all there?

[Russekof71]

hello I really like your mod but the problem is that there are some basic stock parts that I like. If I find its parts in the squad folder that I copy them by changing the name will restock detect them and apply the change?

[Fusion confusion]

8 hours ago, kerbalxploder said:

Does this mean the parts were replaced with the stock counterparts, or was there nothing at all there?

Nope, I just saw the parts that were untouched by the team, the rest were gone

[ble210]

On 12/4/2020 at 9:06 AM, Russekof71 said:

hello I really like your mod but the problem is that there are some basic stock parts that I like. If I find its parts in the squad folder that I copy them by changing the name will restock detect them and apply the change?

I am also curious as to how to bring back stock parts.  I am suspecting that there are bugs with the Restock heat shields (specifically, that they don't fully cover and protect what is above them, which is exacerbated in larger systems like JNSQ) , and want to test this theory.

[Clamp-o-Tron]

On 12/4/2020 at 11:06 AM, Russekof71 said:

hello I really like your mod but the problem is that there are some basic stock parts that I like. If I find its parts in the squad folder that I copy them by changing the name will restock detect them and apply the change?

 

Just now, ble210 said:

I am also curious as to how to bring back stock parts.  I am suspecting that there are bugs with the Restock heat shields (specifically, that they don't fully cover and protect what is above them, which is exacerbated in larger systems like JNSQ) , and want to test this theory.

Restoring Stock Parts · PorktoberRevolution/ReStocked Wiki (github.com)

[ble210]

1 hour ago, Clamp-o-Tron said:

 

Restoring Stock Parts · PorktoberRevolution/ReStocked Wiki (github.com)

Thank you Clampotron.  I successfully made a .restock file that whitelists heat shields, however the stock heat shields still don't show up in my game (only the restock ones do).  The whitelist contains the following:

Squad/Parts/Aero/HeatShield/
Squad/Parts/Aero/InflatableHeatShield/

This whitelist apparently does work to load the stock heatshields, since I get the pertinent lines in my log:

[LOG 18:13:38.764] Load(Texture): Squad/Parts/Aero/HeatShield/Fairing
[LOG 18:13:38.765] Load(Texture): Squad/Parts/Aero/HeatShield/heatshield
[LOG 18:13:38.767] Load(Texture): Squad/Parts/Aero/InflatableHeatShield/HeatShield
[LOG 18:13:38.770] Load(Texture): Squad/Parts/Aero/InflatableHeatShield/HeatShieldFairing
[LOG 18:13:38.772] Load(Texture): Squad/Parts/Aero/InflatableHeatShield/HeatShield_NRM

[LOG 18:14:07.981] Load(Model): Squad/Parts/Aero/HeatShield/HeatShield0
[LOG 18:14:07.986] Load(Model): Squad/Parts/Aero/HeatShield/HeatShield1
[LOG 18:14:07.992] Load(Model): Squad/Parts/Aero/HeatShield/HeatShield2
[LOG 18:14:07.997] Load(Model): Squad/Parts/Aero/HeatShield/HeatShield3
[LOG 18:14:08.003] Load(Model): Squad/Parts/Aero/InflatableHeatShield/HeatShield

 

Curious as to what steps I may be missing; as far as I can tell I've followed them all in the links you posted (thank you again for your help!)

Edit:  Doh!  I missed the second step (disabling the MM patch).  I'll try that now.

Edited December 6, 2020 by ble210

[Poodmund]

7 hours ago, ble210 said:

I am also curious as to how to bring back stock parts.  I am suspecting that there are bugs with the Restock heat shields (specifically, that they don't fully cover and protect what is above them, which is exacerbated in larger systems like JNSQ) , and want to test this theory.

I have no issues with the heat shields and we do not have any issue raised against them in this regard. If you have a bug to report then please raise it on the GitHub tracker.

[eberkain]

12 hours ago, Poodmund said:

I have no issues with the heat shields and we do not have any issue raised against them in this regard. If you have a bug to report then please raise it on the GitHub tracker.

https://github.com/PorktoberRevolution/ReStocked/issues/914

https://github.com/PorktoberRevolution/ReStocked/issues/577

There is 100% definitely an issue with the Restock + FAR + JNSQ.  Maybe its a new issue in 1.10.1, I dunno.  But here is my testing info. 

After restoring the stock heat shields I have no issues anymore.   I will post on github too.  EDIT: https://github.com/PorktoberRevolution/ReStocked/issues/923

Edited December 6, 2020 by eberkain

[ble210]

20 hours ago, eberkain said:

https://github.com/PorktoberRevolution/ReStocked/issues/914

https://github.com/PorktoberRevolution/ReStocked/issues/577

There is 100% definitely an issue with the Restock + FAR + JNSQ.  Maybe its a new issue in 1.10.1, I dunno.  But here is my testing info. 

After restoring the stock heat shields I have no issues anymore.   I will post on github too.  EDIT: https://github.com/PorktoberRevolution/ReStocked/issues/923

I've had the same experiences as eberkain.  I've run ~10 tests from a Mun-height apoapsis with the 1.875 command pod and restock 1.875 heat shield; all were destroyed on re-entry.  I've run 4 additional tests with the exact same craft, with the only difference being a stock heat shield; all four survived re-entry.  I am not using FAR.

[Me.hasOwnProperty isHappy]

Pulled request for the localization file change for Restock.

Though have some questions:

66 #LOC_Restock_variant-engine_shroud_grey-orange = Metallic Shroud

Is it supposed to be so? Name says grey/orange, but description is metallic.

 

82 #LOC_Restock_variant-engine_pod-orange = Pod (Orange)

83 #LOC_Restock_variant-engine_pod-grey = Pod (Grey)

Where do i find these ones in the game? Guess i've checked all parts that have different color/mounting variants, but found none.

 

BTW variant description in the game sometimes doesn't fit in the pop up window losing some letters at the end, and it there are lots of variant the icons for them are also left outside. One can switch them by feel, but cannot see.

PS mostly done, should be playable without confusing.  Some minor errors still may be encountered, but those depend on declension of words, cases and gender.

Edited December 7, 2020 by Me.hasOwnProperty isHappy

[Poodmund]

@eberkain & @ble210, could you please save this config: https://raw.githubusercontent.com/Poodmund/ReStocked/master/Distribution/Restock/GameData/ReStock/PatchesMH/Aero/restock-mh-heat-shields.cfg and overwrite the one saved in "Kerbal Space Program\GameData\ReStock\PatchesMH\Aero"?

Once you've overwritten that config, delete the file "Kerbal Space Program\PartDatabase.cfg" and relaunch the game. Then please test the 1.875m heatshield again and note any differences.

[eberkain]

2 hours ago, Poodmund said:

@eberkain & @ble210, could you please save this config: https://raw.githubusercontent.com/Poodmund/ReStocked/master/Distribution/Restock/GameData/ReStock/PatchesMH/Aero/restock-mh-heat-shields.cfg and overwrite the one saved in "Kerbal Space Program\GameData\ReStock\PatchesMH\Aero"?

Once you've overwritten that config, delete the file "Kerbal Space Program\PartDatabase.cfg" and relaunch the game. Then please test the 1.875m heatshield again and note any differences.

Same result as before.   https://youtu.be/V03Rh5sh6W4

You can see the temps from hot spot and the pod skin temp just steadily goes up until it explodes. 

I restored the stock heat shields and recorded a video with it.  https://youtu.be/hzXWVM35Yh4

And just for kicks, here are logs from using the stock shields to compare with the failure logs posted before. 

https://drive.google.com/file/d/1Vio2So61ISYfwZD3KagQsAp-Tmd4lJsv/view?usp=sharing

https://drive.google.com/file/d/1BpHq0mbAt_dayZGFtdh4ODQo6jSiZNBs/view?usp=sharing

I'm starting to think this may be something weird with my install since its not more widespread, lots of people use JNSQ and Restock. 

The way to really figure this out is to start with a clean install and find the bare minimum mods required to cause this issue, I just don't know if I have the energy for that.   Too busy spending my time playing this new sandbox science playthrough. 

 

 

[EchoLima]

34 minutes ago, eberkain said:

I'm starting to think this may be something weird with my install since its not more widespread, lots of people use JNSQ and Restock. 

I don't currently have time to test it (maybe I can later this week), but I've had similar problems when entering JNSQ Eve's atmosphere with a 1.875m Restock heatshield. The craft consistently exploded at ~40,000km.

[ble210]

On 12/7/2020 at 10:15 AM, Poodmund said:

@eberkain & @ble210, could you please save this config: https://raw.githubusercontent.com/Poodmund/ReStocked/master/Distribution/Restock/GameData/ReStock/PatchesMH/Aero/restock-mh-heat-shields.cfg and overwrite the one saved in "Kerbal Space Program\GameData\ReStock\PatchesMH\Aero"?

Once you've overwritten that config, delete the file "Kerbal Space Program\PartDatabase.cfg" and relaunch the game. Then please test the 1.875m heatshield again and note any differences.

I'll try to give it a go this weekend.

[eberkain]

On 3/6/2019 at 2:20 AM, Nertea said:

Q: Will you add xxxx? A: Probably not.

I mean, it doesn't say no.   

You know what would be super handy?  Structural Tubes in the 0.625 size. 

[Jorge Aerospace]

I love the revamps! They are the perfect mixture between the Stock Style and a new design.

[BrunoViking]

I downloaded your mod and I really liked most of the revamped parts. But some parts I did not like at all. I know that I could whitelist the parts that I want to load, but I would spent a long time doing it. So, I was wondering if there is a more practical way to block these restock parts from being loaded. 

Thanks in advance 

[BrunoViking]

So, I managed to whitelist all the parts that I didn't like in restock in the exact same way that was described here. But it did nothing whether than breaking my save file  ( I had backups, don't worry). I saw that all the parts that I whitelisted just vanished from the game.  Is there a way to make whitelisting easier, like inside of the game? It would be good to prevent the type of problem that occurred to me.

[eberkain]

you can use Janitors Closet.  

[BrunoViking]

As far as I know, Janitors closet can only deactivate parts, not textures. But I will give it a try. Thanks for the answer! 

Edited December 11, 2020 by BrunoViking

[RedRoyal25]

Hey... you think you can make the stock textures an option by default? The ReStock textures would be the default textures but there is an option to pick stock. Or is there an easier way to do it locally than manually changing configs for over 250 parts?

[Nertea]

14 hours ago, RedRoyal25 said:

Hey... you think you can make the stock textures an option by default? The ReStock textures would be the default textures but there is an option to pick stock. Or is there an easier way to do it locally than manually changing configs for over 250 parts?

Besides the fact that we have no interest in doing that, the stock part switcher is not capable enough to support this.

On 12/10/2020 at 1:01 PM, BrunoViking said:

So, I managed to whitelist all the parts that I didn't like in restock in the exact same way that was described here. But it did nothing whether than breaking my save file  ( I had backups, don't worry). I saw that all the parts that I whitelisted just vanished from the game.  Is there a way to make whitelisting easier, like inside of the game? It would be good to prevent the type of problem that occurred to me.

We've honestly gone out of the way to try to make this simple. No further work is planned.

[Bluespace]

On 5/5/2020 at 6:06 AM, Weimaraner said:

This mod provides TU configs for lots of mods, including restock and restock plus.

THX dude! Magpiemods is awesome

[Poodmund]

I can't find the dislike button.