[1.8 - 1.12.x] Distant Object Enhancement Continued v2.0.3.1 (29 September, 2021)

[Relonsk]

Works with 1.10?

[Paaaad]

13 minutes ago, Relonsk said:

Works with 1.10?

Working fine for me.

[Relonsk]

17 minutes ago, Paaaad said:

Working fine for me.

Thanks.

[Neil Kermstrong]

31 minutes ago, Relonsk said:

Works with 1.10?

Yeah 

[infinite_monkey]

Planets appear as a dark spot visible through the atmosphere. They should be hidden behind it, just like the stars. Would it be possible to fix that?

 

[TheDarkBadger]

1 hour ago, infinite_monkey said:

Planets appear as a dark spot visible through the atmosphere. They should be hidden behind it, just like the stars. Would it be possible to fix that?

 

Thanks, i'll have a look into it

[captinjoehenry]

I love this mod and it works great.  Except for the distant object rendering.  That consistently does not work.  The only thing that shows up is a small white dot instead of the station.  I do make use of a lot of mod parts if that effects anything.

[TheDarkBadger]

15 hours ago, captinjoehenry said:

I love this mod and it works great.  Except for the distant object rendering.  That consistently does not work.  The only thing that shows up is a small white dot instead of the station.  I do make use of a lot of mod parts if that effects anything.

Just had a look back at the previous versions, seems that a previous version of KSP broke that feature a while ago, back when it was managed by MOARdv. I'll see if i can track down what broke and and see if i can fix it

 

*Edit*

Ok, seems that this feature does work - at least on my test build for the newest version of KSP. Could you check your settings?

Edited September 27, 2020 by TheDarkBadger

[Gordon Dry]

As I'm trying to pinpoint this issue
https://forum.kerbalspaceprogram.com/index.php?/topic/197120-halo-like-visual-issue-ksp-1101/

I stumpled upon this in the log:

Uploading Crash Report
NullReferenceException
  at (wrapper managed-to-native) UnityEngine.Component.get_transform(UnityEngine.Component)
  at DistantObject.FlareDraw.GenerateBodyFlares () [0x0032f] in <a3a15caa52954c7b93cbff005f15659c>:0 
  at DistantObject.FlareDraw.Awake () [0x00184] in <a3a15caa52954c7b93cbff005f15659c>:0 
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)
UnityEngine.GameObject:Internal_AddComponentWithType(Type)
UnityEngine.GameObject:AddComponent(Type)
AddonLoader:StartAddon(LoadedAssembly, Type, KSPAddon, Startup)
AddonLoader:StartAddons(Startup)
AddonLoader:OnLevelLoaded(GameScenes)
AddonLoader:OnSceneLoaded(Scene, LoadSceneMode)
UnityEngine.SceneManagement.SceneManager:Internal_SceneLoaded(Scene, LoadSceneMode)

KSP just continues, so a hidden "crash" occured with that mod.

Could that have anything to do with my issue?

[linuxgurugamer]

11 minutes ago, Gordon Dry said:

As I'm trying to pinpoint this issue
https://forum.kerbalspaceprogram.com/index.php?/topic/197120-halo-like-visual-issue-ksp-1101/

I stumpled upon this in the log:

Uploading Crash Report
NullReferenceException
  at (wrapper managed-to-native) UnityEngine.Component.get_transform(UnityEngine.Component)
  at DistantObject.FlareDraw.GenerateBodyFlares () [0x0032f] in <a3a15caa52954c7b93cbff005f15659c>:0 
  at DistantObject.FlareDraw.Awake () [0x00184] in <a3a15caa52954c7b93cbff005f15659c>:0 
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)
UnityEngine.GameObject:Internal_AddComponentWithType(Type)
UnityEngine.GameObject:AddComponent(Type)
AddonLoader:StartAddon(LoadedAssembly, Type, KSPAddon, Startup)
AddonLoader:StartAddons(Startup)
AddonLoader:OnLevelLoaded(GameScenes)
AddonLoader:OnSceneLoaded(Scene, LoadSceneMode)
UnityEngine.SceneManagement.SceneManager:Internal_SceneLoaded(Scene, LoadSceneMode)

KSP just continues, so a hidden "crash" occured with that mod.

Could that have anything to do with my issue?

 I wouldn't call that a hidden crass, just something which had an exception and stopped running at that point.  Was it repeating continously?

[Gordon Dry]

2 minutes ago, linuxgurugamer said:

Was it repeating continously?

No

[infinite_monkey]

On 9/20/2020 at 9:08 PM, TheDarkBadger said:

Thanks, i'll have a look into it

Thanks. I just noticed that planets are also rendered in front of sunflares

[Gordon Dry]

Just after my last post above a new build of DOE for KSP 1.10.1 was released, so instead of removing it I decided to update it instead.
But the issue retained.

Now I removed DOE and I don't see the "halo" anymore on the vessel (in orbit) which had it prior removing the mod.
I will investigate this a little more until my assumption gets fixated that indeed DOE is the culprit.

Edit:

toggling the features of DOE did not help

Edited September 28, 2020 by Gordon Dry

[TheDarkBadger]

5 hours ago, Gordon Dry said:

Just after my last post above a new build of DOE for KSP 1.10.1 was released, so instead of removing it I decided to update it instead.
But the issue retained.

Now I removed DOE and I don't see the "halo" anymore on the vessel (in orbit) which had it prior removing the mod.
I will investigate this a little more until my assumption gets fixated that indeed DOE is the culprit.

Edit:

toggling the features of DOE did not help

Could you please PM me your modlist? It might be DOE not liking some other mod

Thanks

[captinjoehenry]

On 9/27/2020 at 8:38 AM, TheDarkBadger said:

Just had a look back at the previous versions, seems that a previous version of KSP broke that feature a while ago, back when it was managed by MOARdv. I'll see if i can track down what broke and and see if i can fix it

 

*Edit*

Ok, seems that this feature does work - at least on my test build for the newest version of KSP. Could you check your settings?

Yep I have those settings set.  But still when I'm out of physics range it just renders as a white dot.  I think I recall at one point this was caused by mod added parts...?

[TheDarkBadger]

19 hours ago, captinjoehenry said:

Yep I have those settings set.  But still when I'm out of physics range it just renders as a white dot.  I think I recall at one point this was caused by mod added parts...?

Yeah it seems to be modded parts, Stock vessels load fine (At least from my testing) i'll have a look into why modded parts break the vessel rendering.

[Spike88]

So I've run into an issue where there is a small white circle with a blue center that shows up on my rockets.

After searching around trying to figure it out, I found out that it's an issue between Sigma Binary and DOE, that has been previously resolved by @Sigma88 with the help of another user.

Here is the issue:

https://github.com/Sigma88/Sigma-Dimensions/issues/90

https://github.com/Sigma88/Sigma-Binary/issues/52

 

And here is the fix by Sigma88:

https://github.com/Sigma88/DistantObject/releases

 

Now I'm assuming the version of DOE you took over doesn't include this fix since it looks like you took 1.9.1.1 and Sigma fixed it in 1.9.1.2 and 1.9.2.0

Is there anyway you can look at this and see if it's something that could be added to this version?

 

Thank You.

Edited October 29, 2020 by Spike88

[Sigma88]

I sent you a PR with the fix I had added in my version, not sure if it still works because I didn't test it in ksp

[TheDarkBadger]

10 hours ago, Sigma88 said:

I sent you a PR with the fix I had added in my version, not sure if it still works because I didn't test it in ksp

Thanks for the fix

Updated to v2.0.1.1

[Spike88]

I can confirm this fixed this issue. Thank you!

 

Edit: Screenshot Tax

Eve, Duna and a third planet visible just to the right of my V2

Edited November 1, 2020 by Spike88

[cyberKerb]

Thanks for this mod. I'm using it in 1.10.1 with scatterer and I've also got both DLC.

I had a question, I'm seeing comets showing up as dark smudges in the sky during the day. Just wondering if that's how they are supposed to look?

[infinite_monkey]

Does everybody see planets flickering? Can that be reduced/eliminated?

[TheDarkBadger]

19 hours ago, cyberKerb said:

Thanks for this mod. I'm using it in 1.10.1 with scatterer and I've also got both DLC.

I had a question, I'm seeing comets showing up as dark smudges in the sky during the day. Just wondering if that's how they are supposed to look?

Could you please post a picture of what you are seeing and i'll take a look?  
On my end it comets look the same as in vanilla.

5 hours ago, infinite_monkey said:

Does everybody see planets flickering? Can that be reduced/eliminated?

Cant replicate this issue myself, could you PM me your mod list and i'll take a more in depth look
 

[cyberKerb]

1 hour ago, TheDarkBadger said:

Could you please post a picture of what you are seeing and i'll take a look?  
On my end it comets look the same as in vanilla.

Sorry! Clearly I didn't know what they looked like in Vanilla.  I removed the mod to check and I guess that's how a normal comet looks. It's on the far side of Kerbol and around Eve Orbit at the moment. I was expecting it to be a little more subtle for that distance. Hmmm... just wondering if I should log a KSP bug report for the comet being rendered in front of the  sun-flares. (I'm now doing a check without Scatterer to see if that might be related)  It's scatterer, I'll post over there.

without Scatterer

 

Edited November 25, 2020 by cyberKerb

[TheDarkBadger]

Updated to KSP 1.11.x