parts [1.10.x] SDHI Strobe-O-Matic Warning Rotator Lights (V1.0.1 / 29 August 2018)

[sumghai]

After a quick test, I can confirm that this mod still works in 1.10.x without any updates.

Disco ain't dead, folks!

[Anodizer]

Is it possible to change the speed of the rotation?  

[sumghai]

3 hours ago, Anodizer said:

Is it possible to change the speed of the rotation?  

No - the rotation speed is baked into the animation of the strobe models.

[dprostock]

Hello!

Are you planning to update it? Thank you!

[sumghai]

49 minutes ago, dprostock said:

Hello!

Are you planning to update it? Thank you!

This mod should still work fine in the current version of KSP.

Are you experiencing any particular errors?

[dprostock]

Oh... yes. 

KSP 1.11 + BG

When I assemble the ship, the green strobe is spinning continuously but without light, and the rest is not. None of them respond, in the VAB, to the orders to turn off and on the lights.

Then, already in the launcher, none responds or turns on, except the green one that continues to rotate but without light.

As a commentary, the MK1 and MK2 lights also seem affected, I don't know if it's related or what.

How else can I help?

 

In the VAB

Pre Launch -Light Off ( grrrr MK1/MK2 )

Pre Launch - Light On

Spoiler

x] Science! Continued (xScienceContinued 5.26)
ABookCase Orbital Reference System (ABCORS 0.5.1.2)
AT Utils (AT-Utils v1.9.6)
B9 Part Switch (B9PartSwitch v2.17.0)
BonVoyage (BonVoyage 1:1.2.0)
BreakingGround-DLC (BreakingGround-DLC (unmanaged))
Chatterer (Chatterer 0.9.99)
Chatterer Extended (ChattererExtended 0.6.2)
ClickThrough Blocker (ClickThroughBlocker 1:0.1.10.15)
Community Category Kit (CommunityCategoryKit v5.2.0.0)
Distant Object Enhancement Continued (DistantObject v2.0.2.0)
Distant Object Enhancement Continued default config (DistantObject-default v2.0.2.0)
Easy Vessel Switch (EVS) (EasyVesselSwitch 2.1)
Engine Lighting Relit (EngineLightRelit 1.6.3)
Environmental Visual Enhancements (EnvironmentalVisualEnhancements 3:1.10.1-3)
Environmental Visual Enhancements - Stock Planet Config files (EnvironmentalVisualEnhancements-HR 2:EVE-1.2.2-1)
Filter Extensions - Plugin (FilterExtensions 3.2.6)
Final Frontier (FinalFrontier 1.10.0-3485)
Hangar Extender (HangerExtenderExtended 3.6.0)
HyperEdit (HyperEdit 1.5.8.0)
IndicatorLights (IndicatorLights 1.7)
IndicatorLights Community Extensions (IndicatorLightsCommunityExtensions 1.6.2)
Kalculator (Kalculator 0.2.3)
Kerbal Alarm Clock (KerbalAlarmClock v3.13.0.0)
Kerbal Attachment System (KAS 1.7)
Kerbal Changelog (KerbalChangelog v1.3.0)
Kerbal Engineer Redux (KerbalEngineerRedux 1.1.8.3)
Kerbal Inventory System (KIS 1.27)
Kerbal Joint Reinforcement Continued (KerbalJointReinforcementContinued v3.5.2)
Kerbal Reusability Expansion (SpaceXLegs 2.8.6)
KerboKatz - SmallUtilities - FPSViewer (KerboKatzSmallUtilities-FPSViewer 1.5.4-KSP1.8)
KerboKatzUtilities (KerboKatzUtilities 1.5.2-KSP1.8)
KSP AVC (KSP-AVC 1.4.1.5)
KSP Resonant Orbit Calculator (ResonantOrbitCalculator 0.0.6.2)
Magpie Mods (MagpieMods 1.5.8)
Making History (MakingHistory-DLC 1.11.0)
MastodonPatch (MastodonPatch v0.0.0.1)
MechJeb 2 (MechJeb2 2.12.0.0)
Module Manager (ModuleManager 4.1.4)
MSP-3000 Material Science Pod (MSP3000 v1.1)
OPT Reconfig (OPTReconfig 3.0)
OPT Spaceplane (Legacy) (OPTSpacePlaneParts 1:3.0)
OPT Spaceplane Continued (OPTSpacePlaneMain 1:3.0)
Planet Wiki (PlanetWiki 1:4.1)
QuickCursorHider (QuickCursorHider 1:1.1.0.6)
RasterPropMonitor (RasterPropMonitor 1:v0.31.4)
RasterPropMonitor Core (RasterPropMonitor-Core 1:v0.31.4)
RCS Build Aid (RCSBuildAid v1.0.5)
Real Plume (RealPlume 2:v13.3.2)
Real Plume - Stock Configs (RealPlume-StockConfigs v4.0.4)
Reentry Particle Effect Renewed (ReentryParticleEffect 1.9.1.1)
ReStock (ReStock 1.2.1)
ReStock Extra - Rigid Legs (RestockRigidLegs 1.2.1)
ReStock+ (ReStockPlus 1.2.1)
SCANsat (SCANsat v20.4)
Science - Full Reward! (Continued) (Science-Full-Reward v5.2)
Science - Full Transmit! (Science-Full-Transmit v1.1)
Science Pancake - 2.5m Materials Bay (SciencePancake 1.0)
ScienceAlert ReAlerted (ScienceAlert 1.9.8.9)
SDHI Strobe-O-Matic Warning Rotator Lights (SDHI-StrobeOMatic v1.0.1)
SimpleFuelSwitch (SimpleFuelSwitch 1.4)
SmokeScreen - Extended FX Plugin (SmokeScreen 2.8.14.0)
Sum Dum Heavy Industries - Shared Assets (SDHI-SharedAssets 4.0.4)
Surface Mounted Lights (surfacelights 1.17)
TAC Fuel Balancer (TacFuelBalancer v2.21.5.1)
TextureReplacer (TextureReplacer v4.3.1)
Textures Unlimited (TexturesUnlimited 1.5.10.25)
The Janitor's Closet (JanitorsCloset 0.3.7)
Throttle Controlled Avionics (ThrottleControlledAvionics v3.7.2)
Toolbar (Toolbar 1:1.8.0.5)
Toolbar Controller (ToolbarController 1:0.1.9.4)
Tracking Station Evolved (TrackingStationEvolved 6.0)
Trajectories (Trajectories v2.3.4)
Transfer Window Planner (TransferWindowPlanner v1.7.2.0)
WorldStabilizer (WorldStabilizer 0.9.7-ksp-1.8.1)
Zero MiniAVC (ZeroMiniAVC 1:1.1.0.1)
 

 

[sumghai]

@dprostock, I've confirmed the bug in my own game as well.

However, it's been a very long time since I've modded for KSP, so it may (also) take a while for me to figure out how to fix this.

[dprostock]

Ok! 

Please, I am willing to help you in any way if necessary.

Thank!!!!

 

 

[Virtualgenius]

Did you ever get chance to resolve this 

[sumghai]

14 hours ago, Virtualgenius said:

Did you ever get chance to resolve this 

Not yet, I'm afraid.

[Virtualgenius]

Bummer  I used one for this 

Edited August 6, 2021 by Virtualgenius

[Nizrael]

Oh, man.  I might start learning to code just so I can update this mod; my Mün base landing pad NEEDS these lights, for landing guidance and for those after-hours EVA dance parties.  The disco must be resuscitated! 

[Virtualgenius]

@sumghaiDid you ever get chance to resolve the issue with these they are very good

Edited December 26, 2021 by Virtualgenius

[OrbitalManeuvers]

I have some observations from some testing and fiddling. Maybe something I found will be of use to someone. Here goes:

This is 1.12.3. The green light is an outlier in that its animation works, although it never turns off. None of the other animations work. None of the lights produce any light in the VAB or in flight.

I know next to nothing about modding but I looked at the cfgs and noticed that the lightName param has two values. I have the luxury of having hundreds of other mods installed across multiple installs, so I grepped to see if any other parts did this too, and none do. So I edited one of the lights to have just one value for lightName, and using either PointLight or Spotlight changed the VAB behavior, though it's still not as designed I'm sure. Using only PointLight gets you a small internal light turning on/off, and using only Spotlight gets you a light that does rotate and does illuminate the environment, but I don't think it's quite right ... not sure what's it's supposed to look like. When I did get light to appear with using only Spotlight, it was white.

Anyway, so it seems there's a difference between the green model and the others, and there's something up when declaring multiple transforms for lightName that causes no light to appear at all.

Very nice models btw!

 

[Virtualgenius]

@sumghai I was wondering if you had a chance to look at this yet 

Edited July 10, 2022 by Virtualgenius

[Rakete]

Since KSP has received it's last update, a repaired version of this mod would be great. @sumghai

[sumghai]

6 hours ago, Rakete said:

Since KSP has received it's last update, a repaired version of this mod would be great. @sumghai

As much as I'd like that, the final update fundamentally changed how emissives and animations works, which basically broke the core functionality of this mod.

It's the exact same problem that's plaguing the docking lights and docking hatch window emissives from the SDHI Service Module System mod.

[Rakete]

1 hour ago, sumghai said:

As much as I'd like that, the final update fundamentally changed how emissives and animations works, which basically broke the core functionality of this mod.

So there will be no fixed version for 1.12.x ? That's sad, but fully understandable... I guess it would be too much  work, to fully reconstruct the mechanism. Thanks anyway for that great mod in the past.

Edited January 7, 2023 by Rakete

[Stone Blue]

On 12/26/2021 at 1:32 PM, OrbitalManeuvers said:

This is 1.12.3. The green light is an outlier in that its animation works, although it never turns off. None of the other animations work. None of the lights produce any light in the VAB or in flight.

 So I edited one of the lights to have just one value for lightName, and using either PointLight or Spotlight changed the VAB behavior, though it's still not as designed I'm sure. Using only PointLight gets you a small internal light turning on/off, and using only Spotlight gets you a light that does rotate and does illuminate the environment, but I don't think it's quite right ... not sure what's it's supposed to look like. When I did get light to appear with using only Spotlight, it was white.

Anyway, so it seems there's a difference between the green model and the others, and there's something up when declaring multiple transforms for lightName that causes no light to appear at all.

I've poked this mod, too.
So, I'm guessing with the green light, Sumghai probably checked the "Play Automatically" box in Unity, for that one... at least the always-on rotation (animation), seems to bear that out.

I found the same with defining multiple light names in the cfg key. I found out, you can fix that, simply by naming *both* light game objects, the *same* name, *in the model, before export*. Works just like naming seperate animation tracks, the *same* name, to get them *all* to play as a single animation

I'm close to having these fixed, except for one small, but major problem: They work like they are supposed to, *except*, they only rotate once, then turn off.
The problem is, i cant seem to get the animation to keep looping while activated.

Edited January 11, 2023 by Stone Blue

[sumghai]

16 hours ago, Stone Blue said:

I've poked this mod, too.
So, I'm guessing with the green light, Sumghai probably checked the "Play Automatically" box in Unity, for that one... at least the always-on rotation (animation), seems to bear that out.

I found the same with defining multiple light names in the cfg key. I found out, you can fix that, simply by naming *both* light game objects, the *same* name, *in the model, before export*. Works just like naming seperate animation tracks, the *same* name, to get them *all* to play as a single animation

I'm close to having these fixed, except for one small, but major problem: They work like they are supposed to, *except*, they only rotate once, then turn off.
The problem is, i cant seem to get the animation to keep looping while activated.

Yeah, this was essentially the problem I had - they rotate once, then stop.

And getting multiple light objects with the same name to play nice is also an issue that has plagued the SDHI SMS mod as well - I've struggled to get the docking port lights and emissives working properly again.

In any case, if you do manage to figure this out, drop me a PM, and I'll fold your fixes into an official release.

[Jup]

I found this on a quick search, and I wonder if it helps any?

https://answers.unity.com/questions/339124/how-to-loop-animation-from-code.html
and
https://answers.unity.com/questions/204331/animation-loop.html

I would like to add my name to the list of players who would be eternally grateful for a working release in 1.12.x

One last edit, since it's late and I really should be in bed lol...

Would it be simpler to code a stationary light (with all the standard brightness/beam angles adjustments) and then have a rotating "occluder" to give the strobing effect?
It seems that the standard lighting is pretty well established: Omnilights, navigation etc
The only trick is a looping, shadow casting, shroud.

Edited March 14, 2023 by Jup
last minute thoughts...

[Stone Blue]

On 3/14/2023 at 6:16 AM, Jup said:

I found this on a quick search, and I wonder if it helps any?

While those are all good ideas/leads, and yeah, relevant, I explored all that pretty extensively.

I think it needs to go one step further.
This:
https://docs.unity3d.com/Manual/AnimationLayers.html

I poked that a little bit, but by that point I was pretty exhausted/frustrated, and while I skimmed the info there and tried it once or twice, I didnt *really* tae the time to fully comprehend it, and i dont think I implemented the right settings.

I believe that the ModuleAnimationGroup module that the stock Orbital Scanner part (which i used as an axample, since it does *exactly* what we want),
I *think*, has the `deployAnimationName' on layer 3, `activeAnimationName` & `deactivateAnimationName` on layer 4, but now we get into the code, and I know *just* enuff about coding to be very dangerous

Anyway, I tried just about *every* combination of the three modules I've included below. I'm including it, not in a working/close to working state (you would have to mess around completely commenting out combinations of whole modules, as well as individual lines).  IIRC, I used *either* ModuleLight or ModuleAnimateGeneric with ModuleAnimationGroup, not *both at the same time*, to get close to solving this.

Hopefully someone can solve the last piece of this puzzle. If so, I think it could *widely* be used to fix/enhance *many* other parts, in *many* other mods.

My example, with extensive comments: (take my statements as a grain of salt, tho. use moar as a starting point to experiment with)
 

Spoiler

//	MODULE
//	{
//		name = ModuleLight
//		lightName = SDHI_Point
//		lightMeshRendererName = led
//		disableColorPicker = true							//default is false
//		moduleID = ModuleAnimationGroup						//default moduleID = "lightModule"
//		useAnimationDim = true
//		lightBrightenSpeed = 0.1
//		lightDimSpeed = 0.1
//		resourceAmount = 0.01
//		animationName = SDHI_WRL
//		useResources = true
//
//		isOn = true
//		uiWriteLock = false	//true
//		guiActive = false									//unknown
//		castLight = false									//true			doesnt work
//		showStatus = false									//doesnt work
//		flareRendererName = rotator_loop					//doesnt work
//		axisMode = KSPAxisMode.Incremental
//		incrementalSpeed = 30
//		rotationAngle = 360
//	}

//	MODULE
//	{
//		name = ModuleAnimationGroup
//		activeAnimationName = dummy		//CompiledAnimation	//keep this blank, it works. Also works if this is the same as deployAnim
//		deactivateAnimationName = CompiledAnimation			//with dummy anim here, part works, but light goes off after the the anim
//		deployAnimationName = CompiledAnimation				//keep this, and it plays but stops. using dummy anim, it toggles & "Moving" status.. does nothing & stops

//		deployActionName = SDHI On 							//default #autoLOC_6001485 = Activate
//		retractActionName = SDHI Off 						//default is #autoLOC_6001957 = Deactivate

//		alwaysActive = true									//default is false Doesnt seem to make a difference, unless it keeps the "hidden" animation always active?
//		autoDeploy = true									//default is false	Set to True will suppressActionsEvents to true (so there are no PAW actions or events shown)
																//Will set isDeployed to true on startup. Another module must manage the deployment.
//		displayActions = false								//default is true	If set to False all Actions will be suppressed from the UI. 
//		moduleType = #autoLOC_7001229 						//default is #autoLOC_7001229 = Scanner
//		stopActiveAnimIfDisabled = true						//default is false	No visible effect yet..retest when/if continuos anim is working
//		suppressActionsEvents = true						//default is false  Set to True will suppress all Actions and Events from the PAW and UI. Does NOT set
																//isDeployed to true on startup. Another module must manage the deployment.
//		toggleActionName = SDHI On/Off 						//default is #autoLOC_6002389 = Toggle <<1>>
//		deployActionName = SDHI On 1 						//default is #autoLOC_6002387 = Deploy <<1>>
//		retractActionName = SDHI Off 1 						//default is #autoLOC_6002388 = Retract <<1>>
//	====Below inherited from PartModule =======================================================
//		isEnabled = false									//default is true
//		moduleIsEnabled = false								//default is true
//		moduleName = ModuleLight							//ModuleAnimateGeneric,
//	}

	MODULE 
	{
		name = ModuleAnimateGeneric
//		actionAvailable = false								//default is true
		actionGUIName = Lights							    //default is "#autoLOC_6001354"
//		allowAnimationWhileShielded = false					//default is true
//		allowDeployLimit = true								//default is false
//		allowManualControl = false							//default is true
//		animationIsDisabled = true							//default is false
		animationName = CompiledAnimation
		animSpeed = 0.2									    //default is 1f
//		animSwitch = false									//default is true
//		animTime = 											//default is 0f
//		aniState = FIXED									//default is animationStates.LOCKED	;"MOVING" sets the anim active always, also anim speed now works
//		CrewCapacity = 0									//default is 0	Dynamic crew capacity when animation is fully played.
		defaultActionGroup = Light						    //default is KSPActionGroup.None
//		deployPercent = 									//default is 100f
//		disableAfterPlaying = true							//default is false
		endEventGUIName = Light Off						    //default is "#autoLOC_6001354"
//		evaDistance = 5										//default is 5f
//		eventAvailableEditor = false						//default is true
//		eventAvailableEVA = false							//default is true
//		eventAvailableFlight = false						//default is true
		instantAnimInEditor = false						    //default is true
//		isOneShot = true									//default is false
//		layer = 4											//default is 1	changing seems to have no effect
//		moduleID = 											//default is "genericAnim"
//		restrictedNode = 									//default is ""
//		revClampDirection = true							//default is false
//		revClampPercent = true								//default is false
//		revClampSpeed = true								//default is false
		showStatus = true									//default is true
		startEventGUIName = Light On						//default is "#autoLOC_6001354"
//		status = Fixed										//default is Localizer.Format("#autoLOC_215362")
//		useMultipleDragCubes = false						//default is true	Determines whether this module will use multiple drag
                                                                 cubes. Set to false for cosmetic-only animations, eg: Lights 
																
//	====Below inherited from PartModule =======================================================
//		isEnabled = false									//default is true
//		moduleIsEnabled = false								//default is true
//		moduleName
//		overrideStagingIconIfBlank = false					//default is true
//		resHandler =										//default is  new ModuleResourceHandler()
//		showUpgradesInModuleInfo = true						//default is false
//		stagingDisableText = 								//default is ""
//		stagingEnabled = false								//default is true
//		stagingEnableText = 								//default is ""
//		stagingToggleEnabledEditor = true					//default is false
//		stagingToggleEnabledFlight = true					//default is false
//		upgradesApply = false								//default is true
//		upgradesAsk = false									//default is true

//==========notes
//		status =Locked & aniState = LOCKED	"On" PAW button, light on-no anim; actiavte plays anim, no way to turn off;  animSpeed is NOT applied
//		status =Locked & aniState = MOVING	 no PAW button, light & anim plays automatically; no way to turn off; animSpeed is applied
//		status =Locked & aniState = CLAMPED	"On" PAW button, light on-no anim; actiavte plays anim, no way to turn off;  animSpeed is NOT applied
//		status =Locked & aniState = FIXED	"On" PAW button, light on-no anim; actiavte plays anim, no way to turn off;  animSpeed is NOT applied
//		status =Fixed  & aniState = LOCKED	"On" PAW button, light on-no anim; actiavte plays anim, no way to turn off;  animSpeed is NOT applied
//		status =Fixed  & aniState = MOVING	 no PAW button, light & anim plays automatically; no way to turn off; animSpeed is applied
//		status =Fixed  & aniState = CLAMPED	"On" PAW button, light on-no anim; actiavte plays anim, no way to turn off;  animSpeed is NOT applied
//		status =Fixed  & aniState = FIXED	"On" PAW button, light on-no anim; actiavte plays anim, no way to turn off;  animSpeed is NOT applied
																
	}
}

 

Actuallly... WTH... Here, i just pushed my work to Github, incase anyone wants to try to pic up where i left off... i dont know if I'll come back to it, after spending almost 2 weeks trying to figure it out

Just *remember*, yeas, there are other mods/plugins that could most likely be used to fix these, but in the spirit of the original, and I believe by Sumghai's intent:
*The idea is to get this all accomplished using ONLY stock modules, with no extra code/.dll, or 3rd party plugin dependencies*

https://github.com/StoneBlue/SDHI-StrobeOMatic-StoneBlue

@sumghai just FYI so you know my attempts are on a repo incase *you* ever wanna poke this mod again

I modified/optimized an original model, named `SDHI_WRL.mu`.  I think all the different parts/models/materials, could be accomplished using just *one* model, with the stock part variant system. I was also gonna do a an optional B9PartSwitch patch, to combine everything to just one part in the editor, as I *know* that would work.... not sure if the stock variant system would be able to get it done.

Edited March 15, 2023 by Stone Blue