[1.12.x] DaMichel's CargoBays (DCB) - Version 1.1.99.0-prerelease <Split'n'Polish: CargoBays> (27 Jul 2022)

[Rutabaga22]

17 minutes ago, JadeOfMaar said:

@Rutabaga22 @zer0Kerbal The heatshield is just a visual style and not actually functional. You're looking at the underside of a B9 Aerospace S2 cockpit and B9 S2--2.5m adapter.

 

Thank you!

[Krazy1]

Hi @zer0Kerbal

I'm using 1.1.99.1 prerelease and I tried a new ship with a 2m long 2.5m bay and saw some issues.

1. The drag is not occluded for parts inside (bug #45)
2. The  surface lighting on the doors looks odd to me... maybe related to bug #44. When hovering pointer over it, not all the panels/ sections of the curved door surface are highlighted, and which sections are highlighted changes with camera position. The highlight itself doesn't bother me but the lighting seems to behave similarly. The yellow frame inside seems to glow or too light, not sure.
3. Seeing orange error on screen in editor when loading a saved ship. From KSP log: [ERR 17:43:11.107] [ModuleCargoBay]: Module ModuleToggleCrossfeed is not an IScalarModule
4. In the PAW, the open/ close toggle button always says "open doors" even when they are open. It does appear to open/ close correctly however. 

KSP log

player log

Not ideal - lots of other mods. Thanks for maintaining this mod. It gives ship builds a lot more flexibility.

[zer0Kerbal]

On 8/5/2023 at 9:19 PM, Krazy1 said:

Hi @zer0Kerbal

I'm using 1.1.99.1 prerelease and I tried a new ship with a 2m long 2.5m bay and saw some issues.

1. The drag is not occluded for parts inside (bug #45)
2. The  surface lighting on the doors looks odd to me... maybe related to bug #44. When hovering pointer over it, not all the panels/ sections of the curved door surface are highlighted, and which sections are highlighted changes with camera position. The highlight itself doesn't bother me but the lighting seems to behave similarly. The yellow frame inside seems to glow or too light, not sure.
3. Seeing orange error on screen in editor when loading a saved ship. From KSP log: [ERR 17:43:11.107] [ModuleCargoBay]: Module ModuleToggleCrossfeed is not an IScalarModule
4. In the PAW, the open/ close toggle button always says "open doors" even when they are open. It does appear to open/ close correctly however. 

KSP log

player log

Not ideal - lots of other mods. Thanks for maintaining this mod. It gives ship builds a lot more flexibility.

@Krazy1 - thank you, I've reopened #45 - still need to know which parts.

Kindly drag'n'drop the logs into the bug report.

Will look into this shortly.

[Krazy1]

On 8/7/2023 at 9:15 PM, zer0Kerbal said:

@Krazy1 - thank you, I've reopened #45 - still need to know which parts.

Kindly drag'n'drop the logs into the bug report.

Will look into this shortly.

Posted. I'll try to test different sizes this weekend

[Krazy1]

Tested... parts inside all bays have drag. Bay size, internal part node or surface attached didn't matter. Also saw an Airplanes Plus bay has the same issue.  Posted in issue 45

Another little thing... there are 2 node attach points offset slightly from each other, one correct distance, one slightly inside the part you are attaching to. So when placing the CB, you need to fiddle with the placement to avoid parts overlapping a little and having some z-fighting where they overlap. It's hard to get the right placement with the 5m size parts especially.

ICYMI @zer0Kerbal

Edited August 20, 2023 by Krazy1
typo, tag

[Krazy1]

@zer0Kerbal they discovered the drag may be related to attachment nodes. 

 

[Lisias]

4 minutes ago, Krazy1 said:

@zer0Kerbal they discovered the drag may be related to attachment nodes. 

 

Yep. Just inspected them, and I found one 2.5 part with the wrong definitions.

https://github.com/zer0Kerbal/CargoBays/pull/53

At least one of the problems you found will be fixed by it - and I suspect that a lot of other problems are due 3rd parties (or even Stock), as I finding such mishaps on every corner I look!!!