Jump to content

linuxgurugamer

Bug Hunter
  • Posts

    24,945
  • Joined

  • Last visited

Everything posted by linuxgurugamer

  1. No problem, I can do it for you, if you like. I just need your permission
  2. Ok, from what I see in the code, KSP_VERSION is not required for the min or max to work. It's optional from what I can tell, essentially you need at least one of them set. Here is the important code, it's duplicated in both the full AVC and Mini-AVC: public bool IsCompatible { get { return IsCompatibleKspVersion || ((kspVersionMin != null || kspVersionMax != null) && IsCompatibleKspVersionMin && IsCompatibleKspVersionMax); } } public bool IsCompatibleKspVersion { get { return Equals(KspVersion, actualKspVersion); } } public bool IsCompatibleKspVersionMax { get { return KspVersionMax >= actualKspVersion; } } public bool IsCompatibleKspVersionMin { get { return KspVersionMin <= actualKspVersion; } } I found the following: public bool IsUpdateAvailable { get { return this.IsProcessingComplete && this.LocalInfo.Version != null && this.RemoteInfo.Version != null && this.RemoteInfo.Version > this.LocalInfo.Version && this.RemoteInfo.IsCompatibleKspVersion && this.RemoteInfo.IsCompatibleGitHubVersion; } } which seems to indicate that the KSP_VERSION actually IS necessary. But I'm wondering if this is a bug. I'd say for now, put it back, but I'm going to contact @cybutek about it
  3. I know what it says, but I've seen cases where, when KSP_VERSION is specified, the MIN and MAX are ignored. I suppose it's possible that if the KSP_VERSION doesn't equal one of the other two, that it gets ignored. I'll have to take a dive into the code later
  4. New release, 0.0.2: Updated for KSP 1.3.1 I'll add this as an enhancement request. May be a little bit, I'm busy with updates right now Next time, ping me so I see the message
  5. New release, 1.1.2: Updated for KSP 1.3.1 It WAS dead. Now it's alive. I really have no idea, but it does need RPM to work, so probably it is.
  6. The .version file is somewhat wrong, it says both KSP version of 1.3.1, and then a KSP_verion_min of 1.3.0, it also has a trailing comma which fails JSON checks. I've seen some odd behaviour from both CKAN (I know you don't support it) and AVC when there is both a KSP_VERSION and a KSP_VERSION_MIN Can I suggest the following as a fix: { "NAME": "RasterPropMonitor", "URL": "https://raw.githubusercontent.com/Mihara/RasterPropMonitor/master/GameData/JSI/RasterPropMonitor/RasterPropMonitor.version", "DOWNLOAD": "https://github.com/Mihara/RasterPropMonitor/releases", "VERSION": { "MAJOR": 0, "MINOR": 29, "PATCH": 1 }, "KSP_VERSION_MIN": { "MAJOR": 1, "MINOR": 3, "PATCH": 0 }, "KSP_VERSION_MAX": { "MAJOR": 1, "MINOR": 3, "PATCH": 1 } }
  7. New release, 1.4.10.1 Updated MM dll I just went through all the mods I've updated for 1.3.1, it was only this and All'Y'ALL which had the wrong dll. Thanks
  8. You could try the Loading Screen Manager mod. I hope to have it updated for 1.3.1 today
  9. Very nice. CKAN anytime soon?
×
×
  • Create New...