[1.12.x] Toolbar Continued - Common API for draggable/resizable buttons toolbar

[linuxgurugamer]

51 minutes ago, Coyote21 said:

OK, sorry thought I was saving some time by only posting, what I thought was the relevant section of my log.

Using version 1.7.20 installed with CKAN, with UnBlur

The mods with icon issues are all the ones using .dds files for icons, but specifically in my case, they are:

• Action Group Manager
• Chatterer
• Quick Exit
• kOS

I have fixed all but Action Group Manager by simply converting the .dds files to .png files. This is not working for Action Group Manager however.

I have undone my fixes (returned all to original) for this output_log.

output_log.txt avail at https://www.dropbox.com/s/fjyh32dokij2jpv/output_log.txt?dl=0

Let me know if you need anything else.

 

Ok, I'll get this fixed this evening.

Thank you for testing, please leave the log file available until tomorrow

52 minutes ago, Coyote21 said:

OK, sorry thought I was saving some time by only posting, what I thought was the relevant section of my log.

It never hurts to point out what you think is relevant, but sometimes there is other stuff in the log, sometimes thousands of lines away, which is needed.  So, even when posting the relevant portions, it's also useful to post the log as well.

Anyway, thank you for doing this.  Strangely enough, I haven't seen this in my games.

Silly question, did you test without the UnBlur mod?

[drtedastro]

1 hour ago, linuxgurugamer said:

Well, a log file would have helped.

Please make sure you are running the latest version, and then post a log if it happens, also would be helpful to know which mods' icons are giving you the problem

Do you have the unBlur mod installed? It's optional now, but when present is supposed to avoid some slowdowns associated with reading files

and yes, logs would help.

thanks for reply.

I do not have the "unblur" mod loaded.

I will get you the logs for with old and new toolbarcontrol in use.

thanks. 

[linuxgurugamer]

@Coyote21 are you getting the same issue without the unBlur mod?

[Coyote21]

5 hours ago, linuxgurugamer said:

@Coyote21 are you getting the same issue without the unBlur mod?

Yes, I only installed unBlur to try to fix it.

Without unBlur the Chatterer, kOS, and QuickExit icons turn into Red Questions marks on white background. The Action Group Manager icon remains purple.

Output_log.txt without unBlur installed avail here

https://www.dropbox.com/s/q5lmk0acvzkus4c/output_log - No_UnBlur.txt?dl=0

Edited July 22, 2019 by Coyote21
More Info

[linuxgurugamer]

5 hours ago, linuxgurugamer said:

• Action Group Manager
• Chatterer
• Quick Exit

I use these three, and I don't see any issue with them right now.

@drtedastro I suspect you are getting a lot of exceptions in your log

@Coyote21  @drtedastro

I'm going to make a debug version of the ToolbarController this evening, please try it out when you can

[drtedastro]

Excellent , i will do it when off work.

cheers.

ted.

[Coyote21]

No hurry, I've fixed (hacked) Chatterer, QuickExit and kOS by converting the .dds icons to .png and I've decided I like Action Groups Extended more than Action Group Manager so I've removed AGManager.

[Coyote21]

OK, I might have misled you a bit with the .dds icon files.

Its started to happen now with .png icons as well.

Kaptain's Log is now also showing purple square. It was fine for sometime, then started turning purple for no apparent reason after being clicked.

I could swear I have used it many times before but now it turns into a purple square after being clicked everytime.

Clicking it again or closing the Kaptain's log UI does not change it back to normal.

On first loading a save it's fine, until you click on it.

Do you need another output.log? 

https://www.dropbox.com/s/a71ao0q99atemv8/output_log - Kaptains_Log.txt?dl=0

 

 

[linuxgurugamer]

32 minutes ago, Coyote21 said:

OK, I might have misled you a bit with the .dds icon files.

Its started to happen now with .png icons as well.

Kaptain's Log is now also showing purple square. It was fine for sometime, then started turning purple for no apparent reason after being clicked.

I could swear I have used it many times before but now it turns into a purple square after being clicked everytime.

Clicking it again or closing the Kaptain's log UI does not change it back to normal.

On first loading a save it's fine, until you click on it.

Do you need another output.log? 

https://www.dropbox.com/s/a71ao0q99atemv8/output_log - Kaptains_Log.txt?dl=0

 

 

I know whats wrong, its just being a PITA to fix

[linuxgurugamer]

For those who have been having problems with the toolbar, here is an updated beta, this beta totally removes the UnBlur mod, and keeps the button scaling.

It also seemed to resolve a blurring issue on small buttons.

Please try it out and let me know ASAP if you have any problems.

https://www.dropbox.com/s/o1xoce5ibxfilfz/000_Toolbar-1.7.21.zip?dl=0

For those interested, the source for this is on Github, in the branch UnblurRevert

[Beetlecat]

Can confirm the solid-color toolbar button(s) I was noticing are now back to normal with that linked beta.

Edited July 24, 2019 by Beetlecat

[Brigadier]

7 hours ago, linuxgurugamer said:

For those who have been having problems with the toolbar, here is an updated beta, this beta totally removes the UnBlur mod, and keeps the button scaling.

It also seemed to resolve a blurring issue on small buttons.

Please try it out and let me know ASAP if you have any problems.

https://www.dropbox.com/s/o1xoce5ibxfilfz/000_Toolbar-1.7.21.zip?dl=0

For those interested, the source for this is on Github, in the branch UnblurRevert

I've run basic tests of this under KSP 1.7.1/GPP and it seems to eliminate the pink icon on the toolbar problem that I've experienced recently.

[linuxgurugamer]

New release, 1.7.21

• Removed UnBlur entirely
• Fixes purple buttons

Apologies to all who had problems with the last version.  Sometimes a good idea in theory doesn't work out in practice.

[Coyote21]

Just d/l and tested. Works great again, thanks.

[edemlama]

I still get a purple button for TAC as well as a bunch of ? for MechJeb (not all)

 

 

Edited July 25, 2019 by edemlama

[linuxgurugamer]

New release, 1.7.22

• Fixed purple buttons from mods which add textures to the game database at runtime without a file (looking at [x]Science!)
• Optimized the Texture code a bit to eliminate duplicated code
• Changed resize from Bilinear to Point
• Added check for textures being resized to same size and returns if so without doing anything
• Added check for small icon (24x24) when bigtexture is available, if it is and a small texture is available, use that instead

[Tonka Crash]

12 hours ago, linuxgurugamer said:

New release, 1.7.22

• Fixed purple buttons from mods which add textures to the game database at runtime without a file (looking at [x]Science!)

First thing I do when I start for the day is check CKAN for updates. I got Toolbar and KEI. Now TacFuelBalancer has a purple texture on my toolbar. Everything was fine yesterday. 

https://www.dropbox.com/s/4bmwlsnp3dyofgs/KSP_Toolbar.zip?dl=0

According to the log the texture loaded just fine, but when it it comes to using the toolbar the texture can't be found.

If I select "Configure Visible Buttons" Both TacFuelBalancer and RCS Build Aid are purple in just the Toolbar Button Visibility menu, but RCS Build Aid has the correct texture in the VAB.

[linuxgurugamer]

43 minutes ago, Tonka Crash said:

First thing I do when I start for the day is check CKAN for updates. I got Toolbar and KEI. Now TacFuelBalancer has a purple texture on my toolbar. Everything was fine yesterday. 

https://www.dropbox.com/s/4bmwlsnp3dyofgs/KSP_Toolbar.zip?dl=0

According to the log the texture loaded just fine, but when it it comes to using the toolbar the texture can't be found.

If I select "Configure Visible Buttons" Both TacFuelBalancer and RCS Build Aid are purple in just the Toolbar Button Visibility menu, but RCS Build Aid has the correct texture in the VAB.

I really hate these mods which play games with the game database.  I'll look at this later

[Lisias]

33 minutes ago, linuxgurugamer said:

I really hate these mods which play games with the game database.  I'll look at this later

The TacFuelBalancer calls directly a static method from the ToolbarController_NS (one on the Utils). I realized that while mangling with my experimental forks.

The easiest way out is to use the old method as a facade to whatever you are using now.

[linuxgurugamer]

Thanks, but it's not the only one. And I thought I had fixed that.

[linuxgurugamer]

New release, 1.7.22.1

• Fixed nullref when loading buttons
• Fixed check for file existence

[linuxgurugamer]

5 hours ago, Lisias said:

The TacFuelBalancer calls directly a static method from the ToolbarController_NS (one on the Utils). I realized that while mangling with my experimental forks.

The easiest way out is to use the old method as a facade to whatever you are using now.

Just an FYI, that method was put into the ToolbarController to provide a common method for mods to read images.

[edemlama]

21 hours ago, linuxgurugamer said:

New release, 1.7.22.1

• Fixed nullref when loading buttons
• Fixed check for file existence

I'm getting purple Tac button again after this update, it worked with 1.7.22

Edited July 27, 2019 by edemlama

[linuxgurugamer]

2 hours ago, edemlama said:

I'm getting purple Tac button again after this update, it worked with 1.7.22

Log file and a picture, please.

[edemlama]

31 minutes ago, linuxgurugamer said:

Log file and a picture, please.

I had the purple button in 1.7.21, was fixed with 1.7.22 and now it's back 

here you go 

log: https://mega.nz/#!r4chCY5D!Ahr01bvUskmOzl1kBorxtFQXfGpyFSI9xjIIDVQN_0o

picture: https://mega.nz/#!T4d1RSZb!TaDynMnso7fG7vUKRIm3GYxeibluymBTOHzdeeouQY4

Thanks