xD-FireStriker Posted February 3, 2023 Share Posted February 3, 2023 On 2/2/2023 at 9:54 AM, Lisias said: Your problem is not this "damn mod". The problem is the damn crappy patches you installed on your rig, and I strongly suggest you start considering carefully about restricting yourself from installing things on it without the proper care. I had this issue for many moons with no thought of a fix, just thinking it was yet another quaky side of Tweakscale. Any tips on finding the crappy patches to fix this in future? Quote Link to comment Share on other sites More sharing options...
Lisias Posted February 3, 2023 Author Share Posted February 3, 2023 23 minutes ago, xD-FireStriker said: I had this issue for many moons with no thought of a fix, just thinking it was yet another quaky side of Tweakscale. Any tips on finding the crappy patches to fix this in future? That's the problem: this time, it is not the patches. The misbehaviour is essentially the same because it affects somehow a critical code that handles ScaleType migrations that work on the same ConfigNode a patch would do. This used to be a nasty problem until early 2022 when I published the migration code. Problem: that damned thing worked when i wrote it, and it worked last time I checked it purposely - what I admit, it's some time ago. So I found that TweakScale 2.5 beta didn't had the problem and gladly back ported all the respective changes into what would be 2.4.6.22 and… Guess what? The very same snippet borked on 2.4.6.xxx codebase! So the problem is not the migration code, it's something else. On a wild guess, I noticed that TS 2.5 Beta doesn't use KSPe.Light, but the full blown one - so I compiled 2.4.6.21 using it instead of the KSPe.Light stunt - and for some time, the damned thing worked when KSPe.Light was not installed, and borked when KSPe.Light was installed! So I gone thought my archive and grabbed every single KSPe.Light I ever compiled for TweakScale and installed it there, one by one, and rebooted KSP and tried to reproduce the problem - since the thing was using KSPe full, doesn't matter the Light version I shove on that directory. This series of tests apparently pinpointed TweakScale 2.4.6.0 as the first one with a faulty KSPe.Light, because the one shipped on 2.4.5.9 didn't triggered the problem! And then, subtly, I reached a situation in which the problem is being reproduced all the time no matter KSPe.Light is there or not, suggesting I was wrong and the problem was being triggered by something else, and all that testings with multiple KSPe.Light were all coincidences - or perhaps only one of the possible triggers of the problem, being this new trigger something that is active right now and didn't was untriggered yet at the present time. Remembering another completely bonkers issue I had tried to help to diagnose some years ago, I tried rebooting the machine to see if anything changes. And nope, nothing had changed, the problem is still there right now. What I'm considering now is that I inadvertently created another problem today a some point doing all these testings, and since the misbehaviour is pretty similar to the original one, I may had infringed confirmation bias to myself on all these testings, so right now I'm reticent on pinpointing my finger on anything. Apparently my hint on the (original) problem not affecting TweakScale 2.5 Beta is still valid - but I will confirm it (or not) tomorrow, as right now it's time to give this a rest (as well to myself - I had tried to solve too many problems today, not only this one. Good thing I managed to solve some of them, though). if you are curious about all this craziness: https://github.com/net-lisias-ksp/KSPe/issues/46 On a side note, TweakScale had a working "scale migration tool" on the KSP 1.3 era, and it may had worked on the 1.4 era too. This stopped to work more or less on 1.5 or 1.6 (don't remember exactly right now), when KSP introduced the KSPUpgradePipeline, the code KSP uses to inject back PartModules and new attributes on older craft files and savegames. It's the reason you can load a craft file (or a whole savegame) made by earlier versions of KSP into newer ones and get the thing working. It's also how you can load a craft file made by someone that doesn't have TweakScale installed and then be able to scale things on it - KSPUpgradePipeline injected TweakScale on that part for you. The thing is that the KSPUpgradePipeline kicks after the OnLoad KSP event and before the first Unity's Update event, and TweakScale used to do its magic exactly on that point that got squashed by the pipeline - KSPUpgradePipeline notices the prefab data is different than the MODULE config node it just loaded and then squashes the prefab values on whatever is there. This screwed up royally the TS migration code, as by the time it was being kicked in, the data it needs to recalculate things is gone. I solved the problem by doing the migration during the OnLoad handling, before the KSPUpgradePipeline kicks in - and so I had access to the original ConfigNode's data. So I did the magic there, and allowed KSP to keep loading this updated ConfigNode as it was the one being read from the disk - essentially, being my own mini UpgradePipeline in the stack. The code I wrote at that time wasn't the best, I called it a day on the exact instant the thing worked as intended - but, hey, it was working! Exactly why this gone south it's unknown at this moment. What has gone south I think I had detected, but I need to reassess the whole situation as I may had contaminated the testings with a new mistake and so my current conclusions may be unfunded. Interesting day this one of mine, no? Quote Link to comment Share on other sites More sharing options...
dan1ell1ma Posted February 3, 2023 Share Posted February 3, 2023 Quote Link to comment Share on other sites More sharing options...
dan1ell1ma Posted February 4, 2023 Share Posted February 4, 2023 (edited) Hello! I installed the beta verison, and solved the problem of part size misbehavior. Now the lauch button dont works anymore. When inside VAB, i click to launch but the game backs to KSC. Edited February 4, 2023 by dan1ell1ma Quote Link to comment Share on other sites More sharing options...
Lisias Posted February 4, 2023 Author Share Posted February 4, 2023 (edited) 3 hours ago, dan1ell1ma said: Hello! I installed the beta verison, and solved the problem of part size misbehavior. Now the lauch button dont works anymore. When inside VAB, i click to launch but the game backs to KSC. That's a new. The Beta is beta for a reason, one little misbehaviour or another are expected - but not something big as this one. I would not had even committed such a code.[but I had] There's a TweakScale button on the AppBar in the Editor? Did you installed the KSPe thingy, a dependency on it? Post your KSP.log so I can see what gone bad on your rig. — - — POST EDIT — — — @dan1ell1ma, don't bother. I rushed 2.5.0.51 Beta too fast, I found a pretty stupid mistake on the "new" migration code that is borking on Launch, aborting the sequence. Use Beta to load and save your crafts, then revert back to the previous release for playing. I'm fixing Beta and will publish a .52 release in the next few hours, but, hey, this thing is a Beta. Edited February 4, 2023 by Lisias Damn. I did it. :/ Quote Link to comment Share on other sites More sharing options...
dan1ell1ma Posted February 4, 2023 Share Posted February 4, 2023 You are awesome! Tmj! Quote Link to comment Share on other sites More sharing options...
Lisias Posted February 4, 2023 Author Share Posted February 4, 2023 NOTAM TweakScale 2.5.0.52 **BETA** is on the wild, and available on github only. I fixed that dumb mishap of mine made on .51 , as well revised all the Scale Migration Code to cope with some… "new"… changes on KSP behaviours related to PartModule.OnLoad(ConfigNode). This thing is, now, safe to Load your Craft files and Savegames, and to the best of my (scarse) available time for testing it, it appears to work. HOWEVER… The Beta is still a very new codebase, and unexpected things may still happen. People in need to migrate from older Craft files and Savegames where the ScaleTypes for some parts had changed over time, as well people that uses All Tweak and got themselves some new TweakScale patching for parts that didn't had them before, will need to install TweakScale Beta 2.5.0.52 to salvage them. Load and Save, and you are done. Keeping 2.5.0.x BETA for ongoing gaming, however, may be hazardous. As I said, it's a ongoing development branch and some implementation decisions may fireback unexpectedly, Unless you are willing to help me on beta testing the thing (and, so, no playing your valuable savegames on it), I recommend to roll back to the current Release 2.4.6.21 after converting your assets. What I expect to be the new 2.4.6.22 release is, right now, work in progress. Now that I have identified the reason for a "new" misbehaviour, I can go back to the workbench in order to diagnose the reason 2.4.6.21 is failing on the Scale Migration Tool due an (now) "old" misbehaviour. As I said before, Two lightnings can hit the same person on the same place at the same time, after all . It hurts, but at least that dude on the video survived the ordeal, so TweakScale will also. Cheers (and be aware of Lightning Bolts!) Quote Link to comment Share on other sites More sharing options...
Lisias Posted February 5, 2023 Author Share Posted February 5, 2023 ANNOUNCE Release 2.4.6.22 is available for downloading, with the following changes: I DON’T KNOW why I had to release this one. I don’t know what had broken, I don’t know why the changes needed to be made to make things thigh again solved the problem. I know what, I know where. But I don’t know why. Things that were working on March 2022 just stopped working - on the same test beds they worked before. Works issues: #287 Misunderstanding (?) on how PartModule.OnLoad(ConfigNode) really works #286 PartModule.OnLoad is not called with node as null on Flight Scene! (Dis)Honorable mention: #288 Carnage on crafts from very old TweakScale versions. This one was very, very weird. I will not repeat myself on a long wall of text, people masochistic enough to learn the gory details, please visit the issues linked above. TL;DR: Things that were working on March 2022, from KSP 1.4.3 to 1.12.3 (I think) suddenly stopped working. While trying to detect what in hell was happening, **I** did a new mistake that messed a bit the diagnosing. Suddenly, the initial misbehaviour just vanished in thin air leaving only the one I made in the process. Fixing "my" mistake revealed that a behaviour that was consistent since the first time I implemented the ScaleType Migrating Code had changed too. So I worked around all that crap and created 2.4.6.22. What and where I did the changes are obviously on the commits. Why I had to make that changes are still a mystery at this moment. Anyway, things are working again RIGHT NOW from KSP 1.4.3 to 1.12.5 for sure - I just tested them. Ping @AlonzoTG. And a huge thanks to @starfall22 for helping on diagnosing this… event. Disclaimer By last, but not the least... Spoiler No Module Manager was harmed during the development of TweakScale. This Release will be published using the following Schedule: GitHub, reaching first manual installers and users of KSP-AVC. Right now. CurseForge. Right now. SpaceDock (and CKAN users). Right now. The reasoning is to gradually distribute a potentially Support Fest release in a way that would me allow to provide proper support if anything else goes wrong. Quote Link to comment Share on other sites More sharing options...
BlackDinoShadows Posted February 5, 2023 Share Posted February 5, 2023 I've a question , is there a sort of bypass for rescaling everythings because my rescale don't work for BDB or more old mods like Integrated Phoenix Industries (Space Tug) so is there a bypass or it's just a problem with my tweakscale ? Quote Link to comment Share on other sites More sharing options...
GoAHead Posted February 5, 2023 Share Posted February 5, 2023 since latest release i can't switch vessels and also the exit menue doesn't work anymore. [LOG 11:40:53.766] [FLIGHT GLOBALS]: Switching To Vessel SSTO-MK3-Science-local ---------------------- [LOG 11:40:53.766] Flight globals not ready - Setting active vessel at frame 8560 [LOG 11:40:53.783] Targetron Error: Failed to draw vessel listing at TweakScale.TweakScale.OnSave (ConfigNode node) [0x00007] in <cf1abb1b50de40fe83042990f01ebf6f>:0 at PartModule.Save (ConfigNode node) [0x00131] in <4b449f2841f84227adfaad3149c8fdba>:0 at ProtoPartModuleSnapshot..ctor (PartModule module) [0x000d2] in <4b449f2841f84227adfaad3149c8fdba>:0 at ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel, System.Boolean preCreate) [0x00420] in <4b449f2841f84227adfaad3149c8fdba>:0 at ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel) [0x00000] in <4b449f2841f84227adfaad3149c8fdba>:0 at ProtoVessel..ctor (Vessel VesselRef, System.Boolean preCreate) [0x001e3] in <4b449f2841f84227adfaad3149c8fdba>:0 at ProtoVessel..ctor (Vessel VesselRef) [0x00000] in <4b449f2841f84227adfaad3149c8fdba>:0 at Vessel.BackupVessel () [0x00022] in <4b449f2841f84227adfaad3149c8fdba>:0 at FlightState..ctor () [0x00264] in <4b449f2841f84227adfaad3149c8fdba>:0 at Game.Updated (GameScenes startSceneOverride) [0x0001a] in <4b449f2841f84227adfaad3149c8fdba>:0 at GamePersistence.SaveGame (System.String saveFileName, System.String saveFolder, SaveMode saveMode, GameScenes startScene) [0x00045] in <4b449f2841f84227adfaad3149c8fdba>:0 at FlightGlobals.setActiveVessel (Vessel v, System.Boolean force, System.Boolean clearDeadVessels) [0x00244] in <4b449f2841f84227adfaad3149c8fdba>:0 at FlightGlobals.SetActiveVessel (Vessel v) [0x0002a] in <4b449f2841f84227adfaad3149c8fdba>:0 at Targetron.Targetron.DrawTargeter (System.Int32 windowID) [0x00992] in <9a958599057743649ef7094cabf37bdd>:0 [EXC 11:45:41.649] NullReferenceException: Object reference not set to an instance of an object TweakScale.TweakScale.OnSave (ConfigNode node) (at <cf1abb1b50de40fe83042990f01ebf6f>:0) PartModule.Save (ConfigNode node) (at <4b449f2841f84227adfaad3149c8fdba>:0) ProtoPartModuleSnapshot..ctor (PartModule module) (at <4b449f2841f84227adfaad3149c8fdba>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel, System.Boolean preCreate) (at <4b449f2841f84227adfaad3149c8fdba>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel) (at <4b449f2841f84227adfaad3149c8fdba>:0) ProtoVessel..ctor (Vessel VesselRef, System.Boolean preCreate) (at <4b449f2841f84227adfaad3149c8fdba>:0) ProtoVessel..ctor (Vessel VesselRef) (at <4b449f2841f84227adfaad3149c8fdba>:0) Vessel.BackupVessel () (at <4b449f2841f84227adfaad3149c8fdba>:0) FlightState..ctor () (at <4b449f2841f84227adfaad3149c8fdba>:0) Game.Updated (GameScenes startSceneOverride) (at <4b449f2841f84227adfaad3149c8fdba>:0) (wrapper dynamic-method) Game.Game.Updated_Patch2(Game) PauseMenu.<draw>b__25_12 () (at <4b449f2841f84227adfaad3149c8fdba>:0) DialogGUIButton.OptionSelected () (at <4b449f2841f84227adfaad3149c8fdba>:0) DialogGUIButton.<Create>b__23_1 () (at <4b449f2841f84227adfaad3149c8fdba>:0) UnityEngine.Events.InvokableCall.Invoke () (at <12e76cd50cc64cf19e759e981cb725af>:0) UnityEngine.Events.UnityEvent.Invoke () (at <12e76cd50cc64cf19e759e981cb725af>:0) UnityEngine.UI.Button.Press () (at <0c883c16262a4198973f823d01e07427>:0) UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at <0c883c16262a4198973f823d01e07427>:0) UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <0c883c16262a4198973f823d01e07427>:0) UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.Event logs => https://1drv.ms/u/s!Am0PDmGqv17_irltS_B-HnNk7i8Y9w?e=xNbYXL switching back to version 21 seems to work again Quote Link to comment Share on other sites More sharing options...
Professor K Posted February 5, 2023 Share Posted February 5, 2023 (edited) 5 hours ago, GoAHead said: since latest release i can't switch vessels and also the exit menue doesn't work anymore. logs => https://1drv.ms/u/s!Am0PDmGqv17_irltS_B-HnNk7i8Y9w?e=xNbYXL switching back to version 21 seems to work again I'm seeing the same thing here. Same NullReferenceException errors and all. What brought it to my notice first was that F5 Quicksave stopped working, then I realized I couldn't switch back to the space center or even exit to main menu. Rolling Tweakscale back to v21 resolved the issue for me as well. -K Edited February 5, 2023 by Professor K typos Quote Link to comment Share on other sites More sharing options...
Lisias Posted February 5, 2023 Author Share Posted February 5, 2023 (edited) 7 hours ago, GoAHead said: since latest release i can't switch vessels and also the exit menue doesn't work anymore. [LOG 11:40:53.766] [FLIGHT GLOBALS]: Switching To Vessel SSTO-MK3-Science-local ---------------------- [LOG 11:40:53.766] Flight globals not ready - Setting active vessel at frame 8560 [LOG 11:40:53.783] Targetron Error: Failed to draw vessel listing at TweakScale.TweakScale.OnSave (ConfigNode node) [0x00007] in <cf1abb1b50de40fe83042990f01ebf6f>:0 at PartModule.Save (ConfigNode node) [0x00131] in <4b449f2841f84227adfaad3149c8fdba>:0 at ProtoPartModuleSnapshot..ctor (PartModule module) [0x000d2] in <4b449f2841f84227adfaad3149c8fdba>:0 at ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel, System.Boolean preCreate) [0x00420] in <4b449f2841f84227adfaad3149c8fdba>:0 at ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel) [0x00000] in <4b449f2841f84227adfaad3149c8fdba>:0 at ProtoVessel..ctor (Vessel VesselRef, System.Boolean preCreate) [0x001e3] in <4b449f2841f84227adfaad3149c8fdba>:0 at ProtoVessel..ctor (Vessel VesselRef) [0x00000] in <4b449f2841f84227adfaad3149c8fdba>:0 at Vessel.BackupVessel () [0x00022] in <4b449f2841f84227adfaad3149c8fdba>:0 at FlightState..ctor () [0x00264] in <4b449f2841f84227adfaad3149c8fdba>:0 at Game.Updated (GameScenes startSceneOverride) [0x0001a] in <4b449f2841f84227adfaad3149c8fdba>:0 at GamePersistence.SaveGame (System.String saveFileName, System.String saveFolder, SaveMode saveMode, GameScenes startScene) [0x00045] in <4b449f2841f84227adfaad3149c8fdba>:0 at FlightGlobals.setActiveVessel (Vessel v, System.Boolean force, System.Boolean clearDeadVessels) [0x00244] in <4b449f2841f84227adfaad3149c8fdba>:0 at FlightGlobals.SetActiveVessel (Vessel v) [0x0002a] in <4b449f2841f84227adfaad3149c8fdba>:0 at Targetron.Targetron.DrawTargeter (System.Int32 windowID) [0x00992] in <9a958599057743649ef7094cabf37bdd>:0 [EXC 11:45:41.649] NullReferenceException: Object reference not set to an instance of an object TweakScale.TweakScale.OnSave (ConfigNode node) (at <cf1abb1b50de40fe83042990f01ebf6f>:0) PartModule.Save (ConfigNode node) (at <4b449f2841f84227adfaad3149c8fdba>:0) ProtoPartModuleSnapshot..ctor (PartModule module) (at <4b449f2841f84227adfaad3149c8fdba>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel, System.Boolean preCreate) (at <4b449f2841f84227adfaad3149c8fdba>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel) (at <4b449f2841f84227adfaad3149c8fdba>:0) ProtoVessel..ctor (Vessel VesselRef, System.Boolean preCreate) (at <4b449f2841f84227adfaad3149c8fdba>:0) ProtoVessel..ctor (Vessel VesselRef) (at <4b449f2841f84227adfaad3149c8fdba>:0) Vessel.BackupVessel () (at <4b449f2841f84227adfaad3149c8fdba>:0) FlightState..ctor () (at <4b449f2841f84227adfaad3149c8fdba>:0) Game.Updated (GameScenes startSceneOverride) (at <4b449f2841f84227adfaad3149c8fdba>:0) (wrapper dynamic-method) Game.Game.Updated_Patch2(Game) PauseMenu.<draw>b__25_12 () (at <4b449f2841f84227adfaad3149c8fdba>:0) DialogGUIButton.OptionSelected () (at <4b449f2841f84227adfaad3149c8fdba>:0) DialogGUIButton.<Create>b__23_1 () (at <4b449f2841f84227adfaad3149c8fdba>:0) UnityEngine.Events.InvokableCall.Invoke () (at <12e76cd50cc64cf19e759e981cb725af>:0) UnityEngine.Events.UnityEvent.Invoke () (at <12e76cd50cc64cf19e759e981cb725af>:0) UnityEngine.UI.Button.Press () (at <0c883c16262a4198973f823d01e07427>:0) UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at <0c883c16262a4198973f823d01e07427>:0) UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <0c883c16262a4198973f823d01e07427>:0) UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.Event logs => https://1drv.ms/u/s!Am0PDmGqv17_irltS_B-HnNk7i8Y9w?e=xNbYXL switching back to version 21 seems to work again Embarrassing. I had tested this use case (quitting the game and loading it again while in Flight Scene), but didn't bored to try a quicksave. Since reverting to .21 solves the problem, it would be relatively easy to see where the problem is. Except that the damned thing is working fine on my rig. I quicksaved, I quickloaded, I launched a lot of crafts with the ScaleTypes screwed to TweakScale have to rework them. Can you send me your Player.log? Anyway, working on it. 2 hours ago, Professor K said: I'm seeing the same thing here. Same NullReferenceException errors and all. What brought it to my notice first was that F5 Quicksave stopped working, then I realized I couldn't switch back to the space center or even exit to main menu. Rolling Tweakscale back to v21 resolved the issue for me as well. Can you send me your KSP.log too? Interesting enough, I found something on my Player.log: probeCoreSphere.v2 Exploded!! - blast awesomeness: 0 (Filename: ./Runtime/Export/Debug/Debug.bindings.h Line: 35) 0 libmonobdwgc-2.0.dylib 0x0000000109ad2731 mono_handle_native_crash + 242 1 libmonobdwgc-2.0.dylib 0x0000000109a32b59 mono_sigsegv_signal_handler + 220 2 libsystem_platform.dylib 0x00007fff795e0b5d _sigtramp + 29 3 ??? 0x0000000000000000 0x0 + 0 4 UnityPlayer.dylib 0x0000000102af5098 _ZN4FMOD12DSPWaveTable4readEPPfPiPj16FMOD_SPEAKERMODEij + 1496 5 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 6 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 7 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 8 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 9 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 10 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 11 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 12 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 13 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 14 UnityPlayer.dylib 0x0000000102af4617 _ZN4FMOD12DSPSoundCard4readEPvPj16FMOD_SPEAKERMODEij + 135 15 UnityPlayer.dylib 0x0000000102b046d0 _ZN4FMOD6Output3mixEPvj + 640 16 UnityPlayer.dylib 0x0000000102b45882 _ZN4FMOD15OutputCoreAudio10renderProcEPvPjPK14AudioTimeStampjjP15Audi oBufferList + 50 17 CoreAudio 0x000000010bdf087f _ZN15AUConverterBase9RenderBusERjRK14AudioTimeStampjj + 729 18 CoreAudio 0x000000010bf0c2d7 _ZN6AUBase11DoRenderBusERjRK14AudioTimeStampjP15AUOutputElementjR15Au What's weird is that probeCoreSphere.v2 is not even Scaled on this test... 8 hours ago, BlackDinoShadows said: I've a question , is there a sort of bypass for rescaling everythings because my rescale don't work for BDB or more old mods like Integrated Phoenix Industries (Space Tug) so is there a bypass or it's just a problem with my tweakscale ? YES, it's "All Tweak". It works fine for parts using only Stock PartModules. Parts with Fuel Switches may or may not work - it's a trial and error process. Parts with custom modules WILL NOT WORK. Some characteristis will scale fine, some others will not. Again. trial and error process. There's a gotcha: this KrapFest you are seeing above is exactly due a code that handles when you migrate ScaleTypes, what happens when you replace the patchings for something else. That's exactly what happens when you install All Tweak, and then someone write proper patches for something. — — POST EDIT — — A full Test Session involving 2.4.6.22 and the Test Crafts (with the screwed ScaleTypes, and also with crafts without scaling) were done with KSP 1.4.3 , one of my references test rigs as it's is the less buggy environment I have around (second only to 1.3.1). NO BUGS FOUND. This means that I'm fighting KSP again. Now I'm working on detecting in which KSP this started to happen. Edited February 5, 2023 by Lisias POST EDIT Quote Link to comment Share on other sites More sharing options...
GoAHead Posted February 5, 2023 Share Posted February 5, 2023 @Lisias updated KSP.log and added Player.log to the already shared directory Quote Link to comment Share on other sites More sharing options...
Professor K Posted February 5, 2023 Share Posted February 5, 2023 1 hour ago, Lisias said: Can you send me your KSP.log too? Interesting enough, I found something on my Player.log: probeCoreSphere.v2 Exploded!! - blast awesomeness: 0 (Filename: ./Runtime/Export/Debug/Debug.bindings.h Line: 35) 0 libmonobdwgc-2.0.dylib 0x0000000109ad2731 mono_handle_native_crash + 242 1 libmonobdwgc-2.0.dylib 0x0000000109a32b59 mono_sigsegv_signal_handler + 220 2 libsystem_platform.dylib 0x00007fff795e0b5d _sigtramp + 29 3 ??? 0x0000000000000000 0x0 + 0 4 UnityPlayer.dylib 0x0000000102af5098 _ZN4FMOD12DSPWaveTable4readEPPfPiPj16FMOD_SPEAKERMODEij + 1496 5 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 6 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 7 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 8 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 9 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 10 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 11 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 12 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 13 UnityPlayer.dylib 0x0000000102adc4d4 _ZN4FMOD9DSPFilter4readEPPfPiPj16FMOD_SPEAKERMODEij + 324 14 UnityPlayer.dylib 0x0000000102af4617 _ZN4FMOD12DSPSoundCard4readEPvPj16FMOD_SPEAKERMODEij + 135 15 UnityPlayer.dylib 0x0000000102b046d0 _ZN4FMOD6Output3mixEPvj + 640 16 UnityPlayer.dylib 0x0000000102b45882 _ZN4FMOD15OutputCoreAudio10renderProcEPvPjPK14AudioTimeStampjjP15Audi oBufferList + 50 17 CoreAudio 0x000000010bdf087f _ZN15AUConverterBase9RenderBusERjRK14AudioTimeStampjj + 729 18 CoreAudio 0x000000010bf0c2d7 _ZN6AUBase11DoRenderBusERjRK14AudioTimeStampjP15AUOutputElementjR15Au What's weird is that probeCoreSphere.v2 is not even Scaled on this test... I'm sorry, but I was rather frustrated at the time (having just lost 2 hours work of getting through a tricky rescue mission) and I didn't save a copy of the log file. The errors were virtually identical to the ones @GoAHead posted though. I'm running KSP 1.12.5 with both DLCs installed, all through Steam, under Windows 10-64bit. The ship I was on had no parts altered with Tweaksacale at all. -K Quote Link to comment Share on other sites More sharing options...
Lisias Posted February 5, 2023 Author Share Posted February 5, 2023 (edited) 1 hour ago, GoAHead said: @Lisias updated KSP.log and added Player.log to the already shared directory Thank you very much! 49 minutes ago, Professor K said: I'm sorry, but I was rather frustrated at the time (having just lost 2 hours work of getting through a tricky rescue mission) and I didn't save a copy of the log file. The errors were virtually identical to the ones @GoAHead posted though. I'm running KSP 1.12.5 with both DLCs installed, all through Steam, under Windows 10-64bit. The ship I was on had no parts altered with Tweaksacale at all. Not a problem and perfectly understandable. And, yeah, I had already detected that having parts scaled was not a problem. As having them with the ScaleType screwed neither. In fact, I had just run a smoketest on KSP 1.4.3, 1.7.3, 1.11.2 and 1.12.5 on my development rigs without a single issue. The only weird thing I got was the CTD I posted before on my 1.12.5.ACP (a special rig that is never used by testings or development, only for final checks before launching new releases of my things). Since the need for more information - things are, sincerely, pretty weird right now. For people interested on the gory details: https://github.com/net-lisias-ksp/TweakScale/issues/289 — — — POST EDIT — — — @GoAHead, I think I found. It's something on KSPIE (on the FNPlugin to be exact). I don't know yet what's happening, but I'm digging on it. @Professor K, do you use KSPIE too? Edited February 5, 2023 by Lisias POST EDIT Quote Link to comment Share on other sites More sharing options...
GoAHead Posted February 5, 2023 Share Posted February 5, 2023 @Lisiasif you want any help please let me know. i can offer you some testing too (real life job) Quote Link to comment Share on other sites More sharing options...
Professor K Posted February 5, 2023 Share Posted February 5, 2023 (edited) 54 minutes ago, Lisias said: @GoAHead, I think I found. It's something on KSPIE (on the FNPlugin to be exact). I don't know yet what's happening, but I'm digging on it. @Professor K, do you use KSPIE too? I do not, no. -K If It helps, here's all the mods I'm running. <DIR> 000_ClickThroughBlocker <DIR> 000_Harmony <DIR> 000_KSPAPIExtensions <DIR> 001_ToolbarControl <DIR> 999_KSP-Recall <DIR> AutoAGL <DIR> AxialAerospace SimpleCargoSolutions <DIR> B9PartSwitch <DIR> BetterCrewAssignment <DIR> BetterScienceLabsContinued <DIR> BoulderCo <DIR> Chatterer <DIR> ChopShop <DIR> ChromaWorks <DIR> CommunityCategoryKit <DIR> CommunityResourcePack <DIR> DaMichel AeroRadial SphericalTanks <DIR> DefaultActionGroups <DIR> DistantObject <DIR> EasyVesselSwitch <DIR> EnvironmentalVisualEnhancements <DIR> FP_DPSoundFX <DIR> GoodspeedAerospace <DIR> GPOSpeedPump <DIR> HotBeverage FuelCells SensorModules <DIR> IndicatorLights <DIR> IndicatorLightsCommunityExtensions <DIR> Kaboom <DIR> KAS <DIR> KerbalEngineer <DIR> KerbalHacks Droptanks <DIR> Kerbaltek Hyperedit <DIR> KipEng KipDockingPorts <DIR> KIS <DIR> KSPCommunityFixes <DIR> masTerTorch KerbalDustExperiment <DIR> MechJeb2 <DIR> MiniSampleReturnCapsule <DIR> MK1CabinHatch <DIR> ModuleManagerWatchDog <DIR> NearFutureConstruction <DIR> NearFutureExploration <DIR> NearFutureProps <DIR> PapaKerballinisPizza <DIR> PlanetaryBaseInc <DIR> ReStock <DIR> SciencePancake <DIR> SolarScience <DIR> StationKeeping <DIR> StationPartsExpansionRedux <DIR> StationPartsExpansionReduxIVAs <DIR> SurfaceLights <DIR> TrackingStationEvolved <DIR> TweakScale 000_KSPe.dll 666_ModuleManagerWatchDog.dll 999_Scale_Redist.dll Delta-V Map.ksp KSPCF_UserSettings.cfg KSPModFileLocalizer.dll ModuleManager.4.2.2.dll ModuleManager.ConfigCache ModuleManager.ConfigSHA ModuleManager.Physics ModuleManager.TechTree PlanetWiki_v4.1.ksp remove_fun_part_patch.cfg Edited February 5, 2023 by Professor K added mod list Quote Link to comment Share on other sites More sharing options...
AlonzoTG Posted February 6, 2023 Share Posted February 6, 2023 (edited) TWEAKSCALE 2.4.6.22 IS BROKEN, DO NOT USE!!!!! It throws fatal errors and mentions a problem (duplicate config parameters) which do not exist in the files, each config line is unique in the actual files. I tried to play the game and the game refuses to save past a certain point in my flight and barfs tweakscale NREs to the log... [snip] It used to be a very reliable mod... =( [LOG 23:13:11.446] ScaleModList: listSize 697 maxListSize 589 [EXC 23:13:17.218] NullReferenceException: Object reference not set to an instance of an object TweakScale.TweakScale.OnSave (ConfigNode node) (at <cf1abb1b50de40fe83042990f01ebf6f>:0) PartModule.Save (ConfigNode node) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoPartModuleSnapshot..ctor (PartModule module) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel, System.Boolean preCreate) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoVessel..ctor (Vessel VesselRef, System.Boolean preCreate) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoVessel..ctor (Vessel VesselRef) (at <be370b73275e49439ea5e41ceef6700f>:0) Vessel.BackupVessel () (at <be370b73275e49439ea5e41ceef6700f>:0) FlightState..ctor () (at <be370b73275e49439ea5e41ceef6700f>:0) Game.Updated (GameScenes startSceneOverride) (at <be370b73275e49439ea5e41ceef6700f>:0) Game.Updated () (at <be370b73275e49439ea5e41ceef6700f>:0) QuickSaveLoad.doSave (System.String filename, System.String screenMsg) (at <be370b73275e49439ea5e41ceef6700f>:0) QuickSaveLoad.quickSave (System.Boolean saveAs) (at <be370b73275e49439ea5e41ceef6700f>:0) QuickSaveLoad.Update () (at <be370b73275e49439ea5e41ceef6700f>:0) UnityEngine.DebugLogHandler:LogException(Exception, Object) ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object) UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object) [EXC 23:13:23.259] NullReferenceException: Object reference not set to an instance of an object TweakScale.TweakScale.OnSave (ConfigNode node) (at <cf1abb1b50de40fe83042990f01ebf6f>:0) PartModule.Save (ConfigNode node) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoPartModuleSnapshot..ctor (PartModule module) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel, System.Boolean preCreate) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoVessel..ctor (Vessel VesselRef, System.Boolean preCreate) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoVessel..ctor (Vessel VesselRef) (at <be370b73275e49439ea5e41ceef6700f>:0) Vessel.BackupVessel () (at <be370b73275e49439ea5e41ceef6700f>:0) FlightState..ctor () (at <be370b73275e49439ea5e41ceef6700f>:0) Game.Updated (GameScenes startSceneOverride) (at <be370b73275e49439ea5e41ceef6700f>:0) Game.Updated () (at <be370b73275e49439ea5e41ceef6700f>:0) QuickSaveLoad.doSave (System.String filename, System.String screenMsg) (at <be370b73275e49439ea5e41ceef6700f>:0) QuickSaveLoad.quickSave (System.Boolean saveAs) (at <be370b73275e49439ea5e41ceef6700f>:0) QuickSaveLoad.Update () (at <be370b73275e49439ea5e41ceef6700f>:0) UnityEngine.DebugLogHandler:LogException(Exception, Object) ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object) UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object) [EXC 23:13:23.558] NullReferenceException: Object reference not set to an instance of an object TweakScale.TweakScale.OnSave (ConfigNode node) (at <cf1abb1b50de40fe83042990f01ebf6f>:0) PartModule.Save (ConfigNode node) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoPartModuleSnapshot..ctor (PartModule module) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel, System.Boolean preCreate) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel) (at <be370b73275e49439ea5e41ceef6700f>:0) ProtoVessel..ctor (Vessel VesselRef, System.Boolea Edited February 6, 2023 by Gargamel Content redacted Quote Link to comment Share on other sites More sharing options...
Lisias Posted February 6, 2023 Author Share Posted February 6, 2023 1 hour ago, AlonzoTG said: It throws fatal errors and mentions a problem (duplicate config parameters) which do not exist in the files, each config line is unique in the actual files. I tried to play the game and the game refuses to save past a certain point in my flight and barfs tweakscale NREs to the log... Dear sir, screaming about is not going to help. Without your KSP.log, I can't do anything. Please publish your KSP.log on dropbox or something. Quote Link to comment Share on other sites More sharing options...
luna_cat Posted February 6, 2023 Share Posted February 6, 2023 I love Tweak Scale. I think that it's an essential part of the game. Unfortunately version 2.4.6.22 will not allow me to save my game. There's lots of exceptions like this: [EXC 09:11:24.417] NullReferenceException: Object reference not set to an instance of an object TweakScale.TweakScale.OnSave (ConfigNode node) (at <cf1abb1b50de40fe83042990f01ebf6f>:0) PartModule.Save (ConfigNode node) (at <a5c262f7fe724eb9918d4487db8b635e>:0) ProtoPartModuleSnapshot..ctor (PartModule module) (at <a5c262f7fe724eb9918d4487db8b635e>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel, System.Boolean preCreate) (at <a5c262f7fe724eb9918d4487db8b635e>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel) (at <a5c262f7fe724eb9918d4487db8b635e>:0) ProtoVessel..ctor (Vessel VesselRef, System.Boolean preCreate) (at <a5c262f7fe724eb9918d4487db8b635e>:0) ProtoVessel..ctor (Vessel VesselRef) (at <a5c262f7fe724eb9918d4487db8b635e>:0) Vessel.BackupVessel () (at <a5c262f7fe724eb9918d4487db8b635e>:0) FlightState..ctor () (at <a5c262f7fe724eb9918d4487db8b635e>:0) Game.Updated (GameScenes startSceneOverride) (at <a5c262f7fe724eb9918d4487db8b635e>:0) GamePersistence.SaveGame (System.String saveFileName, System.String saveFolder, SaveMode saveMode, GameScenes startScene) (at <a5c262f7fe724eb9918d4487db8b635e>:0) Quote Link to comment Share on other sites More sharing options...
Lisias Posted February 6, 2023 Author Share Posted February 6, 2023 (edited) 2 hours ago, luna_cat said: I love Tweak Scale. I think that it's an essential part of the game. Unfortunately version 2.4.6.22 will not allow me to save my game. There's lots of exceptions like this: [EXC 09:11:24.417] NullReferenceException: Object reference not set to an instance of an object TweakScale.TweakScale.OnSave (ConfigNode node) (at <cf1abb1b50de40fe83042990f01ebf6f>:0) PartModule.Save (ConfigNode node) (at <a5c262f7fe724eb9918d4487db8b635e>:0) ProtoPartModuleSnapshot..ctor (PartModule module) (at <a5c262f7fe724eb9918d4487db8b635e>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel, System.Boolean preCreate) (at <a5c262f7fe724eb9918d4487db8b635e>:0) ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel) (at <a5c262f7fe724eb9918d4487db8b635e>:0) ProtoVessel..ctor (Vessel VesselRef, System.Boolean preCreate) (at <a5c262f7fe724eb9918d4487db8b635e>:0) ProtoVessel..ctor (Vessel VesselRef) (at <a5c262f7fe724eb9918d4487db8b635e>:0) Vessel.BackupVessel () (at <a5c262f7fe724eb9918d4487db8b635e>:0) FlightState..ctor () (at <a5c262f7fe724eb9918d4487db8b635e>:0) Game.Updated (GameScenes startSceneOverride) (at <a5c262f7fe724eb9918d4487db8b635e>:0) GamePersistence.SaveGame (System.String saveFileName, System.String saveFolder, SaveMode saveMode, GameScenes startScene) (at <a5c262f7fe724eb9918d4487db8b635e>:0) Yes, I'm getting some of these reports lately. Unfortunately, these are not happening on my rig. I had already diagnosed at least one case, but I need confirmation before going public with my findings. Can you please send me your full KSP.log after reproducing the issue? You will find this file in the same place where the KSP's executable is. Edited February 6, 2023 by Lisias Kinda of tyop... Quote Link to comment Share on other sites More sharing options...
Lisias Posted February 6, 2023 Author Share Posted February 6, 2023 (edited) NOTAM A bug on a workaround code for an old problem was found on TS 2.4.6.22 . TL;DR: in the past, bad patches were plaguing the TweakScale ecosystem, and one of that bad patching is injecting TweakScale twice in a part. I don't need to explain what would happen with two TS modules trying to scale the same part at the same time. We can easily reproduce this using the following patch somewhere in your GameData @PART[strutCube]:FINAL { MODULE { name = TweakScale type = screwed defaultScale = 3125 } } From this point, all strutCube parts will have two TweakScale sections in your craft and sfs files: Spoiler ship = Untitled Space Craft version = 1.4.3 description = type = VAB size = 0.905763268,1.24505234,0.905763268 persistentId = 3392072693 rot = 0,0,0,0 missionFlag = Squad/Flags/default vesselType = Debris PART { part = probeCoreSphere_4294689086 partName = Part persistentId = 2354039458 pos = 0,15,0 attPos = 0,0,0 attPos0 = 0,15,0 rot = 0,0,0,1 attRot = 0,0,0,1 attRot0 = 0,0,0,1 mir = 1,1,1 symMethod = Radial autostrutMode = Off rigidAttachment = False istg = -1 resPri = 0 dstg = 0 sidx = -1 sqor = -1 sepI = -1 attm = 0 modCost = 0 modMass = 0 modSize = 0,0,0 link = strutCube_4294678208 attN = bottom,strutCube_4294678208_0|-0.3383468|0 EVENTS { } ACTIONS { } PARTDATA { } MODULE { name = ModuleCommand isEnabled = True hibernation = False hibernateOnWarp = False stagingEnabled = True EVENTS { } ACTIONS { MakeReferenceToggle { actionGroup = None wasActiveBeforePartWasAdjusted = False } HibernateToggle { actionGroup = None wasActiveBeforePartWasAdjusted = False } } UPGRADESAPPLIED { } } MODULE { name = ModuleKerbNetAccess isEnabled = True stagingEnabled = True EVENTS { } ACTIONS { OpenKerbNetAction { actionGroup = None wasActiveBeforePartWasAdjusted = False } } UPGRADESAPPLIED { } } MODULE { name = ModuleDataTransmitter isEnabled = True xmitIncomplete = False stagingEnabled = True EVENTS { } ACTIONS { StartTransmissionAction { actionGroup = None active = False wasActiveBeforePartWasAdjusted = False } } UPGRADESAPPLIED { } } MODULE { name = TweakScale isEnabled = True type = stack active = True available = True currentScale = 0.625 defaultScale = 0.625 defaultTransformScale = (0, 0, 0) DryCost = 300 OriginalCrewCapacity = 0 stagingEnabled = True EVENTS { } ACTIONS { } UPGRADESAPPLIED { } } MODULE { name = AttachedOnEditor isEnabled = True active = True originalPos = (0, 15, 0) originalRotation = (0, 0, 0, 1) moduleVersion = 6 stagingEnabled = True originalAttachNodePos = (0.0, -0.3, 0.0) originalAttachNodeSize = 0 originalAttachNodeOrientation = (0.0, -1.0, 0.0) originalAttachNodeOffset = (0.0, 0.0, 0.0) EVENTS { } ACTIONS { } UPGRADESAPPLIED { } } MODULE { name = ModuleTripLogger isEnabled = True stagingEnabled = True EVENTS { } ACTIONS { } Log { flight = 0 } UPGRADESAPPLIED { } } RESOURCE { name = ElectricCharge amount = 10 maxAmount = 10 flowState = True isTweakable = True hideFlow = False isVisible = True flowMode = Both } } PART { part = strutCube_4294678208 partName = Part persistentId = 1812148777 pos = 0,14.5329189,0 attPos = 0,0,0 attPos0 = 0,-0.46708107,0 rot = 0,0,0,1 attRot = 0,0,0,1 attRot0 = 0,0,0,1 mir = 1,1,1 symMethod = Radial autostrutMode = Off rigidAttachment = False istg = -1 resPri = 0 dstg = 0 sidx = -1 sqor = -1 sepI = -1 attm = 0 modCost = 0 modMass = 0 modSize = 0,0,0 attN = top,probeCoreSphere_4294689086_0|0.1287344|0 EVENTS { } ACTIONS { } PARTDATA { } MODULE { name = TweakScale isEnabled = True type = stack active = True available = True currentScale = 0.3125 defaultScale = 0.3125 defaultTransformScale = (0, 0, 0) DryCost = 16 OriginalCrewCapacity = 0 stagingEnabled = True EVENTS { } ACTIONS { } UPGRADESAPPLIED { } } MODULE { name = AttachedOnEditor isEnabled = True active = True originalPos = (0, 14.5329189, 0) originalRotation = (0, 0, 0, 1) moduleVersion = 6 stagingEnabled = True originalAttachNodePos = (0.0, 0.1, 0.0) originalAttachNodeSize = 0 originalAttachNodeOrientation = (0.0, 1.0, 0.0) originalAttachNodeOffset = (0.0, 0.0, 0.0) originalAttachNodePos = (0.0, -0.1, 0.0) originalAttachNodeSize = 0 originalAttachNodeOrientation = (0.0, -1.0, 0.0) originalAttachNodeOffset = (0.0, 0.0, 0.0) EVENTS { } ACTIONS { } UPGRADESAPPLIED { } } MODULE { name = TweakScaleRogueDuplicate // Programatically tainted due duplicity. Only one single instance above should exist, usually the first one. isEnabled = True type = stack active = False available = False currentScale = 3125 defaultScale = 3125 defaultTransformScale = (0, 0, 0) DryCost = 0 OriginalCrewCapacity = 0 stagingEnabled = True EVENTS { } ACTIONS { } UPGRADESAPPLIED { } } } Note the second TweakScale section correctly handled. Everything was fine for some years, until I had changed something on 2.4.6.22 to solve another issue, and created this one by accident. A fix is currently work in progress: https://github.com/net-lisias-ksp/TweakScale/issues/290 The workaround for this problem is to revert back to 2.4.6.21 until the next release is published - or to fix your patching. I may had created a bug on the workaround code for this problem, but the trigger for it is still a bad patch. I would recommend to @AlonzoTGto double check his installation, as I had said initially - or perhaps just stop modding your KSP, if you don't know how to do it properly. @Luna Cat, @Professor K, please send me your Logs/ModuleManager/* contents and your GameData/ModuleManager.ConfigCache for inspection. You guys do have rogue patchings in your rig, and these are a known source of problems. This doesn't excuse TweakScale from this problem, but ideally you should get rid of those too! I will gladly help on the task. Last, but not least, I want to give a huge thank you to @GoAHead for their invaluable help on diagnosing this one. I had completely forgot about this TweakScaleRogueDuplicate stunt, I would never be able to diagnose this one without such marvellous help. TweakScale 2.4.6.23 is on the works, and it will be issued as soon as possible™. Edited February 6, 2023 by Lisias Entertaining grammars made slightly less entertaining... Quote Link to comment Share on other sites More sharing options...
Lisias Posted February 7, 2023 Author Share Posted February 7, 2023 (edited) ANNOUNCE Release 2.4.6.23 is available for downloading, with the following changes: The fix for the ScaleType Migration Code on 2.4.6.22 ended up creating a new bug on the TweakScaleRogueDuplicate security feature, leading KSP rigs infected with this problem to crash when trying to save the game. My bad. Really sorry. HUGE KUDOS to GoAHead on Forum for their invaluable efforts on helping me on diagnosing this problem. I would not had done this one by myself. Closes Issues: #290 Regression on handling the TweakScaleRogueDuplicate patching problem. #289 Yet another unexpected Misbehaviour, this time on PartModule.OnSave. See last NOTAM for details. On a side (and sad) note… I still don't know why the code on 2.4.6.22 had to be written (salvo for this unhappy line of code that I let pass unchecked). Sooner or Later™ I will need to revisit this issue. Disclaimer By last, but not the least... Spoiler No Module Manager was harmed during the development of TweakScale. This Release will be published using the following Schedule: GitHub, reaching first manual installers and users of KSP-AVC. Right now. CurseForge. Right now. SpaceDock (and CKAN users). Right now. The reasoning is to gradually distribute a potentially Support Fest release in a way that would me allow to provide proper support if anything else goes wrong - as it did with .22... Edited March 3, 2023 by Lisias All your Distribution Channels belongs to us! Quote Link to comment Share on other sites More sharing options...
ElonsMusk Posted February 7, 2023 Share Posted February 7, 2023 On 2/5/2023 at 11:24 PM, AlonzoTG said: TWEAKSCALE 2.4.6.22 IS BROKEN, DO NOT USE!!!!! Lisias is one of the most dedicated mod developers I've come across, not just in Kerbal. There's so much documentation of every change and every patch (for which there are so many your head would spin) and they have been successful in rooting out and smushing major bugs in Tweakscale for years now. All the while keeping it largely compatible with the majority of part mods out there. Show them some respect and help them solve the issue you're having by remaining civil. It's fair to caution other users on a build drop, but there are many channels to address bugs. Declaring a build unusable is a fair warning, but you'd better be sure you know for sure that TweakScale is the culprit, and it's not a mod creators fault for not backing up your favourite save files before changing things. Sorry if I sound harsh, I love our precious mod community too much to let people get away with disrespecting the process. Developing mods for the public is time consuming and patience-testing --they do this as a service to us we owe them better treatment of them and their work. Quote Link to comment Share on other sites More sharing options...
dan1ell1ma Posted February 7, 2023 Share Posted February 7, 2023 13 hours ago, Lisias said: ANNOUNCE Release 2.4.6.23 is available for downloading, with the following changes: The fix for the ScaleType Migration Code on 2.4.6.22 ended up creating a new bug on the TweakScaleRogueDuplicate security feature, leading KSP rigs infected with this problem to crash when trying to save the game. My bad. Really sorry. HUGE KUDOS to GoAHead on Forum for their invaluable efforts on helping me on the diagnosing this problem. I would not had done this one by myself. Closes Issues: #290 Regression on handling the TweakScaleRogueDuplicate patching problem. #289 Yet another unexpected Misbehaviour, this time on PartModule.OnSave. See last NOTAM for details. On a side (and sad) note… I still don't know why the code on 2.4.6.22 had to be written (salvo for this unhappy line of code that I let pass unchecked). Sooner or Later™ I will need to revisit this issue. Disclaimer By last, but not the least... Hide contents No Module Manager was harmed during the development of TweakScale. This Release will be published using the following Schedule: GitHub, reaching first manual installers and users of KSP-AVC. Right now. CurseForge. Soon™. SpaceDock (and CKAN users). A bit less Soon™. The reasoning is to gradually distribute a potentially Support Fest release in a way that would me allow to provide proper support if anything else goes wrong - as it did with .22... Thanks Lisias, you are awesome. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.