[1.12.X] ShineFix [WIP]

[DiegoR1025]

How much will this affect performance?
And what reflection settings would I need to make this look good?
Cool mod

[Saturn1234]

Restock Recolour support would be really nice.

[rockmeowstar]

ShineFix 1.1.0

A decent Shabby implementation.

 

Global refactor:

• Asset and config usage reduced from 156 to 35 files with the same effect;
• Only 1 mu mesh in the mod (it's a cylinder battery almost indistinguishable from the stock model);
• Fixed Stayputnik materials;
• Fixed some strange behaviour of a module with multiple color variants;
• Fixed crew position on EVA, returned the third option of EVA for Inline mk1 cabin;
• Removed some unnecessary changes from the alpha level, more stock feeling;
• Minor fix: inline mk2 docking port is shiny now!

https://github.com/rockmeowstar/KSP_ShineFix/releases/tag/1.1.0

On 11/17/2024 at 3:40 AM, DiegoR1025 said:

How much will this affect performance?
And what reflection settings would I need to make this look good?
Cool mod

Like any retexture, it's not adding anything heavy cause it's the same resolution. But the dependencies can slightly boost your performance (refactored shader code in there). 
I suggest you 512 or 1024 for the reflection settings, not 2048 (too heavy). The screenshots are made on 1024.

[BSS_Snag]

The day this gets restock support is a day we will rejoice further

[modus]

Hi @rockmeowstar I'm having trouble unzipping the latest version, both from spacedock and github.

Never had any problems with previous versions (or other mods, I just unzipped another mod to my gamedata), it's an 0x80004005 'unspecified error' error, on the FlagGeneralMaterial.cfg, but probalbly also on other files.
Anyone else reporthing this, or is it just me that can't access the files?

(loving the mod btw!)

[rockmeowstar]

1 hour ago, modus said:

Hi @rockmeowstar I'm having trouble unzipping the latest version, both from spacedock and github.

Never had any problems with previous versions (or other mods, I just unzipped another mod to my gamedata), it's an 0x80004005 'unspecified error' error, on the FlagGeneralMaterial.cfg, but probalbly also on other files.
Anyone else reporthing this, or is it just me that can't access the files?

(loving the mod btw!)

Good day! 

You can freely remove two cfg files called FlagGeneralMaterial and FlagReplacement located in 000_ShineFix folder. This is an experiment with the materials, and maybe it's too broad for some modded gamedata folders. The result will cause just the rollback to stock flag materials (nothing else). 

[modus]

1 hour ago, rockmeowstar said:

Good day! 

You can freely remove two cfg files called FlagGeneralMaterial and FlagReplacement located in 000_ShineFix folder. This is an experiment with the materials, and maybe it's too broad for some modded gamedata folders. The result will cause just the rollback to stock flag materials (nothing else). 

That didn't solve the issue unfortunately. Now it's CabinGlossMaterials.dds that's giving the error.

Now that I'm comparing the 2 folders (the one I already have and the one I downloaded), I do see some differences.

This is my gamedata
 

 

and this is what I downloaded

Is it supposed to be like this?

[rockmeowstar]

57 minutes ago, modus said:

Is it supposed to be like this?

Looks like you have to delete the previous ShineFix and install the new one, it's a conflict between two different versions. It was totally refactored and renamed so now you have two configs for one part

[modus]

I'll try that, but when I was still on my pc I couldn't unzip to desktop either.

Anyway, good to know I have to delete the old folder

[rockmeowstar]

https://github.com/rockmeowstar/KSP_ShineFix/releases/tag/v1.2.0

https://spacedock.info/mod/3764/ShineFix

Dependency and compatibility fixes:

• Removed mesh and texture conflicts;
• Added full ReStock compatibility by config.

If you installed the previous version, please don't forget to remove it to avoid config conflicts.

Edited November 24 by rockmeowstar

[rockmeowstar]

Just a material example in good quality

[ShadowMC2]

9 hours ago, modus said:

Hi @rockmeowstar I'm having trouble unzipping the latest version, both from spacedock and github.

Never had any problems with previous versions (or other mods, I just unzipped another mod to my gamedata), it's an 0x80004005 'unspecified error' error, on the FlagGeneralMaterial.cfg, but probalbly also on other files.
Anyone else reporthing this, or is it just me that can't access the files?

(loving the mod btw!)

see if you can extract via WinRAR / 7Zip, seems to have worked for me with the same issue

[Fizzlebop Smith]

I am attempting to use 7Zip to decompress the folder and getting an "unspecified error"  onto trying winrar

 

[RileyHef]

You are absolutely cooking with this mod! A few thoughts:

- Space Station Parts Redux is heavy on windows and would benefit GREATLY from your work.

- Speaking of part mods, ever think about providing a some sort of guide on the basics of your modding process? There are countless mods that could benefit from the window effects alone. Between the countless modded parts and the desperate need for a standardized style for reflections I could see the community helping quite a bit with expanding your work.

- Any thoughts on how this mod could work in partnership with TU/TURD/Recolors? To have these clean reflections along with existing texture customizations would really bring KSP parts to a new level. In my head the feasibility would be difficult but I'm curious to dive deeper to discover exactly what those barriers are.

 

Anyway, love your work - keep it up! 

[modus]

Same issue with latest version (1.2.0), will try with 7zip/winrar 

edit: seems like I could unzip with winrar to desktop. Will try replacing old folder, should be fine.

Edited November 24 by modus

[kurgut]

9 hours ago, rockmeowstar said:

Added full ReStock compatibility by config.

Huzzah ! Amazing

Thanks for your work on this  

[rockmeowstar]

1 hour ago, modus said:

Same issue with latest version (1.2.0), will try with 7zip/winrar 

edit: seems like I could unzip with winrar to desktop. Will try replacing old folder, should be fine.

I packed the zip archive via 7zip, maybe this info should help

Will pack the next ones by windows default zip

Edited November 24 by rockmeowstar

[rockmeowstar]

4 hours ago, RileyHef said:

You are absolutely cooking with this mod! A few thoughts:

- Space Station Parts Redux is heavy on windows and would benefit GREATLY from your work.

- Speaking of part mods, ever think about providing a some sort of guide on the basics of your modding process? There are countless mods that could benefit from the window effects alone. Between the countless modded parts and the desperate need for a standardized style for reflections I could see the community helping quite a bit with expanding your work.

- Any thoughts on how this mod could work in partnership with TU/TURD/Recolors? To have these clean reflections along with existing texture customizations would really bring KSP parts to a new level. In my head the feasibility would be difficult but I'm curious to dive deeper to discover exactly what those barriers are.

 

Anyway, love your work - keep it up! 

Yes, I definitely love making things shinier and it would be hard for me to resist such a challenge.

Thanks for the idea! I have already provided such instructions in one local modding community, and will be ready to provide it globally. I also think that this is a great idea, when everyone follows the same standards - and in fact, it is very easy to implement. I just need to correctly translate my thoughts.

Regarding the compatibility of the mod with any other mods that make changes to the parts, I can only say that the most important characteristics that I should recommend to absolutely everyone are the preservation of certain properties of the material in one paradigm.

 

Behold, the ultimate shininess guide: 

For specular-based materials: 

1. Specular color is ALWAYS #e7e7e7
2. Shininess is ALWAYS 0.593
3. Everything else is made via gloss alpha channel 

For shininess-based materials: 

1. Specular color is ALWAYS #e7e7e7
2. Everything else is made via shininess channel 

Shininess settings

Material	Alpha value (0-255)	Shininess value (0-1)
Wood, sand, and fabric	000 - 040	0.000 - 0.157
Matte metal and stone	041 - 107	0.158 - 0.420
Scratched/painted metal	108 - 143	0.421 - 0.560
Plastic	144 - 175	0.561 - 0.686
Metal and varnished wood	176 - 192	0.687 - 0.753
Foil and chrome	193 - 200	0.754 - 0.784
Polished metal	201 - 219	0.785 - 0.859
Glass	220 - 241	0.860 - 0.945
Mirror glass	242 - 255	0.946 - 1.000

 

For example, stock Gigantor solar panel have these settings: 

Specular: #e7e7e7
Shininess: 0.593

Matte metal between solar elements: 66
Plain metal on the backside: 176
Glass on the solar elements: 221

Shininess based Gigantor solar panel in ReStock have these settings: 

Specular: #e7e7e7
Shininess: 0.923

Shiny material alpha: 255

(just a white rectangle, nothing to paste there)

[rockmeowstar]

2 hours ago, modus said:

Same issue with latest version (1.2.0), will try with 7zip/winrar 

edit: seems like I could unzip with winrar to desktop. Will try replacing old folder, should be fine.

I promptly fixed it and ask you to double-check.
This was due to the fact that I packed the archive via 7zip, and this caused some complications on the computers of those who used the default archiver. 

Re-uploaded the updated version of the archive into the current release, now it should work.

[modus]

4 hours ago, rockmeowstar said:

I promptly fixed it and ask you to double-check.
This was due to the fact that I packed the archive via 7zip, and this caused some complications on the computers of those who used the default archiver. 

Re-uploaded the updated version of the archive into the current release, now it should work.

Double check: check!

Thx!

[Saturn1234]

Will this work with Shaddy?

[HebaruSan]

On 9/16/2024 at 6:54 PM, rockmeowstar said:

License: Non-Commercial Open Data License (NCODL)

Hi @rockmeowstar, would you mind sharing a link to the terms of this license? Some web searching for either the full name or the abbreviation turns up no likely hits, and the download doesn't contain any license-related information. This makes it hard to determine what users are allowed to do with this mod. Thanks!

[rockmeowstar]

14 minutes ago, HebaruSan said:

Hi @rockmeowstar, would you mind sharing a link to the terms of this license? Some web searching for either the full name or the abbreviation turns up no likely hits, and the download doesn't contain any license-related information. This makes it hard to determine what users are allowed to do with this mod. Thanks!

Oh, sorry!

Using for academic and personal purposes is allowed, that's the point. The license is on my GitHub and looks like I forgot to add the last license revision to the release:

https://github.com/rockmeowstar/KSP_ShineFix/blob/main/LICENSE

UPD: added LICENSE and README to release archives everywhere

Edited November 24 by rockmeowstar

[rockmeowstar]

16 minutes ago, Saturn1234 said:

Will this work with Shaddy?

Confused two mods in my original answer. But I guess that happens.
I guess I need to check and then I can give an answer.

[rockmeowstar]

And just to mention, got some questions like "does it break interiors?"

No, but actually it adds some shininess to the particular details like oxygen gas tanks, door handles, navballs, and controls.

The examples are in spoiler. So, it is doing not much because I didn't even start shininess refactor for interiors yet. But guys, I am very accurate in terms of using materials

Spoiler

 

 

 

Just wanted to say one thing: unfortunately interior does not reflect itself, it works like an outside mirror (you can see the runway through the wall in the reflection of the exit window, and this is what I've got now)

Edited November 24 by rockmeowstar