linuxgurugamer

It shouldn't matter with VSR whether it is applied before or after this mod. The parts in Fusebox are renamed, so VSR won't touch them. I'm working on it now, will also add "Depreciated" to the title.

It's CTT,, but your suggestion is also good. I'll get that done this evening.

I'll try CTT, but could you first verify that it's happening, then post the log file AND (if you have it) the installed ckan file to make it easier for me to make a test installation?

@AccidentalDisassembly dd @DStaal I just tested Fusebox with Filter Extensions and EEX, neither of them showed multiple identical batteries. Are you running with a different tech tree?

Thanks for the reports, I'll do some tests with/without both Filter Extensions and Janitor's Closet to see what's going on These parts need to be available for existing vessels, but not in the editor Stock system or expanded? Also, log file, when you can, please

they shouldnt be there. They are replacements for the ReserveBattery parts from AmpYear, in case someone want's to switch from using Ampyear to FuseBox. I'll have to fix this, thanks for asking and letting me know. I'm a bit puzzled, they shouldn't have the same name. for example, the battery pack is copied to a new part and should have the following: reserveBatteryPack @title = Z-100 Reserve Rechargeable Battery Pack

As long as nothing else is using them, yes. I'd suggest using The Janitor's Closet to do this. It tries to be careful about what it prunes (when you do the PermaPrune option)

new release, 0.1.7: Fixed nullrefs in editor Added empty module to avoid AmpYear error in log

Really? then what is this: DATA { type = List<Vessel> requiredValue = false stations = AllVessels().Where(v => v.VesselType() == Station) title = Find the stations } // Find a body that we have returned from that does not have a space station DATA { type = CelestialBody requiredValue = true uniquenessCheck = CONTRACT_ACTIVE targetBody1 = ReturnedFromBodies().Where(body => @/stations.Where(v => v.CelestialBody() == body).Count() == 0).SelectUnique() title = Must have returned from a Celestial Body, but not have any stations deployed. } This is in the 10-SpaceStations.cfg file, looks like stations IS defined, in the Data section. I'll freely admit it is generating an error, but I have no idea why.

Great! So, when will the next update be available?

Me too. But CC reported an error on it.

First what? 3 pages in?

And this isn't another: ReturnedFromBodies().Where(body => @/stations.Where(v => v.CelestialBody() == body).Count() == 0).SelectUnique() ????

Some more info, looks like one of the problems is a single equals singn instead of two in the following: IPContracts/Contracts/10-SpaceStations.cfg: targetVessel1 = AllVessels().Where(v => v.VesselType() == Station && v.IsOrbiting() = true && v.CelestialBody() == @targetBody).SelectUnique() IPContracts/Contracts/10-SpaceStations.cfg: targetVessel1 = AllVessels().Where(v => v.VesselType() == Station && v.IsOrbiting() = true && v.CelestialBody() == @targetBody).SelectUnique() IPContracts/Contracts/10-SpaceStations.cfg: targetVessel1 = AllVessels().Where(v => v.VesselType() == Station && v.IsOrbiting() = true && v.CelestialBody() == @targetBody).SelectUnique() IPContracts/Contracts/10-SpaceStations.cfg: targetVessel1 = AllVessels().Where(v => v.VesselType() == Station && v.IsOrbiting() = true && v.CelestialBody() == @targetBody).SelectUnique() see where it says " v.IsOrbiting() = true", I think it should be two equal signs there

@pap1723 the Nullrefs I was getting from CC this evening were from this contract pack: NullReferenceException: Object reference not set to an instance of an object at ContractConfigurator.ExpressionParser.CelestialBodyParser.CheckTree (KSPAchievements.CelestialBodySubtree tree, ProgressItem pi) [0x00000] in <filename unknown>:0 at ContractConfigurator.ExpressionParser.CelestialBodyParser+<>c__DisplayClass8_0.<BodiesForItem>b__0 (KSPAchievements.CelestialBodySubtree node) [0x00000] in <filename unknown>:0 at System.Linq.Enumerable+<CreateWhereIterator>c__Iterator1D`1[KSPAchievements.CelestialBodySubtree].MoveNext () [0x00000] in <filename unknown>:0 at System.Linq.Enumerable+<CreateSelectIterator>c__Iterator10`2[KSPAchievements.CelestialBodySubtree,CelestialBody].MoveNext () [0x00000] in <filename unknown>:0 at System.Linq.Enumerable+<CreateWhereIterator>c__Iterator1D`1[CelestialBody].MoveNext () [0x00000] in <filename unknown>:0 at System.Collections.Generic.List`1[CelestialBody].AddEnumerable (IEnumerable`1 enumerable) [0x00000] in <filename unknown>:0 at System.Collections.Generic.List`1[CelestialBody]..ctor (IEnumerable`1 collection) [0x00000] in <filename unknown>:0 at System.Linq.Enumerable.ToList[CelestialBody] (IEnumerable`1 source) [0x00000] in <filename unknown>:0 at ContractConfigurator.ExpressionParser.CelestialBodyParser+<>c.<RegisterMethods>b__5_43 () [0x00000] in <filename unknown>:0 at ContractConfigurator.ExpressionParser.Function`1[System.Collections.Generic.List`1[CelestialBody]].Invoke () [0x00000] in <filename unknown>:0 at ContractConfigurator.ExpressionParser.Function`1[System.Collections.Generic.List`1[CelestialBody]].Invoke (System.Object[] parameters) [0x00000] in <filename unknown>:0 at ContractConfigurator.ExpressionParser.ExpressionParser`1[CelestialBody].ParseMethod[CelestialBody] (ContractConfigurator.ExpressionParser.Token token, .CelestialBody obj, Boolean isFunction) [0x00000] in <filename unknown>:0 Rethrow as Exception: Error parsing statement. Error occurred near '*': ReturnedFromBodies().Where(body => @/stations.Where(v => v.CelestialBody() == body).Count() == 0).SelectUnique() ....................* <-- HERE at ContractConfigurator.ExpressionParser.ExpressionParser`1[T].ParseExpression (System.String key, System.String expression, ContractConfigurator.ExpressionParser.DataNode dataNode) [0x00000] in <filename unknown>:0 at ContractConfigurator.ExpressionParser.ExpressionParser`1[T].ExecuteExpression (System.String key, System.String expression, ContractConfigurator.ExpressionParser.DataNode dataNode) [0x00000] in <filename unknown>:0 at ContractConfigurator.ConfigNodeUtil.ParseSingleValue[CelestialBody] (System.String key, System.String stringValue, Boolean allowExpression) [0x00000] in <filename unknown>:0 at ContractConfigurator.ConfigNodeUtil.ParseValue[CelestialBody] (.ConfigNode configNode, System.String key, Boolean allowExpression) [0x00000] in <filename unknown>:0 at ContractConfigurator.ConfigNodeUtil.ParseValue[CelestialBody] (.ConfigNode configNode, System.String key, System.Action`1 setter, IContractConfiguratorFactory obj, .CelestialBody defaultValue, Syste Here is the full log: https://www.dropbox.com/s/crtssqsq2kpbczj/log.zip?dl=0 I have version 0.2 installed of your contract pack.

Just like RL

@RealGecko I redid the PR for you. I reverted what VS did in converting tabs to spaces I also didn't commit the csproj and other files. The only ones I commeted are the KEI.cs, ExcludedExperiments.cfg and the README It is a lot cleaner, hopefully you will be able to follow it easier now.

this is now a github link, along with the source code which I pushed to the repo

Did you make any changes in the code, if I do adopt this I'd like to give you credit. Same for @MeCripp

You want to look at: EVAEnhancementsBehaviour.cs Also look at EVAParachutes and DangIt (it uses Events a lot) But the simplest way is one of the following: if (FlightGlobals.ActiveVessel.vesselType == VesselType.EVA) or this: if (vessel.isEVA)

Put something into an Update () function that checks to see if you are EVA or not. If so, enable it, otherwise disable it. Lots of mods do this, just search for Events in a mod's code (events is capitolized). On a phone now, otherwise I'd post an example

Then you would be ok with my putting it on Github and making a more "official" release, so it could be installed with CKAN, etc? I would appreciate any continuing help with it, just thinking about doing this to keep it from being lost

Patreon here: https://www.patreon.com/linuxgurugamer Re the other, I've added it as an issue on Github

Thanks. Are you doing this as an official release, or just an "here it is if you want it" type of thing?

To make it very clear: @Ser and I had a disagreement. It was not unfriendly, or, at least, not meant to be unfriendly. I was requested to look at this mod by @OldMold, and wasn't aware of @Ser's previous involvement. While I had started on working on it, I would not have done a "official" fork or release without attempting to contact the original author. Unfortunately, I've tried to contact this particular author in the past, and was essentially ignored, which probably tainted my perceptions. @Ser has a working version, and actually, DID post his source to Github, but it was under a different branch and wasn't really obvious as to where it was. I found it when looking at the history of this. @Ser has stated, and I'm agreeing with him, that he should attempt to continue this mod. So, I am officially NOT WORKING on this, please contact @Ser about it. I have offered him some suggestions in a PM, he is free to take or leave them, no offense intended or taken either way. Also, I have told him that I would be happy to offer any assistance he may need in the future with it. Again, no offense intended, or taken if he doesn't take me up on the offer.