ensou04 Posted March 17, 2022 Author Share Posted March 17, 2022 (edited) 2 hours ago, DeadJohn said: I have a question for those of you using RSE in KSP 1.12. Does it suffer from the general 1.12 sound bug (engine sounds stop working and don't return until a restart), or is RSE luckily unaffected by that bug? I don't see this happening unless its a Unity bug because RSE is its own Sound Effects System independent of KSP's stock sound stuff Edited March 17, 2022 by ensou04 Quote Link to comment Share on other sites More sharing options...
Kwebib Posted March 19, 2022 Share Posted March 19, 2022 @ensou04 I no longer see an option to disable the staging sound in the latest build. Is this intentional? Quote Link to comment Share on other sites More sharing options...
ensou04 Posted March 19, 2022 Author Share Posted March 19, 2022 (edited) 1 hour ago, Kwebib said: @ensou04 I no longer see an option to disable the staging sound in the latest build. Is this intentional? it has been moved to ShipEffects.cfg. but this is an oversight I only intended to move the audioclip sources fields. I'm gonna move it back to settings.cfg in a bit. EDIT: moved it back to Settings.cfg. try the new build now Edited March 19, 2022 by ensou04 Quote Link to comment Share on other sites More sharing options...
Kwebib Posted March 19, 2022 Share Posted March 19, 2022 (edited) Works perfectly, thanks. That staging sound is silly. Edited March 19, 2022 by Kwebib Quote Link to comment Share on other sites More sharing options...
ensou04 Posted March 19, 2022 Author Share Posted March 19, 2022 1 hour ago, Kwebib said: Works perfectly, thanks. That staging sound is silly. no problem! and yeah stock staging sound doesn't complement RSE sound effects at all. I'm still thinking of a good replacement for them. Quote Link to comment Share on other sites More sharing options...
ensou04 Posted March 19, 2022 Author Share Posted March 19, 2022 I've found the source of Sound breaking in-game (eg: engines not making sound). It started happening to RSE ever since I added RCS sounds. The sound limit for KSP was set to only 15 sounds that can be heard, which you can imagine will max out very quickly as you have RSE with a Cluster of 5 Engines + RCS Thrusters. Each Engine and RCS Thrusters uses at least 2 sounds at the same time. This rarely happens to Stock KSP because stock sound is simpler and minimal. I fixed this issue by increasing the Real Voice Limit to 64. I'm considering making this configurable just in case anyone starts having performance issues caused by too many sounds playing in game. Quote Link to comment Share on other sites More sharing options...
610yesnolovely Posted March 19, 2022 Share Posted March 19, 2022 Nice find! Is that related to a very rare sound bug where engine sounds simply no longer work, the only way to fix it is to restart the game (changing scenes, reloading, nothing fixes it)? Quote Link to comment Share on other sites More sharing options...
ensou04 Posted March 20, 2022 Author Share Posted March 20, 2022 (edited) Rocket Sound Enhancement has been updated! The Config Pack is now a Separate Mod and has its own GitHub Repository. The Plugin Mod is now ready for v1.0.0. Just need more testing and Basic Features (like in-game settings) and then we'll graduate this from WIP Status to Release. Downloads Rocket Sound Enhancement v0.6.1 (Plugin): https://github.com/ensou04/RocketSoundEnhancement/releases/tag/0.6.1 Rocket Sound Enhancement Default v1.0.0 (Config and Sound Pack): https://github.com/ensou04/RocketSoundEnhancementDefault/releases/tag/1.0.0 Changelog Rocket Sound Enhancement v0.6.1 Setting Muffling to 0 now goes to silent. Code Optimization on Audio Limiter Rocket Sound Enhancement v0.6.0 Compiled on 1.12.3 Implemented a new Audio Limiter (Fairly Childish Limiter/Compressor) Added RCS Part Module Volume Settings are now controlled by Stock In-game Settings Moved Audio Limiter and Muffler Settings to Settings.cfg Increased KSP Real Voices/Sound Limit to 64 (originally was only 15) Fixed Engage/Disengage Not Working Together Fixed "Volume" Config Node for RSE_Wheels and RSE_Engines not being in code. Change Muffling Settings to Internal Muffling only by Default Rocket Sound Enhancement Default v1.0.0 Added RCS Sound Effects and Patches Updated ReStock Compatibility Patch Added Waterfall Restock Patch (not fully tested) Added Waterfall Stock Patch (not fully tested) Added Realplume Patch (Thanks Kari1407) Remastered Rocket Engine Sound Effects Edited March 20, 2022 by ensou04 Quote Link to comment Share on other sites More sharing options...
Kwebib Posted March 20, 2022 Share Posted March 20, 2022 Sweet! I know I've asked about this in the past, but is it still not possible to get complete silence in space? Currently you can still hear low rumbles, even with a setting of zero Hz on the low pass filter. Quote Link to comment Share on other sites More sharing options...
ensou04 Posted March 20, 2022 Author Share Posted March 20, 2022 2 minutes ago, Kwebib said: Sweet! I know I've asked about this in the past, but is it still not possible to get complete silence in space? Currently you can still hear low rumbles, even with a setting of zero Hz on the low pass filter. Not at the moment . I think I have an idea on how to do it. I'll give it a try and see how it works, if it works I'll push it to the master. Quote Link to comment Share on other sites More sharing options...
Benzo Kerman Posted March 20, 2022 Share Posted March 20, 2022 One question- would this still work with waterfall? This looks really sick though! Quote Link to comment Share on other sites More sharing options...
ensou04 Posted March 20, 2022 Author Share Posted March 20, 2022 Just now, Benzo Kerman said: One question- would this still work with waterfall? This looks really sick though! Waterfall Restock and Waterfall Stock is supported but not fully tested. Quote Link to comment Share on other sites More sharing options...
ensou04 Posted March 20, 2022 Author Share Posted March 20, 2022 @Kwebib try the new plugin now (v0.6.1), Muffling should now go to silent if you set it to 0. Quote Link to comment Share on other sites More sharing options...
physius Posted March 20, 2022 Share Posted March 20, 2022 Thanks for the update. I really hope this sort of sound design makes into stock KSP2! Quote Link to comment Share on other sites More sharing options...
Rocketology Posted March 20, 2022 Share Posted March 20, 2022 @ensou04 This is one of the first mods I always install for another go at KSP. Great sound is one of those things that many overlook, but has such a dramatic affect on immersion and gameplay satisfaction. As always, well done! Quote Link to comment Share on other sites More sharing options...
Kwebib Posted March 20, 2022 Share Posted March 20, 2022 3 hours ago, ensou04 said: @Kwebib try the new plugin now (v0.6.1), Muffling should now go to silent if you set it to 0. Perfect! Thank you. I just tried it out and it seems to be working. Quote Link to comment Share on other sites More sharing options...
ensou04 Posted March 21, 2022 Author Share Posted March 21, 2022 (edited) Been working on this the entire day. Settings for Limiting(Sound Effects Mastering) and Muffling now have Presets to make things simpler, but you can still customize your own by using the Custom Preset. This build will be pushed to master later once I'm done working on the Saving Part. Available Presets for Sound Effects Mastering: Balanced (Default Preset) Cinematic (Wide Dynamic Range, Quiet Sounds are mostly the same, Louder sounds are Louder without going too extreme) NASA-Reels (Inspired by real rocket launch footage. This is the Loudest Preset, Quiet Sounds are Louder than Balanced and Stock) Available Presets for Muffling: Internal(IVA) Muffling Only Muffled Vacuum Silent Vacuum Edited March 21, 2022 by ensou04 Quote Link to comment Share on other sites More sharing options...
theonegalen Posted March 21, 2022 Share Posted March 21, 2022 fantastic! Quote Link to comment Share on other sites More sharing options...
ensou04 Posted March 22, 2022 Author Share Posted March 22, 2022 (edited) Plugin Update! RSE is getting closer to release. If this update doesn't have anything broken. We'll finally be ready to Graduate to the Release Page Downloads Rocket Sound Enhancement v0.7.1 (Plugin): https://github.com/ensou04/RocketSoundEnhancement/releases/tag/0.7.1 Rocket Sound Enhancement Default v1.0.0 (Config and Sound Pack): https://github.com/ensou04/RocketSoundEnhancementDefault/releases/tag/1.0.0 Changelog Rocket Sound Enhancement v0.7.1 Fixed Music being Muffled Rocket Sound Enhancement v0.7.0 New In-game Settings Window (During Flight) Audio Limiter/Sound Effects Mastering now has Presets Available through In-Game Settings Audio Muffler Presets now Available through In-Game Settings Sound Effects Mastering Presets: Balanced (The Default Preset, Sounds are balanced with Reasonable Dynamic Range) Cinematic (Wide Dynamic Range, Loud Sounds are Louder and Quiet Sound Are Quieter than Balanced) NASA-Reels (Inspired by Real Rocket Launch Footage, This is the Loudest Preset with minimal Dynamic Range) Audio Muffler Presets: Interior-Only (Only Muffle sounds when the Camera is in IVA view) Muffled-Vacuum Silent-Vacuum Other Changes: Handling of Configs has been changed in code. Code Cleanup Edited March 22, 2022 by ensou04 Quote Link to comment Share on other sites More sharing options...
ensou04 Posted March 23, 2022 Author Share Posted March 23, 2022 (edited) Fixed some bugs specially with Wheel Collisions. I'm not sure if I got them all but so far I'm not hearing any scraping sound effects anymore to anything that's not supposed to be making noises. I also tweaked how muffling behaves with the Orbit Map View. It will muffle the sound with either the Interior Muffling Value or the Vacuum Muffling Value, whichever is the lowest value. For the Default Config Pack, I still have no Idea how I will approach the Jet Engines so if you have any ideas and references please share them! Downloads Rocket Sound Enhancement v0.7.2 (Plugin): https://github.com/ensou04/RocketSoundEnhancement/releases/tag/0.7.2 Rocket Sound Enhancement Default v1.0.2 Config and Sound Pack): https://github.com/ensou04/RocketSoundEnhancementDefault/releases/tag/1.0.2 Changelog Rocket Sound Enhancement v0.7.2 Potential Fix for Collision Loop Sound Effects Persisting after Impact Custom Audio Muffler Settings now react instantly to new settings Tweaked Orbit View Muffling Removed "MuffleChatterer" from LOWPASSFILTER in Settings.cfg Added "AffectChatterer" under RSE_SETTINGS in Settings.cfg Code Optimization Rocket Sound Enhancement Default v1.0.2 Fixed Waterfall Patches (Again) Fixed ReStock Patch using the wrong :FOR[xxx] name v1.0.1 Fixed Waterfall Patches Edited March 23, 2022 by ensou04 Quote Link to comment Share on other sites More sharing options...
Joker58th Posted March 23, 2022 Share Posted March 23, 2022 (edited) 53 minutes ago, ensou04 said: I still have no Idea how I will approach the Jet Engines so if you have any ideas and references please share them! JetSoundsUpdated does a pretty good job with the jet engines so I'm not sure you need to do anything? Just a thought... Edited March 23, 2022 by Joker58th Quote Link to comment Share on other sites More sharing options...
Vandest Posted March 23, 2022 Share Posted March 23, 2022 (edited) Thank you @ensou04 for this great mod ! I saw a little issue with patch for Stock Waterfall Effects, you use this: @PART[*]:HAS[@MODULE[RSE_Engines]]:FOR[zzzRocketSoundEnhancementDefault]:NEEDS[StockWaterfallEffects] { !EFFECTS{} } @PART[*]:HAS[@MODULE[RSE_RCS]]:FOR[zzzRocketSoundEnhancementDefault]:NEEDS[StockWaterfallEffects] { !EFFECTS{} } But with this you remove EFFECTS nodes where there is your module. So you remove EFFECTS nodes where there isn't modules of Stock Waterfall Effects and this is also remove EFFECTS nodes from other mode like RealPlume-Stock (I use it for SRB). So, to remove sound provided by Stock Waterfall Effects, you just need to check if this part get the ModuleWaterfallFX module : @PART[*]:HAS[@MODULE[ModuleWaterfallFX]]:FOR[zzzRocketSoundEnhancementDefault]:NEEDS[StockWaterfallEffects] { !EFFECTS{} } Well, I go back to enjoy with your terrible sounds ! Edited March 23, 2022 by Vandest Quote Link to comment Share on other sites More sharing options...
ensou04 Posted March 23, 2022 Author Share Posted March 23, 2022 (edited) 8 hours ago, Vandest said: So, to remove sound provided by Stock Waterfall Effects, you just need to check if this part get the ModuleWaterfallFX module : @PART[*]:HAS[@MODULE[ModuleWaterfallFX]]:FOR[zzzRocketSoundEnhancementDefault]:NEEDS[StockWaterfallEffects] { !EFFECTS{} } Thanks for the fix I assume Waterfall ReStock patch should be like this as well. 8 hours ago, Vandest said: Well, I go back to enjoy with your terrible sounds ! I don't know if this is a compliment or insult but do enjoy Edited March 23, 2022 by ensou04 Quote Link to comment Share on other sites More sharing options...
Kwebib Posted March 23, 2022 Share Posted March 23, 2022 3 hours ago, ensou04 said: I don't know if this is a compliment or insult but do enjoy Maybe he meant "terrific". Speaking of patches, I meant to tell you earlier, but didn't get around to it. Near Future Launch Vehicles have Waterfall configs and are silent with your patches. I think this just means they need RSE configs made? Quote Link to comment Share on other sites More sharing options...
ensou04 Posted March 23, 2022 Author Share Posted March 23, 2022 (edited) 40 minutes ago, Kwebib said: Maybe he meant "terrific". Speaking of patches, I meant to tell you earlier, but didn't get around to it. Near Future Launch Vehicles have Waterfall configs and are silent with your patches. I think this just means they need RSE configs made? that's probably because of the old patch @Vandest pointed out. it shouldn't happen now with the latest Default Config. Although I do plan on making actual patches for Near Future stuff even using its own sounds on most parts but just through RSE. Forget what i said. you're right, with the new patch, anything that has waterfall will have its sounds removed now despite not having RSE Modules with them. . . . Edited March 23, 2022 by ensou04 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.