[1.8.1-1] [PLEASE FORK ME] Kopernicus & KittopiaTech

[Merkov]

1 minute ago, RentedTritium said:

Ok, cool. That's all I meant. I looked around and couldn't find any planet packs that did that, which made me suspicious that I was missing something and it wasn't possible.

I believe OPM does this with two of the moons orbiting Urlum.

[Spheniscine]

1 minute ago, RentedTritium said:

Ok, cool. That's all I meant. I looked around and couldn't find any planet packs that did that, which made me suspicious that I was missing something and it wasn't possible.

Kerbol Plus Remade adds Havet as a trojan dwarf to Kerbin (interesting since it means there are no such thing as transfer windows between it and Kerbin), and Outer Planets Mod has Priax as a trojan companion to Polta, both orbiting Urlum.

[RentedTritium]

I'm even playing OPM! How did I not spot that?

[Merkov]

12 minutes ago, RentedTritium said:

I'm even playing OPM! How did I not spot that?

Well, both Priax and Polta are pretty small, and since their orbit lines overlap, it's not inconceivable that you'd not notice two little blips on that line.

[Thomas P.]

Kopernicus 1.2.2-1 is on Github. It contains no config or feature related changes, but the API has changed, if you interact with it through code.

I moved the parsing and attribution library out of Kopernicus, because I really love how it works, and maybe someone wants to use it in a non-Kopernicus project: https://github.com/Kopernicus/config-parser
Following my tradition: This change broke @Sigma88s mods. But tbh I think future updates wont break them again.

[Sigma88]

8 minutes ago, Thomas P. said:

future updates wont break them again

now I'm kinda sad

[Uberns]

5 hours ago, Thomas P. said:

Woah! 1.2.2 has been released, and no @Snark action was neccessary yet!

I'm pretty sure Satan just posted a pic of him wearing a fur coat in his house.

[*MajorTom*]

49 minutes ago, Thomas P. said:

Kopernicus 1.2.2-1 is on Github. It contains no config or feature related changes, but the API has changed, if you interact with it through code.

I moved the parsing and attribution library out of Kopernicus, because I really love how it works, and maybe someone wants to use it in a non-Kopernicus project: https://github.com/Kopernicus/config-parser
Following my tradition: This change broke @Sigma88s mods. But tbh I think future updates wont break them again.

I use SVT+jool rings  before, but new version of kopernicus disable game loading - black infinite loading screen (game works only if i delete this new kopernicus version). Maybe this also SVT issue but who knows?

Edit! no this is real kopernicus issue:

I delete SVT folder jool_rings and svekopernicus, but with kopernicus folder in gamedata i look into infinite loadscreen

then i delete kopernicus... and game load is ok

 

Edited December 7, 2016 by *MajorTom*

[Tyko]

Wow @Thomas P. awesome quick work! Thanks

[The White Guardian]

@Thomas P. does this version also include @blackrack's amazing ring shader? Or will that be a Scatterer feature?

Sorry, it just looks so amazing that I can't wait to play with it.

[Thomas P.]

Just now, The White Guardian said:

@Thomas P. does this version also include @blackrack's amazing ring shader? Or will that be a Scatterer feature?

Sorry, it just looks so amazing that I can't wait to play with it.

I recieved nothing from blackrack, so no it is not included. And I think he mentioned that he wants to put it into Kopernicus, but I am not sure

[blackrack]

17 minutes ago, The White Guardian said:

@Thomas P. does this version also include @blackrack's amazing ring shader? Or will that be a Scatterer feature?

Sorry, it just looks so amazing that I can't wait to play with it.

It's not done yet.

 

16 minutes ago, Thomas P. said:

I recieved nothing from blackrack, so no it is not included. And I think he mentioned that he wants to put it into Kopernicus, but I am not sure

It's going in Kopernicus, the only thing that will require scatterer is the ring shadows on the planet/atmosphere (since it's too much of a hassle to do otherwise)

[Rekthor]

I'm having the same issue as @*MajorTom*. An infinite black screen upon loading a save game, that disappears when I remove the updated version of Kopernicus. I can see Kerbal Alarm Clock, Toolbar and any mod buttons on it, but nothing else appears. The issue is not exclusive to that one save and persists across multiple different saves. The only mod I'm using that relies upon Kopernicus is Outer Planets.

Let me know if there's any more info I can give.

Edited December 7, 2016 by Rekthor

[Sigma88]

1 minute ago, Rekthor said:

I'm having the same issue as @*MajorTom*. An infinite black screen upon loading a save game, that disappears when I remove the updated version of Kopernicus. I can see Kerbal Alarm Clock, Toolbar and any mod buttons on it, but nothing else appears. The issue is not exclusive to that one save and persists across multiple different saves. The only mod I'm using that relies upon Kopernicus is Outer Planets.

Let me know if there's any more info I can give.

click on the nyan cat in my sig, it'll bring you to a list of stuff we need

Edited December 7, 2016 by Sigma88

[Thomas P.]

3 hours ago, *MajorTom* said:

I use SVT+jool rings  before, but new version of kopernicus disable game loading - black infinite loading screen (game works only if i delete this new kopernicus version). Maybe this also SVT issue but who knows?

Edit! no this is real kopernicus issue:

I delete SVT folder jool_rings and svekopernicus, but with kopernicus folder in gamedata i look into infinite loadscreen

then i delete kopernicus... and game load is ok

 

 

1 hour ago, Rekthor said:

I'm having the same issue as @*MajorTom*. An infinite black screen upon loading a save game, that disappears when I remove the updated version of Kopernicus. I can see Kerbal Alarm Clock, Toolbar and any mod buttons on it, but nothing else appears. The issue is not exclusive to that one save and persists across multiple different saves. The only mod I'm using that relies upon Kopernicus is Outer Planets.

Let me know if there's any more info I can give.

Please delete all mods that are not related to Kopernicus. I an install with Kopernicus, OPM, AlternisKerbol and nothing else, I dont get any issues while loading saves. This could be an issue of a third party mod, caused by one of the added planets.

Another question: Are you on 1.2.2 or 1.2.1?

Edited December 7, 2016 by Thomas P.

[Mechtech]

I am ALSO having this issue, currently in the process of troubleshooting-hello, whats this? back in a sec, gotta test something.

Edit: okay, I was trawling various log files before I ran off, as I'd discovered the culprit- somehow, Better Burn Time was making Kopernicus go 'URK.' removed Better Burn Time, problem went away. presumably, something in how BBT gets its calc data isn't playing nice with the latest version. I suggest checking your root/logs/Kopernicus/Kerbin.Body.Log for exceptions (it's pretty easy, just open it up and scroll to the bottom) to see if anything else is messing with it.

I'm waiting for the game to reload so I can provide a sample of the glitched logs for @Thomas P. and @Snark to look at to see if either can nail down the issue (I have nearly a hundred mods, takes me a while to start up) so I'll edit this post again shortly.

In the meantime, I suppose I'll just have to live without Better Burn Time. drat.

Edited December 7, 2016 by Mechtech
Update

[Mechtech]

alrighty, @Thomas P., below are the KSP and Kerbin.body.log files for my own game. if some of the others that have the black-screen-issue could also check whether BBT is the root cause?

Linky

this is the actual error, along with the line directly above BTW:

[LOG 15:46:55]: Parsing Target barycenter in (Kopernicus.Configuration.Body) as (Kopernicus.NumericParser`1[System.Boolean])
[LOG 15:46:55]: Exception Was Recorded: Could not load type 'System.Runtime.CompilerServices.ExtensionAttribute' from assembly 'BetterBurnTime'.
  at (wrapper managed-to-native) System.MonoCustomAttrs:GetCustomAttributesInternal (System.Reflection.ICustomAttributeProvider,System.Type,bool)
  at System.MonoCustomAttrs.GetCustomAttributesBase (ICustomAttributeProvider obj, System.Type attributeType) [0x00000] in <filename unknown>:0 
  at System.MonoCustomAttrs.GetCustomAttributes (ICustomAttributeProvider obj, System.Type attributeType, Boolean inherit) [0x00000] in <filename unknown>:0 
  at System.MonoType.GetCustomAttributes (System.Type attributeType, Boolean inherit) [0x00000] in <filename unknown>:0 
  at Kopernicus.Parser.LoadExternalParserTargets (.ConfigNode node, System.String modName, Boolean getChilds) [0x00000] in <filename unknown>:0 
  at Kopernicus.Configuration.Body.Kopernicus.IParserEventSubscriber.PostApply (.ConfigNode node) [0x00000] in <filename unknown>:0 
  at Kopernicus.Parser.LoadObjectFromConfigurationNode (System.Object o, .ConfigNode node, System.String modName, Boolean getChilds) [0x00000] in <filename unknown>:0 
  at Kopernicus.Configuration.Loader.Kopernicus.IParserEventSubscriber.PostApply (.ConfigNode node) [0x00000] in <filename unknown>:0 

hope that helps.

[Snark]

54 minutes ago, Mechtech said:

alrighty, @Thomas P., below are the KSP and Kerbin.body.log files for my own game. if some of the others that have the black-screen-issue could also check whether BBT is the root cause?

Okay, that stack trace is seriously bizarre.  BetterBurnTime doesn't do anything with reflection.  Nothing in the System.Reflection namespace, nothing with System.Runtime.CompilerServices, nothing.  Why on earth Kopernicus would end up trying to load that stuff out of BetterBurnTime is beyond me.  Certainly there's never been any interop problem with Kopernicus and BBT before, and I haven't changed any code in BBT since 10/18 (which was after 1.2 but before 1.2.1).

So I'm guessing this is some sort of issue with Kopernicus code that BBT has innocently stumbled into.  There's not really anything for me to investigate here, since there's no actual BBT code in the stack trace.

If it turns out that I'm wrong, though, and there's something in BetterBurnTime that's either buggy or not following best practices or something, please ping me and I'm happy to put out a fix ASAP.  Kopernicus is one of my favorite mods and I definitely don't want to stand in its way! 

 

[Mechtech]

yeah, the extent of my coding knowledge is pretty much on the 'hello world' level and doing things like MM patches or .Lua stuff for HW2, really high-level stuff. I figured that it was Something Weird Tee Emm from the mod interaction but I figured letting both of you know would likely get it nailed down faster. I imagine even knowing BBT shouldn't be doing that will help a bit.

 

anyway, @Thomas P., you wanna weigh in with any ideas as to what may be going wrong? I'm perfectly happy without BBT (I use Mechjeb a lot, which generally makes it somewhat redundant) but having it is nice.

[smotheredrun]

Thanks @Thomas P.!  

[Snark]

Okay, peeked a little bit at this.  I think I see the problem, thanks to the log @Mechtech posted.

Technobabble in spoiler section, so as not to hurt the eyes of any non-technical folks. @Thomas P., does this seem reasonable?

Spoiler

Here's the relevant code from the logged error message.  The bug is happening in the new config-parser code that Thomas mentioned earlier.

It looks like what this code is doing is iterating through every loaded assembly, and calling MemberInfo.GetCustomAttributes on it, and just assuming that that's going to work.

MemberInfo.GetCustomAttributes is documented as throwing TypeLoadException if a custom attribute can't be loaded, which looks as though it's exactly what's happening here.  So, I would assume that the fix is for the Kopernicus config parser to wrap a try-catch around that call to MemberInfo.GetCustomAttributes, to trap the expected TypeLoadException.  If it gets one of those, just shrug and move on, rather than propagating the exception.

 

[Thomas P.]

11 hours ago, Snark said:

Okay, peeked a little bit at this.  I think I see the problem, thanks to the log @Mechtech posted.

Technobabble in spoiler section, so as not to hurt the eyes of any non-technical folks. @Thomas P., does this seem reasonable?

  Reveal hidden contents

Here's the relevant code from the logged error message.  The bug is happening in the new config-parser code that Thomas mentioned earlier.

It looks like what this code is doing is iterating through every loaded assembly, and calling MemberInfo.GetCustomAttributes on it, and just assuming that that's going to work.

MemberInfo.GetCustomAttributes is documented as throwing TypeLoadException if a custom attribute can't be loaded, which looks as though it's exactly what's happening here.  So, I would assume that the fix is for the Kopernicus config parser to wrap a try-catch around that call to MemberInfo.GetCustomAttributes, to trap the expected TypeLoadException.  If it gets one of those, just shrug and move on, rather than propagating the exception.

 

Sounds reasonable. Hotfix released. Seems to work with BetterBurn Time over here.

[asdfCYBER]

18 hours ago, Mechtech said:

alrighty, @Thomas P., below are the KSP and Kerbin.body.log files for my own game. if some of the others that have the black-screen-issue could also check whether BBT is the root cause?

Linky

this is the actual error, along with the line directly above BTW:

[LOG 15:46:55]: Parsing Target barycenter in (Kopernicus.Configuration.Body) as (Kopernicus.NumericParser`1[System.Boolean])
[LOG 15:46:55]: Exception Was Recorded: Could not load type 'System.Runtime.CompilerServices.ExtensionAttribute' from assembly 'BetterBurnTime'.
  at (wrapper managed-to-native) System.MonoCustomAttrs:GetCustomAttributesInternal (System.Reflection.ICustomAttributeProvider,System.Type,bool)
  at System.MonoCustomAttrs.GetCustomAttributesBase (ICustomAttributeProvider obj, System.Type attributeType) [0x00000] in <filename unknown>:0 
  at System.MonoCustomAttrs.GetCustomAttributes (ICustomAttributeProvider obj, System.Type attributeType, Boolean inherit) [0x00000] in <filename unknown>:0 
  at System.MonoType.GetCustomAttributes (System.Type attributeType, Boolean inherit) [0x00000] in <filename unknown>:0 
  at Kopernicus.Parser.LoadExternalParserTargets (.ConfigNode node, System.String modName, Boolean getChilds) [0x00000] in <filename unknown>:0 
  at Kopernicus.Configuration.Body.Kopernicus.IParserEventSubscriber.PostApply (.ConfigNode node) [0x00000] in <filename unknown>:0 
  at Kopernicus.Parser.LoadObjectFromConfigurationNode (System.Object o, .ConfigNode node, System.String modName, Boolean getChilds) [0x00000] in <filename unknown>:0 
  at Kopernicus.Configuration.Loader.Kopernicus.IParserEventSubscriber.PostApply (.ConfigNode node) [0x00000] in <filename unknown>:0 

hope that helps.

I did have the error, I did not have Better Burn Time.

1 hour ago, Thomas P. said:

Sounds reasonable. Hotfix released. Seems to work with BetterBurn Time over here.

Thank you very much! It works here better too.

[APlayer]

I am not sure whether that is intended, a bug or just a product of my stupidity, but when I updated Kopernicus yesterday, I forgot to update ModularFlightIntegrator and opening up KSP showed me the menu background... but not the menu itself! I just saw Kerbin, the Mun and that's all...

Eventually I tracked it down to Kopernicus and reinstalled, doing this I noticed the ModularFlightIntegrator was still the old one, and updating it fixed all.

However, is it really supposed, or even allowed, to fully destroy KSP? It feels wrong somehow.

[Eklykti]

On 08.12.2016 at 6:13 PM, Thomas P. said:

Sounds reasonable. Hotfix released. Seems to work with BetterBurn Time over here.

Well, the game seems to load fine for me, but there are still lot of these weird errors in the log:

 

Missing method .ctor in assembly /home/infoman/games/KSP-GOG/1.2.2/game/GameData/BetterBurnTime/BetterBurnTime.dll, type System.Runtime.CompilerServices.ExtensionAttribute
The class System.Runtime.CompilerServices.ExtensionAttribute could not be loaded, used in BetterBurnTime
Can't find custom attr constructor image: /home/infoman/games/KSP-GOG/1.2.2/game/GameData/BetterBurnTime/BetterBurnTime.dll mtoken: 0x0a000001
Missing method .ctor in assembly /home/infoman/games/KSP-GOG/1.2.2/game/GameData/IndicatorLights/IndicatorLights.dll, type System.Runtime.CompilerServices.ExtensionAttribute
The class System.Runtime.CompilerServices.ExtensionAttribute could not be loaded, used in IndicatorLights
Can't find custom attr constructor image: /home/infoman/games/KSP-GOG/1.2.2/game/GameData/IndicatorLights/IndicatorLights.dll mtoken: 0x0a000001

http://upload.yo.md/uploads/file_record/file/1137/Player.log.txt