[1.0.x]Destruction Effects (flames and smoke on joint breaks)

[sarbian]

I replied to the issue liked above with is what the most likely source of the problem. It should be no more than a couple of line changes.

[SpannerMonkey(smce)]

Just now, sarbian said:

I replied to the issue liked above with is what the most likely source of the problem. It should be no more than a couple of line changes.

Much appreciated cheers

[Guest]

11 hours ago, SpannerMonkey(smce) said:

I'll be sure to push them up as soon as I'm happy with the overall appearance.

By that do you means as in making the flame look realistic or spraying bugs with coding?

[Guest]

I love these FX. @SpannerMonkey(smce)'s flames actually kinda look better than the legacy's. Here's a picture:

[panzer1b]

@SpannerMonkey(smce), ive back to working on altering this mod (spent a while doing a cloud mod and a few maps for a RTS i play), and there is still one thing that drives me up the wall...

The stupid compiler refuses to accept the following line in the code:

var velocity = Part?.GetComponent<Rigidbody>().velocity ?? Rb.velocity;

This is highlighted in red:

.GetComponent<Rigidbody>().velocity ?? Rb.velocity

Im a noob at coding so i have no idea why this isnt working?  I have VS set up 100% correctly (according to wiki) as it is now (i can compile other mods fine), i have the references the same as you have, and it makes no sense to me why it doesnt let me compile that one line of code...  Did the version of .net framework change or something since U5 was updated?

If you have any time id appreciate some help with this, i really want to start working on this mod legit, but without the ability to compile (i need to be able to edit the particle spawn timer to mess with effects, and i need to get rid of the vaccum effects disabling code so i can actually use this in space with my capital ship battles) i cant really do much to work on this...

[SpannerMonkey(smce)]

11 hours ago, panzer1b said:

The stupid compiler refuses to accept the following line in the code:

Hi, got to say that I'm a complete noob too when it comes to coding, and  usually get by by just fixing the error that the console gives me, Rb  should be rb i think though,  so what does the  error code say?   As long as you are using the latest DLL references there should be no issues with that side of things .  The best person to ask would be @jrodriguez as he's considerably more gifted in code Fu than i am, but if you give me a link to your code I'd be happy to see if i could fix it, i do seem to be getting a little luckier of late  

[panzer1b]

On 11/20/2016 at 10:40 AM, SpannerMonkey(smce) said:

Hi, got to say that I'm a complete noob too when it comes to coding, and  usually get by by just fixing the error that the console gives me, Rb  should be rb i think though,  so what does the  error code say?   As long as you are using the latest DLL references there should be no issues with that side of things .  The best person to ask would be @jrodriguez as he's considerably more gifted in code Fu than i am, but if you give me a link to your code I'd be happy to see if i could fix it, i do seem to be getting a little luckier of late  

Im literally trying to compile the exact same code found on github (the latest version).  Im getting stuck on the line i mentioned above in the DEGaplessParticleEmitter.cs file.  i can upload my entire code folder if this will be of help, but sofar i just dont get why you are able to compile it and im not even if its the exact same code?  Something has to be wrong with my compiler setup as i cant think of any other possible reason why it wont compile...

[jrodriguez]

30 minutes ago, panzer1b said:

Im literally trying to compile the exact same code found on github (the latest version).  Im getting stuck on the line i mentioned above in the DEGaplessParticleEmitter.cs file.  i can upload my entire code folder if this will be of help, but sofar i just dont get why you are able to compile it and im not even if its the exact same code?  Something has to be wrong with my compiler setup as i cant think of any other possible reason why it wont compile...

Are you using VS2015?

var velocity = Part?.GetComponent<Rigidbody>().velocity ?? Rb.velocity;

? is a null propagation feature implemented as part of C# 6.0 which requires VS2015.

 ? is equivalent to

var velocity = null or default value

if( Part != null){

velocity = Part.GetComponent...

}

 

 

 

Edited November 21, 2016 by jrodriguez

[SpannerMonkey(smce)]

26 minutes ago, panzer1b said:

Im literally trying to compile the exact same code found on github (the latest version).  Something has to be wrong with my compiler setup as i cant think of any other possible reason why it wont compile...

Well in that case I'm stumped as I've just run a rebuild of the same code and it compiled and works fine, you must have an out of date reference or something similar, as the RB changed a couple of days before ksp1.2.1 popped,  See below compiler shot and ref's

Spoiler

 

[panzer1b]

On 11/21/2016 at 2:14 PM, jrodriguez said:

Are you using VS2015?

var velocity = Part?.GetComponent<Rigidbody>().velocity ?? Rb.velocity;

? is a null propagation feature implemented as part of C# 6.0 which requires VS2015.

 ? is equivalent to

var velocity = null or default value

if( Part != null){

velocity = Part.GetComponent...

}

 

 

 

Guess i need to update, been on 2012 for a while now...

Thanks for the advice!

[Guest]

I think it's time we start a new post because lets face it, the only people who know this is me, @jrodriguez, @SpannerMonkey(smce) and @panzer1b

Edited November 26, 2016 by Murican_Jeb
Fixed

[Probus]

Did I miss a link to the updated version of this?

[SpannerMonkey(smce)]

15 minutes ago, Probus said:

Did I miss a link to the updated version of this?

We currently can't edit the OP so most links will be buried in thread, though i wouldn't swear to there ever being one for the latest, in which case  you'll need this

https://github.com/jrodrigv/DestructionEffects/releases/download/v1.2.0/DestructionEffects.1.2.0_11172016.zip

[linuxgurugamer]

Since you've seemed to have adopted this, why don't you start a new thread and ask the moderators to lock this one?

Also, the netkan is still saying this is only 1.10 to 1.1.99 compatible.  Would you like me to get it updated?

[Guest]

So are we going to add the new thread?

[Guest]

Anything new?

Anyone?

Please?

[SpaceFoon]

This mod kills my FPS but I use it anyway..

[jrodriguez]

Hi all,

I have finally created the new thread for this mod with a link to the new release for KSP 1.2.2!

Regards

@BahamutoD It would be great if you can update the OP  . And maybe we can lock this thread.

 

[linuxgurugamer]

1 hour ago, jrodriguez said:

Hi all,

I have finally created the new thread for this mod with a link to the new release for KSP 1.2.2!

Regards

@BahamutoD It would be great if you can update the OP  . And maybe we can lock this thread.

 

Great.  You can ask the moderators to lock the thread when it's been updated