[KSP 1.10.1] Destruction Effects v1.12.0 (09/23/20)

Errol · February 13, 2017

Could it be toggled-able between a long and a short hard coded time?

Falco01 · February 14, 2017

An idea woudl be to have a 4 different effects (particle FX i mean) 2 with the old effect and 2 with the new one, one short one long and be able to switch between them using a config or smth.

Also, idk if it's a feature but if I use the autostrutting it trigger the fx at takeoff on the parts with autostruts, it will also trigger again on those parts if a part break (any part) or a kerbal eva if you use the old fx it never goes away unlike the other one and if I use the autostrutting it trigger the fx at as soon as physics kick in on the parts with autostruts, it will also trigger again on those parts if a part break (any part) or a kerbal eva (if autostruts ofc)

It's pretty taxing on the pc and make it unplayable rather quickly, rigid attachment doesn't do it though.

I'll make a log later, I just stumbled upon this thread on a break to prepare my lab so no game right now ^_^

I hope this will be helpful in some way, have a nice day

Errol · February 14, 2017

I can confirm I ran into the same bug with autostruts.

Falco01 · February 14, 2017

An other idea with the fx, give it a starting velocity like 90% of the one of the emitter then slowing down to a steady rise as it does rn, sometimes it look a bit silly to have a very fast object leaving a perfectly still trail of smoke and fire.
Especially noticable with the new effect in my opinion.
Look at the flame effect in beamNG drive to see what I mean

Edited February 14, 2017 by Falco01

Azimech · February 16, 2017

If this can be made into a full fledged part module, the possibilities increase tremendously.

Errol · February 16, 2017

I think it would look great if it just had a much shorter duration. I tend to have lots of joints break at once, which means lots of flames at near each other in time.

Autostrut bug too....

February 18, 2017

@Errol

Some people want it to have a long duration (like me)

Errol · February 18, 2017

Making it toggleable between long and short would make both camps happy.

February 18, 2017

On 2/13/2017 at 7:35 AM, SpannerMonkey(smce) said:

its not something that can be done in a cfg or a patch, the values for emission and duration are hard code

@Errol

Errol · February 19, 2017

That response was to a request to make the duration user definable, which is different then making it toggleable between two settings, now isn't it?

Heck, this request literally requires no coding, if there is large enough demand for it (at least a few people have shown interest) they could just recompile the plugin with different settings and have seperate downloads. That wouldn't be unprecedented; there are a number of visual mods that offer low and high res versions.

Edited February 19, 2017 by Errol

smokytehbear · February 19, 2017

This is a quick picture of the autostrut bug in action:

Gotta admit it looks pretty but is absolute hell on framerate. That and it's just autostruts, nothing is actually exploding in a massive fireball... so yeah.

February 19, 2017

18 hours ago, Errol said:

Heck, this request literally requires no coding,

Oh, so toggles for settings don't reqiure coding?

Listen, almost everything reqiures coding. Anything that has to do with GUI's reqiure codes. Heck, to even run the GUI's and stuff, it all reqiures coding.

Mods, these are the things that esspecialy reqiure coding, because they are different parts (or whatever the mod is about) that are not stock. Probaly everything in this game has at least a little bit of coding.

There. Now let's not argue about this any further or a moderator will give us a warning point.

jrodriguez · February 19, 2017

18 hours ago, Errol said:

That response was to a request to make the duration user definable, which is different then making it toggleable between two settings, now isn't it?

Heck, this request literally requires no coding, if there is large enough demand for it (at least a few people have shown interest) they could just recompile the plugin with different settings and have seperate downloads. That wouldn't be unprecedented; there are a number of visual mods that offer low and high res versions.

As @Murican_Jeb said. it requires coding - Not a lot but a maybe a couple of hours of my time to make it configurable. The thing is that I have a lot of more interesting stuff to do at this very moment (I have to continue working on the next release of BDArmory and also I'm playing RO/RSS !)

SuicidalInsanity · February 19, 2017

One thing to note - whatever the FX for DestructionFX ends up being, the KSP Particle Emitter(s) used for DFX need to be updated to use the TransparentFX layer - without it, particle FX is regarded as solid and propagates mach/re-entry FX as if it were part of the vessel proper, resulting rendering weirdness and a substantial drop in FPS.

February 19, 2017

@SuicidalInsanity Same problem for BDA.

Apparently it had something to do with a unity version older than the one they should have used. I think as soon as the fix for BDA comes, then they will probaly do a little tinkering with DFX.

Errol · February 20, 2017

Forgive me for assuming that duration would be a single parameter in code, making it simple to release two seperate versions of the plugin entirely, each compiled with a different value in that parameter and a unique filename/download. If it is actually more complicated then that, forgive my ignorance and I'll drop it.

February 20, 2017

@Errol Hey, don't worry man! We all make lots of mistakes, esspecialy on the internet! I hope you aren't offended.

The Aziz · February 23, 2017

Autostrut bugs?

That would explain this....

Not that is a problem to me but looks hilarious :v

Edited February 23, 2017 by The Aziz

linuxgurugamer · March 12, 2017

Getting nullrefs when loading:

Spoiler

(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 42)

Exception handling event onPartJointBreak in class FlamingJoints:System.NullReferenceException: Object reference not set to an instance of an object
at DestructionEffects.FlamingJoints.ShouldFlamesBeAttached (.PartJoint partJoint) [0x00000] in <filename unknown>:0
at DestructionEffects.FlamingJoints.OnPartJointBreak (.PartJoint partJoint, Single breakForce) [0x00000] in <filename unknown>:0
at EventData`2[PartJoint,System.Single].Fire (.PartJoint data0, Single data1) [0x00000] in <filename unknown>:0

(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 42)

NullReferenceException: Object reference not set to an instance of an object
at DestructionEffects.FlamingJoints.ShouldFlamesBeAttached (.PartJoint partJoint) [0x00000] in <filename unknown>:0
at DestructionEffects.FlamingJoints.OnPartJointBreak (.PartJoint partJoint, Single breakForce) [0x00000] in <filename unknown>:0
at EventData`2[PartJoint,System.Single].Fire (.PartJoint data0, Single data1) [0x00000] in <filename unknown>:0
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:LogException(Exception)
EventData`2:Fire(PartJoint, Single)
PartJoint:DestroyJoint()
Part:ReleaseAutoStruts()
Part:OnDestroy()

(Filename: Line: -1)