[1.12.x] Mk1-Cabin-Hatch [v1.0.1]

[Murdabenne]

Error with the new Module Manager: bad syntax for the Indicator Lights patch
 

@PART[MK1CrewCabin]:NEEDS[MK1CabinHatch]:NEEDS[IndicatorLights]:BEFORE[MK1CabinHatch]:AFTER[IndicatorLights]
{
    @MODEL,1
    {
        @position = 0, -0.35, -0.625
    }
    @MODEL,2
    {
        @position = 0, -0.5375, -0.625
    }
}

You can have only 1 of the following:  FOR  BEFORE  AFTER  FIRST  LAST.

How to resolve this error?

[Skalou]

On 06/12/2017 at 11:35 PM, Murdabenne said:

Error with the new Module Manager: bad syntax for the Indicator Lights patch

How to resolve this error?

Oh, i didn't know of the existence of this patch!
it could be great to notify the concerned modders  @SchwinnTropius, @Snark

i'm not the author of it, but i can take a look.

[Snark]

@Murdabenne @Skalou

It looks as though what happened here is that ModuleManager just released a major new version, which broke "backwards bug compatibility".  Specifically:  There's a particular type of syntax mistake that was never intended to be "legal" in the first place... but past versions of MM were lax about enforcement.  The new MM uses more rigorous input validation, so old code that used to squeak by is now getting caught.  The fix for it is to update that old code so it stops doing the thing it was never supposed to be doing in the first place but folks didn't realize at the time. 

The error you mention has already come up for IndicatorLights Community Extensions-- you can see the discussion here:

 

...I plan to release an update for IndicatorLights Community Extensions as soon as I can, to address the matter for that particular mod.  It should be an easy fix.

In the meantime, I wouldn't be surprised if other mod authors with MM patches in their mods could run into the same issues; if they do, the fix will be similar.

[Skalou]

Thank's,

for impatient players, i suggested a fix here:
https://forum.kerbalspaceprogram.com/index.php?/topic/149567-13-indicatorlights-community-extensions-v13-compatibility-patches-for-indicatorlights/&do=findComment&comment=3240430

Edited December 10, 2017 by Skalou

[Murdabenne]

@Snark Yep - thats why I posted.  the MM "strict" mode is breaking a ton of things. For instance, nearly 300 errors come up with Allista's ConfigurableContainer mod scripts, mainly to use of FOR and AFTER.  Seems to be a common construct, probably should drop the FOR and simply make it NEEDS.  Just thought I'd let you know here as a courtesy - as well as my posts in the other threads where the actual error mods scripts originated.

Thanks for doing what you do!

[Snark]

Just an update:  I've released v1.3.1 of IndicatorLights Community Extensions, so the issues with IndicatorLights compatibility should be cleared up.  Thanks for spotting & helping with the fix, folks!

[Bit Fiddler]

would it be possible to make this hatch be more versatile by making it a surface attach part?  we could then surface attack it to any part in the editor or with KIS/KAS in flight for making a hatch into any container.

 

it would be nice if:

 

1) there were 2 versions, horizontal and vertica,l so we could mount it on top or the sides.

2) we can scale it to fit any diameter part.

3) if there is already crew space in the part just add the door and make no further modifications, however if the part has no crew space it would then add crew space of 1 kerbal. and just give it the default black IVA view so the kerbal will show up in the GUI.

 

 

4) as a side project could you update the hatches on the rest of the parts so they all match the visual styling of this hatch?  or does that require having access to the parts model in unity?  and if so, what about if you did make the surface attach part, and it was scaled slightly bigger such that it would cover the default hatches hiding them, and making the part appear to have your visual style hatch.

[Mark Kerbin]

This feels kinda grave dig, but is this mod not working for anyone else in 1.4?

[Skalou]

I can confirm the mod Mk1-Cabin-Hatch (v0.2.0) still works for KSP 1.4.x

@Bit Fiddler,good idea but not now for me, there is some parts like this in the history DLC too.

[Mark Kerbin]

@skalou

tks fam.  I was being stupid. (there was a button)

[Jesusthebird]

It bothers me that the mk2 front cockpit has only 1 hatch..on the side but the inline mk2 has 2?...?? I keep thinking about this mod when it bothers me with hopes someone feels my pain. It kinda helps

[Beetlecat]

This mod always gets some love! thanks for keeping it up to date!

[Murdabenne]

Thanks for the 1.6.1 version bump!

[Skalou]

Mk1-Cabin-Hatch  v0.2.0 still works for KSP version 1.7 and should work for many  future versions

Thanks for reporting here a new working (or not) ksp version.

Edited May 4, 2019 by Skalou

[ndiver]

I can also say that it still works fine for 1.4.5  (i'm still playing with this older version cause of mods). I downloaded it yesterday evening to try, and it works as it should.

I just react because I see the reply of Skalou few hours after i tried it for the first time.

I really like that it does not create a new part but just give the possibility to put or not a hatch on the existing one depending of your need vessel by vessel.

Edited May 4, 2019 by ndiver

[Dante80]

Just installed this via CKAN. Having the following problem. In the editor, the icon for the part clearly shows the hatch. When I try to place the part though, the texture for it is not there. The hatch is invisible, but it works if you press EVA (the kerbal seems to come out the window).

Could someone help? I'm attaching MM/KSP logs and a gamedata folder picture below.

http://www.mediafire.com/file/u1a0q74bzdulczb/logs-Dante80.zip/file

Edited October 2, 2019 by Dante80

[zer0Kerbal]

@Dante80 5 will get you 10 that ReStock is the issue. Would you try uninstalling ReStock and see if it comes home for dinner?

[Skalou]

@Dante80,

Did you tried: the option is toggleable in the editor via the part's right-click menu "add top hatch" ?

P.S: this mod still works for the KSP version 1.7.3

Edited October 7, 2019 by Skalou

[Dante80]

I'm a complete idiot, you are right.

The mod works beautifully in 1.7.3

[Omar X]

This is an excellent and much needed mod, but can someone tell me where to find it in the VAB? I can't find it anywhere.

[Corax]

8 minutes ago, Omar X said:

This is an excellent and much needed mod, but can someone tell me where to find it in the VAB? I can't find it anywhere.

Just the standard part. Right-click in the VAB/SPH to set which variant to use. IIRC it's called "Add top hatch" in the context window.

[Omar X]

On 3/8/2020 at 4:46 AM, Corax said:

Just the standard part. Right-click in the VAB/SPH to set which variant to use. IIRC it's called "Add top hatch" in the context window.

Thanks for the response, Corax. I was aware of that feature, but seems I remember using it before as a stand-alone part, that could be added to any other component, for example like the BZ-52 Attachement Point. Am I confusing it with something else?

[overkill13]

Possibly add on airlocks.  

 

[Skalou]

New version 1.0.0 available, at least compatible up to KSP v 1.9.1.

See the Change Log and the 1st post of this thread for more details.

BACKWARD COMPATIBILITY:
In previous versions older than v1.0.0 the option was toggle-able in the editor via the part's right-click menu "Add Top Hatch".
There is a compatibility patch file for the transition named "DEPRACTEDcompatibilityPatch.cfg.txt" located in "Kerbal Space Program/GameData/MK1CabinHatch", you have to rename it to "DEPRACTEDcompatibilityPatch.cfg" (remove the .txt extension at the end) to activate it. So you will have both versions of the hatch model and time to migrate your crafts and finish your running missions. Once none of your crafts have the old model you can rename the compatibility file back with the .txt extension.

 

Edited May 6, 2020 by Skalou

[Skalou]

New version 1.0.1 available,

See the Change Log and the 1st post of this thread for more details.