Jump to content

Kerbin Side Remastered [1.0.1] [1.7.3]

Eskandare

By Eskandare
in KSP1 Mod Releases

 Share

Recommended Posts

Beetlecat

Beetlecat

Posted
Posted
22 minutes ago, Kartoffelkuchen said:

@infinite_monkey Yeah, got the same issue. I installed Kerbal Konstructs 1.4.3.4, KerbinSideRemastered_0.90 and using KSP 1.4.4, but nothing has changed. Maybe an incompatibility of Kerbal Konstructs?

Kerbal Konstructs is borked in 1.4.4. The best bet is to roll back to 1.4.3 for the time being since nothing is going to get fixed until 1.4.5 releases (including Kopernicus, the *other* necessary mod for all the cool toys :) ).

 

Link to comment
Share on other sites
infinite_monkey

infinite_monkey

Posted
Posted
4 minutes ago, Beetlecat said:

Kerbal Konstructs is borked in 1.4.4. The best bet is to roll back to 1.4.3 for the time being since nothing is going to get fixed until 1.4.5 releases (including Kopernicus, the *other* necessary mod for all the cool toys :) ).

Do you happen to know when 1.4.5 is going to be released?

Link to comment
Share on other sites
Lisias

Lisias

Posted
Posted
3 hours ago, Ger_space said:

There will be no fix for ksp 1.4.4. 

I need to wait for a Bugfix within ksp. Hopefully 1.4.5 will contain that.

Could you, please, explain what's broken? This can can be useful to me.

Link to comment
Share on other sites
Ger_space

Ger_space

Posted
Posted
20 hours ago, Lisias said:

Could you, please, explain what's broken? This can can be useful to me.

The initialization of PQSCITY objects changed and would require a call of a function that is marked "protected". 

There is no way I can do that, even c# reflection will not work.

Link to comment
Share on other sites
Kartoffelkuchen

Kartoffelkuchen

Posted
Posted
On 7/19/2018 at 8:23 PM, Beetlecat said:

Kerbal Konstructs is borked in 1.4.4. The best bet is to roll back to 1.4.3 for the time being since nothing is going to get fixed until 1.4.5 releases (including Kopernicus, the *other* necessary mod for all the cool toys :) ).

 

Do you know where I can download KSP 1.4.3 (no steam version)? Would love to try this out but it doesn't seem available on the store, maybe a direct link still exists which was removed from the store?

@Ger_space Welp, that's sounds complicated... let's hope this will be fixed

Link to comment
Share on other sites
Lisias

Lisias

Posted
Posted
33 minutes ago, Kartoffelkuchen said:

Do you know where I can download KSP 1.4.3 (no steam version)?

To the best of my knowledge, there's no Forum Rules compliant way to download a previous version but the very source where you downloaded the one you are using now. I think you should contact your Store support for help.

Link to comment
Share on other sites
Lisias

Lisias

Posted
Posted (edited)
On 7/21/2018 at 2:18 AM, Ger_space said:

The initialization of PQSCITY objects changed and would require a call of a function that is marked "protected". 

There is no way I can do that, even c# reflection will not work.

I did a peek on the matter out of curiosity, and I think that you mean the Start() method, that is not only protected but also virtual. And it didn't changed from 1.4.1 (I checked on the managed DLLs from 1.4.1).

The virtual hinted me that they didn't exactly changed the initialization process - they probably unadvisedly deleted or supressed a super.Start() call somewhere, and by "luck" it didn't broke nothing on stock. Yet.

At least, it's the most common reason on the similar bugs I found in my career.

I noticed a Null Pointer happening on the pqscity.Orientate() call on the KerbalKonstruct.Core.StaticInstance.spawnObject, and so tried a polymorphism stunt: 

namespace KerbalKonstructs.Core
{
    public enum HeightReference
    {
        Unset = 0,
        Sphere = 1 ,
        Terrain = 2
    }

	public class PQSCityFixed : PQSCity
	{
		public PQSCityFixed() : base()
		{
			Log.Normal("PQSCityFixed Constructor()");
		}
		public void DoStart()
		{
			Log.Normal("PQSCityFixed DoStart()");
			this.Start();
		}
	}

//blahblahblahblahblahblahblah

    /// <summary>
    /// Spawns a new Instance in the Gameworld and registers itself to the Static Database 
    /// </summary>
    /// <param name="editing"></param>
    /// <param name="bPreview"></param>
    internal void spawnObject(Boolean editing, Boolean bPreview)
    {
        // blahblahblahblahblahblahblah
        pqsCity = gameObject.AddComponent<PQSCityFixed>(); ((PQSCityFixed)pqsCity).DoStart();

And then I got this on the log file: 

[LOG 10:18:39.567] KK: PQSCityFixed Constructor()
[LOG 10:18:39.568] KK: PQSCityFixed DoStart()
[EXC 10:18:39.568] NullReferenceException: Object reference not set to an instance of an object
	PQSCity.Orientate (Boolean allowReposition)
	PQSCity.Start ()
	KerbalKonstructs.Core.PQSCityFixed.DoStart ()
	KerbalKonstructs.Core.StaticInstance.spawnObject (Boolean editing, Boolean bPreview)
	KerbalKonstructs.KerbalKonstructs.loadInstances (.UrlConfig configurl, KerbalKonstructs.Core.StaticModel model, Boolean bSecondPass)
	KerbalKonstructs.KerbalKonstructs.LoadModelInstances ()
	KerbalKonstructs.KerbalKonstructs.Awake ()
	UnityEngine.GameObject:AddComponent(Type)
	AddonLoader:StartAddon(LoadedAssembly, Type, KSPAddon, Startup)
	AddonLoader:StartAddons(Startup)
	AddonLoader:OnLevelLoaded(GameScenes)
	AddonLoader:OnSceneLoaded(Scene, LoadSceneMode)
	UnityEngine.SceneManagement.SceneManager:Internal_SceneLoaded(Scene, LoadSceneMode)

Well… Still the same problem, so I was wrong and your assessment of the situation is accurate. But perhaps this stunt can be of use for you somehow?

— EDIT — 

Found this on 1.4.4 change log:

Quote 

* Increase PQS cache on startup and performance improvements.

I bet my mouse this is related.

 

ADDENDUM: just found this, so... Yeah. I'm brought no news.

Edited by Lisias
adding info ; better PQSCityFixed hack
Link to comment
Share on other sites
infinite_monkey

infinite_monkey

Posted
Posted
On 7/21/2018 at 3:09 PM, Kartoffelkuchen said:

Do you know where I can download KSP 1.4.3 (no steam version)? Would love to try this out but it doesn't seem available on the store, maybe a direct link still exists which was removed from the store?

Why no steam version? With steam, you can go to Beta, which allows previous versions

Link to comment
Share on other sites
Ger_space

Ger_space

Posted
Posted
13 hours ago, Lisias said:

I did a peek on the matter out of curiosity, and I think that you mean the Start() method, that is not only protected but also virtual. And it didn't changed from 1.4.1 (I checked on the managed DLLs from 1.4.1).

The virtual hinted me that they didn't exactly changed the initialization process - they probably unadvisedly deleted or supressed a super.Start() call somewhere, and by "luck" it didn't broke nothing on stock. Yet.

At least, it's the most common reason on the similar bugs I found in my career.

I noticed a Null Pointer happening on the pqscity.Orientate() call on the KerbalKonstruct.Core.StaticInstance.spawnObject, and so tried a polymorphism stunt: 


namespace KerbalKonstructs.Core
{
    public enum HeightReference
    {
        Unset = 0,
        Sphere = 1 ,
        Terrain = 2
    }

	public class PQSCityFixed : PQSCity
	{
		public PQSCityFixed() : base()
		{
			Log.Normal("PQSCityFixed Constructor()");
		}
		public void DoStart()
		{
			Log.Normal("PQSCityFixed DoStart()");
			this.Start();
		}
	}

//blahblahblahblahblahblahblah

    /// <summary>
    /// Spawns a new Instance in the Gameworld and registers itself to the Static Database 
    /// </summary>
    /// <param name="editing"></param>
    /// <param name="bPreview"></param>
    internal void spawnObject(Boolean editing, Boolean bPreview)
    {
        // blahblahblahblahblahblahblah
        pqsCity = gameObject.AddComponent<PQSCityFixed>(); ((PQSCityFixed)pqsCity).DoStart();

And then I got this on the log file: 


[LOG 10:18:39.567] KK: PQSCityFixed Constructor()
[LOG 10:18:39.568] KK: PQSCityFixed DoStart()
[EXC 10:18:39.568] NullReferenceException: Object reference not set to an instance of an object
	PQSCity.Orientate (Boolean allowReposition)
	PQSCity.Start ()
	KerbalKonstructs.Core.PQSCityFixed.DoStart ()
	KerbalKonstructs.Core.StaticInstance.spawnObject (Boolean editing, Boolean bPreview)
	KerbalKonstructs.KerbalKonstructs.loadInstances (.UrlConfig configurl, KerbalKonstructs.Core.StaticModel model, Boolean bSecondPass)
	KerbalKonstructs.KerbalKonstructs.LoadModelInstances ()
	KerbalKonstructs.KerbalKonstructs.Awake ()
	UnityEngine.GameObject:AddComponent(Type)
	AddonLoader:StartAddon(LoadedAssembly, Type, KSPAddon, Startup)
	AddonLoader:StartAddons(Startup)
	AddonLoader:OnLevelLoaded(GameScenes)
	AddonLoader:OnSceneLoaded(Scene, LoadSceneMode)
	UnityEngine.SceneManagement.SceneManager:Internal_SceneLoaded(Scene, LoadSceneMode)

Well… Still the same problem, so I was wrong and your assessment of the situation is accurate. But perhaps this stunt can be of use for you somehow?

— EDIT — 

Found this on 1.4.4 change log:

I bet my mouse this is related.

it is reladed to the changes. I talked with a helpfull KSP Developer about the problem. He said that KSP 1.4.5 will contain a bugfix for it, so im patently waiting until it is released. If its then still not working, i will start digging deeper into it. 

Link to comment
Share on other sites
CJagd

CJagd

Posted
Posted
On 4/27/2018 at 6:51 PM, damonvv said:

Wwhsq40.png      qsroR57.png

5Bogc4D.png

Thank you very much for these! Fits perfectly in my KSC!

Is there a way to have a file or a folder with all this setup? Kind of like the KSR Airport mod ?
I'm just unable to recreate this awesome base.

Link to comment
Share on other sites
Damon

Damon

Posted
Posted
2 hours ago, CJagd said:

Is there a way to have a file or a folder with all this setup? Kind of like the KSR Airport mod ?
I'm just unable to recreate this awesome base.

I mean I did better.. but lost the files sadly :( 
bOTlrR1.png

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...