[1.4.3 <= KSP <= 1.12.5] KSP Recall - 0.4.1.0- 2024-0407

[GoAHead]

2 hours ago, damerell said:

I've experienced similar problems in 0.2.2.4 - both the inability to save and dysfunctional pause menu. I regret I can't provide logs right now, but I'm posting since it seems worth mentioning I do _not_ have the PartFX dll mentioned. The string "PartFX" does not appear in my KSP.log and I have no file whose name matches "PartFX" in GameData.

PartFX is  the dll which is used by EVE

[GoAHead]

@Lisiasi can send you my ckan  mod export file with a proper savegame so you should have the same testing condidions. crazy idea?

let me know

[Lisias]

17 minutes ago, GoAHead said:

PartFX is  the dll which is used by EVE

So it's highly improbable it's related to the problem

So, right now, AttachedOnEditor is the prime suspect for the problem - what's really bugs me, because I used that damned thing for a month.  

 

2 minutes ago, GoAHead said:

@Lisiasi can send you my ckan  mod export file with a proper savegame so you should have the same testing condidions. crazy idea?

let me know

Not at all! It will help a lot!

 

1 hour ago, Poppa Wheelie said:

Do you need new logs or ModuleManager.ConfigCache?

Not this time, with the add'ons installed and the savegame, the ConfigCache will be similar. Thnks!

Edited June 28, 2022 by Lisias
Brute force post merge.

[GoAHead]

@Lisias the following link should open the folder where you can find the needed stuff => FOLDER

when using the ckan installer file make sure to allow older versions to be installed. some mods got never updated but still working well. the lowest version  of a mod called  Textures Unlimited = 1.4.3

Following described what i did to reproduce the bug

• load the savegame  and switch to WOLF-LKW located  on the mun
• (optional cause i'm not sure if this initially triggers it) open the Bon Voyage Controller located on the Vessels top of Cockpit (doesn't open)
• Use the Targetron to switch to another Vessel (doesn't work)
• open  up  the menue (ESC) try to Save or exit (doesn't work)
• open Up the loading Savegames Mod hitting F9 works loading the save but doesn't help in this case

anyway you will only be able to kill it with fire (Taskmanager)

 

let me know if anything else is needed

 

Update: i guess it would help to get rid of mods such like parallax cause they are big in size (1.8GB) .. i do not assume it would cause the issue

 

Edited June 28, 2022 by GoAHead

[AmanitaVerna]

This is probably unrelated, because I was running KSP 0.2.2.3 at the time, but on June 18th, I also experienced an inability to save, switch scene, or exit the game, but only once (edit: to be clear, no matter how many times I clicked any of those buttons, they didn't work. It just hasn't happened again since I force-killed the game with task manager). I haven't experienced it again since. I'm still playing the same saved game I was playing then. I updated to 0.2.2.4 on June 25 and to 0.3.0.0 on June 26.

I noticed that I am missing some of the DLLs in the list you posted, which, if one of them is doing the thing, that could be why I didn't run into any problems after updating KSP Recall to 0.2.2.4. These are the ones I don't have:

Scale_Redist v1.0.0.0 / v2.4.6.15
KAS-API-v2 v2.0.7239.35367 / vKAS API v2
KAS v1.11.8189.42072 / v1.11 for KSP v1
KSPDev_Utils.2.7 v2.7.0.0 / v2.7 for KSP v1
KerbalEngineer.Unity v1.0.0.0
KerbalEngineer v1.1.9.0
KSPDev_Utils.2.6 v2.6.7847.1936 / v2.6 for KSP v1
KSPe.Light.TweakScale v2.4.1.15
Scale v2.4.6.15
KSP-AVC v0.0.0.1

(I do have KSP-AVC v1.4.1.9)

Except for KSP-AVC, I don't have any version of any of those.

Edited June 29, 2022 by AmanitaVerna

[Lisias]

1 hour ago, GoAHead said:

Update: i guess it would help to get rid of mods such like parallax cause they are big in size (1.8GB) .. i do not assume it would cause the issue

As  a matter of fact...

Recently I reworked KSP-Recall and TweakScale to cope with one of the most weirds problem I ever got on KSP.

https://github.com/net-lisias-ksp/KSP-Recall/issues/45 (currently on Recall 0.3 , under test before going to SpaceDock)

https://github.com/net-lisias-ksp/TweakScale/issues/256 (currently on 2.5 Beta only)

TL;DR: We have concurrency on KSP, no matter what anyone else says to you.

Before Making History, we had the following Status Quo on KSP:

1. Everything that needed to be loaded, it's loaded on LOADING Scene. Surprisingly, uh?
2. Once you get into Main Menu, no more loading was done - everything was already in memory and registered on the GameDatabase (or prefab)

So the Main Menu was an excellent place to shove Sanity Checks, last minute configurations or to update your own modules with data not reliably accessible on the LOADING scene (for example, TweakScale could not be sure about calculating costs from other modules at LOADING because any module those name is alphabetically sorted after TweakScale was not instantiated yet!).

However, Making History screwed up the zeitgeist by loading some of its assets and parts on Main Menu, changing the GameDatabase. Even worse, apparently this is being made on a different thread (real thread), as the Sanity Checks from TweakScale (and later, Recall) were borking while trying to access some data on the GameDatabase, like this:

[LOG 17:37:15.783] [TweakScale] ERROR: part=Interstellar-Technologies.AM-Catalyzed-ICFE-Afterburning (KSPIT KN-162 Afterburning AM Cat ICFE) Exception on Sanity Che
  at ConfigNode.CopyToRecursive (ConfigNode node, System.Boolean overwrite) [0x00000] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0
  at ConfigNode.CopyToRecursive (ConfigNode node, System.Boolean overwrite) [0x0014a] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0
  at ConfigNode.CopyToRecursive (ConfigNode node, System.Boolean overwrite) [0x0014a] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0
  at ConfigNode.CreateCopy () [0x00006] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0
  at GameDatabase.GetConfigNode (System.String url) [0x0002f] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0
  at TweakScale.PrefabDryCostWriter.GetMeThatConfigNode (Part p) [0x0002a] in <a9032097ee634581808fefb223046629>:0
  at TweakScale.PrefabDryCostWriter.checkForOverrules (Part p) [0x00000] in <a9032097ee634581808fefb223046629>:0
  at TweakScale.PrefabDryCostWriter+<WriteDryCost>d__3.MoveNext () [0x00417] in <a9032097ee634581808fefb223046629>:0  at error:0

And I found the exact Exception signature on your last KSP.log.

The solution I found to this problem is to start a CoRoutine that would keep calculating the size of the GameDatabase waiting it to stop growing (as it was being repopulated by Making History with new data), and then skips some additional tens of frames. And this dirty trick worked  - until the user started to overload the rig...

When you overload your rig, Unity starts to skips frames in a (desperate) attempt to keep the game minimally useable. And guess where the CoRoutines are hooked? Yeah, on the frames. So KSP by skipping frames, was skipping also the CoRoutines tied to the frame, and what happens so? At least two terrible things (not mutually exclusive):

• The Making History somehow is delayed to after the Sanity Checks kicks in, essentially reverting to that nasty situation I got in 2018 when Making History was released
  • On a way more unforgiving environment, see below
• The Sanity Checks take so much time to start to run that the user is able to start a game before it's concluded!!!

And both situations, by themselves, completely screws up the prefab - and the consequences are essentially unpredictable - anything goes. 

Before KSP 1.8, things are slightly less worse because a lot of safeties were coded on key places of KSP (that try-catch thingy I once talked about). On KSP 1.8, apparently, these things were being removed to improve performance (you can expect from 5 to 10% of performance improvement by removing try-catches from loops!) but that came with a cost: major screw ups from add'ons will not only cause a huge drop on the framerate, they now kills the running thread - leaving a lot of unfinished business behind.

And these unfinished business will lead a lot of guys to bork (not only TweakScale) including Stock. EVERYBODY relies on a sane and intact GameDatabase in order to correctly do their business! (Garbage In, Garbage Out!).

And this can be a plausible explanation for the reason I didn't experienced this problem on my testings - I don't overload my rig (what's something prety easy to do, that damned thing is a Mac Potato!), any sligheslty heavier add'on and I got 4 to 6 fps, unplayable!  (I managed to drop the fps down to 0.76 once, just to see how low I could reach!).

Somehow, Recall 0.2.2.4 was the straw that broke the camel's back. If I'm right, and I have a reasonable confidence I am, you will have your problem fixed by:

1.  Installing the latest KSP-Recall (0.3.0.0 at this time) manually
   1.  https://github.com/net-lisias-ksp/KSP-Recall/releases
2. installing the latest TweakScale Beta (2.5.0.46) manually
   1. https://github.com/net-lisias-ksp/TweakScale/releases
   2. hard dependency (you need to install the latest one)
      1.  https://github.com/net-lisias-ksp/KSPe/releases

Completely backup all your KSP installment before doing it, just in case. This last TS Beta is stable enough (it is where I check new features before backporting them to the 2.4.x.x. production series), but not everything on it is finished and good to go gold yet. On the bright side, I repeatedly switch between 2.5.x.x and 2.4.x.x. on my testbeds and it's almost a year since the last time I got a problem by doing that.

But better safe than sorry, backup the whole thing and assume that the Beta will format your hard drive if you fart while playing.

WARNING

To everybody else that are not having problems, please do not try TS Beta - unless on disposable savegames. I try some crazy things on Beta now and then, and some of that crazy things eventually bite.

— — — (I just got notified by this post while writing the wall of text above! — — — 

Just now, AmanitaVerna said:

This is probably unrelated, because I was running KSP 0.2.2.3 at the time, but on June 18th, I also experienced an inability to save, switch scene, or exit the game, but only once. I haven't experienced it again since. I'm still playing the same saved game I was playing then. I updated to 0.2.2.4 on June 25 and to 0.3.0.0 on June 26.

I noticed that I am missing some of the DLLs in the list you posted, which, if one of them is doing the thing, that could be why I didn't run into any problems after updating KSP Recall to 0.2.2.4. These are the ones I don't have:

<BAITA CUT>

Don't worry, that DLLs are 100% innocent as it appears. At that time, it was my only shot. I will edit that post to avoid further confusion.

The wall of text above explains my current working theory, and what you said about experiencing the problem once on 0.2.2.3 apparently support my thesis - by running side tasks on the computer (as browsers - Facebook is terrible on my rig, I need to close Facebook to play KSP most of the time!), your KSP can get temporarily overloaded and start to skip frames, and the we have the situation I described above!

[ss8913]

so following a previous suggestion I have reverted to 0.2.2.3 - in 0.2.2.4 which was installed by ckan on 6/27/2022, after a few minutes of play I am unable to save any games, and autosave isn't working either.  F5 doesn't work, alt-F5 manual save causes the entire game to crash, plus when this happens I cannot go back to tracking station/space center - seems like the bug y'all are talking about.  My log is full of this when I try any of these operations:

 

[EXC 19:43:20.256] ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
    System.ThrowHelper.ThrowArgumentOutOfRangeException (System.ExceptionArgument argument, System.ExceptionResource resource) (at <9577ac7a62ef43179789031239ba8798>:0)
    System.ThrowHelper.ThrowArgumentOutOfRangeException () (at <9577ac7a62ef43179789031239ba8798>:0)
    KSP_Recall.AttachedOnEditor.AttachedOnEditor.SaveTo (ConfigNode node) (at <efe4553404694f348ee12b5243575982>:0)
    KSP_Recall.AttachedOnEditor.AttachedOnEditor.OnSave (ConfigNode node) (at <efe4553404694f348ee12b5243575982>:0)
    PartModule.Save (ConfigNode node) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoPartModuleSnapshot..ctor (PartModule module) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel, System.Boolean preCreate) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoVessel..ctor (Vessel VesselRef, System.Boolean preCreate) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoVessel..ctor (Vessel VesselRef) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    Vessel.BackupVessel () (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    FlightState..ctor () (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    Game.Updated (GameScenes startSceneOverride) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    GamePersistence.SaveGame (System.String saveFileName, System.String saveFolder, SaveMode saveMode, GameScenes startScene) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    GamePersistence.SaveGame (System.String saveFileName, System.String saveFolder, SaveMode saveMode) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    FlightAutoSave+<PersistentSave>d__6.MoveNext () (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <12e76cd50cc64cf19e759e981cb725af>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)
[EXC 19:43:58.506] ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.

[GoAHead]

@Lisias i will check your betas today after my business hours.

it was fun to read your last post and get some technically insights

have a great day

[Krazy1]

Me too @Lisias. As you said, all bets are off and the symptoms are weird... it starts obviously misbehaving when I "jump to ship" from a KAC alarm. Then it's stuck in a loop redrawing the dV in the lower left of the flight screen. I can't go to space center, tracking station or main menu but I can load a saved game, but it doesn't actually recover to normal. Same message:

Spoiler

[EXC 21:25:26.074] ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
    System.ThrowHelper.ThrowArgumentOutOfRangeException (System.ExceptionArgument argument, System.ExceptionResource resource) (at <9577ac7a62ef43179789031239ba8798>:0)
    System.ThrowHelper.ThrowArgumentOutOfRangeException () (at <9577ac7a62ef43179789031239ba8798>:0)
    KSP_Recall.AttachedOnEditor.AttachedOnEditor.SaveTo (ConfigNode node) (at <efe4553404694f348ee12b5243575982>:0)
    KSP_Recall.AttachedOnEditor.AttachedOnEditor.OnSave (ConfigNode node) (at <efe4553404694f348ee12b5243575982>:0)
    PartModule.Save (ConfigNode node) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoPartModuleSnapshot..ctor (PartModule module) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel, System.Boolean preCreate) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoVessel..ctor (Vessel VesselRef, System.Boolean preCreate) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoVessel..ctor (Vessel VesselRef) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    Vessel.BackupVessel () (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    FlightState..ctor () (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    Game.Updated (GameScenes startSceneOverride) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    Game.Updated () (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    FlightDriver+<PostInit>d__34.MoveNext () (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <12e76cd50cc64cf19e759e981cb725af>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

KSP log

player log

MMconfigcache

I have about 60 mods, so not lightweight. I'll see if I have time to beta test, maybe this weekend. Good luck with the Mac Potato. 

[Robhar174]

16 hours ago, Lisias said:

Please send me your KSP.log and the ModuleManager.ConfigCache. No need to reinstall the newer Recall, as I already know what to look and I don't need the problem happening anymore.

 

Sorry to ask again but exactly how? (cut and paste doesn't work)

[Robhar174]

2 hours ago, Krazy1 said:

Me too @Lisias. As you said, all bets are off and the symptoms are weird... it starts obviously misbehaving when I "jump to ship" from a KAC alarm. Then it's stuck in a loop redrawing the dV in the lower left of the flight screen. I can't go to space center, tracking station or main menu but I can load a saved game, but it doesn't actually recover to normal. Same message:

  Reveal hidden contents

[EXC 21:25:26.074] ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
    System.ThrowHelper.ThrowArgumentOutOfRangeException (System.ExceptionArgument argument, System.ExceptionResource resource) (at <9577ac7a62ef43179789031239ba8798>:0)
    System.ThrowHelper.ThrowArgumentOutOfRangeException () (at <9577ac7a62ef43179789031239ba8798>:0)
    KSP_Recall.AttachedOnEditor.AttachedOnEditor.SaveTo (ConfigNode node) (at <efe4553404694f348ee12b5243575982>:0)
    KSP_Recall.AttachedOnEditor.AttachedOnEditor.OnSave (ConfigNode node) (at <efe4553404694f348ee12b5243575982>:0)
    PartModule.Save (ConfigNode node) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoPartModuleSnapshot..ctor (PartModule module) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel, System.Boolean preCreate) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoPartSnapshot..ctor (Part PartRef, ProtoVessel protoVessel) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoVessel..ctor (Vessel VesselRef, System.Boolean preCreate) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    ProtoVessel..ctor (Vessel VesselRef) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    Vessel.BackupVessel () (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    FlightState..ctor () (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    Game.Updated (GameScenes startSceneOverride) (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    Game.Updated () (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    FlightDriver+<PostInit>d__34.MoveNext () (at <39c0323fb6b449a4aaf3465c00ed3c8d>:0)
    UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <12e76cd50cc64cf19e759e981cb725af>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

KSP log

player log

MMconfigcache

I have about 60 mods, so not lightweight. I'll see if I have time to beta test, maybe this weekend. Good luck with the Mac Potato. 

Did you try undocking? The results were spectacular

[Robhar174]

47 minutes ago, Robhar174 said:

 

Sorry to ask again but exactly how? (cut and paste doesn't work)

Or do you have enough material?

[Lisias]

11 hours ago, ss8913 said:

so following a previous suggestion I have reverted to 0.2.2.3 - in 0.2.2.4 which was installed by ckan on 6/27/2022, after a few minutes of play I am unable to save any games, and autosave isn't working either.  F5 doesn't work, alt-F5 manual save causes the entire game to crash, plus when this happens I cannot go back to tracking station/space center - seems like the bug y'all are talking about. 

Yeah, definitively  0.2.2.4 was the straw that broke the camel's back on some rigs...

Keep 0.2.2.3 for some time, or fast forward to 0.3.0.0 (on github and curseforge).

 

7 hours ago, Robhar174 said:

Or do you have enough material?

Send me just the KSP.log after reproducing the problem to have confirmation (see the Krazy1 case below). It's not that uncommon that the same issue ends up being triggered by something else (think on the same weak point being exploited by two different attackers). It's hopefully the same, tough.

Oh, I almost forgot: use dropbox, google drive or even post the log on a comment on this discussion (if you have an old enough account - my repos were being littered recently and I had to do some harsh measures):

https://github.com/net-lisias-ksp/KSP-Recall/discussions/46

 

9 hours ago, Krazy1 said:

Me too @Lisias. As you said, all bets are off and the symptoms are weird... it starts obviously misbehaving when I "jump to ship" from a KAC alarm. Then it's stuck in a loop redrawing the dV in the lower left of the flight screen. I can't go to space center, tracking station or main menu but I can load a saved game, but it doesn't actually recover to normal.

Weirdly enough, apparently the source for your headaches are being triggered by another land-mine:

[ERR 21:23:53.867] [ScienceSubject] - Error in converting Situation InSpaceHigh_System.ArgumentException: Requested value 'InSp
  at System.Enum+EnumResult.SetFailure (System.Enum+ParseFailureKind failure, System.String failureMessageID, System.Object fai
  at System.Enum.TryParseEnum (System.Type enumType, System.String value, System.Boolean ignoreCase, System.Enum+EnumResult& pa
  at System.Enum.Parse (System.Type enumType, System.String value, System.Boolean ignoreCase) [0x00010] in <9577ac7a62ef4317978
  at System.Enum.Parse (System.Type enumType, System.String value) [0x00000] in <9577ac7a62ef43179789031239ba8798>:0
  at ScienceUtil.GenerateLocalizedTitle (System.String id, System.Boolean skipAsteroidsComets) [0x0019e] in <39c0323fb6b449a4aa

I see no evidences of misbehaviour from Recall  and/or TweakScale on your rig - and both had concluded their business without problems:

[LOG 21:20:45.180] [KSP_Recall] INFO: SanityCheck Concluded : 605 parts found ; 0 parts using Resourceful ; 0 parts using Driftless ; 0 parts using Attached ; 0 parts using ChillingOut ; 0 parts using RefundingForKSP111x, 595 parts using AttachedOnEditor, 0 show stoppers detected .
<CUT>
[LOG 21:20:45.265] [TweakScale] INFO: WriteDryCost Concluded : 605 parts found ; 0 checks failed ; 0 parts with hotfixes ; 0 parts with issues overruled ; 0 Show Stoppers found; 0 Sanity Check failed; 124 unscalable parts.

Oh well, now we have an evidence that Recall 0.2.2.4 may be involved on the problem, but it's not causing it! At least in your case, your log is sensibly different from the others (other than having - besides a lot of others - one same problem, the ArgumentOutOfRangeException stunt).

You know what? I'm starting to think that Recall may be innocent after all… Your log is suggesting that whatever I did on 0.2.2.4 was just triggering the problem more frequently (I have at least one occurrence registered above on 0.2.2.3).

We may be dealing with a bigger issue, after all...

Edited June 29, 2022 by Lisias
better phrasing

[arkaik]

On 6/27/2022 at 7:04 PM, Lisias said:

The bug reported by MgnfcntBstrd was related to Procedural Parts. In a nutshell, every part must have some data available on the Config when a thingy called PartModule calls the Load Method. One of these data are the Attachment Nodes, and without the attachment nodes, KSP doesn't knows how to slap parts together.

Some part sets, however, don't follow this protocol, and they update these data at runtime after the PartModule calls the Load, and by this time, it's too late for some situations (as KSP-Recall that needs that data available on the OnLoad!!!).

So I made a patch for PP (you can see it here) that would scavenge the needed data from other sections of the file and build the attachment nodes myself, so the information could be available at OnLoad for Recall.

And this solved the problem, what means that I was right.

I'm guessing that some part on your rig have the same problem.

In order to check for it, I will need your KSP.log and also the ModuleManager.configcache. The information I need are there - I'm currently out of time to do exploratory tests by myself (day job is bitting!), so the fastest way for diagnosing the problem is by looking into your files.

 

I'm guessing this is the same problem again. Can you send me your KSP.log and ModuleManager.configcache?

 

Oukey…. We have a bug-fest around here. Can you send me the ModuleManager.ConfigCache too? With three different people complaining about the same problem, having the 3 different ConfigCache will help me to detect coincidences, and it will make my life sensibly easier!

Sorry for the late response! I'm glad to see that there is progress in finding out the culprit. I'm linking my KSP log and ModuleManager log, hopefully these help to narrow down the culprit.

I cloned an instance of my main game through CKAN to test these. For these I basically did the same thing that I had done before, which was:

-Update KSP Recall to 2.2.4

-Launch game, load main save

-Click Tracking Station, move to vessel

-Click on Menu and click the Space Center/Tracking Station button, which did not work

This is the link containing the logs up to the last step previously mentioned, if I have missed anything let me know, this is my first time asking for support in the forums so please bear with me

https://drive.google.com/drive/folders/1fnRa0rplB9Cn8uHe6mSya0yVU0abJqi9?usp=sharing

[GoAHead]

@Lisiasi'm sorry to  say the beta didn't worked for me

• did a complete copy of the current instance
• deleted all old versions of twekscale recall and other stuff which is within the new beta downloads

i installed:

1.  Installing the latest KSP-Recall (0.3.0.0 at this time) manually
   1.  https://github.com/net-lisias-ksp/KSP-Recall/releases
2. installing the latest TweakScale Beta (2.5.0.46) manually
   1. https://github.com/net-lisias-ksp/TweakScale/releases
   2. hard dependency (you need to install the latest one)
      1.  https://github.com/net-lisias-ksp/KSPe/releases

new KSP.log and configCache are within my public folder / BetaTest => https://1drv.ms/u/s!Am0PDmGqv17_hKpOqPRyuaODwZc86w?e=KBfEdd

:-(

Edited June 29, 2022 by GoAHead

[AmanitaVerna]

I have noticed InSpaceHigh_ exceptions in my player.log as well, though I didn't notice any problems as a result, so I doubt they're related to this issue. I wonder if they're coming from the asteroid samples I have on two ships docked to two asteroids in Kerbin's orbit? They have ids like "asteroidSample@KerbinInSpaceHigh_PotatoRoid61388568" and the exceptions only showed up when going to the space center or editor scenes, and I can't find "InSpaceHigh_" anywhere else in any *.cfg, *.sfs, or *.craft files in my KSP folder.

[HighLogic]: =========================== Scene Change : From MAINMENU to SPACECENTER (Async) ===================== 

...

[SceneLoadSpeedBoost] Save loaded from disk in 888ms 

...

Loading Planet Nodes 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

PlanetNodeCount:  2 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

[ScienceSubject] - Error in converting Situation InSpaceHigh_System.ArgumentException: Requested value 'InSpaceHigh_' was not found.
  at System.Enum+EnumResult.SetFailure (System.Enum+ParseFailureKind failure, System.String failureMessageID, System.Object failureMessageFormatArgument) [0x00023] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.TryParseEnum (System.Type enumType, System.String value, System.Boolean ignoreCase, System.Enum+EnumResult& parseResult) [0x0017a] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.Parse (System.Type enumType, System.String value, System.Boolean ignoreCase) [0x00010] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.Parse (System.Type enumType, System.String value) [0x00000] in <9577ac7a62ef43179789031239ba8798>:0 
  at ScienceUtil.GenerateLocalizedTitle (System.String id, System.Boolean skipAsteroidsComets) [0x0019e] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0  
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

[ScienceSubject] - Error in converting Situation InSpaceHigh_System.ArgumentException: Requested value 'InSpaceHigh_' was not found.
  at System.Enum+EnumResult.SetFailure (System.Enum+ParseFailureKind failure, System.String failureMessageID, System.Object failureMessageFormatArgument) [0x00023] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.TryParseEnum (System.Type enumType, System.String value, System.Boolean ignoreCase, System.Enum+EnumResult& parseResult) [0x0017a] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.Parse (System.Type enumType, System.String value, System.Boolean ignoreCase) [0x00010] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.Parse (System.Type enumType, System.String value) [0x00000] in <9577ac7a62ef43179789031239ba8798>:0 
  at ScienceUtil.GenerateLocalizedTitle (System.String id, System.Boolean skipAsteroidsComets) [0x0019e] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0  
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

[ScenarioDestructibles]: Loading... 0 objects registered 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)
    
...

[HighLogic]: =========================== Scene Change : From SPACECENTER to EDITOR (Async) ===================== 

...
    
------------------- initializing editor mode... ------------------ 

...


Loading Planet Nodes 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

PlanetNodeCount:  2 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

[ScienceSubject] - Error in converting Situation InSpaceHigh_System.ArgumentException: Requested value 'InSpaceHigh_' was not found.
  at System.Enum+EnumResult.SetFailure (System.Enum+ParseFailureKind failure, System.String failureMessageID, System.Object failureMessageFormatArgument) [0x00023] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.TryParseEnum (System.Type enumType, System.String value, System.Boolean ignoreCase, System.Enum+EnumResult& parseResult) [0x0017a] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.Parse (System.Type enumType, System.String value, System.Boolean ignoreCase) [0x00010] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.Parse (System.Type enumType, System.String value) [0x00000] in <9577ac7a62ef43179789031239ba8798>:0 
  at ScienceUtil.GenerateLocalizedTitle (System.String id, System.Boolean skipAsteroidsComets) [0x0019e] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0  
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

[ScienceSubject] - Error in converting Situation InSpaceHigh_System.ArgumentException: Requested value 'InSpaceHigh_' was not found.
  at System.Enum+EnumResult.SetFailure (System.Enum+ParseFailureKind failure, System.String failureMessageID, System.Object failureMessageFormatArgument) [0x00023] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.TryParseEnum (System.Type enumType, System.String value, System.Boolean ignoreCase, System.Enum+EnumResult& parseResult) [0x0017a] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.Parse (System.Type enumType, System.String value, System.Boolean ignoreCase) [0x00010] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.Parse (System.Type enumType, System.String value) [0x00000] in <9577ac7a62ef43179789031239ba8798>:0 
  at ScienceUtil.GenerateLocalizedTitle (System.String id, System.Boolean skipAsteroidsComets) [0x0019e] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0  
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

[ScenarioDestructibles]: Loading... 0 objects registered 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

...

[HighLogic]: =========================== Scene Change : From EDITOR to SPACECENTER ===================== 

...

Loading Planet Nodes 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

PlanetNodeCount:  2 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

[ScienceSubject] - Error in converting Situation InSpaceHigh_System.ArgumentException: Requested value 'InSpaceHigh_' was not found.
  at System.Enum+EnumResult.SetFailure (System.Enum+ParseFailureKind failure, System.String failureMessageID, System.Object failureMessageFormatArgument) [0x00023] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.TryParseEnum (System.Type enumType, System.String value, System.Boolean ignoreCase, System.Enum+EnumResult& parseResult) [0x0017a] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.Parse (System.Type enumType, System.String value, System.Boolean ignoreCase) [0x00010] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.Parse (System.Type enumType, System.String value) [0x00000] in <9577ac7a62ef43179789031239ba8798>:0 
  at ScienceUtil.GenerateLocalizedTitle (System.String id, System.Boolean skipAsteroidsComets) [0x0019e] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0  
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

[ScienceSubject] - Error in converting Situation InSpaceHigh_System.ArgumentException: Requested value 'InSpaceHigh_' was not found.
  at System.Enum+EnumResult.SetFailure (System.Enum+ParseFailureKind failure, System.String failureMessageID, System.Object failureMessageFormatArgument) [0x00023] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.TryParseEnum (System.Type enumType, System.String value, System.Boolean ignoreCase, System.Enum+EnumResult& parseResult) [0x0017a] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.Parse (System.Type enumType, System.String value, System.Boolean ignoreCase) [0x00010] in <9577ac7a62ef43179789031239ba8798>:0 
  at System.Enum.Parse (System.Type enumType, System.String value) [0x00000] in <9577ac7a62ef43179789031239ba8798>:0 
  at ScienceUtil.GenerateLocalizedTitle (System.String id, System.Boolean skipAsteroidsComets) [0x0019e] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0  
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

[ScenarioDestructibles]: Loading... 0 objects registered 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

 

[Lisias]

2 hours ago, GoAHead said:

@Lisiasi'm sorry to  say the beta didn't worked for me

Damn. So I'm back to something wrong on upgrading from 0.2.2.3 to 0.2.2.4 . 0.3.0.0 uses the same Module version as 0.2.2.4.

Revert back to 0.2.2.3 and get rid of the TSBeta.

Damn, we have TWO different problems happening on the same time.

One of the problems appears to be related to that overload rig losing frames.

The other appears to be something wrong on the AttachedOnEditor "migrating tool". I think this one is the one causing most problems now.

I will work on it tonight.

Edited June 29, 2022 by Lisias
Hit "Save" too soon.

[Lisias]

3 hours ago, AmanitaVerna said:

I have noticed InSpaceHigh_ exceptions in my player.log as well, 

@AmanitaVerna, I need the full KSP.log . As it appears, we have TWO different types of problems, and they are not mutually exclusive . I need the full log to check where else things are borking (and what it's installed).

additionally… Posting long cuts of the log on forum overloads it - I could not answer you soon because I was unable to edit a post with all that text on my mobile! 

Apparenltly you are getting the Skipping Frame problem. Try to install Recall 0.3.0.0 to see if anything changes - if you are using TweakScale, try the 2.5 beta.

 

3 hours ago, GoAHead said:

@Lisiasi'm sorry to  say the beta didn't worked for meI had this crazy idea, let's see what happens:

Thank you very much for your logs.

That's the problem: I think Recall is innocent on your case. You see this entry?

[LOG 19:51:53.103] [TweakScale.Sanitizer] ERROR: part=Interstellar-Technologies.AM-Catalyzed-ICFE-Afterburning (KSPIT KN-162 Af
  at ConfigNode.CopyToRecursive (ConfigNode node, System.Boolean overwrite) [0x00000] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0
  at ConfigNode.CopyToRecursive (ConfigNode node, System.Boolean overwrite) [0x0014a] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0
  at ConfigNode.CopyToRecursive (ConfigNode node, System.Boolean overwrite) [0x0014a] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0
  at ConfigNode.CreateCopy () [0x00006] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0
  at GameDatabase.GetConfigNode (System.String url) [0x0002f] in <39c0323fb6b449a4aaf3465c00ed3c8d>:0
  at TweakScale.Sanitizer.Abstract.GetMeThatConfigNode (Part p) [0x0002a] in <b3d0cbc25641492b91ba97c2ac25adf8>:0
  at TweakScale.Sanitizer.HotFixes.CheckForHotFixes (Part p) [0x00000] in <b3d0cbc25641492b91ba97c2ac25adf8>:0
  at TweakScale.Sanitizer.HotFixes.DoCheck (AvailablePart p, Part prefab) [0x00002] in <b3d0cbc25641492b91ba97c2ac25adf8>:0  at

This is happening BEFORE the Main Menu, because TweakScale beta do it's business on the Scene Change - and it does it at once, on the same "frame" so, nope, this time I'm not guilty of trying concurrency stunts. Something is very wrong on your rig way before the Main Menu.

Recall 0.3.0.0. on the other hand, didn't borked at all:

[LOG 19:51:53.605] [KSP_Recall] INFO: SanityCheck: Started
[LOG 19:51:53.606] [KSP_Recall] INFO: Removing AttachedOnEditor support for kerbalEVA () due this part is not supported..
[LOG 19:51:53.606] [KSP_Recall] INFO: Removing AttachedOnEditor support for kerbalEVAfemale () due this part is not supported..
[LOG 19:51:53.606] [KSP_Recall] INFO: Removing AttachedOnEditor support for kerbalEVAVintage () due this part is not supported..
[LOG 19:51:53.606] [KSP_Recall] INFO: Removing AttachedOnEditor support for kerbalEVAfemaleVintage () due this part is not supported..
[LOG 19:51:53.606] [KSP_Recall] INFO: Removing AttachedOnEditor support for kerbalEVASlimSuit () due this part is not supported..
[LOG 19:51:53.606] [KSP_Recall] INFO: Removing AttachedOnEditor support for kerbalEVASlimSuitFemale () due this part is not supported..
[LOG 19:51:53.621] [KSP_Recall] INFO: SanityCheck Concluded : 5565 parts found ; 0 parts using Resourceful ; 0 parts using Driftless ; 0 parts using Attached ; 0 parts using ChillingOut ; 0 parts using RefundingForKSP111x, 5541 parts using AttachedOnEditor, 0 show stoppers detected .
[LOG 19:51:53.622] [HighLogic]: =========================== Scene Change : From LOADING to MAINMENU =====================

Flawless.

So, in your case at least, Recall and TweakScale are only inocent bystanders being hit by the splash damage and yelling about.

I'm trying to reproduce your installment here to see what I get.

Edited June 29, 2022 by Lisias
Brute Force post merge.

[AmanitaVerna]

10 minutes ago, Lisias said:

@AmanitaVerna, I need the full KSP.log . As it appears, we have TWO different types of problems, and they are not mutually exclusive . I need the full log to check where else things are borking (and what it's installed).

additionally… Posting long cuts of the log on forum overloads it - I could not answer you soon because I was unable to edit a post with all that text on my mobile! 

Apparenltly you are getting the Skipping Frame problem. Try to install Recall 0.3.0.0 to see if anything changes - if you are using TweakScale, try the 2.5 beta.

Sorry about that, I had no idea that could happen.

Here's the full KSP.log and player.log from that session, in a .7z file: https://1drv.ms/u/s!AlnEemcsDL9XlcoKdERS2lNAhK50yA?e=Xu25AM

I can upload them in a zip file instead if you need, but it ended up being twice as large (not that it's all that large).

I'm already using Recall 0.3.0.0, and I don't use TweakScale (since I use Kerbalism, which doesn't play nice with it). I have some other exceptions in my logs but I don't think any of them are related to Recall, and as I mentioned in my previous post, I've only had the inability to save/switch scenes/exit/etc problem happen once, a couple weeks ago, when I was still running Recall 0.2.2.3.

[Lisias]

4 hours ago, AmanitaVerna said:

Sorry about that, I had no idea that could happen.

Not a problem!

 

4 hours ago, AmanitaVerna said:

Here's the full KSP.log and player.log from that session, in a .7z file: https://1drv.ms/u/s!AlnEemcsDL9XlcoKdERS2lNAhK50yA?e=Xu25AM

I can upload them in a zip file instead if you need, but it ended up being twice as large (not that it's all that large).

Thank you very much. I need your logs because I want to compare it with the other ones, in an attempt to rule out suspects. If a bunch of add'ons are working for you, it's unlikely (but, granted, not impossible) they could be the problem on someone else - unless we have a environmental problem (as a overloaded rig).

About the 7z, I really prefer this format. Thanks. I'm on a UNIX by the way, I can easily handle even tar.bz2 if you prefer to share things on this arcane format!

 

8 hours ago, GoAHead said:

@Lisiasi'm sorry to  say the beta didn't worked for me

• did a complete copy of the current instance
• deleted all old versions of twekscale recall and other stuff which is within the new beta downloads

Humm… I'm trying to use CKAN to install your ModPack, but...

macmini62:MacOS lisias$ mono ckan.exe install -c /Users/lisias/Downloads/Modpack.ckan
installed-Kerbal-Space-Program-LastGame dependency on AirParkContinued 2:1.7.1.7 version (any) not satisfied
If you're lucky, you can do a `ckan update` and try again.
Try `ckan install --no-recommends` to skip installation of recommended modules.
Or `ckan install --allow-incompatible` to ignore module compatibility.

I tried both —no—recommends and —allow-incompatible , without success. By the smell of it, I'on considering that at least your case is a toe-stomping-fest due something deprecated or outdated…[Never mind - it's CKAN , I realised that I can't install partially a ModList, CKAN refuses to install anything if anyone of the itens are not recognized]

I'm installing things by hand now.

Edited June 30, 2022 by Lisias
bleh. it's ckan.

[Krazy1]

18 hours ago, Lisias said:

Weirdly enough, apparently the source for your headaches are being triggered by another land-mine:

18 hours ago, Lisias said:

[ERR 21:23:53.867] [ScienceSubject] - Error in converting Situation InSpaceHigh_System.ArgumentException: Requested value 'InSp

That's nothing new... I saw this months ago... I commented on it either here or in TS. Maybe I can find it again. It's stock log spam caused by asteroid samples taken in a biome different from when you first rendezvoused with it (I think).  There's a log entry for every sample like that in your save file, and every time it reloads the save file at scene changes. It's an error, not an exception. I really think it's nothing. 

13 hours ago, AmanitaVerna said:

I have noticed InSpaceHigh_ exceptions in my player.log as well, though I didn't notice any problems as a result, so I doubt they're related to this issue

agree. I reverted to Recall 0.2.2.3 and I have no problems. 

@Robhar174 no undocking, unfortunately

Edited June 30, 2022 by Krazy1

[Lisias]

Oukey… Some news.

We definitively have TWO DIFFERENT PROBLEMS kicking my SAS.

People getting the ArgumentOutOfRangeException , please revert to KSP-Recall 0.2.2.3 . On a pretty spartan KSP 1.12.3 test bed, I could easily reproduce the problem. So it's a problem on AttachedOnEditor - or perhaps a new bad interaction between it and KSP 1.12.3 (damn, I had tested that migration tool in the past!)[NOPE! It was a major brain fart of mine. How that damned thing didn't blew up before is one of the mysteries of life.] - the thing is not on that migration code I talked about, I completely removed it and yet I have the exact same issue (and not a new one as one would expect). Still working on it.

What's really puzzling me is why this is happening only on 0.2.2.3 -> 0.2.2.4, because that code should also be blowing on 0.2.2.2 -> 0.2.2.3 and it didn't. I think that going straight from 0.2.2.2 to 0.2.2.4 doesn't triggers any problems, but I still need to confirm it. [Boy, when I fart, I do it spectacularly… Geez...]

@MgnfcntBstrd, @Merkurokrom, @arkaik, @Poppa Wheelie, @ss8913, @Krazy1 this will mitigate your problems.

@AmanitaVerna, you didn't got this one because AttachedOnEditor is only patched when a known client needs it. If no known Module that needs it is found, it's not patched to save some memory and CPU cycles.

 

Everybody else with weirder Exceptions, the quickest (and dirtier) workaround is to rename the file:

• <KSP_Root>/GameData/SquadExpansion/MakingHistory/makinghistory.kspexpansion

to

• <KSP_Root>/GameData/SquadExpansion/MakingHistory/makinghistory.kspexpansion.NOLOAD

This will prevent MH Mission Editor (and some other things) from being loaded (and kicking in that concurrency toe-stomping-fest I described above), but you will still have the new parts available.

@GoAHead, I think your problem is related to this one.

@Krazy1, @MgnfcntBstrd, @arkaik, you guys also had some weird exceptions on your KSP.log. Way different from the GoAhead one, but still, it worths a shot. Try renaming the makinghistory.kspexpansion and see if the game improves somehow.

Edited June 30, 2022 by Lisias
damn. found the problem. :P

[Krazy1]

14 minutes ago, Lisias said:

This will prevent MH Mission Editor

There's a mod for that... https://spacedock.info/mod/2052/Making Less History
But it's not compatible with KSP 1.8+ so I don't dare to try it on 1.12.3. Renaming a file seems easy... yes, that worked. I only did a short test on a small sandbox save, but it worked. 

[AmanitaVerna]

@Lisias Ah, so I was saved from the first problem by not having TweakScale or whatever other mods use AttachedOnEditor, and from the second by not having Making History?

[Lisias]

20 hours ago, Krazy1 said:

There's a mod for that... https://spacedock.info/mod/2052/Making Less History
But it's not compatible with KSP 1.8+ so I don't dare to try it on 1.12.3.

it should work, I checked the code - absolutely nothing even remotely related to KSP itself, just finding the file and renaming it.

The downside of the thing, however, is that you need to reboot KSP after configuring it - defeating the purpose of having an Add'On at first place. We need a better and extensible Launcher.

20 hours ago, Krazy1 said:

yes, that worked. I only did a short test on a small sandbox save, but it worked. 

Good news. The next versions of KSP-Recall and TweakScale will have the MH workaround implemented. I can't fix the problem for everybody else, so there's a good chance that you will still need to keep MH renamed - but I least I can withdraw myself from the problem.

(KSP-Recall 0.3.0.0 also has the fix, but it also have the problem plaguing everybody else here, so it's not an option. Wait for 0.3.0.1 - I think I can cook it on the next two hours).

 

16 hours ago, AmanitaVerna said:

@Lisias Ah, so I was saved from the first problem by not having TweakScale or whatever other mods use AttachedOnEditor, and from the second by not having Making History?

Yes… 

I was trying to avoid saying this with the full words - TweakScale was dragged down into the mess, not the cause of it.  

On the bottom line, most of the time TweakScale is only being bashed by someone - it happened that, this time, I was one of them! 

— — 

Well, that's the history:

On Recall 0.2.2.1, I realised I needed to preserve more data on the Module. So I coded the upgrade tool to fill the empty spaces without overwriting the current ones - it looked as a good idea at that time. And the damned thing worked - besides looking into it now, it should not. In a way or another, I planted a bomb on 0.2.2.1 that kept ticking until nowadays.

On Recall 0.2.2.2, I realised that the part rotation was also missing on OnLoad, and AttachedOnEditor was updated to save this info too.

Now, on Recall 0.2.2.3 , I realised that I had to apply AttachedOnEditor on all parts, and not only on the parts that have TweakScale. It's counterintuitive, but in fact when attaching parts into each other, TweakScale is called to check if the nodes are correct - and on this process, TS needs to find the scaling part counter-part nodes on the attached part and if the attached part doesn't have it initialised as expected, TS borks. (and yeah, this is the KSP 1.9 Editor screwing up with us). And by this time, lots of people has already their surface of exposure expanded.

And, now, on 0.2.2.4 I had (finally) realised that if the part's attachment node positions are missing, so are the rotation and offset, and included these ones on the solution. But… (and this is here that huge brain fart happened), I forgot to increase the MODULE_VERSION. So the damned upgrade code was not detecting the problem, and so it was not running that specific upgrade - and this is the reason this was working for MODULE_VERSION 3, 4 and 5 (from 0.2.2.2 and previous).

Full history: https://github.com/net-lisias-ksp/KSP-Recall/issues/52

Issue fixed on https://github.com/net-lisias-ksp/KSP-Recall/issues/49

I will release 0.3.0.1 today, not sure yet when, but it will be today.

Edited July 1, 2022 by Lisias
fixing a statement