[1.12.3] Rocket Sound Enhancement - Plugin: v0.9.6 - 07/09/22 | Config Pack: v1.2.4 - 07/09/22

[ensou04]

@linuxgurugamer here it is. i am definitely missing something here

@PART[*]:HAS[!MODULE[ModuleWheelBase],!MODULE[KerbalEVA],!MODULE[ShipEffectsCollisions]]
{	
	MODULE
	{
		name = ShipEffectsCollisions
	}
}

 

[Stone Blue]

@ensou04 sorry if this is a stoopid question, but have you tried three seperate patches, instead of all three, in one?
I'm prolly not understanding the MM logic there, but to me it looks like *all* three of those module conditions need to be met at once, for patch activation? vOv

Like, you have NOT/AND... not NOT/OR

EDIT: yeah... I figured OR needed to be in there somewheres.. I asked in Discord, and someone respectable confirmed you need to replace " , " with " | " ... comma is AND... " | " is OR...

Edited October 18, 2020 by Stone Blue

[ensou04]

12 minutes ago, Stone Blue said:

@ensou04 sorry if this is a stoopid question, but have you tried three seperate patches, instead of all three, in one?
I'm prolly not understanding the MM logic there, but to me it looks like *all* three of those module conditions need to be met at once, for patch activation? vOv

Like, you have NOT... not NOT/OR

TBH thats probably why, because i have no idea how MM works. as i understood it as "filter out parts that contains Any of these modules"
so i'll try that now and see what happens
In hindsight i need sleep, if i separate them: then the first one will run and add the module to the next modules that are supposed to be blacklisted. 

Edited October 18, 2020 by ensou04

[Stone Blue]

1 minute ago, ensou04 said:

TBH thats probably why, because i have no idea how MM works. as i understood it as "filter out parts that contains Any of these modules"
so i'll try that now and see what happens

'K .. make sure you catch my edit in there...:P

 

[ensou04]

caught it just now, thanks  also hope you caught my edit lol

UPDATE:
ok so i did just that, there were no errors but,  the collision module still gets applied to the kerbals. i'll just deal with it later

@PART[*]:HAS[!MODULE[ModuleWheelBase]|!MODULE[KerbalEVA]|!MODULE[ShipEffectsCollisions]]
{	
	MODULE
	{
		name = ShipEffectsCollisions
	}
}

 

Edited October 18, 2020 by ensou04

[linuxgurugamer]

2 hours ago, ensou04 said:

caught it just now, thanks  also hope you caught my edit lol

UPDATE:
ok so i did just that, there were no errors but,  the collision module still gets applied to the kerbals. i'll just deal with it later

This is from EVA Enhancements:

@PART[kerbalEVA*]:HAS[@MODULE[ModuleScienceExperiment]:HAS[~experimentID[ROCScience]]]
{
	MODULE
	{
		name = EVAEnhancements
	}
}

and this is from DeadlyReentry:

@PART[*]:HAS[@MODULE[KerbalEVA]]
{
..... do something here
}

 

Edited October 18, 2020 by linuxgurugamer

[ValiZockt]

3 hours ago, Stone Blue said:

EDIT: yeah... I figured OR needed to be in there somewheres.. I asked in Discord, and someone respectable confirmed you need to replace " , " with " | " ... comma is AND... " | " is OR...

However, I was very wrong. OR statements can only be used in NEEDS not in HAS or anything else. 

[JadeOfMaar]

@ensou04 I believe what you're looking to do looks like this:

// Tag parts, in succession, for each module you disagree with.
// Can't use OR boolean anywhere except in :NEEDS
@PART:HAS[@MODULE[ModuleWheelBase]]
{    
	%RSENoFX = True // % prefix means create if not exist, edit if exist. This prevents the key repeating later on in parts that have other blacklisted modules
}

@PART:HAS[@MODULE[KerbalEVA]]
{    
	%RSENoFX = True
}

// Do the actual operation on all parts that don't have this key.
// The :AFTER is only there to provide an opportunity for other modders to tag their own parts (if ever needed) before this operation happens.
@PART:HAS[~RSENoFX[*]]:AFTER[RocketSoundEnhancement]
{    
	%MODULE[ShipEffectsCollisions] {}
	@RSENoFX = Done // change this key's value to prevent infinite loops
}

 

Edited October 18, 2020 by JadeOfMaar

[ensou04]

@JadeOfMaar thanks! it worked but it still ignored Kerbals for some reason , the wheels blacklist works just fine. so I just did @PART[kerbalEVA*] as a temporary fix,  its not elegant but that worked a treat. Kerbals don't sound like dumpsters now. lets just hope there's no real parts that has kerbalEVA in its name

EDIT:
i missed this, maybe i should have tried this as well:

@PART[*]:HAS[@MODULE[KerbalEVA]]
{
..... do something here
}

Edited October 19, 2020 by ensou04

[ensou04]

RSE Engine module now functional, started experimenting with crossfading between sound samples on thrust. I also just recently discovered that Unity3D supports loop points so i used it on this. now engines can have an "initial" sound before the actual loop begins on thrust.

RSE_Engine is a replacement for the AUDIO node on EFFECTS,  Allows us to easily layer sounds. also makes it easier to deal with engines that only uses ModuleEngines.
Here's what the Config looks like:

Spoiler

MODULE
{
	name = RSE_Engines
	moduleID = Mainsail_V2 		//Unique Identifier for this part module
	engineID = engineID			//if using multimode engines or if engineID is available

	RUNNING
	{
		SOUNDLAYER
		{
			name = ThrustHigh
			audioClip = RocketSoundEnhancement/Sounds/Engines/RSE_Liquid_Large_High
			loop = true
				
			channel = ShipBoth
				
			volume = 0.0 0.0
			volume = 0.66 0.0
			volume = 1.0 1.0
				
			pitch = 1.0
		}
		SOUNDLAYER
		{
			name = ThrustMid
			audioClip = RocketSoundEnhancement/Sounds/Engines/RSE_Liquid_Large_Mid
			loop = true
				
			channel = ShipBoth
				
			volume = 0.0 0.0
			volume = 0.33 0.0
			volume = 0.66 1.0
			volume = 1.0 0.0
				
			pitch = 1.0
		}
		SOUNDLAYER
		{
			name = ThrustLow
			audioClip = RocketSoundEnhancement/Sounds/Engines/RSE_Liquid_Large_Low
			loop = true
			
			channel = ShipBoth
			
			volume = 0.0 0.0
			volume = 0.33 1.0
			volume = 0.66 0.0
			volume = 1.0 0.0
			
			pitch = 1.0
		}
	}
	ENGAGE{}
	DISENGAGE{}
	FLAMEOUT{}
	
}

 

 

 

Edited October 22, 2020 by ensou04

[Stone Blue]

AWESOME SAUCE!!!

[ensou04]

Getting Ready for 0.5.0 Release, started working on the sound effects as the Plugin is done for the most part.

Here's a Launch Test featuring  Sounds for Extra Large Engines

 

Edited October 25, 2020 by ensou04

[dresoccer4]

just stumbled upon this mod and wanted to say... I'M FOR IT!

[ensou04]

Testing out some big sounds for heavy engines like the KE-1.  also features the new decoupler sounds 

Also on a side note, @CobaltWolf had asked back then if we can do "Bwoop" Sounds on ignition which is possible using loop points on the samples as demonstrated here. I just have to find a good recording of that and make a sample set

 

Edited October 30, 2020 by ensou04

[Me.hasOwnProperty isHappy]

@ensou04 Some words about this "bwoop" sound of the turbopump starting up. This document has some useful info. Page 6 shows the profile of rpm growing up, which corresponds to the sound. If you are still searching for the recording, guess I can help looking through Scott Manley's videos, remember he was talking about it.

[Electrocutor]

@ensou04 Which engines will v0.5 cover?

[ensou04]

@Electrocutor All of stock engines, they're all done. I just need to add compatibility for Restock now. we'll add mod engines later

[ensou04]

Getting closer to v0.5 release

• Implemented a rudimentary Audio Muffling, not as powerful as Audio Muffler Redux, it doesn't do audio culling. but its  very lightweight.
• All engines are now patched except for Jet Engines (just needs restock compatibility, jets will be done later)
• New Physics Based SFX, Currently working on adding more eg: impacts
• Sound Handling now supports Stereo Spread.

New Settings

 

Edited November 10, 2020 by ensou04

[RyanRising]

I don't think I can fully express how wonderful it is to hear all this come together. Bravo!

[evileye.x]

On 11/10/2020 at 5:05 PM, ensou04 said:

Getting closer to v0.5 release

This is some awesome work! So immersive sound...

[ensou04]

Just Another Rover Wheel Sounds Mod™

Plane Take off and Landing:

on another note, you can check out the source on Github now while im still finishing up the sounds and patches.  https://github.com/ensou04/RocketSoundEnhancement

Edited November 14, 2020 by ensou04

[Beetlecat]

This is fantastic. Audio Muffler has been a must-mod for me forever due to the sensory requirement of it. It's just weird without it.

This is above and beyond that. Having rover sounds and landing gear scritches again is going to be so great along with that amazing rocket roar.

Now, it's only that weird default staging sound that still lingers.

[ensou04]

5 hours ago, Beetlecat said:

Now, it's only that weird default staging sound that still lingers.

actually, you can change it now with my mod  its one of the first things i implemented. i just didn't put sounds for this on the vids cuz i havent made anything for it yet.

SHIPEFFECTS_SOUNDLAYERS
{	
	nextStageClip = sound_click_tick
	cannotSeparateClip = failSeparateClip
}

EDIT:
Ok after reading back on the thread  there seems to be a consensus that people want to disable staging sounds entirely. so I made an option for it. should it be disabled by default?

Edited November 15, 2020 by ensou04

[Me.hasOwnProperty isHappy]

Awesome work, system's blaring now!

Found this video with turbo-driven engine start-up. Sound is pretty clear. What do you think about implementing something similar to these woop and blast sounds?

 

On 11/10/2020 at 3:05 PM, ensou04 said:

All engines are now patched except for Jet Engines (just needs restock compatibility, jets will be done later)

Does that mean that the sound of the engine itself will be altered too? I mean this mod , which is currently hold by @linuxgurugamer

 

One more question, do you consider also adding background music and sound effects when landed at different biomes? Like snow crackling, wind, water splashes, etc.

[ensou04]

2 hours ago, Me.hasOwnProperty isHappy said:

Awesome work, system's blaring now!

Found this video with turbo-driven engine start-up. Sound is pretty clear. What do you think about implementing something similar to these woop and blast sounds?

Thank you

Well the engine sounds I have already have Blasts and some "swhoop" sounds on some of them but I guess I could work on it further?

 

2 hours ago, Me.hasOwnProperty isHappy said:

Does that mean that the sound of the engine itself will be altered too?

I meant I haven't done any sound effects for the jet engines yet so they'll be left alone. although I do have patches for the RAPIER so that might overlap with Jet Sounds Updated

 

2 hours ago, Me.hasOwnProperty isHappy said:

One more question, do you consider also adding background music and sound effects when landed at different biomes? Like snow crackling, wind, water splashes, etc.

That is very much possible so I'll put that on the plan list,  might as well compose some music and ambient sound effects.  thanks for the idea!

Edited November 15, 2020 by ensou04