Restock Waterfall Expansion 3.1.0 (Aggie Engine Repairs) for Kerbal Space Program (1.12.5)!

[lyriclemon]

Hello. I was wondering if it was possible to reemplace the Restock Waterfall RCS effect with the normal Waterfall RCS effect. Also I wonder if it is possible to eliminate the smoke plume from the liquid engines that appear in Restock Waterfall but not in normal Waterfall. Thank you.

[AtomicTech]

1 hour ago, lyriclemon said:

Hello. I was wondering if it was possible to reemplace the Restock Waterfall RCS effect with the normal Waterfall RCS effect. Also I wonder if it is possible to eliminate the smoke plume from the liquid engines that appear in Restock Waterfall but not in normal Waterfall. Thank you.

I'll look into the RCS Plumes for an update later this year

For the smoke plumes, I'll think about it; I do like them to be honest.

 

[lyriclemon]

26 minutes ago, AtomicTech said:

I'll look into the RCS Plumes for an update later this year

For the smoke plumes, I'll think about it; I do like them to be honest.

 

Ok, no problem for the engine plumes, no big deal. But in my oppinion the normal Waterfall RCS effect looks more realistic (and way cooler) than the Restock one, and I was wondering if eliminating some file would revert it from Restock Waterfall to Stock Waterfall effect. Cheers.

[kurgut]

Hi, thanks for your work on this mod !

It seems like your mod is overwriting Jet Sounds mod, since you delete the EFFECTS node for waterfall's, while jet sounds is editing stock engine effects...
Do you think a compatibility patch could be considered ?
I also asked in jet sounds thread, since I'm not sure on which side it would  be easier to do...

Peace  

[linuxgurugamer]

@AtomicTech

I have an updated set of engine configurations (RestockWaterfallExpansion/Engine Configurations) which fixes the problem of this overwriting JetSoundsUpdated.  Let me know if you'd like me to send it to you

Given the way this is written, this can only be fixed here, not in the JSU mod

[miklkit]

I noticed that my rapier engines had reverted to stock and went searching for a cure and ended up here.  Dled and installed this mod manually because it is not in CKAN.  The rapiers now look good again, but naturally the craft I tested first also has the aerospike engine and it looks pretty puny now.  Did I do something wrong?

[Cytauri]

@AtomicTech Is it planned that there will be Near Future Aeronautics configs or is this only for Restock? Thanks!

[UltraJohn]

Hi, the RWE 2.1.0 version zip file contains a duplicate StockWaterfallEffects folder for some reason. (inside WaterfallRestock folder there's the second copy)

The RestockWaterfallExpansion Templates folder contains a lot of duplicate configs also in StockWaterfallEffects Templates folder.

It also looks like the version installed through CKAN does not quite match the same files as the manual install, causing you to have duplicate configs for some engines.

Edited July 21, 2023 by UltraJohn

[AtomicTech]

On 7/5/2023 at 5:55 PM, Cytauri said:

@AtomicTech Is it planned that there will be Near Future Aeronautics configs or is this only for Restock? Thanks!

Just for restock, though I might look into that for the future.

On 7/21/2023 at 7:46 AM, UltraJohn said:

Hi, the RWE 2.1.0 version zip file contains a duplicate StockWaterfallEffects folder for some reason. (inside WaterfallRestock folder there's the second copy)

The RestockWaterfallExpansion Templates folder contains a lot of duplicate configs also in StockWaterfallEffects Templates folder.

It also looks like the version installed through CKAN does not quite match the same files as the manual install, causing you to have duplicate configs for some engines.

I'm not a CKAN wrangler and I'm not quite sure how to fix that... Maybe @HebaruSan might know?

On 5/26/2023 at 9:31 PM, linuxgurugamer said:

@AtomicTech

I have an updated set of engine configurations (RestockWaterfallExpansion/Engine Configurations) which fixes the problem of this overwriting JetSoundsUpdated.  Let me know if you'd like me to send it to you

Given the way this is written, this can only be fixed here, not in the JSU mod

Aye aye! I'd love to have this! Do you mind sending it to me via discord?

On 5/25/2023 at 1:25 AM, kurgut said:

Hi, thanks for your work on this mod !

It seems like your mod is overwriting Jet Sounds mod, since you delete the EFFECTS node for waterfall's, while jet sounds is editing stock engine effects...
Do you think a compatibility patch could be considered ?
I also asked in jet sounds thread, since I'm not sure on which side it would  be easier to do...

Peace  

When I get LGG's update, I'll throw it in

On 6/25/2023 at 10:29 PM, miklkit said:

I noticed that my rapier engines had reverted to stock and went searching for a cure and ended up here.  Dled and installed this mod manually because it is not in CKAN.  The rapiers now look good again, but naturally the craft I tested first also has the aerospike engine and it looks pretty puny now.  Did I do something wrong?

Hi, do you have screenshots of this?

[Cytauri]

5 hours ago, AtomicTech said:

Just for restock, though I might look into that for the future.

Nice! Don’t worry about it, I really like your Restock work and I’m glad you are still working on it!

[linuxgurugamer]

6 hours ago, AtomicTech said:

On 5/26/2023 at 10:31 PM, linuxgurugamer said:

@AtomicTech

I have an updated set of engine configurations (RestockWaterfallExpansion/Engine Configurations) which fixes the problem of this overwriting JetSoundsUpdated.  Let me know if you'd like me to send it to you

Given the way this is written, this can only be fixed here, not in the JSU mod

Aye aye! I'd love to have this! Do you mind sending it to me via discord?

Thought I did, sending it now

6 hours ago, AtomicTech said:

On 7/21/2023 at 8:46 AM, UltraJohn said:

Hi, the RWE 2.1.0 version zip file contains a duplicate StockWaterfallEffects folder for some reason. (inside WaterfallRestock folder there's the second copy)

The RestockWaterfallExpansion Templates folder contains a lot of duplicate configs also in StockWaterfallEffects Templates folder.

It also looks like the version installed through CKAN does not quite match the same files as the manual install, causing you to have duplicate configs for some engines.

I'm not a CKAN wrangler and I'm not quite sure how to fix that... Maybe @HebaruSan might know?

This sounds like a bad zip file, I looked at it, and the zip file DOES have both the RestockWaterfallExpansion AND the SotckWaterfallEffects folders there

[miklkit]

It turns out that I do not have an old screenie of a Dart engine, but here are some recent ones.

Taking off.

heading up

in space

For reference here is what the Rapiers used to look like.

[AtomicTech]

12 hours ago, miklkit said:

It turns out that I do not have an old screenie of a Dart engine, but here are some recent ones.

Taking off.

heading up

in space

For reference here is what the Rapiers used to look like.

Will look into this

[Nyxilo]

On 7/25/2023 at 7:05 AM, AtomicTech said:

Just for restock, though I might look into that for the future.

I'm not a CKAN wrangler and I'm not quite sure how to fix that... Maybe @HebaruSan might know?

Aye aye! I'd love to have this! Do you mind sending it to me via discord?

When I get LGG's update, I'll throw it in

Hi, do you have screenshots of this?

Hey ! Do you have an idea when your mod will be compatible with Jet Sounds Upddated ?
RWE and JSU are real nice mods, having them together would be awesome.

[AtomicTech]

On 8/25/2023 at 7:24 AM, Nyxilo said:

Hey ! Do you have an idea when your mod will be compatible with Jet Sounds Upddated ?
RWE and JSU are real nice mods, having them together would be awesome.

Howdy!

I didn't notice your comment until now; I didn't have any plans to do so as I didn't know that this mod existed. However we'll ask @linuxgurugamer if he's got any ideas on how to do this

(I might even consider integrating the mod if the license allows lol)

Edited September 28, 2023 by AtomicTech

[AtomicTech]

I'm hoping to do a 2.2.0 in the near future or soon^tm 

I believe the goals to be looking into adding jet sounds updated, looking into the Scatterer Issue, looking into the Dart engine issue, and potentially consolidating RWE's folders.

[AtomicTech]

Is anyone here available to try out a prototype for version 2.2?

This prototype version will feature a recombined RWE folder along with sounds from JSU courtesy of @linuxgurugamer

[AtomicTech]

The only parts that are JSU enhanced (at the moment) are the Juno and Goliath.

Goliath Config sneak peek:

Spoiler

// JSU Enhanced

@PART[turboFanSize2]:NEEDS[Waterfall]:FOR[RestockWaterfallExpansion]
{
  // Removes the stock effect block, and replace it with one that has no particles
  !EFFECTS {}
    EFFECTS
    {        
        fx_goliath_running
        {            
            AUDIO
            {
                channel = Ship
                clip = RestockWaterfallExpansion/JSUSounds/GE90_Running_High
                volume = 0.0 0.0
                volume = 0.05 0.4
                volume = 1.0 1.0
                pitch = 0.0 0.6
                pitch = 1.0 1.0
                loop = true
            }                
        }
        fx_goliath_spool
        {
            AUDIO
            {
                channel = Ship
                clip = RestockWaterfallExpansion/JSUSounds/GE90_Running_Low
                volume = 0.0 0.0
                volume = 0.05 0.7
                volume = 1.0 1.0
                pitch = 0.0 0.4
                pitch = 0.05 0.5
                pitch = 1.0 1.0
                loop = true
            }
        }
        engage
        {
            AUDIO
            {
                channel = Ship
                clip = RestockWaterfallExpansion/JSUSounds/GE90_Startup
                volume = 1.0
                pitch = 2.0
                loop = false
            }
        }
        disengage
        {
            AUDIO
            {
                channel = Ship
                clip = RestockWaterfallExpansion/JSUSounds/GE90_Shutdown
                volume = 1.0
                pitch = 2.0
                loop = false
            }
        }
        flameout
        {
            PREFAB_PARTICLE
            {
                prefabName = fx_exhaustSparks_flameout_2
                transformName = smokePoint
                oneShot = true
            }
            AUDIO
            {
                channel = Ship
                clip = sound_explosion_low
                volume = 1.0
                pitch = 2.0
                loop = false
            }
        }
    }
    
@MODULE[ModuleEngines*]
    {
      %powerEffectName = fx_goliath_running
      %spoolEffectName = fx_goliath_spool
    }
    
  MODULE
  {
    name = ModuleWaterfallFX
    moduleID = goliathFX
    CONTROLLER
    {
        name = atmosphereDepth
        linkedTo = atmosphere_density
    }
    CONTROLLER
    {
        name = throttle
        linkedTo = throttle
        engineID = Cruise
        responseRateUp = 0.02
        responseRateDown = 0.02
    }
    CONTROLLER
    {
        name = mach
        linkedTo = mach
    }
    TEMPLATE
    {
      templateName = stock-kerozine-turbofan-1
      overrideParentTransform = thrustTransform
      position = 0,0,0
      rotation = 0, 0, 0
      scale = 1, 1, 1
    }
  }
}

 

Juno sneak peak:

Spoiler

// JSU Enhanced

@PART[miniJetEngine]:NEEDS[Waterfall]:FOR[RestockWaterfallExpansion]
{
  // Removes the stock effect block, and replace it with one that has no particles
  !EFFECTS {}
    EFFECTS
    {        
        fx_juno_running
        {            
            AUDIO
            {
                channel = Ship
                clip = RestockWaterfallExpansion/JSUSounds/TFE731_Running_High
                volume = 0.0 0.0
                volume = 0.05 0.2
                volume = 1.0 0.5
                pitch = 0.0 1.2
                pitch = 1.0 2.0
                loop = true
            }                    
        }
        fx_juno_spool
        {
            AUDIO
            {
                channel = Ship
                clip = RestockWaterfallExpansion/JSUSounds/TFE731_Running_Low
                volume = 0.0 0.0
                volume = 0.05 0.35
                volume = 1.0 0.5
                pitch = 0.0 0.6
                pitch = 0.05 0.8
                pitch = 1.0 1.5
                loop = true
            }
        }
        engage
        {
            AUDIO
            {
                channel = Ship
                clip = RestockWaterfallExpansion/JSUSounds/TFE731_Startup
                volume = 0.8
                pitch = 2.5
                loop = false
            }
        }
        disengage
        {
            AUDIO
            {
                channel = Ship
                clip = RestockWaterfallExpansion/JSUSounds/TFE731_Shutdown
                volume = 0.8
                pitch = 2.5
                loop = false
            }
        }
        flameout
        {
            PREFAB_PARTICLE
            {
                prefabName = fx_exhaustSparks_flameout_2
                transformName = thrustTransform
                oneShot = true
            }
            AUDIO
            {
                channel = Ship
                clip = sound_explosion_low
                volume = 1.0
                pitch = 2.0
                loop = false
            }
        }
    }
    
@MODULE[ModuleEngines*]
    {
      %powerEffectName = fx_juno_running
      %spoolEffectName = fx_juno_spool
    }
    
  MODULE
  {
    name = ModuleWaterfallFX
    moduleID = junoFX
    CONTROLLER
    {
        name = atmosphereDepth
        linkedTo = atmosphere_density
    }
    CONTROLLER
    {
        name = throttle
        linkedTo = throttle
        engineID = Cruise
        responseRateUp = 0.02
        responseRateDown = 0.02
    }
    CONTROLLER
    {
        name = mach
        linkedTo = mach
    }
    TEMPLATE
    {
      templateName = stock-kerozine-turbofan-1
      overrideParentTransform = thrustTransform
      position = 0,0,0.257
      rotation = 0, 0, 0
      scale = 0.33, 0.33, 0.33
    }
  }
}

 

[xXIndestructibleEVAXx]

I'd be willing to try it out!

[AtomicTech]

2 hours ago, xXIndestructibleEVAXx said:

I'd be willing to try it out!

Nice!
Lemme prep you a Google Drive link

@xXIndestructibleEVAXx,

Here's the prototype:

https://drive.google.com/file/d/10mPmCyXjEcsAyelzxC5WIRE7S7SOE-Gh/view?usp=share_link

Be sure to delete the RestockWaterfallExpansion, StockWaterfallEffects, and the WaterfallRestock folder before downloading this!

[xXIndestructibleEVAXx]

ok, i got some homework to do, as soon as I'm done I'll give it a shot!

[xXIndestructibleEVAXx]

@AtomicTech

Main thing to report: the Juno and Goliath sounds work great, but the Juno has no visuals. Waterfall recognizes it and displays "JunoFX" but says that module has 0 effects on it (apologies if the terminology is wrong, not too familiar with waterfall)

Additionally: the Dart (aerospike) has no waterfall effects, just the stock plume

Full report: the kerolox plume on the Cheetah engine is slightly clipped through the nozzle; all three plumes on the Vector are totally broken (purple cylinder instead of effects), the Rhino has no effects at all,  the Wolfhound is partially broken (small purple line inside plume),  the Juno has no effects at all, the Dart has stock effects, and additionally, idk if you intend to do any RestockPlus engines, but if you do, the Cherenkov has only stock effects. If not mentioned, assume it's fine.

Edited October 18, 2023 by xXIndestructibleEVAXx

[AtomicTech]

13 hours ago, xXIndestructibleEVAXx said:

@AtomicTech

Main thing to report: the Juno and Goliath sounds work great, but the Juno has no visuals. Waterfall recognizes it and displays "JunoFX" but says that module has 0 effects on it (apologies if the terminology is wrong, not too familiar with waterfall)

Additionally: the Dart (aerospike) has no waterfall effects, just the stock plume

Full report: the kerolox plume on the Cheetah engine is slightly clipped through the nozzle; all three plumes on the Vector are totally broken (purple cylinder instead of effects), the Rhino has no effects at all,  the Wolfhound is partially broken (small purple line inside plume),  the Juno has no effects at all, the Dart has stock effects, and additionally, idk if you intend to do any RestockPlus engines, but if you do, the Cherenkov has only stock effects. If not mentioned, assume it's fine.

Alrighty then, 

I copy:

1. The Dart needs plumes.
2. The Juno needs fixing.
3. The Kerolox plume on the Cheetah needs to be realigned.
4. The Vector needs to be completely repaired.
5. The Rhino also needs a complete fix.
6. The Wolfhound needs fixing.
7. The Cherenkov needs Waterfall effects.

Awesome, thank you!

[xXIndestructibleEVAXx]

Best of luck! Glad I could help!

[AtomicTech]

On 10/19/2023 at 11:28 AM, xXIndestructibleEVAXx said:

Best of luck! Glad I could help!

Yeah! Thanks-a-bunch-again!